Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
27,591 Commits 28 Branches 143 Tags 624 MiB
Commit Graph

9 Commits

Author SHA1 Message Date
Rohitt Vashishtha e14dbecdd1 zblueslip: Store more_info and stack as well in the logs. 
Now, the get_test_logs() returns an array of objects instead
of an array of strings as follows:

[{
  message: "something",
  more_info: {},
  stack: {},
}]
 2018-07-10 16:22:52 -04:00
Steve Howell 42435db492 Add run_test helper for individual tests. 
This run_test helper sets up a convention that allows
us to give really short tracebacks for errors, and
eventually we can have more control over running
individual tests.  (The latter goal has some
complications, since we often intentionally leak
setup in tests.)
 2018-05-15 08:24:44 -07:00
Rohitt Vashishtha bddb6a1a14 zblueslip: Log output for all function calls. 
Also adds asserts on blueslip.log() call in node_tests/people_errors.js.
 2018-04-23 16:18:35 -07:00
Tim Abbott 322fc52cd5 people: Suppress reporting late user additions when reloading. 
If the browser is in the progress of reloading when it finishes
fetching some messages, it's not really a bug, and we shouldn't report
it as such.

This should help make Zulip's browser error reporting less spammy.
 2018-04-23 12:20:27 -07:00
Rohitt Vashishtha ba21afe9a6 zblueslip: Convert node_tests/people_errors.js to zblueslip. 2018-04-19 15:02:00 -04:00
Rohitt Vashishtha b22e8dc2b7 lint: Replace 'return undefined;' with 'return;'. 
Also adds a custom rule to eslint. Since the recommended way of extending
eslint is to create plugins as standalone npm packages, the separate rule
is published as 'eslint-plugins-empty-returns'.

Fixes #8669.
 2018-03-13 08:22:42 -04:00
Steve Howell aa61db9301 Change warn -> error in people.report_late_add(). 
This commit is easy to revert if we want to tone down errors
to warnings for the short term, while our codepath still does
proper handling for adding users when they come in messages.
 2017-11-07 09:51:10 -08:00
Steve Howell 02a011d627 Add people.report_late_add(). 
We want to know when users are added after page load, as it can
be a symptom of stray messages leaking in or live-update problems,
etc.

Fixes #7120
 2017-11-07 09:51:10 -08:00
Steve Howell b492f3569a tests: Extract node_tests/people_errors.js. 
This is mostly a pure extraction, but we needed to duplicate
a bit of setup from people.js, and I added an assertion
for warning about "No user_id provided".
 2017-11-07 09:51:10 -08:00