Tim Abbott
b2a24e0306
Revert "Add authorization check before serving files."
...
This reverts commit e985b57259
.
This commit will break production when we next do a release, because
we haven't done a migration to create Attachment objects for
previously uploaded files.
2016-06-27 12:09:56 -07:00
Tim Abbott
f7e87bc1f0
test_helpers: Require that login calls actually succeed.
...
This caught several bugs where test code wasn't doing what it's author
intended.
2016-06-27 11:51:04 -07:00
Tim Abbott
4cac7bbb32
test_helpers: Refactor login test helpers.
...
We now have a separate login helper for the case where the return
value is desired.
2016-06-27 11:50:43 -07:00
Tim Abbott
a05c03d3b5
test_messages: Fix trying to login as a bot user.
...
Due to a recent refactoring, the first user in the subscribers list is
now a bot.
2016-06-27 11:48:39 -07:00
Tim Abbott
370b38696a
test_messages: Fix broken huddle messages test.
...
The second login call was failing because the user didn't exist.
2016-06-27 11:48:36 -07:00
rahuldeve
e985b57259
Add authorization check before serving files.
2016-06-27 11:24:35 -07:00
rahuldeve
674def30ee
Add support for serving files using API authentication.
...
Also remove 'get_uploaded_file' view function and the corresponding
old '/user_upload/' url pattern.
2016-06-27 11:00:41 -07:00
rahuldeve
2bf15603f3
Modify rest_dispatch to support method specific flags.
...
[simplified substantially by tabbott]
2016-06-27 10:53:15 -07:00
rahuldeve
823bf15c6e
Add API route for uploading files.
2016-06-27 10:30:58 -07:00
Tim Abbott
79570f99c2
json_upload_file: Remove unnecessary has_request_variables.
2016-06-27 10:29:30 -07:00
Tim Abbott
8272fb4a94
zerver.views.upload: Move upload functions later in file.
2016-06-27 10:28:09 -07:00
Eklavya Sharma
e155573a1c
zilencer's populate_db.py: Type annotate all variables.
2016-06-27 10:22:49 -07:00
Eklavya Sharma
8cacd5fcf8
zilencer's populate_db.py: Type annotate some variables.
2016-06-27 21:00:10 +05:30
Eklavya Sharma
ea3c671494
zilencer's populate_db.py: Improve an annotation.
2016-06-27 21:00:10 +05:30
Eklavya Sharma
66d1867869
zilencer's populate_db.py: Fix string types.
2016-06-27 21:00:10 +05:30
Eklavya Sharma
a9fa78fc4a
api/zulip/__init__.py: Make compatible with newer mypy.
2016-06-27 21:00:09 +05:30
Eklavya Sharma
f20699b615
zerver/lib/statistics.py: Fix annotations.
...
Add type annotation to a variable.
Use abstract base container types where suitable.
Add missing imports from typing.
2016-06-27 18:03:29 +05:30
Eklavya Sharma
3917b822e5
zerver/lib/bulk_create.py: Type annotate variables.
2016-06-27 17:52:37 +05:30
Eklavya Sharma
d7a83ed019
zerver/views/__init__.py: Type annotate a variable.
2016-06-27 17:52:37 +05:30
Eklavya Sharma
63a5323259
zerver/views/streams.py: Type annotate variables.
2016-06-27 17:52:22 +05:30
Eklavya Sharma
9aa6fd988a
zerver/lib/actions.py: Type annotate variables.
2016-06-27 17:52:07 +05:30
Eklavya Sharma
7ca1e658b5
zerver/lib/cache.py: Change some TypeVars to Any.
...
Change ItemT and CompressedItemT to Any.
See https://github.com/python/mypy/issues/1721 .
2016-06-27 16:50:50 +05:30
Tim Abbott
f8c710b70e
Update documentation on development auto-reloading.
...
Now that queue workers auto-reload, we need to document that fact.
And we make a few tweaks to the relevant discussion, while we're at
it.
2016-06-26 20:20:13 -07:00
rahuldeve
3ca53df152
Add test for worker queue autoreloading.
2016-06-26 20:12:37 -07:00
rahuldeve
a3745178e5
Use django.utils.autoreload to restart queue workers at code change.
...
Fixes #621 , #1045 .
2016-06-26 20:12:11 -07:00
Tim Abbott
61d1de19cf
docs: Don't require typing module to be installed.
2016-06-26 10:10:59 -07:00
Tim Abbott
dc014b0866
docs: Add link to documentation building docs.
2016-06-26 10:04:07 -07:00
Tim Abbott
74c23d71e2
docs: Add details on viewing/editing these docs.
2016-06-26 10:04:06 -07:00
Tim Abbott
1838cd4d8f
docs: Split out version control guidelines.
2016-06-26 10:04:06 -07:00
Tim Abbott
96fef7a0a1
docs: Reorganize RTD table of contents.
2016-06-26 10:04:05 -07:00
Tim Abbott
9aea3cdc9b
docs: Add current Zulip release version to docs.
2016-06-26 10:03:56 -07:00
Tim Abbott
89b5eaaa7d
docs: Improve several headings.
2016-06-26 09:54:19 -07:00
Tim Abbott
149fd88733
docs: Add missing link in schema-migrations.md.
2016-06-26 09:54:19 -07:00
Tim Abbott
ea611c0dcd
docs: Add some full-text search documentation.
2016-06-26 09:32:54 -07:00
Tim Abbott
199e2df1e3
Split styles/settings.css out of zulip.css.
2016-06-26 08:21:39 -07:00
dhanus
1169329a71
Annotate zerver/views/webhooks/github.py.
2016-06-26 08:13:49 -07:00
Eklavya Sharma
85cb3e6103
zerver/views/webhooks/github.py: Make exception string str.
...
Passing a unicode string to Exception can sometimes fail.
Convert it to str to prevent that.
2016-06-26 08:13:49 -07:00
Eklavya Sharma
a32f83b182
zerver/views/webhooks/github.py: Fix string literals.
...
Change some string literals to unicode.
2016-06-26 08:13:49 -07:00
Eklavya Sharma
fa4adf0c62
zerver/views/webhooks/bitbucket.py: Fix an annotation.
2016-06-26 08:13:49 -07:00
Eklavya Sharma
36c2214d94
zerver/views/webhooks/bitbucket.py: Fix string literals.
...
Convert some strings literals to unicode.
2016-06-26 08:13:49 -07:00
Max
9b6205d0ed
Annotate zerver/decorator.py.
2016-06-26 08:13:49 -07:00
Max
daab2ca475
zerver/tornadoviews.py: Improve an annotation.
...
Use django.core.handlers.base.BaseHandler instead of Any.
2016-06-26 19:05:54 +05:30
Tim Abbott
7d3b451902
lint: Check for extremely long lines.
...
Currently, we check for lines longer than 180 characters; we can lower
this as we clean up or wrap longer strings.
2016-06-25 10:52:03 -07:00
Tim Abbott
ce7c7d3510
Wrap youtube_re.
2016-06-25 10:52:03 -07:00
Tim Abbott
c25c8d8c98
forms: Wrap some very long lines.
2016-06-25 10:52:03 -07:00
Vishnu Ks
7d654a26c8
Casper test for realm creation.
2016-06-25 10:50:12 -07:00
Vishnu Ks
eb9798027c
Move development URLs into dev_urls.py.
2016-06-25 10:50:12 -07:00
Tim Abbott
28b6f1d850
urls: Move non-legacy URLs back out of legacy_urls.py.
...
Only the old API endpoints were actually legacy URLs.
2016-06-25 10:49:56 -07:00
Tim Abbott
982cd5005b
requirements: Remove duplicate coverage dependency.
2016-06-24 21:50:31 -07:00
Taranjeet
71c02c3391
Requirements: Add comments in common.txt.
...
Sourced primarily from puppet/zulip/manifests/app_frontend_base.pp.
[with some additions by tabbott]
2016-06-24 21:49:55 -07:00