Commit Graph

4418 Commits

Author SHA1 Message Date
Harshit Bansal c864816f64 emoji_picker: Extract `register_popover_events()` function. 2017-08-29 14:09:35 -07:00
Harshit Bansal aebb49b18c emoji_picker: Move some functions to avoid lint errors.
Move `render_emoji_popover()` and `toggle_emoji_popover()` to bottom
to avoid lint errors.
2017-08-29 14:09:35 -07:00
Rishi Gupta 09b4927578 hotspots.js: Fix hotspots not appearing.
The original had two bugs in this line of code that cancelled each other
out. 4d0f304 fixed one, causing hotspots to no longer appear. This commit
fixes the second.
2017-08-29 14:08:45 -07:00
Steve Howell 0501570cd1 Remove POST-based API for setting topic mutes. 2017-08-29 16:53:38 -04:00
Cynthia Lin 0686567e46 settings UI: Make disabled checkboxes darker.
Fixes part of #6331.
2017-08-28 21:14:26 -07:00
Vaida Plankyte 30772a2570 onboarding: Replace turtle in onboarding message.
The one we currently have is the same as the one in the registration
emails, and also very low resolution (doesn't show well in lightbox).
Likely we should replace this with something completely different at
some point, but this is an improvement for now.
2017-08-28 20:46:29 -07:00
Rishi Gupta f88949b043 portico-signin.css: Left-justify moving label.
The moving label is acting like a placeholder here, and should be positioned
as such for consistency with the rest of the site. The two forms with a
moving label are /accounts/find/ and /accounts/password/reset.
2017-08-28 20:44:48 -07:00
Rishi Gupta 75337258a8 accounts-settings: Reassure user if they do not have a password for API key. 2017-08-28 20:39:53 -07:00
Cynthia Lin 5f9cd1f7d2 message view: Set mininum height for embedded tweets.
Fixes #5973.
2017-08-28 20:36:12 -07:00
Tim Abbott aa66d0129a settings: Reorder organization settings.
This makes the situation with the "Save changes" buttons slightly more
reasonable.  We'll want to do more on this front, though.
2017-08-28 17:27:22 -07:00
Brock Whittaker dba09c979c Restructure organization settings and permissions.
This restructures organization settings and permissions to be
more accurately grouped and for the permissions page to not be too
long.

CHANGES:

PROFILE:
    (this was split out)
    organization-profile-admin.handlebars:
        form #1:
            name
            description
            (SUBMIT)
        avatar:
            (UPLOAD)
            (DELETE)

SETTINGS:
    organization-settings-admin.handlebars:
        language (mostly untouched)
        message editing:
            time limit/history/retention
        message feed:
            mandatory-topics
            preview images
            preview websites

PERMISSIONS:
    organization-permissions-admin.handlebars
    (mostly stuff was removed)
    Joining:
        restrict domains
        require invite
    User Identity:
        name changes
        email changes
    Streams/Emoji:
        creating streams:
            waiting period (ADDED)
        adding emojis
    (SUBMIT) for whole panel

The profile group (name, description, avatar) were split into a new
page that did not previously exist, and the permissions was stripped
of message settings (message editing, message feed), but keeping the
"waiting period" input and putting it in the "Streams & custom emoji"
section.

Fixes: #5844.
2017-08-28 17:20:13 -07:00
Tim Abbott e74f509b32 settings_org: Add waiting_period_threshhold to framework. 2017-08-28 17:19:16 -07:00
Tim Abbott 98468101c4 settings_org: Decapitalize Text setting type. 2017-08-28 17:14:45 -07:00
Tim Abbott f67326bb81 css: Rename 'Humbug' font to Source Sans Pro.
That's what the font is actually called, and should help future Zulip
developers save time trying to figure out what's up and why our font
is unrelated to the "Humbug" font on the Internet.
2017-08-28 16:16:08 -07:00
Brock Whittaker 40dfef490d /help/: Remove perfectScrollbar.
This removes perfectScrollbar because it breaks CTRL-F.
2017-08-28 16:09:06 -07:00
Tim Abbott b62ce96dc8 css: Fix outline CSS for informational overlays.
Fixes #6188 for real.
2017-08-28 16:08:30 -07:00
Brock Whittaker 2a7480051f third: Update version of Source Sans Pro font.
Our previous version was several years old.
2017-08-28 16:08:30 -07:00
Brock Whittaker b6feac678b Remove all `font-weight: 500` instances.
Previously, the font-weight for 500 did not exist in our set, so
all of those examples defaulted to 400. This fixes them to stay
as they previously were by migrating them to a font weight of 400.
2017-08-28 15:01:53 -07:00
Harshit Bansal 5a54a143be subscriptions: Fix the rendering of emojis in stream descriptions. 2017-08-28 14:49:40 -07:00
Harshit Bansal 912d4ebd66 reactions.css: Remove the hack used for correctly positioning the emojis. 2017-08-28 14:49:40 -07:00
Rishi Gupta 0519bade1b integrations: Remove box-shadow offset on search box.
It looked a bit odd, since we don't use box-shadow offsets anywhere else on
the page (or the app as a whole).
2017-08-28 14:38:24 -07:00
Tim Abbott 1eead8db2d find_account: Fix problematic line-wrapping. 2017-08-28 14:33:06 -07:00
Tim Abbott ac0d90e533 portico: Rename 'find_my_team' to 'find_account'. 2017-08-28 14:29:29 -07:00
Tim Abbott 126171cb76 api: Remove root_domain_uri from API page links.
These pages should be references the current server's UI anyway.
2017-08-28 14:13:37 -07:00
Tim Abbott a0a1fe1512 settings: Rename SERVER_URI to ROOT_DOMAIN_URI.
This should be a lot less confusing.

See #6013 for discussion.
2017-08-28 14:09:28 -07:00
Brock Whittaker d09db16dcd /integrations/: Fix sidebar overflowing parent container.
The sidebar height was set to shorter than what the sidebar actually
was and so it would overflow the parent. By resetting it, it now
will not overflow.

Fixes: #6315.
2017-08-28 12:20:17 -07:00
Brock Whittaker ecae244898 portico-signup: Clean up confirm continue register page.
This cleans up the styling of the page by adding the white box
around the text content, and by making the header the same
`.get-started` class as other headers in the portico-signup group.
2017-08-28 12:10:16 -07:00
Cynthia Lin 1a0a29c41d hotkeys: Fix modal and overlay hiding on user settings.
Fixes #4811
2017-08-28 12:03:16 -07:00
Brock Whittaker 1f9eac990e footer: Responsively remove extra space and compact footer.
This removes some of the min-height constraint on .flex that would
push the footer down futher than it should have been and would
introduce scrolling to the page.
2017-08-28 11:46:07 -07:00
Brock Whittaker a2fc3d34db settings: Make col-width consistent between tables.
This makes the column width consistent between tables in the
organization users section by making the "Name" section 20%.
2017-08-28 11:38:18 -07:00
Brock Whittaker c8641d49b5 /help/: Remove portico footer.
I don't think we need the footer in here.
2017-08-28 11:07:03 -07:00
Brock Whittaker 8435714bb5 Make page responsive around new footers.
This removes the old flex model for the footer to stay at the bottom
of short pages and instead always just positions the footer below
the portico content and makes the content generally tall enough that
issues don't occur.
2017-08-28 11:07:03 -07:00
Brock Whittaker 04888101e2 Replace old portico footer with new sectioned one.
This replaces the old footer that has one section with a small list of
items. This expands the footer to have multiple sections.

Actual content tweaked and tagged for i18n by tabbott.
2017-08-28 11:07:02 -07:00
Brock Whittaker e616b464eb Fix padding around –– OR –– on register form.
This fixes the padding above the –– OR –– line on the register form.
This also fixes the left-alignment of the form starting at 795px
wide.

Fixes: #6265.
2017-08-28 09:51:33 -07:00
Brock Whittaker 6b80c61712 Allow for scrolling of stream membership table again.
This adds perfectScrollbar to the `.subscriber_list_container` to
allow for the table to scroll naturally again. This was broken
because when perfectScrollbar is put on the parent element, any
naturally scrolling element within it will not scroll naturally
anymore.

Tweaked by tabbott to update the scrollbar on rerender.

Fixes: #6215.
2017-08-28 09:48:34 -07:00
Brock Whittaker db1e8edbc3 settings: <tbody> ::after hack no longer required.
The hack used to make the placeholders in the ::after element
work correctly is no longer needed, so we can revert the width
of 200% back to 100%.

The hack is no longer required because Vaida split these into
two tables, of which in the second table there are no columns,
which means that 100% represents the table width rather than
the width of the first column.

Fixes: #6271.
2017-08-28 09:24:51 -07:00
Tim Abbott bb655e6945 css: Fix selecting of the EDITED notices.
Apparently, the previous approach didn't actually work.
2017-08-27 22:54:34 -07:00
Tim Abbott b988a1c661 css: Fix selecting of EDITED notices and weird whitespace.
This completes the effort to make selecting messages work in a way
consistent with what users might expect to be correct.

Fixes #5328.
2017-08-27 22:18:30 -07:00
Tim Abbott b49448de7d message_edit: Eliminat whitespace in recipient row controls.
This is hacky, but I can't figure out another way to do it that
doesn't cause other problems.

Ideally, we'd add some sort of exclude rule to our HTML template
linter so we can check the rest of the file.
2017-08-27 22:18:29 -07:00
Tim Abbott 3c8eb3c743 message_edit: Create recipient_bar_controls span.
This refactor will facilitate making it possible to set CSS properties
on this controls span; in particular, we're hoping to disable user
selection of the whitespace in this region.

The main side effect of this refactor is that we need to add JS code
to also hide the icon-vector-pencil element, since it's now in a new
span.
2017-08-27 22:18:05 -07:00
Tim Abbott f0d8e22b69 css: Don't allow selecting whitespace between hover controls.
This is inspired by #5486 and fixes part of #5328.
2017-08-27 22:18:03 -07:00
Steve Howell 37bf89292a Fix deleting stream from the sidebar.
When we were deleting a stream from the sidebar using the
stream/delete event, we were getting tracebacks due to this sequence
of operations:

    * remove id from stream_list.stream_sidebar
    * rebuild stream list
    * remove sub from stream_data

This fixes the bug by calling stream_data.delete_sub() first.

Deletions are tricky if you do things out of order.  We can probably
prevent tracebacks by having a deleted flag, but that can just cause
different problems.

Last commit tweaked by tabbott to fix a small bug in handling the case
where the user was not subscribed to the delete stream.
2017-08-27 19:11:43 -07:00
Steve Howell 38664e8cad Remove unused call to /json/streams endpoint.
We no longer need /json/streams in settings_streams.js.
2017-08-27 19:08:04 -07:00
Steve Howell 660854f5ad admin: Use client-side data to populate list of streams.
Fixes #3786
2017-08-27 19:08:04 -07:00
Steve Howell 3846e60a71 Add stream_data.get_streams_for_admin(). 2017-08-27 19:08:04 -07:00
Steve Howell 2c925e3567 stream_settings: Remove all_streams variable.
We no longer need this global variable after the prior commit.
2017-08-27 19:08:04 -07:00
Steve Howell 106d58df47 Add stream_data.get_non_default_stream_names().
This allows us to get the typeahead values for adding a default
stream using client-side data.
2017-08-27 19:08:04 -07:00
Steve Howell b32a9444dd js: Clean up how we track default stream names.
We continue to have page_params.realm_default_streams, but
now we do lookups on whether a stream is a default stream
by using a Dict indexed by stream_id.

We are also careful to update that during live updates.

This fixes a flaw that we weren't updating the list of realms
correctly for events that remove a default stream.
2017-08-27 19:08:04 -07:00
Tim Abbott 5d974b7f57 emoji: Remove :s from emoji popover title attributes. 2017-08-27 17:34:44 -07:00
Harshit Bansal 90d8b0f520 emoji_picker: Fix the two different titles appearing for each emoji.
Fixes: #6286.
2017-08-27 17:22:44 -07:00