3c06c899c5
katex_server: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-04 18:53:34 -07:00
d4841bbeff
settings_components: Fix HTMLSelectOneElement selector.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:58:25 -07:00
40440248e6
support: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
2be5cb0223
settings_user_topics: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
939b88b9a7
settings_realm_domains: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
4032f9c0cb
people: Fix bogus filter_people_by_search_terms type.
...
It actually returned Map<number, true>. Set<number> is more
efficient.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
fb7bad235d
message_store: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
4340f400b8
message_store: Fix bogus update_status_emoji_info type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
7a10d8329b
message_store: Fix get_cached_message type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
fe6744ae54
input_pill: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
90978c3233
settings_components: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 15:39:55 -07:00
1a42798b1d
type: Add type HTMLSelectOneElement.
...
Combining HTMLSelectElement & {type: "select-one"} into one type to
improve code readability.
Fixes #29909
2024-05-03 15:32:46 -07:00
d10ad01997
help: Rename and redirect archive-a-stream for channel.
2024-05-03 13:05:57 -07:00
500f476de9
help: Rename and redirect change-the-stream-description for channel.
...
This also contains in-file edits for help/message-retention-policy.md,
help/create-a-channel.md, and help/configure-automated-notices.md.
2024-05-03 13:05:54 -07:00
b714bd9eec
help: Rename and redirect set-default-streams-for-new-users for channel.
2024-05-03 13:02:20 -07:00
c931966e1b
help: Rename and redirect stream-sending-policy for channel.
2024-05-03 13:02:20 -07:00
5342d4ecfb
help: Rename and redirect stream-permissions for channel.
2024-05-03 13:02:19 -07:00
859340c914
help: Rename and redirect mute-a-stream for channel.
2024-05-03 12:55:39 -07:00
d97571e1df
help: Rename and redirect manage-inactive-streams for channel.
2024-05-03 12:55:39 -07:00
9c353d812e
help: Rename and redirect message-a-stream-by-email for channel.
2024-05-03 12:55:39 -07:00
14b899eb20
help: Rename and redirect create-streams for channel.
2024-05-03 12:55:39 -07:00
4dbda25e2e
help: Rename and redirect streams-and-topics for channel.
2024-05-03 12:55:39 -07:00
ffd1a80ef4
common: Remove copy_data_attribute_value.
...
Commit 90d0531e20#23721 ) removed
envelope-link and data-admin-emails.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
eb45eca57b
support: Replace common.copy_data_attribute_value with clipboard.js.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
252b0f193e
password_quality: Convert .data("minLength") et al. to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
7a5e68161a
list_widget: Convert .data("sort"), .data("sort-prop") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
382eec17e2
list_widget: Convert .data("empty") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
72688c26b5
invite: Convert .data("loading-text") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
64c2d442ac
web: Convert .data("user-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
455f8a9c53
web: Convert .data("stream-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
bc9a7ef274
components: Convert .data("tab-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
153847d617
web: Convert .data("search-results-empty") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
ebea1eed18
sidebar_ui: Convert .data("animated-url"), .data("still-url") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
5950093ae0
settings_components: Convert .data("method") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
64c8262eaf
settings_components: Convert .data("setting-widget-type") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
abee323c77
web: Convert .data("code-language") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
c2bae4c9d9
message_list_tooltips: Convert .data("is-bot") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
87ea4313cd
web: Convert .data("message-id") to .attr.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
c97f6c6c71
loading: Remove dead data-spinner_obj access.
...
As of commit 7b00bd6f7e
2024-05-03 12:45:46 -07:00
518daff9db
lightbox: Set data-filename as an attribute, not an invalid property.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 12:45:46 -07:00
f07ed8b6b3
hashchange: Restore narrow state on `escape` keypress to `feed`.
...
If user goes to combined feed view on escape keypress, then
we restore their narrow pointer and offset by restoring it from
browser history if the their last narrow was the combined feed view.
2024-05-03 12:42:22 -07:00
240f7b53b2
message_lists: Remove `save_pre_narrow_offset_for_reload`.
...
This is no longer required since narrow state is restored by
`reload` library and narrow history restores the narrow pointer
and offset when going back to a view.
Only regression here is we will no longer restore the pointer when
user navigates to the combined feed view without using browser back
button and combined feed view is the default view. This is fixed
in the next commit.
2024-05-03 12:42:22 -07:00
2eb216f1da
message_list: Only update selected id and banner for current list.
2024-05-03 12:42:22 -07:00
439091998d
hashchange: Restore pointer state for combined feed view.
...
Now, user can use browser back button to go their last selected
message in combined feed view.
2024-05-03 12:42:22 -07:00
24f47e8993
narrow_history: Use a more accurate way to check hashchange status.
...
`hash_util.search_terms_to_hash` doesn't work correctly for all
hashes, main one being the combined feed view.
2024-05-03 12:42:22 -07:00
f786c2c5d7
hash_util: Fix wrong type specified for `hash` parameter.
2024-05-03 12:42:22 -07:00
478a4a59bc
hash_util: Make it clear that the function doesn't work for all views.
2024-05-03 12:42:22 -07:00
fb9acf8911
message_row: Establish clarifying messagebox-includes-sender class.
2024-05-03 12:34:27 -07:00
6c5085b827
message_header: Bring over control hover selectors.
2024-05-03 12:34:08 -07:00
50c744db48
left_sidebar: Apply grid to 'more conversations' DM row.
2024-05-03 12:21:59 -07:00
6c9484e0be
drafts_overlay_ui: Remove incorrect $ prefix from non-jQuery variable.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 11:42:43 -07:00
7e2811d633
message_view_header: Extract styles to own file.
...
This has the added value of being named in parallel with
web/src/message_view_header.ts
2024-05-03 11:12:55 -07:00
a37deb9fbc
settings: Use settings-field-label class in language widget label.
...
We now use "settings-field-label" class in the label of language
selection widget instead of "title" class to add the bottom margin.
2024-05-03 09:51:36 -07:00
62d2b93079
settings: Remove dropdown-title class.
...
We now use "settings-field-label" and "modal-field-label"
class on label elements in settings and modals respectively
to add the bottom margin which was previously done by
"dropdown-title" class as it is better to have more
generic names to use on label for all type of inputs.
2024-05-03 09:51:36 -07:00
040486776c
modals: Add bottom margin to label elements.
...
This commit adds bottom margin to label elements of
different inputs by adding "modal-field-label" class
to the label elements. Some of them already have the
margin due to having dropdown-title class.
2024-05-03 09:51:36 -07:00
8c6e71a195
settings: Add bottom margin to label elements.
...
This commit adds bottom margin to label elements of
settings inputs in personal, organization, stream
and group settings using the recently added
"settings-field-label" class.
Most of the settings are dropdown settings, so the
label for them already had a margin as they use
"dropdown-title" class.
2024-05-03 09:51:36 -07:00
e7a4790d33
settings: Remove extraneous hr element below "Field choices".
...
There is no need to have hr element below the "Field choices"
heading in custom profile edit form and this also makes it
consistent with the new custom profile field form.
2024-05-03 09:51:36 -07:00
916ea58aaf
settings: Remove unused classes from label elements.
...
This commit removes classes like "title", "input-label"
and "emoji-theme" from label elements in settings and
modals as these are classes are neither used in JS
nor to apply any CSS.
2024-05-03 09:51:36 -07:00
6f4a58fe71
settings: Place and style .settings-field-label on Profile.
2024-05-03 09:51:36 -07:00
10df1c414f
settings: Simplify field-hint selector.
2024-05-03 09:51:36 -07:00
8512ea124d
settings: Add variable for field/hint bottom margin.
2024-05-03 09:51:36 -07:00
29508e54b0
settings: Extend use of settings-profile-user-field-hint class.
2024-05-03 09:51:36 -07:00
38f51683a4
settings: Improve settings-profile-user-field-hint class.
...
This slight transposition makes it read closer to the adjacent
`settings-profile-user-field` class.
2024-05-03 09:51:36 -07:00
5d468ddef8
left_sidebar: Add colon `:` to the list of stream word separators.
2024-05-03 09:20:53 -07:00
519c520c32
tippyjs: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
38f040ad79
search: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
33430f06c3
list_widget: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
f44d343511
invite: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
7cd3a99aad
user_group_popover: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
57c6bfadf6
stream_list: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
ba7fd860b1
spoilers: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
43d83105c6
settings_invites: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
51f929d032
settings_emoji: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
343e80c6fa
recent_senders: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
6f18551b7a
signup: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
3e1736c776
narrow_state: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
89af74f420
message_viewport: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
a3507b8a11
message_util: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
52a992d858
message_edit_history: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
189865f427
localstorage: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
279d911420
lightbox: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
d235675a06
integration_url_modal: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
2642f521c1
hotspots: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
75eb9fb852
flatpickr: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
2e9b313333
dialog_widget: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
e9d0e43668
condense: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
9c6c09b6e0
compose_call: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
d1a2d42403
buddy_list: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
7651a00566
blueslip: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
3c2fae1171
poll_data: Fix implicit use of any.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-03 09:13:07 -07:00
1ba3cda229
compose: Refactor recipient area to use grid layout instead of flexbox.
...
This is a prep commit for moving the narrow to compose recipients button
before the input, and also aids in the overall compose area redesign.
2024-05-02 14:28:04 -07:00
512d53d01a
invites: Stop adjusting invited_at on resends.
2024-05-02 14:23:04 -07:00
afafd04bf9
message_fetch: Increase message history fetching numbers.
...
Now that we've greatly reduced unnecessary data fetches, we have
greater freedom to increase these values while still having good
performance.
2024-05-02 13:59:19 -07:00
a7a89dcc72
message_fetch: Remove on-idle backfill behavior.
...
This only every did a single extra fetch, and now that this fetch is
in the same direction as our main fetching sequence, no longer is
meaningfully different from just specifying a different value of
consts.maximum_initial_backfill_size.
2024-05-02 13:55:17 -07:00
f999de2de2
message_edit: Fix local echo of message edit.
...
Previously, when a message is edited, it is locally echoed with its
pre-edit content.
This is because previously, when we tried to render the edited
message of the edit box during local echo, in order to update
the content, flags, and is_me_message properties of the message
object with that of those returned is markdown.render(), we used
the spread operator and created a new message object, and updated
the existing message object with this new one.
This was misconverted, since edit_locally() method already has a
fully-rendered message object to start with, and is just doing a
rerendering, it should be mutating what message it received, rather
than constructing a new local variable.
2024-05-02 13:51:15 -07:00
d73a5d06c0
compose(typeahead): Remove text color change on hover.
...
Fixes #29842 .
2024-05-02 13:47:47 -07:00
165df5f1f6
message_header: Build message_header.css from zulip.css header styles.
2024-05-02 13:38:58 -07:00
4394e87ef1
popovers: Move from global popover min-width to per-popover basis.
...
This removes the common min-width being used across all popovers and
instead sets the min-width according to a popover's requirements.
This allows for greater control over the popovers since we have a
variety of use cases for them — which a single common min-width cannot
accommodate.
2024-05-02 13:31:37 -07:00
6325ef4896
message_row: Pull message-edit selectors out of .message_row selector.
2024-05-02 13:27:02 -07:00
b5f3702de0
message_row: Pull .locally-echoed selectors out of .message_row stack.
2024-05-02 13:27:02 -07:00
Anders Kaseorg
afeefuddin
Lauryn Menard
Aman Agrawal
Karl Stolley
Sahil Batra
N-Shar-ma
Alex Vandiver
Tim Abbott
roanster007
nimishmedatwal
Sayam Samal