165b6c1ff3
topic lists: Improve node test to show HTML correctly.
2016-11-05 10:38:37 -07:00
1119a24ea3
node tests: Extract node_tests/topic_list.js
...
This moves one method over from stream_list.js. There's still a
lot of boilerplate here, unfortunately, as topic lists have a lot
of dependencies on other parts of the system--narrowing state,
muting state, jQuery, handlebars, etc.
2016-11-05 10:38:37 -07:00
6544c756d6
forms.py: Reorder imports.
2016-11-05 10:37:15 -07:00
5e6d4da8a8
realm creation flow: Prevent disposable email signups.
...
Check user's email address against a list of 2000 disposable email
domains. Does not affect the create_realm management command.
2016-11-05 10:37:15 -07:00
2033381d24
realm creation flow: Restrict subdomains one can create via the web flow.
...
Disallow Realm.string_id's like "streams", "about", and several hundred
others. Also restrict string_id's to be at least 3 characters long, and only
use characters in [a-z0-9-].
Does not restrict realms created by the create_realm.py management command.
2016-11-05 10:37:15 -07:00
c6ceae868b
requirements: Upgrade twisted, adding incremental and constantly.
...
Twisted 16.5.0 has a couple new dependencies.
2016-11-05 09:13:35 -07:00
be506d63f6
requirements: Upgrade a bunch of minor Python package versions.
...
These are all minor versions and thus shouldn't have any impact.
2016-11-05 09:13:28 -07:00
e3646f28bd
test_helpers.py: Fix default args for submit_reg_form_for_user.
...
Previously realm_name and realm_subdomain defalted to None, which when
posted to /accounts/register, are submitted as u'None'. "None" is an invalid
Realm.subdomain, since subdomains can't have capital letters.
2016-11-04 22:01:53 -07:00
950831810b
test_signup.py: Refactor test_create_realm_with_subdomain.
...
Refactor test_create_realm_with_subdomain to match test_create_realm more
closely, so that it's easier to see their similarities and differences.
2016-11-04 22:01:53 -07:00
4db10a05de
test_signup.py: Move test_create_realm_with_subdomain to correct place.
...
Before it was in UserSignUpTest, now it is in RealmCreationTest. The diff
makes it look like test_user_default_language is the target of the move,
but it isn't.
2016-11-04 22:01:53 -07:00
70223ef2da
[third] Update marked base to newer version 0.3.6.
...
This basically re-applies the Zulip changes to marked 0.3.6.
Fixes #2190 .
2016-11-04 21:56:53 -07:00
51fcf1fb7a
tests: Fix spelling of test_transifex.py.
2016-11-04 21:49:39 -07:00
df4b777b35
tests: Fix handling of subdirs and backup files in test-backend.
...
Fixes #1950 .
2016-11-04 21:49:23 -07:00
19b01d74fa
bug fix: Send stream notifications to all users for public streams.
...
If a stream is public, we now send notifications to all realm users
if the name or description of the stream changes. For private
streams, the behavior remains the same.
We do this by introducing a method called
can_access_stream_user_ids().
(showell helped with this fix)
Fixes #2195
2016-11-04 21:41:41 -07:00
c405b67138
tests: Ignore SAVEPOINT queries in queries_captured().
...
We use the queries_captured() context manager in our tests
to capture queries that happen during certain actions. Usually
we use the list of queries to validate that we're not doing
too many database calls.
For most tests the database calls are fairly deterministic,
but SAVEPOINT-related things seem to be more random, and the
number of savepoints is usually not relevant to what the test
is trying to prevent, which is more serious problems like
O(N) database fetches.
2016-11-04 21:30:36 -07:00
e17cb79701
node tests: Remove compile-settings code from templates.js.
2016-11-04 21:23:35 -07:00
6a1b53a195
node tests: Remove compile-settings code from i18n.js.
2016-11-04 21:23:35 -07:00
dae53573cb
node tests: Fix make_sure_all_templates_have_been_compiled().
...
This now searches subdirectories.
2016-11-04 21:23:35 -07:00
3d0c0e2e81
node tests: Remove retry logic for compiling templates.
...
We can now use template_finder.get() to find the name we need.
2016-11-04 21:23:35 -07:00
ee8d54db0f
Change content to rely on data-* attribute.
...
Content now relies on the data-no-description attribute which then
allows for it to be embedded in HTML and therefore translatable.
2016-11-04 17:26:53 -07:00
4400665a6d
subs: Move stream settings into an independent overlay.
...
This replaces the scrolling stream settings feature with a stream
settings overlay.
2016-11-04 17:13:26 -07:00
78ec0341c4
subs: Fix color picker issue with subscribing.
2016-11-04 17:13:26 -07:00
73f020645f
subs: Remove unnecessary update_stream_color call.
...
The color was already being updated in the response from the server.
2016-11-04 16:37:29 -07:00
a70c5eb923
colorpicker: Migrate to use stream IDs to access things.
2016-11-04 16:37:29 -07:00
ab6fd87161
subs: Fix rename stream handling of email addresses.
2016-11-04 16:37:29 -07:00
e6734bfada
subs: Cleanup stream rename logic.
2016-11-04 16:37:29 -07:00
ee976a9bdc
subs: Use subscription_settings when changing descriptions.
2016-11-04 16:37:29 -07:00
45c7945818
subs: Use sub_settings in subscriber add/remove flow.
2016-11-04 16:37:29 -07:00
8e522cd933
subs: Convert stream_home_view_clicked to use sub_settings.
2016-11-04 16:37:29 -07:00
2467f765ad
subs: Stop using sub_row when rendering settings.
2016-11-04 16:37:29 -07:00
16408da823
subs: Cleanup change_stream_privacy.
...
We now:
(1) Only look up streams by ID
(2) Correctly look up both the stream-row and subscriptions_row after
the success handler returns.
2016-11-04 16:37:29 -07:00
32a571445a
subs: Use settings_for_sub when redrawing privacy stuff.
2016-11-04 16:37:29 -07:00
b67c0a4ad5
subs: Move settings_for_sub and button_for_sub earlier.
2016-11-04 16:37:28 -07:00
b1a5d57405
subs: Update get_subscriber_list to use subscription_setings.
2016-11-04 16:37:28 -07:00
109287dceb
subs: Update descriptions in settings separately from stream rows.
2016-11-04 16:37:11 -07:00
7a59ae591a
subs: Fix get_stream_name to use IDs from the DOM.
...
We haven't added a data-stream-name to the subscription_settings
object yet, and ideally we'd be moving away from using
data-stream-name anywhere.
2016-11-04 16:16:07 -07:00
cc03d2014d
subs: Add missing li open/close tags.
...
Two elements were sharing the same li element, when they should be
in different elements.
2016-11-04 13:58:36 -07:00
9b90a47fd6
Change .sub_settings_title to div.
...
All the properties they had weren’t being activated because they were
inline elements. Change to div to activate properties.
2016-11-04 13:55:11 -07:00
7d51b6a454
subs: Create get_stream_name to get stream name from UI.
...
This accepts an arbitrary click target in the DOM inside a stream row
or stream settings element and returns the stream name.
2016-11-04 13:53:12 -07:00
2088e8420f
User user_id, not email, in peer_add events.
2016-11-04 11:37:14 -07:00
c5c3dfe33f
Add subscriber counts to changelog.md.
2016-11-04 11:37:14 -07:00
17e39a88ef
Remove people.test_set_people_name_dict().
...
We use a cleaner approach to setting up test data in echo.js to
allow us to remove the one call to test_set_people_name_dict().
2016-11-04 11:37:14 -07:00
8c47f7f7db
Remove people.test_set_people_dict().
2016-11-04 11:37:14 -07:00
472f049cae
Alphabetize subscription event cases in server_events.js.
...
I also split up peer_add and peer_remove into their own cases,
since they do opposite things and didn't share that much code
in common.
2016-11-04 11:37:14 -07:00
c3f2740481
Remove email_dict from gather_subscriptions_helper().
2016-11-04 11:37:14 -07:00
38f2789152
Remove page_params.email_dict.
2016-11-04 11:37:14 -07:00
3941334d00
Use user_ids for subscribers in stream_data.js.
...
We still shim a lot of methods to keep using emails, but the
internal data structure now has user_ids.
2016-11-04 11:37:12 -07:00
7509f73f02
Clean up stream renaming in the JS code.
...
We now use stream_id as our key to rename streams, which
should prevent a few race conditions long term. (We are
still possibly contending with other events that use
stream_name as a key, so this is not perfect.)
2016-11-04 11:30:18 -07:00
e1372ddf5d
Add people.get_user_id().
2016-11-04 11:30:18 -07:00
4ace9bbd77
Remove dead code related to subs.create_sub().
...
Since we started handling the stream/create event properly,
create_sub() became dead code.
2016-11-04 11:30:18 -07:00
Steve Howell
Rishi Gupta
Tim Abbott
hackerkid
sonali0901
Mohsen Ibrahim
Brock Whittaker