Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
42,936 Commits 28 Branches 143 Tags 626 MiB
Commit Graph

42936 Commits

Author SHA1 Message Date
Priyank Patel 08f5349666 settings_streams: Use e.key instead of deprecated e.which. 
Tested by making sure Enter works as expected in the default stream
input at Manage organization > Default stream.
 2021-06-02 14:04:53 -07:00
Priyank Patel a218143db7 search: Use e.key instead of deprecated e.which. 
Tested by making sure Enter works and expected in the navbar search
with and without the typeahead being present.
 2021-06-02 14:04:53 -07:00
Priyank Patel 607abc0b77 signup: Use e.key instead of deprecated e.which. 
Tested by making sure Enter works as expected in the signup flow.
 2021-06-02 14:04:53 -07:00
Priyank Patel baad874689 integrations: Use e.key instead of deprecated e.which. 
Tested by making sure Enter does the search in the integrations page
when the input is not empty.
 2021-06-02 14:04:53 -07:00
Priyank Patel 969874d633 alert_words_ui: Use e.key instead of deprecated e.which. 
Tested by making sure alert word is added when Enter is pressed in
the alert word input.
 2021-06-02 14:04:53 -07:00
Priyank Patel 98cb0e339c click_handlers: Use e.key instead of deprecated e.which. 
Tested by making sure Enter and Escape works as expected in the edit
stream name in the subscriptions modal.
 2021-06-02 14:04:53 -07:00
Priyank Patel 5fdcf7b534 click_handlers: Use e.button instead of deceprated e.which. 
The middle button click is represented by 1. Tested by clicking
middle button on zulip logo and making sure it is not focused.
 2021-06-02 14:04:53 -07:00
Priyank Patel 53d2712027 settings_org: Use e.key instead of deprecated e.keyCode. 
Tested by making sure pressing Enter in the input field of the
changed organization settings (the organization name for example)
clicks the save changes button if present.
 2021-06-02 14:04:53 -07:00
Priyank Patel 63cf47b63a stream_create: Use e.key instead of deprecated e.keyCode. 
Tested by making sure pressing Enter in the stream creation
description did not create a new line.
 2021-06-02 14:04:53 -07:00
Priyank Patel 121e21d3b9 poll_widget: Use e.key instead of deprecated e.keyCode. 
Tested by making sure Enter and Escape work for editing poll title
and adding new poll options.
 2021-06-02 14:04:53 -07:00
Priyank Patel c292ade96a message_edit: Use e.key instead of deprecated e.keyCode. 
Tested by making sure Enter and Escape works as expected for editing
topics and messages.
 2021-06-02 14:04:53 -07:00
Priyank Patel 2cb71ccc7b emoji_picker: Use e.key instead of deprecated e.keyCode. 
Tested by opening the emoji picker from the composebox and making
sure Enter works as expected on the input.
 2021-06-02 14:04:53 -07:00
Gaurav Pandey f67fc37f7d settings: Rename MAX_EMOJI_FILE_SIZE. 
Rename MAX_EMOJI_FILE_SIZE to
MAX_EMOJI_FILE_SIZE_MIB reflecting
the size in mebibytes.
 2021-06-02 13:55:15 -07:00
Gaurav Pandey 73059dd0c7 settings: Rename MAX_LOGO_FILE_SIZE. 
Rename MAX_LOGO_FILE_SIZE to
MAX_LOGO_FILE_SIZE_MIB reflecting
the size in mebibytes.
 2021-06-02 13:55:15 -07:00
Gaurav Pandey 2ddc62e9b3 settings: Rename MAX_ICON_FILE_SIZE. 
Rename MAX_ICON_FILE_SIZE to
MAX_ICON_FILE_SIZE_MIB reflecting
size in mebibytes.
 2021-06-02 13:55:15 -07:00
Gaurav Pandey 0f6bb210a6 settings: Rename MAX_AVATAR_FILE_SIZE. 
Rename MAX_AVATAR_FILE_SIZE to
MAX_AVATAR_FILE_SIZE_MIB reflecting
size in mebibytes.
 2021-06-02 13:55:15 -07:00
Alex Vandiver 66f77d3b4b send_test_email: Capture and show SMTP log on errors. 2021-06-02 13:18:11 -07:00
Tim Abbott 84c7c8cc0d version: Update version and changelog after 4.3 release. 2021-06-02 12:55:50 -07:00
Alex Vandiver 3ebd627c50 puppet: Fix "import" -> "include" in chat_zulip_org. 2021-06-02 11:02:34 -07:00
Tim Abbott a49e685d97 i18n: Adjust Transifex sync-translations download mode. 
It appears that some server-side change to Transifex resulted in the
"onlytranslated" mode deleting some (all?) strings from django.po files that
were not translated.

Testing determined that the "translator" mode appears to now be the
only mode that works with both our django.po and translations.json
files (We want to avoid both copying the English strings and deleting
strings), so we're switching to that.

Background is available here:
https://chat.zulip.org/#narrow/stream/3-backend/topic/4.2Ex.20branch.20translations.20sync/near/1187324
 2021-06-02 09:48:58 -07:00
PIG208 2ee00972a0 doc: Change supported extension type to reflect the change. 2021-06-02 09:31:38 -07:00
Tim Abbott 05d4c070f4 api docs: Clarify topic and stream_id fields of message edit API. 2021-06-02 08:53:02 -07:00
Suyash Vardhan Mathur db4b674270 apidocs: Fix description of topic parameter in update_message. 
The information of topic being required for stream messages
in update_message OperationID wasn't true. Fixed the
incorrect description.
 2021-06-02 08:38:00 -07:00
Alex Vandiver 2130fc0645 puppet: Add an explicit class for czo. 2021-06-01 22:18:50 -07:00
Abhijeet Prasad Bodas 2489a1bb4c test_event_queue: Don't use lists for call_args assertions. 
This is a bit hacky, but will make these tests more readable,
in that the reader would not have to remember the order or parameter
names.

Python 3.8 introduced `mock.call_args.kwargs`, and once we upgrade,
we can use those to assert actual dictionaries instead of this hack.
 2021-06-01 15:26:49 -07:00
Abhijeet Prasad Bodas f88b943ff4 email_notifications: Remove unnecessary `online_emails` check. 
We already check this in `handle_missedmessage_emails` through
`receives_offline_email_notifications`.
 2021-06-01 15:26:49 -07:00
Abhijeet Prasad Bodas 44534ca47e refactor: Move receives_email_notifications tests to designated file. 2021-06-01 15:26:49 -07:00
Abhijeet Prasad Bodas 3990b183ce models: Remove unused `receives_stream_notifications` function. 
This was introduced in c3a8138f74, but
doesn't have any callers, apart from it's own tests.
 2021-06-01 15:26:49 -07:00
Abhijeet Prasad Bodas 518deb7b9e models: Rename `receives_online_notifications` function. 
Prep for later when we will have a similar setting for
online email notifications.
 2021-06-01 15:26:49 -07:00
Abhijeet Prasad Bodas e11648f22e docs: Fix typo in subsystems/notifications.md. 2021-06-01 15:26:49 -07:00
Siddharth Asthana a4fcbcd4aa static: Fix the incorrect warning message when unsubscribing from stream. 
Fixes #18661
 2021-06-01 14:58:47 -07:00
Alex Vandiver 1771f61f96 docs: Add a missing close paren. 2021-06-01 14:57:42 -07:00
Alex Vandiver 663d3b780d docs: Update path to nginx.conf, as it is now a template. 
Also provide the right expansion for the one embedded variable
currently in the template.
 2021-06-01 14:57:42 -07:00
Priyank Patel 6e59d08a74 settings_org: Fix incorrect selector for the save changes button. 
This change fixes a bug where pressing Enter does not save the
changes as expected, due to an incorrect selector, when the
save/discard changes button shows up in settings. Tested by changing
the Organization name and pressing Enter at Manage Organization >
Organization profile > Organization name.
 2021-06-01 14:56:10 -07:00
Signior-X f79b92a4d0 docs: Add syntax highlighting in api docs. 
This commit adds the language of code snippets in api
markdowns wherever it was left.
 2021-06-01 10:03:25 -07:00
Mateusz Mandera b202116594 auth: Extract sync_user_profile_custom_fields function from ldap sync. 
This logic will be reusable for analogical sync in other auth codepaths.
 2021-06-01 08:32:50 -07:00
Aman Agrawal 36051877a5 recent_topics: Optimize for mobile devices. 
On small widths, add margin to right to action buttons so
that they don't they trigger scrollbar when clicked upon.

Make action buttons larger so that they are easier to click / tap on small
widths.
 2021-06-01 08:32:06 -07:00
Mateusz Mandera e1b8315f5e docs: Give an example command for generating SAML key/cert pair. 2021-06-01 08:29:05 -07:00
Mateusz Mandera b31ef13cf1 docs: Mention that SAML private key cannot be encrypted. 
The underlying xmlsec library doesn't give a very useful error when
trying to load an encrypted private key which can lead to confusion.
 2021-06-01 08:29:05 -07:00
Mateusz Mandera 932c846454 custom_fields: Fix confusing comments for do_update_..._if_changed. 
d66cbd2832 added these mentioning
"always_notify" for some reason, but always_notify clearly isn't a real
thing in this context so the comments need to be fixed to eliminate this
potential source of confusion.
 2021-05-28 15:51:28 -07:00
Anders Kaseorg 6702f434ca giphy: Load Giphy SDK lazily. 
The Giphy SDK sends tracking pings when it loads; we don’t want those
to be sent for visitors who aren’t using Giphy.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-28 15:44:49 -07:00
Anders Kaseorg 80b6808de0 draft: Fix incorrectly centered topics in drafts modal. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-05-28 15:44:19 -07:00
Mateusz Mandera 47a4a9193f auth: Make full_name_validated attr of generic OIDC configurable. 
This will be useful for deployments that want to just use the full name
provided by the IdP and thus skip the registration form. Also in
combination with disabling name changes in the organization, can force
users to just use that name without being able to change it.
 2021-05-28 09:50:23 -07:00
Mateusz Mandera e17758f8ad auth: Implement a generic OpenID Connect backend. 
Fixes #11939.
 2021-05-28 09:43:06 -07:00
Tim Abbott 1103720f45 pgroonga: Remove unnecessary code from first migration. 
This avoids doing a bunch of extra work, including a downtime-risky
`CREATE INDEX` without CONCURRENTLY, when migrating a modern Zulip
system to PGroonga the first time.
 2021-05-28 09:42:33 -07:00
Tim Abbott e0992c85fb migrations: Remove pgroonga check for postgres database. 
Zulip has only supported postgres for a long time, and this is
unlikely to change, so this code was just extra clutter.
 2021-05-28 09:42:33 -07:00
Abhijeet Prasad Bodas 7a4c212dff test_subs: Add comments about num_events. 
This is a bit complex, because many events not directly related
to what we are testing are also sent during these operations, hence
these comments.
 2021-05-28 09:42:14 -07:00
Abhijeet Prasad Bodas aa2fd1593e tornado_redirected_to_list: Fix event list leaks in tests. 
Ideally this should have been part of
481a890ec5.
 2021-05-28 09:42:14 -07:00
Abhijeet Prasad Bodas 3039a01b31 tornado_redirected_to_list: Make expected_num_events required argument. 
Follow up to 481a890ec5.
This will make this more explicit and readable.
 2021-05-28 09:42:14 -07:00
Aman Agrawal 07f972f45a message_events: Pass correct new stream id to recent_senders. 
We were passing new_stream_id as undefined in case of topic
edit as event.new_stream_id is undefined in that case.

We pass the correct stream_id to fix it.
 2021-05-28 09:41:02 -07:00