Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
58,726 Commits 28 Branches 143 Tags 614 MiB
Commit Graph

4 Commits

Author SHA1 Message Date
Anders Kaseorg 9c6c09b6e0 compose_call: Fix implicit use of any. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-03 09:13:07 -07:00
Anders Kaseorg b9e62c7af8 page_params: Split out state data for realm. 
For spectators, the chunk of page_params that originates from
do_events_register isn’t assigned until ui_init.js.  That means the
TypeScript type of page_params is mostly a lie during module load
time: reading a parameter too early silently results in undefined
rather than the declared type, with unpredictable results later on.

We want to make such an early read into an immediate runtime error,
for both users and spectators consistently, and pave the way for
runtime validation of the page_params type.  As a second step, split
out the subset of fields that pertain to the entire realm.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-02-15 10:22:52 -08:00
Anders Kaseorg 3d55e7ef10 eslint: Fix @typescript-eslint/prefer-nullish-coalescing. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-12-23 15:36:05 -08:00
Anders Kaseorg 340b0a1181 compose_call: Convert module to TypeScript. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-10 16:48:57 -07:00