6 Commits

Author	SHA1	Message	Date
Anders Kaseorg	876806eb4d	zjsunit: Lift restriction against mocking third party modules. ... Use fully resolvable request paths because we need to be able to refer to third party modules, and to increase uniformity and explicitness. Signed-off-by: Anders Kaseorg <anders@zulip.com>	2021-03-12 10:06:30 -08:00
Steve Howell	eea78df688	node tests: Clean up mock_module calls. ... This is a deceptively ugly diff. It makes the actual code way more tidy. I basically inlined some calls to mock_module and put some statements in lexical order.	2021-03-07 09:35:58 -05:00
Steve Howell	f54f7cfc33	node tests: Introduce mock_module helper.	2021-03-06 13:15:04 -05:00
Steve Howell	167fda142c	node tests: Remove __esModule cruft. ... We just set __esModule in our rewiremock helper.	2021-03-06 12:36:07 -05:00
Steve Howell	30c7108955	zjsunit: Remove rewiremock dependency. ... We now just use a module._load hook to inject stubs into our code. For conversion purposes I temporarily maintain the API of rewiremock, apart from the enable/disable pieces, but I will make a better wrapper in an upcoming commit. We can detect when rewiremock is called after zrequire now, and I fix all the violations in this commit, mostly by using override. We can also detect when a mock is needlessly created, and I fix all the violations in this commit. The one minor nuisance that this commit introduces is that you can only stub out modules in the Zulip source tree, which is now static/js. This should not really be a problem--there are usually better techniques to deal with third party depenencies. In the prior commit I show a typical workaround, which is to create a one-line wrapper in your test code. It's often the case that you can simply use override(), as well. In passing I kill off `reset_modules`, and I eliminated the second argument to zrequire, which dates back to pre-es6 days.	2021-03-06 11:10:57 -05:00
Steve Howell	779f56d411	node tests: Add test for compose_state.	2021-03-05 12:57:20 -05:00