Brock Whittaker
ec9bad4096
Hide the emoji icon in message when emoji is selected.
...
This hides the emoji icon from the shown state when users select an
emoji from the popover.
2017-03-06 22:24:21 -08:00
Brock Whittaker
4d5aa3ddc9
Restyle and refactor .message_controls for better UX.
...
This refactors the .message_controls to stop relying on absolute
positioning and strange CSS, and throws them inline.
This also restyles so they hang to the right of the time which is now
always present.
Fixes : #3761 .
2017-03-06 22:24:21 -08:00
Tim Abbott
dcb14ec58e
jinja2: Fix mypy confusion caused by weird six import.
2017-03-06 22:24:07 -08:00
Tim Abbott
950e06cf32
populate_db: Remove unused Deployment import.
2017-03-06 00:11:53 -08:00
Tim Abbott
1c3dbdcefe
models: Remove obsolete realm.deployment property.
...
We've now removed all of the code that accesses this.
2017-03-06 00:11:13 -08:00
Tim Abbott
10a52147fc
zilencer: Remove obsolete create_deployment command.
2017-03-06 00:10:03 -08:00
Tim Abbott
e90df029bf
create_realm: Eliminate obsolete deployment code.
...
Since we're not using this model anymore, we certainly don't need it
when creating realms.
2017-03-06 00:07:45 -08:00
Tim Abbott
8815a598d8
digest: Remove obsolete deployment code.
...
This system was quite complicated, and never had great semantics.
Eventually, we'll want some other system for gating which server
should generate digest emails for which realm controlled via the
database.
2017-03-06 00:05:21 -08:00
Tim Abbott
d286c5e68f
feedback: Remove unnecessary realm_for_email.
...
This also has the side effect of removing the hardcoding of
feedback@zulip.com here.
2017-03-06 00:01:58 -08:00
Tim Abbott
6cbd0fcafa
feedback: Move feedback logic out of queue_processors.py.
...
This will make it easier to unit test this logic in the future.
2017-03-06 00:01:57 -08:00
Tim Abbott
e1c1f96f9e
zilencer: Eliminate submit_feedback indirection.
2017-03-06 00:01:57 -08:00
Tim Abbott
ed5b76f566
zilencer: Move feedback code to zerver/lib/feedback.
2017-03-06 00:01:57 -08:00
Tim Abbott
1f9d93bc96
submit_feedback: remove unused domainish variable.
2017-03-06 00:01:57 -08:00
Tim Abbott
9a08ef5545
zilencer: Remove FEEDBACK_TARGET forwarding logic.
...
This feature hardcoded zulip.com, and never really made much sense
("feedback" should generally go to the local server administrator, not
to the Zulip development community).
2017-03-06 00:01:57 -08:00
Tim Abbott
69061e6db4
zilencer: Remove obsolete lookup_endpoints_for_user endpoint.
...
This endpoint was part of the same obsolete system as
desktop_sso_dispatch.
2017-03-06 00:01:56 -08:00
Tim Abbott
9e8023843a
zilencer: Remove obsolete desktop_sso_dispatch.
...
This feature has been obsolete since when Zulip was released as open
source software, since it's purpose was to avoid putting a "server
url" prompt in the desktop app, and now that prompt is required
anyway.
2017-03-06 00:01:47 -08:00
Eeshan Garg
70df1f5829
new-feature-tutorial: Recommend updating user documentation.
...
Fixes : #3876
2017-03-05 23:04:56 -08:00
Tim Abbott
89eb7636ba
remove_push_device_token: Remove unused request argument.
2017-03-05 22:01:28 -08:00
Tim Abbott
657dfcbddc
push: Move remove_push_device_token to library.
2017-03-05 19:15:17 -08:00
Tim Abbott
c0ad9c02fd
push: Extract validate_token helper function.
2017-03-05 19:15:17 -08:00
Tim Abbott
271bd5a282
push: Move add_push_device_token to library.
2017-03-05 19:15:16 -08:00
Tim Abbott
410c0626a6
push: Pass apple alert via the zulip dict.
...
This completes the process of simplifying the interface of the
send_*_push_notification functions, so that they can effectively
support a push notification forwarding workflow.
2017-03-05 18:37:00 -08:00
Tim Abbott
fc192d6b3b
push: Don't pass a UserProfile into send_apple_push_notification..
2017-03-05 18:37:00 -08:00
Tim Abbott
393c4d2eaa
push: Don't pass a UserProfile into _do_push_to_apns_service.
2017-03-05 18:37:00 -08:00
Tim Abbott
53c9e3b4ca
push: Don't pass a full UserProfile into APNsMessage.
2017-03-05 18:37:00 -08:00
Tim Abbott
c8bfd568bc
push: Pass devices list into send_apple_push_notification.
2017-03-05 18:36:58 -08:00
Tim Abbott
0ddaf5c610
push: Pass reg_ids list into send_android_push_notification.
...
This refactoring is preparation for being able to forward push
notifications to users on behalf of another Zulip server.
The goal is to remove access to the current server's database from the
send_*_push_notification code paths.
2017-03-05 18:36:07 -08:00
Tim Abbott
b1b2d8d2c7
push: Move handle_push_notifications to push_notifications.py.
2017-03-05 18:32:09 -08:00
sinwar
d8ff09cb42
requirements: Upgrade pycodestyle to latest version.
...
Fixes #3927 .
2017-03-05 16:17:04 -08:00
sinwar
6f0564e9f4
python: Fix remaining bare excepts in codebase.
...
Fixes #2862 .
2017-03-05 16:17:04 -08:00
Tim Abbott
08e1759ad0
bots: Replace bare excepts with targeted exceptions.
2017-03-05 16:17:04 -08:00
Steve Howell
a17deb144a
Use data-stream-id in topics popover.
2017-03-05 15:44:44 -08:00
Steve Howell
8e2e406404
refactor: Extract stream_popover.js.
...
This module handles the popovers in the stream list--one for
stream actions and another for topic-specific actions.
The extraction was mostly straightforward, but I did move some
of the code related to the color picker to be more consistent
with how I organized the other click handlers.
2017-03-05 15:44:43 -08:00
Steve Howell
ba49962f9a
refactor: Extract stream_popover_sub().
...
Part of this change moved a click handler from subs.js to
popover.js.
2017-03-05 15:44:43 -08:00
Steve Howell
6630b84dc0
Remove data-stream-name from subscription_settings.
2017-03-05 15:44:43 -08:00
Steve Howell
58b018858e
refactor: Pass in sub to ajaxUnsubscribe().
2017-03-05 15:44:43 -08:00
Steve Howell
761a0beb7e
refactor: Rename variable in show_settings_for().
2017-03-05 15:44:43 -08:00
Steve Howell
e703b0bfdb
refactor: Remove stream_name param in update_stream_color().
2017-03-05 15:44:43 -08:00
Steve Howell
f8819256b0
Use stream_id in update_subscription_properties().
2017-03-05 15:44:43 -08:00
Steve Howell
419a3174f1
Send stream_id in stream/update events.
2017-03-05 15:44:42 -08:00
Steve Howell
0bb1af0fd9
Send stream_id in subscription updates.
2017-03-05 15:26:00 -08:00
Cynthia Lin
0f02031846
user docs: Add user guide for *View messages containing files or links*.
...
Fixes #3754
2017-03-05 14:17:25 -08:00
Steve Howell
95cdc744d9
refactor: Simplify code for renaming streams.
2017-03-05 11:55:09 -08:00
Steve Howell
c5757ac8fe
refactor: Change params for subs.mark_subscribed().
...
We pass in sub instead of stream_name, to support callers that
already do lookups by stream id.
And then we make the second optional argument be subscribers, since
that is all we were using from the old `attrs` argument.
2017-03-05 11:55:09 -08:00
Steve Howell
2f8ecad295
Remove unused get_stream_name().
2017-03-05 11:55:09 -08:00
Steve Howell
4f1108cc27
refactor: Pass in a sub to remove_user_from_stream().
2017-03-05 11:55:09 -08:00
Steve Howell
190b2ab1d3
refactor: Pass in a sub to invite_users_to_stream().
2017-03-05 11:55:09 -08:00
Steve Howell
8a4dee4a80
bug fix: Handle bad streams for compose-invite feature.
...
We now handle missing subs more gracefully when you click on the
link to invite somebody you at-mentioned in a stream message.
2017-03-05 11:55:09 -08:00
Steve Howell
6183a0d8b2
bug fix: Handle invalid streams in would_receive_message().
2017-03-05 11:55:09 -08:00
Steve Howell
4b98ec0a12
bug fix: Handle errors in at-mention typeaheads.
...
If a stream doesn't exist, prevent executing code that leads
to needless warnings.
2017-03-05 11:55:09 -08:00