6f0564e9f4
python: Fix remaining bare excepts in codebase.
...
Fixes #2862 .
2017-03-05 16:17:04 -08:00
b6f53d6c14
coverage: bring zerver/lib/validator.py to 100% coverage.
2017-03-05 00:53:27 -08:00
e95f139308
coverage: bring zerver/lib/response.py to 100% coverage.
2017-03-05 00:53:26 -08:00
89decf6ded
coverage: bring zerver/lib/request.py to 100% coverage.
2017-03-05 00:53:26 -08:00
e7ff3415ab
coverage: bring test_helpers.py to 100% coverage.
2017-03-05 00:53:26 -08:00
546fb9199d
coverage: bring test_classes.py to 100% coverage.
2017-03-05 00:53:26 -08:00
e3cfb256dd
coverage: Bring zerver.lib.narrow.py to 100% coverage.
2017-03-05 00:53:26 -08:00
56b1f79fe3
integrations: Fix email integration being listed unconditionally.
2017-03-05 00:53:26 -08:00
5050e42212
test-backend: Document # nocoverage comments.
2017-03-04 23:47:16 -08:00
e7389b4162
test-backend: Require 100% coverage on tests by default.
2017-03-04 23:39:34 -08:00
6c12a49d04
test_auth_backends: Remove now-unnecessary compatibility code.
...
This code was added as part of the Django 1.10 migration to make our
tests work with both Django 1.8 and 1.10. Now that we're on 1.10,
it's no longer required.
2017-03-04 23:38:46 -08:00
39704bac6c
test_bugdown: Remove unused common_bugdown_test.
2017-03-04 23:35:46 -08:00
1a8bc5f383
coverage: Bring test_decorators to 100% coverage.
2017-03-04 23:34:28 -08:00
c73c3c52f8
test_email_mirror: Fix TestCommandMTA.
...
The test didn't actually use the mock, due to an incorrect import
path.
2017-03-04 23:28:48 -08:00
6ea3a9cb1d
coverage: Bring test_templates.py to 100% coverage.
2017-03-04 23:28:48 -08:00
d8171b2efc
coverage: Bring tests.py to 100% coverage.
2017-03-04 23:17:36 -08:00
768307d921
coverage: Bring test_events to 100% coverage.
2017-03-04 23:12:32 -08:00
538570b7c1
test_subs: Bring to 100% test coverage.
2017-03-04 23:07:56 -08:00
065651b4fe
coverage: Exclude uncovered lines in test_signup.
2017-03-04 23:01:50 -08:00
ff9f827c9a
coverage: Don't require coverage in six.PY2/PY3 branches.
2017-03-04 22:51:35 -08:00
5ee33e59b8
coverage: Don't require coverage for NotImplementedErrors.
2017-03-04 22:48:21 -08:00
401ae3db97
coverage: Don't complain about if False coverage.
...
This fixes a test failure on master.
2017-03-04 22:48:14 -08:00
bc0cd7eb90
coverage: Move coverage config to tools/coveragerc.
2017-03-04 22:48:05 -08:00
63664264b8
test-backend: Disable verbose coverage display.
2017-03-04 22:48:05 -08:00
e150640ddd
lint: Add lint rule for loading external scripts.
...
This is a common mistake (I'll add documentation on why in the next
commit), and this is a great hook for sending folks to the
documentation on our frontend build process.
2017-03-04 20:42:47 -08:00
d25bfb88d3
lint: Ban importing zerver.models in database migrations.
...
This doesn't work correctly, but in a subtle way.
2017-03-04 17:32:48 -08:00
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
2bbfdeeb7b
Fix more errors caught by mypy 0.501.
...
Another set of relatively easy to review changes.
2017-03-03 14:15:38 -08:00
28d3af0965
Fix several new errors caught by mypy 0.501.
...
Clear out a bunch of easy to review errors, so we can focus on the more
complicated ones.
2017-03-03 14:12:52 -08:00
521e8700d7
emoji: Update NotoColorEmoji emoji set.
...
Update the existing NotoColorEmoji set to include emoji additions
like gendered professions, rainbow flag, single parent families etc.
Fixes : #3861 .
2017-03-02 19:07:34 +05:30
d90f7c72a3
zephyr: Fix broken postgres regular expression logic and add tests.
...
Like many rare-case code with new tests, it turns out that the logic
for handling null characters in our Zephyr postgres query escaping
never worked, in multiple ways. First, it always changed the second
character in s, not the current one being inspected, and second, the
value it replaced it with was no the correct postgres escape of the
null byte. We fix this and add tests.
This completes the effort to get zerver/views/messages.py to 100%
test coverage.
Fixes #1006 .
2017-03-01 10:38:48 -08:00
b0f53fd1a8
check-templates: Check left and right sidebars.
2017-03-01 09:08:09 -08:00
0712926b84
templates: Rename right-sidebar.html to right_sidebar.html.
2017-03-01 09:02:15 -08:00
748ec32349
templates: Rename left-sidebar.html to left_sidebar.html.
2017-03-01 09:00:51 -08:00
7fb406b889
lint: Expand lint check for use of .text() without i18n.
...
Fixes #3705 .
2017-02-28 20:37:52 -08:00
d9ef6281fa
lint: Clean json_error/JsonableError lint exceptions.
...
We primarily need to be checking for literal strings being passed in
without i18n tags, not for code that passes a constructed value in.
2017-02-28 20:26:18 -08:00
7ed10da4ad
test-backend: Raise zerver/views/report.py test coverage to 100%.
2017-02-28 20:06:00 -08:00
23706a3c9e
Add server error response for failed handlebars template compilation.
...
- Add stamp file creation for the failed templates compilation.
- Add error response to `home` route if stamp file exists. It appears
just for the development environment.
- Add jinja2 template for failed handlebars templates compilation error.
Fixes #3650 .
2017-02-28 09:44:08 -08:00
11ba94f11a
test-backend: Raise zerver/views/integrations.py test coverage to 100%.
2017-02-28 09:31:06 -08:00
6bdefb92e9
test-backend: Raise zerver/views/zephyr.py test coverage to 100%.
2017-02-26 20:54:25 -08:00
3651a432d5
build_emoji: Add `name_to_codepoint` dict to emoji_codes.js file.
2017-02-26 18:28:42 -08:00
1b0d3cbb39
tools/build_emoji: Generate `name_to_codepoint.json` file.
...
Generate the `name_to_codepoint.json` file in build_emoji which will be
used by bugdown/ to map emoji names to codepoints directly.
2017-02-26 18:28:42 -08:00
bc4aef0bc7
emoji: Move zulip-emoji to `images/emoji/unicode`.
...
Move zulip-emoji from its current location `images/emoji` to
`images/emoji/unicode` and add a symlink in `images/emoji`
to zulip.png in `images/emoji/unicode`.
2017-02-26 18:28:41 -08:00
f3cd3e8b8d
test-backend: Raise zerver/views/invite.py test coverage to 100%.
2017-02-26 16:15:25 -08:00
cebc67f9b0
test-backend: Raise zerver/views/unsubscribe.py test coverage to 100%.
2017-02-26 16:13:35 -08:00
257bb40698
realm-icon: Add realm icon feature.
...
- Add realm icon fields to realm model.
- Add migration for new realm model's field.
- Add views for icon uploading and deleting.
- Add routes for realm icons views.
- Add JS widget for realm icon upload setting.
- Add realm icon upload to administration
organization setting.
- Add tests for realm icons.
Fixes #3660 .
2017-02-26 12:16:07 -08:00
f038cd47d9
test-backend: Raise zerver/views/realm.py test coverage to 100%.
2017-02-25 18:18:29 -08:00
5bf83f9e0a
change-email: Implement confirmation flow.
...
This adds to Zulip support for a user changing their own email
address.
It's backed by a huge amount of work by Steve Howell on making email
changes actually work from a UI perspective.
Fixes #734 .
2017-02-23 03:15:17 -08:00
3acf8b050d
Add Django and html singleton tags support to pretty print.
...
In this commit we are modifying pretty print tool to support
Django and html singleton tags. For Addition of html singleton
tags template parser was modified to emit psudeo
html singleton end tags to accompany html singleton tags and
token class was updated to have line_span field.
2017-02-22 20:21:58 -08:00
5b5a0bdb80
Improve check-templates error handling.
...
In this commit we improve the way errors are handled in our
template parser and thus improving the displayed messages in
case of errors. Eg. Errors in case of unbalanced quotes now
makes more sense displaying line and column information
including line where error might be sourced.
2017-02-22 17:39:12 -08:00
sinwar
Tim Abbott
Raghav Jajodia
Rishi Gupta
Harshit Bansal
Elliott Jin
K.Kanakhin
Umair Khan
adnrs96