42f5eea61f
mypy: Improve typing of request.pyi (REQ).
...
This expands request.pyi to type-check the arguments passed into REQ.
Tweaked by tabbott to fix the report.py annotations.
2017-11-04 20:26:03 -07:00
68b0a419ec
decorator: Cut a bunch of dead imports of two view decorators.
...
Saw these when grepping for these two decorators; they're actually
more numerous than the surviving use sites are. Cut out the noise.
2017-11-04 19:27:00 -07:00
5467296f60
decorators: Use human_users_only more aggressively.
2017-10-27 15:16:13 -07:00
1cd017288d
views: Fix imports of REQ/has_request_variables from the wrong place.
...
These were never in zerver/decorator.py, and so it makes sense to
import them zerver/lib/request.py, mostly for ease of finding things.
2017-10-27 15:07:31 -07:00
45e8ce559d
zerver/views: Use python 3 syntax for typing.
2017-10-26 21:58:22 -07:00
1792dcbd09
tests: Call real consume method of queue processors.
...
This switches to more real tests for a first batch of
queue_json_publish() calls that don't cause trouble when
used with call_consume_tests=True.
2017-10-26 14:58:03 -07:00
5515a075ec
urls: Move the report endpoints to be API-style routes.
2017-10-17 22:05:56 -07:00
a466bf8a47
report: Fix handling of reports with no more_info.
2017-10-12 17:38:28 -07:00
b3b5d5b7cd
report: Avoid sending raw message content in error reporting.
...
This fixes a violation of Zulip's privacy policies (that error
reporting never contain message content) in the previous commit.
2017-10-11 17:44:05 -07:00
ce7ab0474d
error_notify: Add IP address to browser error reports.
...
This should make debugging a bit more convenient when we want to know
which of a user's clients was involved.
2017-10-04 13:46:05 -07:00
0744961afe
docs: Add more comprehensive documentation on error reporting.
...
Fixes #2232 .
2017-09-27 19:47:08 -07:00
15ca13c8de
zerver/views: Remove absolute_import.
2017-09-27 10:00:39 -07:00
1338c6fa0c
report: Fix path to find webpack bundle source maps.
...
The previous code only worked for release tarballs, which has the
source maps in both places.
2017-08-01 08:55:45 -07:00
5932896ebb
Fix browser error reporting to find webpack source map files.
...
When we switched to using webpack, source map files weren't being
logged in the expected place.
2017-07-28 16:01:23 -07:00
8611a2cafa
tidying: Combine multiple 'import typing' lines onto one line.
2017-07-16 16:43:21 -07:00
ef532bbbb1
statsd: Change keys to use Realm.string_id instead of domain.
2017-03-13 09:51:02 -07:00
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
a1d296b802
report: Use DEVELOPMENT instead of DEBUG setting.
...
This fixes a weird issue where the following sequences of tests would fail:
test-backend
zerver.tests.test_messages.PersonalMessagesTest.test_personal_to_self
zerver.tests.test_report.TestReport.test_report_error
zerver.tests.test_templates.TemplateTestCase.test_custom_tos_template
It appears that all 3 tests are required for the failure.
While it's not entirely clear what the cause is, a very likely factor
is that settings.DEBUG is special, and so changing it at runtime is
likely to cause weird problems like this.
We fix this by replacing it with settings.DEVELOPMENT, which has the
same value in all environments, but doesn't have this problem of being
a special Django thing.
2017-02-28 21:44:41 -08:00
7ed10da4ad
test-backend: Raise zerver/views/report.py test coverage to 100%.
2017-02-28 20:06:00 -08:00
eeca69cb4b
mypy: Clean up more optional types.
2017-02-10 23:53:44 -08:00
e69c4458c6
errors: Use hostname to report deployment.
2017-01-28 13:07:09 -08:00
0dd5d6cea0
errors: Separate browser error reporting from backend.
2017-01-27 10:27:41 -08:00
dd9e0b8463
errors: Move do_report_error into zerver/lib/.
2017-01-23 23:18:28 -08:00
535ce90272
mypy: Convert zerver/views to use typing.Text.
2016-12-26 13:43:09 -08:00
abc2ff4a06
pep8: Fix many rule E128 violations.
...
[Tweaked by tabbott to adjust some approaches used in wrapping]
2016-12-03 13:33:31 -08:00
e0dbaf1031
Use universal_newlines=True in subprocess.check_output.
...
In python 3, subprocess uses bytes for input and output if
universal_newlines=False (the default). It uses str for input and
output if universal_newlines=True.
Since we mostly deal with strings, add universal_newlines=True to
subprocess.check_output.
2016-07-26 12:06:41 -07:00
10afbc06f9
zerver/views/report.py: Fix line with length greater than 120.
...
zerver/views/report.py: Capture string in temporary variables.
2016-07-18 14:42:39 -07:00
e4ed9195dc
Remove rest_dispatch hack and optimize imports.
...
For a long time, rest_dispatch has had this hack where we have to
create a copy of it in each views file using it, in order to directly
access the globals list in that file. This removes that hack, instead
making rest_dispatch just use Django's import_string to access the
target method to use.
[tweaked and reorganized from acrefoot's original branch in various
ways by tabbott]
2016-06-24 16:11:03 -07:00
ad895eb690
Annotate zerver/views/report.py.
2016-06-11 18:42:37 -07:00
960144a49e
Desupport using uninstantiated REQ with has_request_variables.
...
This makes life difficult for doing static type annotations, and
didn't make the code look that much better anyway.
2016-05-31 07:31:15 -07:00
e64a3d0fae
Move reporting views to their own file.
2015-11-24 05:20:37 -08:00
neiljp (Neil Pilgrim)
Greg Price
Tim Abbott
rht
derAnfaenger
Alena Volkova
Pweaver (Paul Weaver)
Rishi Gupta
Raghav Jajodia
Elliott Jin
Juan Verhook
nikolay
Eklavya Sharma
Taranjeet Singh
acrefoot
Babak
Tim Abbott