5 Commits

Author	SHA1	Message	Date
Steve Howell	12dc567a89	Move insert_syntax_and_focus() to compose_ui.js. ... This change also removes a couple lines of test code that weren't really testing anything.	2017-11-09 09:49:20 -08:00
Tim Abbott	bb80c0cc24	compose_state: Extract insert_syntax_and_focus. ... This moves the existing emoji picker code to a new library.	2017-10-30 17:12:56 -07:00
Joshua Pan	67064a46e5	compose_state.js: Extract focus_in_empty_compose(). ... Wrote some tests for the function also.	2017-09-19 19:07:30 -07:00
Steve Howell	c999bdf823	compose: Distinguish get_message_type() from composing(). ... We now only call compose_state.composing() in a boolean context, where we simply care whether or not the compose box is open. The function now also returns true/false. Callers who need to know the actual message type (e.g. "stream" or "private") now call compose_state.get_message_type().	2017-04-24 12:42:06 -07:00
Steve Howell	70b7d4c00b	Extract compose_state.js. ... This is mostly just moving methods out of compose.js. The variable `is_composing_message`, which isn't a boolean, has been renamed to `message_type`, and there are new functions set_message_type() and get_message_type() that wrap it. This commit removes some shims related to the global variable `compose_state`; now, `compose_state` is a typical global variable with a 1:1 relationship with the module by the same name. The new module has 100% line coverage, most of it coming via the tests on compose_actions.js. (The methods here are super simple, so it's a good thing that the tests are somewhat integrated with a higher layer.)	2017-04-18 12:26:58 -07:00