Shubham Dhama
9c5353cc3d
lightbox: Remove the unwanted scrollbar from the image list.
...
Fixes : #5277 .
2017-06-15 03:39:40 -07:00
Harshit Bansal
7950f82f27
realm_emoji: Make sure that a deactivated realm emoji can't be used.
...
A deactivated realm emoji should neither be accepted further as a
reaction nor its further occurences in a message be rendered as an
emoji. However, all the old occurences should continue to render
normally.
2017-06-15 02:59:57 -07:00
Harshit Bansal
8db2cf8d7c
models.py: Add `deactivated` field to the emoji dicts.
...
Add `deactivated` field to the realm emoji dicts returned from the
`get_realm_emojis_uncached()` function.
2017-06-15 02:59:57 -07:00
Harshit Bansal
e85c11a461
models: Add `deactivated` field to RealmEmoji model.
...
Instead of deleting the emojis we will just mark them as `deactivated`.
This will prevent their further use but at the same time they will be
displayed properly in the reactions and messages in which they are used.
This field will be used as a flag to indicate whether the realm emoji
has been deleted or not.
Includes a database migration.
2017-06-15 02:59:57 -07:00
Cory Lynch
11a7a476d7
search_suggestion: Add negation support for 'has' operator.
2017-06-15 02:32:00 -07:00
Cory Lynch
da4e2954fe
search_suggestion: Remove is:private as default suggestion.
2017-06-15 02:20:50 -07:00
Robert Hönig
6b0aa7f345
bots: Check existance of config file in get_config_info().
2017-06-15 02:17:31 -07:00
Tim Abbott
f4aec8fedd
docs: Reorganize git guide discussion of WIP pull requests.
2017-06-15 02:13:24 -07:00
Vaida Plankyte
f56ecdd34f
docs: Emphasise WIP PRs in git-guide.md.
...
Fiuxes #3233 .
2017-06-15 02:05:57 -07:00
Cory Lynch
89b8d07420
Make search suggestion messages more concise.
...
This involves updating filter.js, mostly. The
tests were updated appropriately for this change,
which also involved changing a caspar test for
narrowing.
2017-06-14 22:34:46 -07:00
Cory Lynch
ab5b0e938d
Add support for "has" operator in search_suggestions.
...
This was never a feature in the old search_suggestions
version, so a new helper function for it was added.
Relevant tests were also added, maintaining 100% coverage.
2017-06-14 22:34:46 -07:00
Cory Lynch
a7ec8cd1f3
Improve topic in search_suggestion.js.
...
Also added some additional testing to handle
some edge cases that I'd like to make sure
don't break down.
2017-06-14 22:34:46 -07:00
Cory Lynch
7cda7c4782
Improve stream in search_suggestions.js.
2017-06-14 22:34:46 -07:00
Cory Lynch
69e8074d14
Improve person/group in search_suggestions.js.
...
The get_person_suggestions and get_group_suggestions functions
were updated to the new system. Support for negation is also
added in the new system.
Relevant tests were also updated. Also, note that the function
get_private_suggestions was removed, as it was rendered
obsolete by these updates.
2017-06-14 22:34:46 -07:00
Cory Lynch
c8d4eff8aa
Improve sent_by_me in search_suggestions.js.
...
Added appropriate tests.
2017-06-14 22:34:46 -07:00
Cory Lynch
79d56c94dc
Improve default and special_filter in search_suggestion.js.
...
Special filter was updated to work even when it is not the first
token in a search query. Furthermore, the default query was
moved around to work with the changes to come for the new
suggestion system.
A test also had to be modified to work with the new system.
2017-06-14 22:34:46 -07:00
Aditya Bansal
a2b5d6efcb
provision: Add wrapper to retry apt-get install if it fails first time.
2017-06-14 21:49:15 -07:00
Aditya Bansal
f9cbb0936a
setup_venv: Add wrapper to retry pip install if it fails first time.
2017-06-14 21:48:15 -07:00
Tim Abbott
1043cd7a2b
docs: Fix tests for error pages.
...
Without the trailing /, these return a 30x error.
2017-06-14 21:21:36 -07:00
Tim Abbott
2555227cc5
errors: Update 404/5xx nginx pages.
...
We remove zulip-devel@ from the 404 page, and improve the comments
explaining why these pages don't use variables.
2017-06-14 21:18:45 -07:00
Cory Lynch
5b03236b90
dev: Update dev_tools.html with error pages.
...
Fixes #5391 .
2017-06-14 21:18:45 -07:00
Cory Lynch
78de70688e
dev: Add URL to preview error 404/5xx pages.
2017-06-14 21:18:45 -07:00
Robert Hönig
790240cc57
bots: Test get_config_info with giphy bot.
...
This involves both using the new `initialize`
method for calling `get_config_info`, and
refactoring the testing framework by adding a
way for mocking this method.
2017-06-14 20:25:07 -07:00
Robert Hönig
027f344f7e
bots: tests: Mock bots only once.
...
This is done by moving the mocking and patching
code to the `setUp` and `tearDown` functions.
2017-06-14 20:25:07 -07:00
Robert Hönig
af5a17540b
bots: Add `get_config_info` function for bots.
2017-06-14 20:25:07 -07:00
Robert Hönig
6d47d1bdba
bots: Add non-obligatory initialize func for bots.
...
A bot that implements `initialize(client)` has initial
access to the `client` object, before `handle_message`
is called.
2017-06-14 20:25:07 -07:00
Cory Lynch
cb4dadfdcd
tools: Create /devtools page for useful dev URLs.
...
Fixes #5179 .
2017-06-14 20:17:56 -07:00
Cory Lynch
3e10bdf0e8
docs: Print output URL in Makefile.
2017-06-14 20:16:08 -07:00
Cory Lynch
3bc369f1cf
tools: Add wrapper tool 'build-docs' for building documentation.
2017-06-14 20:16:02 -07:00
Nick Sweeting
458fcfa646
docs: Add blurb to docs about topic lifetime.
...
Edited by tabbott to also address the issue of deleting topics.
2017-06-14 19:21:54 -07:00
Cynthia Lin
1d5a5036c5
repository: Add CODE_OF_CONDUCT.md.
2017-06-14 18:43:08 -07:00
Jack Zhang
d3e69c5460
Remove style to show text in portico-page-container.
...
Fixes #5368 , #5371 .
2017-06-14 18:37:24 -07:00
Eeshan Garg
bbe7ef6c5e
linter_lib: Exclude webhook URLs from long line checks.
...
Now, URLs starting with `{{ external_api_uri_subdomain }}` are
exempted from the 120 char per line requirement.
2017-06-14 17:42:17 -07:00
Eeshan Garg
2344e26b1a
webhooks/zendesk: Migrate docs to Markdown.
2017-06-14 17:42:17 -07:00
Eeshan Garg
9e77749bfc
webhooks/wordpress: Migrate docs to Markdown.
...
Markdown doesn't support tables, so I used an unordered list
instead for the HTML table at the end.
2017-06-14 17:42:17 -07:00
Eeshan Garg
4a3137be97
webhooks/taiga: Migrate docs to Markdown.
2017-06-14 17:42:17 -07:00
Eeshan Garg
1c5d0bb0fa
webhooks/semaphore: Use append-stream-name.md macro.
2017-06-14 17:42:17 -07:00
Eeshan Garg
0d611d4c8a
webhooks/stripe: Migrate docs to Markdown.
2017-06-14 17:42:17 -07:00
Eeshan Garg
0d817f0870
markdown: Add macro for appending stream name to integration URL.
2017-06-14 17:42:17 -07:00
Eeshan Garg
aa25348ddc
markdown: Recommend substituting bot email and API key in URL.
...
We now recommend substituting the appropriate bot email and
API key in the webhook URL in the webhook-url-with-bot-email.md
macro.
2017-06-14 17:42:14 -07:00
Tim Abbott
fa87c6113d
docs: Document that we use `ts` automatically in Travis CI.
2017-06-14 17:26:41 -07:00
Aditya Bansal
5e4acbaba3
travis: Add 'ts' to all Travis CI builds for timestamping logs.
...
Fixes : #5264 .
2017-06-15 05:08:00 +05:30
Steve Howell
5482a6e129
Add test_narrowing() for stream_list.
2017-06-14 15:29:17 -04:00
Steve Howell
dc9ea24d79
zjquery: Add get().
2017-06-14 15:29:17 -04:00
Steve Howell
7722539504
zjquery: Add better trigger stubbing.
2017-06-14 15:26:41 -04:00
Steve Howell
29416c4b39
Move pm_list.set_click_handlers() call.
...
Instead of calling it from stream_list.initialize(), we
call it from the new pm_list.initialize().
2017-06-14 13:58:54 -04:00
Steve Howell
39e8bed9ef
Test stream_list.update_dom_with_unread_counts().
2017-06-14 12:28:08 -04:00
Steve Howell
499962bb6b
Change arg for stream_list.redraw_stream_privacy().
...
We now pass in a sub, not a stream name.
2017-06-14 11:24:42 -04:00
Steve Howell
bc575685a9
Add more test coverage to stream_list.js.
2017-06-14 11:24:20 -04:00
Steve Howell
fb5d10af14
Extract stream_list.get_global_filter_li().
...
Now we use a consistent approach to find the list items for
Home/Starred messages/Mentioned in the upper corner.
In particular, we get rid of the complicated
iterate_to_find() function.
2017-06-14 09:27:50 -04:00