e51962d6ac
dialog_widget: Assign each dialog widget a unique id.
...
This makes it easy to check if the correct dialog widget is open
and to perform actions based on the state of dialog widget in
async callbacks.
2024-05-15 12:02:57 -07:00
f73f27b45f
invite: Replace "streams" with "channels" in default subs banner.
...
This commit replaces "streams" with "channels" in the banner for
default channel subscriptions shown to user user who cannot
subscribe others.
2024-05-15 10:59:05 -07:00
6f5143b5b8
invite: Fix margins around subscriptions banner.
...
This commit fixes the margins around banner for default stream
subscriptions, shown to users who cannot subscribe others, to
be same as that for other banners like the one shown when
description is not set for the organization.
2024-05-15 10:59:05 -07:00
05d74a367c
invite: Fix invite modal bug for users who can't subscribe others.
...
The bug was due to the element being accessed when not present
in the DOM. This function fixes it by calling the function to
setup streams UI only when the concerned elements are present
in DOM, i.e. when user can subscribe others.
The bug was introduced in 016917679e
2024-05-15 10:59:05 -07:00
fba81d1cd5
upload: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
97b0fd424d
upload: Replace get_item with config object methods.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
60545fb475
upload: Reimplement get_item with config object methods.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
25b29b5cd4
upload: Centralize config object construction.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
d9f05121d9
upload: Fix @uppy/xhr-upload locale configuration.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
ac6e0a2d34
upload: Add missing get_item("upload_banner_message", …) argument.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
b132fc50b3
compose_reply: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
c8981be08f
compose_state: Fix last_focused_compose_type_input type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
941e2ae5dc
inbox_ui: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
1fa6c707ce
inbox_ui: Split filter_should_hide_row into two functions.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
77100aca6a
inbox_ui: Fix CSS escaping.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-15 10:53:09 -07:00
a567fb633a
copy_and_paste: Fix bugs surfaced by typescript migration.
...
Fixed 2 bugs in the detection of the last message row copied. This fixes
the issue where when the mouse was released on the message header after
copying multiple messages, the pasted text was not formatted correctly.
Follow up to #30091 .
2024-05-15 10:44:20 -07:00
5e671de1e7
unread_ops: Fix unable to mark messages as read in Inbox view.
...
Converting stream_id to string invalidates the
value as our narrow parser expects integer as valid stream_id and
stream name if it is string.
2024-05-15 01:29:37 -07:00
c41a352a12
invite: Use include_default_realm_subscriptions parameter in webapp.
...
This commit adds code to use include_default_realm_subscriptions
when user selects "Subscribe to default streams" checkbox
in the invite modal instead of passing the stream ids of
default streams.
2024-05-14 14:20:07 -07:00
016917679e
invites: Do not show streams if user cannot subscribe others.
...
We do not show the streams list in invite modal if the user
does not have permission to subscribe others to stream and
show a notice mentioning it.
2024-05-14 14:20:07 -07:00
4d407c6b8d
copy_and_paste: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 14:12:05 -07:00
2e776bf8dc
copy_and_paste: Fix CSS selector injection bug.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 14:12:05 -07:00
a41d0b16e6
user_topics_ui: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 14:01:04 -07:00
c50b28610c
user_topics_ui: Fix backwards setTimeout arguments.
...
Introduced by commit 401c8bbb21#27254 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 14:01:04 -07:00
f57fb0862e
message_edit: Fix event handlers lost on restoring edit form.
...
To avoid event handlers being lost when we restore a message edit
form we go through the process of creating the edit form for the
message again. This has the additional benefit of updating the
status of buttons based on org settings like GIF or upload button.
2024-05-14 12:21:49 -07:00
ca8f04ea35
message_list_view: Remove unnecessary parameter passed.
...
Since we are already selecting the previously selected id in
`reselect_selected_id` there is no need to pass the message id here.
2024-05-14 12:21:49 -07:00
a30029c8ad
upload: Don't render upload button instead of hiding.
...
Doesn't make sense to hide the upload button button later when
we can just not show it if the browser doesn't has support for
it.
2024-05-14 12:21:49 -07:00
7a831617af
message_edit: Directly use currently_editing_messages for checks.
...
Makes it easier to search and verify changes related to
currently_editing_messages.
2024-05-14 12:21:49 -07:00
9d87131fa8
settings: Use new format to update can_mention_group setting.
...
This commit updates the webapp code to use new format to update
the can_mention_group setting.
2024-05-14 12:17:15 -07:00
6479cc5970
unread_ops: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 12:15:44 -07:00
0cbc6cb82b
unread_ops: Remove unused bulk_update_read_flags_for_narrow arguments.
...
Introduced by commit 664f29b4f1#28560 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 12:15:44 -07:00
d7a9cb6c12
unread_ops: Simplify handle_mark_unread_from_here_error with callback.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 12:15:44 -07:00
a54d178b8a
unread_ops: Fix do_mark_unread_by_narrow arguments after rate limiting.
...
Introduced by commit f0d87fcf6e#23605 ); propagated by commit
0bef960b34#29521 ) and commit
42a6929f5c#30047 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-14 12:15:44 -07:00
4ee37244bb
recent_topics: Change background color in dark mode on hover on a row.
...
Fixes #30083 .
We have used the dark theme color for the left sidebar row hover:
`--color-background-active-narrow-filter`. We are not using that variable
directly since we don't want a change in that color affecting the color in
recent conversations.
We've also used a single color on hover compared to 2 different colors
for unread and read row before. Light mode also uses a single color on
hover.
Relevant CZO conversation:
https://chat.zulip.org/#narrow/stream/101-design/topic/Hover.20color.20in.20Recent.20conversations.20dark.20mode.2E/near/1797727
2024-05-14 11:46:37 -07:00
2e8fdab896
user_pill: Avoid unnecessary array allocations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-13 18:12:54 -07:00
c0c852046d
user_group_pill: Avoid unnecessary array allocations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-13 18:12:54 -07:00
b3fbfd9da8
stream_pill: Avoid unnecessary array allocations.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-05-13 18:12:54 -07:00
4bf8c19b32
message_view_header: Fix misleading variable name.
...
It never contained only icon data.
2024-05-13 17:56:30 -07:00
941c5daf36
navbar: Describe views in top navbar.
...
Adds description in views styled like stream descriptions also adds a
help center link to the appropriate page at the end of each
description.
Fixes #29769 .
2024-05-13 17:56:30 -07:00
d36e19389d
add_subscribers_pill: Convert module to TypeScript.
2024-05-13 16:57:02 -07:00
bf3eb2c269
user_pill: Fix type annotations.
...
Change the type annotation of current_items in create_item_from_email
to InputPillItem<CombinedPillItem>.
2024-05-13 16:57:02 -07:00
0927e03677
user_group_pill: Fix type annotations.
...
Change type annotations of get_user_ids and create_item_from_group_name
to accept CombinedPillContainer and InputPillItem<CombinedPillItem>
respectively.
2024-05-13 16:57:02 -07:00
0f622d3025
stream_pill: Fix type annotations.
...
Change type annotations of get_user_ids and create_item_from_stream_name
to accept CombinedPillContainer and InputPillItem<CombinedPillItem>
respectively.
2024-05-13 16:57:02 -07:00
0b7c63a695
typeahead_helper: Add type CombinedPillItem.
2024-05-13 16:57:02 -07:00
80d19fe15d
css: Fix theme switch changing color of elements at different intervals.
...
Due to these transitions the theme switch from dark <-> light was
not pleasant as the background color and color changed at different
intervals.
2024-05-13 13:21:10 -07:00
d4d57193df
message_store: Clarify display_reply_to type for stream/dm messages.
2024-05-13 12:51:00 -07:00
724306df10
recent_view_ui: Convert module to typescript.
2024-05-13 12:51:00 -07:00
1121d317c2
compose: Restructure HTML for common compose textarea/preview parent.
...
Earlier, the compose textarea and the preview (container) occupied the
same grid area, 1 at a time. Now, they are both children of a common div
which is assigned the same grid area. This allows adding more elements
to the same grid area in the future.
This is purely a code change and should have no visible effects.
This is a prep commit for relocating the compose expand / collapse
buttons to the top right inside corner of the textarea / preview.
2024-05-13 12:11:29 -07:00
91bd6e2b12
compose_closed_ui: Migrate module to TypeScript.
2024-05-12 17:41:22 -07:00
28c13f6d0e
message_store: Modify get_pm_full_names to only take user ids.
...
This will let us properly call it from compose_closed_ui without
a full message object, which we need to convert it to typescript.
2024-05-12 17:41:22 -07:00
8fb1c0683e
compose_closed_ui: Reduce usage of hacky message data structure.
2024-05-12 17:41:22 -07:00
Aman Agrawal
Sahil Batra
Anders Kaseorg
N-Shar-ma
Shubham Padia
Tim Abbott
nimishmedatwal
afeefuddin
evykassirer
Temidayo32