Commit Graph

22294 Commits

Author SHA1 Message Date
neiljp (Neil Pilgrim) 232bcd98b3 mypy: Improve return type of internal_notify_view decorator. 2017-10-28 08:57:49 -07:00
neiljp (Neil Pilgrim) 5c3af83229 mypy: Improve return type of api_key_only_webhook_view decorator. 2017-10-28 08:57:49 -07:00
neiljp (Neil Pilgrim) c063ba72a2 mypy: Improve typing of cache_with_key and cache decorators.
Fixes #1348.
2017-10-28 08:57:49 -07:00
Tim Abbott 2e69d4d420 mypy: Fix type for per_request_display_recipient_cache. 2017-10-28 08:57:49 -07:00
Tim Abbott fa55d7ed33 retry_event: Remove requirement of failed_tries being already there.
This fixes a bug where retries in the signups queue threw an exception.
2017-10-27 18:15:53 -07:00
rht 8b6b4e043f install: Add option to get certs via certbot.
While this doesn't quite complete our plans for certbot support (it's
not documented, etc.), this is a great stride forward.
2017-10-27 17:19:34 -07:00
Catherine Kleimeier fe2adeeee1 hotkeys: Fix ESC removing message feed focus in Firefox.
We correct a bug on Firefox where using the ESC key to close an edit
box that was opened by the left arrow key caused the message feed to
lose focus, making it difficult to navigate the message feed by
keyboard afterwards.

We fix this bug by changing the function that handles the ESC key
during an edit to pass the correct object to the message_edit.end
function.

Fixes #7072.
2017-10-27 17:11:12 -07:00
Tim Abbott 0d1194811f mypy: Remove ignores for a few typeshed bugs fixed upstream. 2017-10-27 17:09:00 -07:00
Tim Abbott bfa148ab39 requirements: Update mypy to latest version.
This involves fixing the mypy annotations in one file
2017-10-27 17:05:52 -07:00
Vishnu Ks e102c42e0f requirements: Upgrade moto to 1.1.24. 2017-10-27 16:56:15 -07:00
Vishnu Ks 43dd26cf08 requirements: Upgrade Twisted to 17.9.0. 2017-10-27 16:56:15 -07:00
Vishnu Ks ea58830673 requirements: Upgrade Sphinx to 1.6.5. 2017-10-27 16:56:15 -07:00
Vishnu Ks cd90e1a3ad requirements: Upgrade six to 1.11.0. 2017-10-27 16:56:15 -07:00
Vishnu Ks f5f94bddda requirements: Upgrade setuptools to 36.6.0. 2017-10-27 16:56:15 -07:00
Vishnu Ks 5c51d19194 requirements: Upgrade pyasn1 and pyasn1-modules. 2017-10-27 16:56:15 -07:00
Vishnu Ks c04cde6e96 requirements: Upgrade psycopg2 to 2.7.3.2. 2017-10-27 16:56:15 -07:00
Vishnu Ks 0291214e0b requirements: Upgrade pip-tools to 1.10.1. 2017-10-27 16:56:15 -07:00
Vishnu Ks e1aabfceca requirements: Upgrade Pillow to 4.3.0. 2017-10-27 16:56:15 -07:00
Vishnu Ks 7fc2e1ad0e requirements: Upgrade oauthlib to 2.0.6. 2017-10-27 16:56:15 -07:00
Vishnu Ks c535816dea requirements: Upgrade lxml to 4.1.0. 2017-10-27 16:56:15 -07:00
Vishnu Ks 308212c80b requirements: Upgrade ipython to 6.2.1. 2017-10-27 16:56:15 -07:00
Vishnu Ks db0cd705d7 requirements: Upgrade html2text to 2017.10.4. 2017-10-27 16:56:15 -07:00
Vishnu Ks e96611ad1d requirements: Upgrade google-api-python-client to 1.6.4. 2017-10-27 16:56:15 -07:00
Vishnu Ks cd064475a7 requirements: Upgrade django-auth-ldap to 1.2.16. 2017-10-27 16:56:15 -07:00
Vishnu Ks 0140a347dc requirements: Upgrade django to 1.11.6. 2017-10-27 16:56:15 -07:00
Vishnu Ks 00331ad84e requirements: Upgrade cryptography to 2.1.2. 2017-10-27 16:56:15 -07:00
Vishnu Ks 92f482a142 requirements: Upgrade cffi to 1.11.2. 2017-10-27 16:56:15 -07:00
Vishnu Ks af4185e1fe requirements: Add simplejson.
simplejson is still used in home.py
2017-10-27 16:56:15 -07:00
Tim Abbott 3abe92fc39 requirements: Update version of pyombed to fork with bs4 bug fixed.
This fixes an annoying warning message that was printed in our tests.
2017-10-27 16:55:27 -07:00
Tim Abbott 095a3ecbdd requirements: Fix missing simplejson dependency. 2017-10-27 16:54:01 -07:00
Tim Abbott 090563fb25 test_tornado: Fix IOLoop exceptions output spam.
We weren't quite following the proper protocol for Tornado tests.
2017-10-27 16:28:33 -07:00
Tim Abbott f790e667b3 test_tornado: Fix repeated autoreload configuration in tests.
Apparently, our previous efforts to disable AUTORELOAD in the tests
were incorrect.
2017-10-27 16:19:03 -07:00
Tim Abbott aacafd7a4d test_tornado: Fix incorrect tearDown method for IOLoops.
We appear to have 2 bugs of this form, so this just cuts half of the
exception/warning log output, but it's a start.
2017-10-27 16:13:42 -07:00
Tim Abbott 49d7d49038 test_narrow: Fix sqlalchemy warning spam. 2017-10-27 16:06:03 -07:00
Tim Abbott d80d15c08d GoogleSubdomainLoginTest: Suppress unnecessary logging output.
This helps make our test output nice and clean.
2017-10-27 16:06:03 -07:00
Tim Abbott e5df05fd35 tests: Suppress logging spam in email mirror tests. 2017-10-27 16:06:03 -07:00
Tim Abbott a1fa7a3c83 JWT: Filter out logging.warning output in tests. 2017-10-27 16:06:03 -07:00
Tim Abbott fca6df09b0 test_home: Mark a couple tests as explicitly slow. 2017-10-27 16:05:55 -07:00
Tim Abbott 28b25a66c2 test_events: Mark several slower tests as explicitly slow. 2017-10-27 15:46:59 -07:00
Tim Abbott ef9679667f test_docs: Fix unnecessary info-level logging in tests. 2017-10-27 15:44:45 -07:00
Tim Abbott e19312b394 Fix zerver.lib.digest log being printed in tests. 2017-10-27 15:44:15 -07:00
Tim Abbott 073c81bbe8 slow_tests: Increase limit for TOO slow notices. 2017-10-27 15:38:17 -07:00
Tim Abbott e8ab7cd1a9 logging: Fix zulip.send_email log being printed in tests.
Our set_loglevel tool didn't set propagate to False, so just using it
directly wouldn't work unless the logger is explcitly declared in
zproject/settings.py, which this one isn't.
2017-10-27 15:34:36 -07:00
Tim Abbott 80a9253f89 attachments: Remove unnecessary use of REQ.
It didn't do anything, because that third argument is actually a
positional argument coming from the URL parsing logic.
2017-10-27 15:18:44 -07:00
Tim Abbott 5467296f60 decorators: Use human_users_only more aggressively. 2017-10-27 15:16:13 -07:00
Tim Abbott 1cd017288d views: Fix imports of REQ/has_request_variables from the wrong place.
These were never in zerver/decorator.py, and so it makes sense to
import them zerver/lib/request.py, mostly for ease of finding things.
2017-10-27 15:07:31 -07:00
Brock Whittaker 25251e0216 /about/: Create a team partial.
This creates a template for the /team/ page that is currently just
embedded inside the /about/ page.  This includes the titles for core
team members with their pictures.
2017-10-27 14:50:48 -07:00
Greg Price 6d403ff255 tests: Simplify set_http_host to dedupe its logic.
This will make it easier to change this logic.
2017-10-27 14:42:24 -07:00
Greg Price e4b4f67b44 subdomains: Tighten search for EXTERNAL_HOST in get_subdomain.
If a Zulip install at example.org got a request at an HTTP `Host`
like foo.example.org.evil.com (or even foo.example.orgevil.com),
we would accept it as subdomain foo.  This isn't likely to happen
in practice because it shouldn't pass ALLOWED_HOSTS, and it's not
obvious to me that anything untoward could be done with it even
if ALLOWED_HOSTS were set wide open, but if nothing else it
multiplies the cases in analyzing this logic.

The reason we had a loose match like this, I assume, is to allow
the user to come from arbitrary ports -- especially in development.
So tighten the pattern to allow just that, and add some tests for
that behavior and a comment explaining why this complication is
needed.
2017-10-27 14:42:24 -07:00
Greg Price 1b19af2612 subdomains: Write some tests for get_subdomain.
This logic is a bit subtle, and we're about to make changes to it.
So let's have some tests.
2017-10-27 14:42:24 -07:00