Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
46,574 Commits 28 Branches 143 Tags 624 MiB
Commit Graph

9 Commits

Author SHA1 Message Date
evykassirer 8c3ff92964 populate_db: Add timezones for some test users. 
After failing to notice a place where we wanted to hide timezone
information, we decided to add timezones to some of the test
users, so that we can better consider the effects of timezones
when manually testing.

Testing:

* ran populate_db and confirmed users had timezones in the UI
* updated test_populate_db.py
 2022-02-22 11:14:58 -08:00
Steve Howell 1e4593b2ae performance: Avoid Recipient lookup. 
We don't have to go to the database to get the Recipient
fields for `user_profile.recipient`.

See also 85ed6f332a from a little
over a year ago--it's very similar.
 2021-12-28 12:15:02 -08:00
rht bb8504d925 lint: Fix typos found by codespell. 2021-10-19 16:51:13 -07:00
Anders Kaseorg 646c04eff2 Rename default branch to ‘main’. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2021-09-06 12:56:35 -07:00
PIG208 495a8476be tests: Use assertion to enforce None-checks in tests. 
This fixes a batch of mypy errors of the following format:
'Item "None" of "Optional[Something]" has no attribute "abc"

Since we have already been recklessly using these attritbutes
in the tests, adding assertions beforehand is justified presuming
that they oughtn't to be None.
 2021-07-24 09:54:21 -07:00
Dinesh c4463ee34c test_example.py: Add a new example to demonstrate mocking. 
Took the help of our mocking docs:
https://zulip.readthedocs.io/en/latest/testing/testing-with-django.html#testing-with-mocks
and rewrote a part of
test_message_edit.EditMessageTest.test_edit_message_content_limit
using mock.patch().
 2021-07-08 10:04:20 -04:00
Dinesh a71ee405e4 test_example: Add a few more common testing methods. 
Adds an example to illustrate the use of:
* self.settings()
* self.assertLogs()
* self.assert_in_success_response()
 2021-06-20 07:16:35 -04:00
Tim Abbott 3eee7c067c test_example: Add discussion of other common pitfalls. 
The new test_example file is great; here I document more pitfalls that
I've seen very often with tests contributed by folks new to the
project.
 2021-06-07 16:02:12 -07:00
Steve Howell 47da28429b tests: Add test_example.py. 
The idea here is to quickly learn basic testing
idioms with code that's executed (unlike docs
which are prone to bitrot).
 2021-06-07 15:29:49 -07:00