Prakhar Pratyush
a22f637769
typing_indicator: Replace private with direct in 'message_type' field.
...
This commit replaces the value `private` with `direct` in the
`message_type` field for the `typing` events sent when a user
starts or stops typing a message.
2023-10-10 17:15:28 -07:00
N-Shar-ma
5817da709c
compose: Refactor and generalise functions for formatting.
...
The logic for formatting code is generalised to make it reusable for
multiple styles of formatting (added in the next commits).
Co-authored-by: N-Shar-ma <bablinaneh@gmail.com>
2023-10-10 16:54:33 -07:00
N-Shar-ma
e24689a1ce
compose: Rename formatting methods and arguments for generalisation.
...
This is a prep commit for extracting general functions for adding and
removing formatting.
2023-10-10 16:54:33 -07:00
N-Shar-ma
6537004ae9
compose: Move bold formatting code into separate functions.
...
This is a prep commit for refactoring formatting code to make future
format button additions need minimal code duplication.
2023-10-10 16:54:33 -07:00
Anders Kaseorg
b396573acf
hello: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 16:51:14 -07:00
Anders Kaseorg
2163cb7770
popovers: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 16:50:48 -07:00
Anders Kaseorg
0006f4a90c
audible_notifications: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 16:50:07 -07:00
Anders Kaseorg
41c64ee8bb
audible_notifications: Add missing $ prefix to parameter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 16:50:07 -07:00
Anders Kaseorg
340b0a1181
compose_call: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 16:48:57 -07:00
Anders Kaseorg
71ac1c880b
page_params: Fix alphabetical order of page_params type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 16:48:57 -07:00
Karl Stolley
b19986b777
left_sidebar: Use custom Zulip star icons.
...
This commit replaces all previous Font Awesome references in the
left side bar and relevant popovers with the custom Zulip star
icon.
Co-Authored-By: Hardik Dharmani <Ddharmani99@gmail.com>
2023-10-10 16:48:20 -07:00
Karl Stolley
fd0dd3acd8
left_sidebar: Refactor left_sidebar.hbs structures for readability.
...
This commit renames the classes and IDs in the views area
(formerly global filters) to a set of flexible values all
prefixed in some way with `left-sidebar-navigation`.
This is meant to make the styles and structures in the area
more readable, while also keeping things flexible into the
future as this area's elements change.
Co-Authored-By: Hardik Dharmani <Ddharmani99@gmail.com>
2023-10-10 16:48:20 -07:00
Hardik Dharmani
7e776b9c76
refactor: Make variable for unread counter's background colors.
...
This is Prep commit that introduces 2 new CSS variable
`--color-background-unread-counter` and
`--color-background-unread-counter-popover-menu` that has value
`hsl(105deg 2% 50% / 50%)` in dark theme and `hsl(105deg 2% 50%)`
in light theme for unread counter and `hsl(200deg 100% 40%)`
for unread counter in popover menus to match its blue theme.
2023-10-10 16:48:20 -07:00
Hardik Dharmani
a61d291ca4
left_sidebar: Correct the color of BACK TO STREAMS in dark theme.
...
This is a Prep commit. This commit fixes the color of
`BACK TO STREAMS` label in the dark theme to be equal to other labels
in left sidebar such as `STREAMS` label.
2023-10-10 16:48:20 -07:00
Aman Agrawal
3498b07379
modals: Rename open_modal to open.
2023-10-10 16:43:57 -07:00
Aman Agrawal
1d4797834e
modals: Rename close_modal to close.
2023-10-10 16:43:57 -07:00
Aman Agrawal
c809abf07f
modals: Rename close_modal_if_open to close_if_open.
2023-10-10 16:43:57 -07:00
Aman Agrawal
0c7184aaa0
modals: Rename close_modal_active to close_active.
2023-10-10 16:43:57 -07:00
Aman Agrawal
d54a917104
modals: Rename is_modal_open to is_open.
2023-10-10 16:43:57 -07:00
Aman Agrawal
577a384845
overlays: Extract modal methods in separate file.
2023-10-10 16:43:57 -07:00
Aman Agrawal
6713ad9d4d
overlays: Extract function checking if overlays or modals are open.
2023-10-10 16:43:57 -07:00
Aman Agrawal
63c1c9a37a
overlays: Extract enable / disable scrolling to a util module.
2023-10-10 16:43:57 -07:00
Aman Agrawal
065420853f
overlays: Fix spelling.
2023-10-10 16:43:57 -07:00
Anders Kaseorg
325b308ed5
about_zulip: Convert module to TypeScript.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 13:20:31 -07:00
Aman Agrawal
ce48aac3db
inbox: Fix stream name wrapping to next line.
2023-10-10 13:06:46 -07:00
Aman Agrawal
e4252f8f08
settings_config: Change order of option for default view.
...
Inbox > Recent conversations > All messages
2023-10-10 13:06:46 -07:00
Aman Agrawal
3a2fbfc2fd
inbox_ui: Fix mute / unmute not working.
...
This is fix for the old version of mute / unmute buttons.
Code borrowed from click_handlers.
2023-10-10 12:47:42 -07:00
Anders Kaseorg
881da05cd3
stream_settings_ui: Extract stream_settings_components module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 12:09:15 -07:00
Aman Agrawal
22f4ecdad6
message_fetch: Don't use MessageList to fetch data for recent view.
...
Since load_messages now supports fetching data with only
MessageListData, we can just use it and avoid calling
MessageListView which also caused our polls and TODO widgets to
not render occasionally.
2023-10-10 11:11:19 -07:00
Aman Agrawal
69e10b4dae
message_fetch: Handle MessageListData directly passed to load_messages.
...
This will allow us to use load_messages to fetch data using it
without initializing a MessageList.
2023-10-10 11:11:19 -07:00
Karl Stolley
88f4ecc943
compose_banner: Restore CSS overzealously removed in #27097 .
...
This also includes a comment for future contributors, explaining
why these styles are necessary.
2023-10-10 10:01:11 -07:00
Anders Kaseorg
521cb15a07
stream_ui_updates: Cut import of stream_settings_ui.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 09:08:53 -07:00
Anders Kaseorg
b9bb0d5aa8
settings_org: Cut import of settings_realm_user_settings_defaults.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-10 09:06:28 -07:00
Anders Kaseorg
1d43a4cccb
stream_edit: Extract toggler to new stream_edit_toggler module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 23:19:59 -07:00
Anders Kaseorg
3cac29a8e1
settings_org: Extract settings_components module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 17:26:49 -07:00
Aman Agrawal
9ab1a726a0
inbox: Add page up/down support similar to recent topics.
...
Leaving page up / down to browser doesn't work very well due to
our custom header, filters and compose.
2023-10-09 16:36:24 -07:00
Aman Agrawal
9fc6af220e
inbox: Handle latest message not fetched when replying.
...
Since inbox is populated based on unread data which is part
of /register request, it is possible that we don't have the
actual message in our message_store. In that case, we return
a fake message object.
2023-10-09 16:36:24 -07:00
Aman Agrawal
2c4156e239
compose_reply: Remove unnecessary pm_recipient being set.
...
`pm_recipient` is already set in `else` case unconditionally,
so setting it early is not required.
2023-10-09 16:36:24 -07:00
Aman Agrawal
bb740ca65e
inbox: Fill compose with dm/stream info for `reply` on inbox-header.
2023-10-09 16:36:24 -07:00
Aman Agrawal
2561e7f2d8
inbox: Set compose recipient according to focused row on `reply`.
...
Fill compose recipient based on the latest message of the focused
row.
2023-10-09 16:36:24 -07:00
Aman Agrawal
50a356389c
inbox: Update closed compose text based on focused element.
...
For header rows, search and filters we just show default text.
2023-10-09 16:36:24 -07:00
Aman Agrawal
3ac6f447d9
inbox_ui: Change current_focus_id when clicking on inbox search.
2023-10-09 16:36:24 -07:00
Aman Agrawal
64cc24722f
inbox_ui: Rename function to reflect it only works for focus in list.
2023-10-09 16:36:24 -07:00
Aman Agrawal
3cbd772b8d
inbox: Make focus outline around unread count wider.
2023-10-09 16:36:24 -07:00
Aman Agrawal
80a7e995af
inbox: Fix spelling mistakes.
...
Found a good spell checker, hopefully no more of those.
2023-10-09 16:36:24 -07:00
Aman Agrawal
e9c86dc524
inbox: Add topic visibility indicator.
2023-10-09 16:36:24 -07:00
Aman Agrawal
8c619d6938
inbox: Rename variable for readability.
2023-10-09 16:36:24 -07:00
Aman Agrawal
49f553ebfc
inbox: Add rectangle focus border around inbox header name.
2023-10-09 16:36:24 -07:00
Anders Kaseorg
50928314f2
settings_users: Remove get_status_field.
...
It’s effectively unused since commit
2d5c678614
(#25061 ), as predicted by
commit d45f0171cb
(#14919 ).
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 16:05:31 -07:00
Anders Kaseorg
95b9d6f7e2
settings: Move set_settings_header to settings_panel_menu.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 16:04:30 -07:00