0e657756f1
dict: Make set method return value consistent with Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:03 -08:00
ab61222dd5
dict: Reimplement Dict using Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
b16222a38b
dict: Remove setdefault method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
8872aca907
dict: Remove clone method.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
22555f53ad
dict: Remove Dict.from_array.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
52765796c2
dict: Remove Dict.from.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-04 12:22:02 -08:00
5b824702b4
unread: Replace key_to_bucket Map with Dict/FoldDict/IntDict.
...
This reverts commit d84646f091
2020-02-04 12:21:29 -08:00
c5af0fccce
docs: Fix anchors for using.
...
We could have just updated the links, but it's probably better the way
it was originally.
2020-02-03 16:55:28 -08:00
4e34f672ff
docs: Reorganize testing.md and using.md.
...
This is a fairly involved set of changes, including changes that:
* Delete various legacy or semi-duplicated sections of testing.md.
Nobody needs to manually delete the postgres datbase anymore, as
reflected in the fact that the docs still mention postgres 9.1 from
Ubuntu Precise.
* Simplify the distracting heading section at the top of testing.md.
* Move content on manual testing to docs/development/using.md.
* Moves some content related to managing the database to
schema-migrations.md. (Resulting in some cleanups to that page as
well).
I ideally would have split this into smaller pieces.
2020-02-03 16:43:27 -08:00
32ff28bf24
docs: Add an article explaining our testing philosophy.
2020-02-03 16:32:35 -08:00
2f3a0fb80a
devtools: Improve labels and headings for some tools.
...
It's useful to be a bit more clear about what precisely these tools
are for.
2020-02-03 16:13:34 -08:00
252910202b
poll_widget: Convert votes from object to Map.
...
Fixes implicity stringification of the user ID keys.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 15:59:26 -08:00
85620df34e
poll_widget: Convert key_to_option from object to Map.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 15:59:26 -08:00
849c7f83a0
blueslip_stacktrace: Handle promises in sourceCache.
...
Fixes “TypeError: sourceContent.split is not a function” at
blueslip_stacktrace.ts:60 when there’s another error during page load.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-03 15:58:57 -08:00
df5345705c
import: Support importing team icon from slack.
2020-02-03 14:09:05 -08:00
5dfd4ea38d
export: Remove unused parameter from _get_exported_s3_record.
2020-02-03 14:09:05 -08:00
5a59bf329e
import: Skip setting user_profile_id metadata only if unavailable.
2020-02-03 14:09:05 -08:00
2ea53a347a
import: Support importing realm icon and logo.
...
Fixes #11216
2020-02-03 14:09:05 -08:00
af3a37b58b
upload: Refactor out realm_avatar_and_logo_path function.
2020-02-03 14:09:05 -08:00
aaa30df94c
Hotkeys: Change hotkeys behaviour on dropdown open.
...
Disables message_view_only hotkeys when dropdown menu is opened.
Fixes : #11990
2020-02-03 13:45:07 -08:00
23c5123a55
hotkeys: Change 'q' and 'w' to message_view_only
...
Add message_view_only property to 'q' and 'w' hotkeys
2020-02-03 13:40:48 -08:00
8e733fb513
settings_org: Extract the function to hide or show the element block.
...
This change leads to some de-duplication of repeated code.
2020-02-03 11:37:40 -08:00
dd6e616c9b
settings_org: De-duplicate code to set value of normal dropdowns.
...
In the future, any property which doesn't have any dependent setting can be
added to `simple_dropdown_properties` list, which automates setting the
value of dropdowns on saving.
2020-02-03 11:37:40 -08:00
df110e8ff9
test_fixtures: Note populate_db depends on server_initialization.py.
...
This should ensure that folks rebasing past this commit from an older
database model get their database rebuilt in the way that will
match the test_subs.py query count of 40.
2020-02-03 10:38:04 -08:00
9f150385bc
design: Fixes height of view stream button.
...
The view stream button had a line-height property which messed up
its height. Fixed it by removing the line-height property.
2020-02-02 21:34:00 -08:00
3dec7f6f6f
design: Fixes poor line wrapping of long stream names using ellipses.
...
Earlier, on narrowing the window to some particular sizes,
long stream names used to overlap with the subscribe and view stream
buttons.
The issue was resolved by cutting the stream name short and putting
ellipses at the end. A title was provided to the stream name div so that
the entire stream name would be visible on hovering over it.
Fixes : #13139
2020-02-02 21:34:00 -08:00
3dc7d60ffe
muting: Record DateTime when a Topic is muted.
...
This includes the necessary migration to add
the date_muted field to the MutedTopic class
and populates it with a hard coded value.
2020-02-02 20:49:53 -08:00
e4259d48a5
dict: Assert that Dict is only used with string keys.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
ad06810501
tests: Replace stream_count, topic_count, html_dict with IntDict.
...
stream_count and topic_count in the actual code have been IntDict
since commit 9ba1829243#13569 ).
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
b41968c4a7
topic_list: Replace active_widgets Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
a7bed2c8a3
stream_list: Replace rows Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
b5cd8dcedd
starred_messages: Replace ids Dict with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
1189747d4c
settings_streams: Replace row_dict Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
90ebaa86e9
settings_sections: Replace is_loaded Dict with loaded_groups Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
21b13e656d
recent_senders: Replace topic_senders and stream_senders with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
ceb37edb55
tests: Avoid _.uniqueId when a number is needed.
...
_.uniqueId returns a string.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
c4e1357e19
pm_conversations: Replace partners Dict with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
052497de1c
muting: Replace muted_topics Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
e10da9c85f
condense: Replace _message_content_height_cache Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
2f91f583fc
unread: Replace buckets with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
5262ff790e
unread: Replace unread_message_ids with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
6a0de3bb74
unread: Replace unread_mentions_counter with Set.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
a9e28218b2
unread: Replace reverse_lookup Dict with IntDict.
...
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
d84646f091
unread: Replace key_to_bucket Dict/FoldDict with Map.
...
Fixes type confusion in unread_topic_counter, which uses stream IDs as
keys.
Since unread_topic_counter calls message_store.get now, update the
mocks so that message_store.get knows about our mocked messages.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
fd9557aa0c
unread: Fix {get_msg_ids,num_unread}_for_person type confusion.
...
These methods take a comma-separated string of user IDs; don’t pass a
number.
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
2020-02-02 20:37:41 -08:00
6aacc4195e
login: Make authentication_methods data available to JavaScript.
...
This is intended to simplify overriding these buttons' controls in the
desktop app to do the authentication in the user's default browser.
2020-02-02 20:22:49 -08:00
b685d506ad
auth: Make login_context available to TwoFactorLoginView.
2020-02-02 20:22:49 -08:00
4fba725803
test_auth_backends: Fix errors after rebasing.
...
Apparently, the rate-limiting PR had some import conflicts with our
recent authentication backend testing changes.
2020-02-02 20:22:32 -08:00
7858e5ee40
webhooks/ansibletower: Update for AWX 9.1.1.
...
Add a simple compatibility function for AWX 9.x.x. Before AWX 9.x.x
a "friendly_name" key was sent by default. Afterwards it was removed
from being a default key but we can still more or less determine if
the triggering event was a job from the REST-style URL.
Note: It is also technically possible to add the key back by defining
a custom notification template in AWX/Tower.
Resolves #13295 .
2020-02-02 20:21:03 -08:00
7b34853328
rate_limiter: Rename authenticate domain to authenticate_by_username.
...
This prepares for adding authenticate_by_ip_address.
2020-02-02 19:15:13 -08:00
Anders Kaseorg
Tim Abbott
Vishnu KS
shubhamgupta2956
Pragati Agrawal
Vaibhav Raj Singh
Ryan Rehman
Mateusz Mandera
Hemanth V. Alluri