fa4050d62d
Improve error handling in is_current_user().
...
Realm bots have a owner of `null` but that is not explicity handled
in `is_current_user()`.
2016-12-14 19:27:43 -08:00
dc6849952b
eslint: change space-before-function-paren from warning to error.
...
Also fix violations.
2016-12-05 09:50:37 -08:00
025fe9980b
Switch no-empty eslint rule from warning to error (in .eslintrc)
2016-12-05 01:35:14 +00:00
0290aeb6ab
lint: Fix several no-unused-vars eslint rule violations.
...
These changes were extracted by tabbott from the original commit
to merge now because they have been reviewed as safe.
2016-12-03 18:43:47 -08:00
426cb13e23
Remove `enforce_arity` function from util.js.
...
Remove `enforce_arity` function from util.js, because it is
not used anymore.
2016-12-03 18:43:46 -08:00
ed0bc831be
eslint: change one-var from warning to error and fix violations
2016-12-02 11:25:16 -07:00
e6369fc29b
eslint: change no-plusplus from warning to 2 and fix violations.
2016-12-01 14:27:17 -08:00
d953eca14c
Make group PMs reply-to's more consistent in case.
...
We now sort lists of users ids deterministically, and we also
sort list of emails deterministically and without regard to case.
This probably fixes the bug #2343 , although I never got a great
repro on that.
2016-11-26 11:48:52 -08:00
e40e756d47
echo: Fix local echo sending a message to "yourself, ".
...
Previously, this would incorrectly include a user with name and email
"" in the recipients list shown in the local echo code path.
We fix this and add a test for the issue.
2016-11-14 21:43:13 -08:00
9b04ec7472
Send dicts for cross realm users to JS.
...
We now send dictionaries for cross-realm bots. This led to the
following changes:
* Create get_cross_realm_dicts() in actions.py.
* Rename the page_params field to cross_realm_bots.
* Fix some back end tests.
* Add cross_realm_dict to people.js.
* Call people.add for cross-realm bots (if they are not already part of the realm).
* Remove hack to add in feedback@zulip.com on the client side.
* Add people.is_cross_realm_email() and use it in compose.js.
* Remove util.string_in_list_case_insensitive().
2016-11-03 09:51:23 -07:00
8216a42d85
subject/topic: Rename same_stream_and_subject().
2016-08-26 20:26:24 -07:00
b1b864341c
Fix @all spam warning when typing @all in backticks.
...
When user'd like to send a message with @all in backticks
they see spam warning in spite of the fact that nobody
would be alerted.
Fixes : #1505 .
2016-08-18 16:10:09 -07:00
5c82e53b9a
Move checking all/everyone message to util.js module.
...
Create is_all_or_everyone_mentioned function in util.js.
2016-08-18 16:10:09 -07:00
77ec6217eb
Add validation for private message recipients.
...
The function will reject messages where recipients aren't either a
member of the realm or a member of cross_realm_user_emails.
Fixes : #930 .
2016-06-11 11:24:45 -07:00
a717c7df18
Seperate extract PM recipients as function.
2016-06-11 11:22:22 -07:00
c35781d505
lint: Require folding of } on same line as else statements.
2016-06-09 14:02:49 -07:00
a829366733
util: Create and use is_pm_recipient helper function.
2016-06-07 21:58:45 -07:00
b25562ca1d
Add and use util.is_current_user helper function.
...
Previously, we were checking if a particular user was the current user
in dozens of places in the codebase, and correct case-insensitive
checks were not used consistently, leading to bugs like #502 .
2016-06-07 21:58:44 -07:00
0bf2d171ae
Fix fading of messages in dialog and users in side-bar.
...
Make comparison of emails in compose_fade.js and util.js
case-insensitive to fix fading of users and messages respectively.
2016-06-07 21:31:47 -07:00
7fce920522
Move favicon-related functions to favicon.js
...
util.reset_favicon -> favicon.reset
util.set_favicon -> favicon.set
(imported from commit 250848ec5dc7ac58649197c8cc4b7b4e7b19f25c)
2014-03-14 20:48:55 -04:00
d52e5e551d
Remove {show,destroy}_first_run_message.
...
We essentially inlined the methods in the three places they
were called.
(imported from commit 622ee718d6dd226187f1e37ff754ee2fa635e6f2)
2014-03-14 20:48:54 -04:00
b12b44579c
Set up $.fn.expectOne in setup.js
...
(imported from commit 77922cf8f506d4eb811498d418215eabf74b76ae)
2014-03-14 20:48:53 -04:00
3889edd824
Move xhr_error_message() into channel.js
...
(imported from commit c68c2d475b5673a3dd5f68c75624dfcfe56728ca)
2014-03-14 20:48:53 -04:00
0e129614cf
Remove unused util.recipient_key() function.
...
(imported from commit cee6a58344971ee1439e6b66ec301f1bd0f80502)
2014-03-14 20:48:53 -04:00
50bc5401a4
Moved loading_indicator functions to loading.js.
...
util.make_loading_indicator -> loading.make_indicator
util.destroy_loading_indicator -> loading.destroy_indicator
(imported from commit 8a171622a6096476dd040912d3f1460d53159f20)
2014-03-14 20:48:52 -04:00
86d310a984
Pass index of element to util.lower_bound matching function
...
(imported from commit eb8ba76b4855355bc23d6419cbb0f3a4aad8b6de)
2014-03-14 20:48:46 -04:00
bdee9721ec
tests: Delay loading old messages and starting get_updates until phantomjs thinks the page has loaded
...
This doesn't affect code when not in testing. It shaves 7 seconds off of casper
test time on my machine.
(imported from commit 7e27fa781bcf16f36d9c8f058427ba57c41068bd)
2014-03-11 13:06:22 -04:00
3a6df13360
Don't fade messages on different topics but the same stream.
...
(imported from commit 1bc2d49b346619609e73794d237faf2352b974b3)
2014-02-12 16:26:57 -05:00
9428f40422
Add a `.expectOne` method to jQuery objects.
...
It asserts that the result set is exactly one element.
(imported from commit c78ff131deb4a13c65c2a68e4b8e09279ece3ea0)
2013-09-04 16:44:33 -04:00
e0eddabeb1
Add util.enforce_arity
...
util.enforce_arity takes a function and returns a new version which
throws an error if an incorrect number of arguments (as determined by
the function prototype) are passed.
(imported from commit 20e69a6dc7b6f8455726ab4fae8d5b7b04dc4103)
2013-08-09 17:12:23 -04:00
eac6463031
Implement message summarization experiment.
...
When you read messages in a narrow and then un-narrow, collapse
adjacent messages read in the narrow into a summary row that can
be clicked to expand those messages.
Scoped to staging with feature flags.
The implementation of this within our current MessageList is rather ugly.
(imported from commit bcb3a39d8c0c334136fe86318f18ead03f0f50bf)
2013-08-07 10:24:03 -04:00
de252b0ee9
Remove utils.memoize().
...
We use _.memoize() in the one place it was called before.
(imported from commit de15a61eed47551f0f539aacba6df3303c865299)
2013-08-06 18:22:11 -04:00
3ce318e9a1
Add CachedValue class to encapsulate the pattern of caching mostly static values
...
(imported from commit 14048847e77974cda3a6214f129492d8d373080d)
2013-08-06 16:15:47 -04:00
349039289c
Set module.exports in util.js.
...
(imported from commit 12b81a6f9b79fe3f024f53e3185d647971952df7)
2013-08-06 14:04:29 -04:00
5a320db3c1
Add curly braces for all javascript if statements lacking them.
...
(imported from commit 32c7643d1a6ecdfaf634424d217938c8a368dade)
2013-08-01 11:47:54 -04:00
a35fff90cc
Replace $.extend
...
(imported from commit 2c1ee3c2714d388f2a71398fe81c049cc54ff94d)
2013-07-30 12:12:59 -04:00
375b1f9eb3
Replace $.map with _.map
...
(imported from commit 97c7a6612d8d56d19f8650db0ea8906afc0f20ef)
2013-07-30 12:09:18 -04:00
88952fb2b1
Replace $.grep with _.filter
...
(imported from commit 3a8830f697551a91f94f06b37d01a3687d8c583d)
2013-07-30 12:06:22 -04:00
3bba0cc927
Move zephyr/static to just static.
...
It's not really a part of the server (aka the rest of zephyr/).
(imported from commit 27f6b6b064938ad927075a68d873e4b68710d279)
2013-07-29 12:11:26 -04:00
Tommy Ip
lonerz
Rafid Aslam
AZtheAsian
kevv87
Steve Howell
Tim Abbott
Tomasz Kolek
Vishnu Ks
Tim Abbott
Givorenon
Steve Howell
Leo Franchi
Zev Benjamin
Jessica McKellar
Kevin Mehall
Kevin Mehall
Steve Howell
Zev Benjamin
Tim Abbott
Scott Feeney