f0f4be4af7
lint: Fix remaining no-unused-vars eslint rule violations.
2016-12-14 22:36:47 -08:00
fe2d38392f
subs: Restore debouncing of stream filtering.
...
This appears to have been accidentally removed in the redesign.
2016-12-14 22:36:47 -08:00
45f39be37f
lint: Fix many no-unused-vars eslint rule violations.
...
These have been carefully audited by tabbott to ensure they are
unlikely to cause regressions.
2016-12-14 21:34:51 -08:00
80ad28bab5
Don't repeat date header if message date is same as previous.
...
This primarily works to make sure that new queued messages don’t end up
with redundant date headers on them.
2016-12-14 20:41:33 -08:00
0329b67048
admin: Limit bots in settings page.
...
Updated `get_editable()` so that organization admins only see their
own bots in their personal settings page; this removes a lot of
unnecessary clutter.
Fixes #2657 .
2016-12-14 19:29:02 -08:00
fa4050d62d
Improve error handling in is_current_user().
...
Realm bots have a owner of `null` but that is not explicity handled
in `is_current_user()`.
2016-12-14 19:27:43 -08:00
546cc27f0d
minor: Add code comment re:unread counts.
2016-12-14 19:10:55 -08:00
5444486acb
Have unread_topic_counter.get_counts() return a result.
...
Before this change, we passed in a hash to get_counts() to
mutate, but now we make the caller responsible for splicing
results into a bigger data structure.
The function now involves no mutation.
2016-12-14 19:10:55 -08:00
b11fbf0b4b
Consolidate stream/topic logic for unread messages.
...
This change introduces an unread_topic_counter object
that manages unread counts for streams and topics. Consolidating
all the logic into a single class will set us up to add
logic for dealing with topic counts that includes provisional
counts of unread messages from the server. It also makes
the current code a little easier to reason about.
Most of this change was simply extracting functions, but
I also removed a few unnecessary and inconsistent calls to
`stream_data.canonicalized_name` that preceded our use of
Dict with a fold_case argument.
2016-12-14 19:10:55 -08:00
c25694a9d9
Do not reload page on form submission in settings page.
...
Currently under Zulip Labs and Notifications, saving changes reloads
the page. This shouldn’t happen.
Fixes #2697 .
2016-12-14 16:32:32 -08:00
6ed7ba8935
Blur all links after clicking.
...
The links don’t have to stay focused and produce unintended side
effects.
2016-12-14 15:37:43 -08:00
660144a79d
Blur the active element on settings/streams modal exit.
...
This blurs any focused element so that you can’t accidentally enter
into anything on a hidden modal.
2016-12-14 15:37:43 -08:00
a460fcddef
Add Date Headers to Floating Bar and Message Headers.
...
This adds the date of a block of messages to the floating recipient
bar along with message headers of blocks that are the first of a
particular day.
2016-12-13 20:36:39 -08:00
8b44ace3a8
frontend: Make global notifications live-update on changes.
...
Fixes #2527
2016-12-13 20:22:13 -08:00
65288848b1
Fix Hiding Stream Creation Prompt on "Enter".
...
The stream creation prompt would be hidden if someone clicked “Enter”
and the form failed. This is presumably due to some bootstrap magic.
2016-12-13 13:16:51 -08:00
868f343980
Do not open compose box if user sidebar search is empty.
...
Fixes #2357 .
2016-12-13 11:04:08 -08:00
1886f0a015
redesign: Convert subscriptions page to overlay.
...
This is a major change to the /#subscriptions page, converting it to
by a side-by-side list of streams and their settings in an overlay.
There are no new features added/removed, but it's a huge changeset,
because it replaces the old navigation logic and moves the stream
creation modal to appear in the right side of this overlay.
2016-12-09 11:08:08 -08:00
0bac986f26
Fixed compose box PM recipient typeahead handling of focus.
...
This closes #2315 .
2016-12-07 22:13:47 -08:00
fe4a0e72fc
Add new button to download ~/.zuliprc from settings page.
...
Added new option to download .zuliprc file directly from settings
page. This should help reduce friction when setting up new
bots/integrations. This new feature is available in the bot cards and
the 'show your API key' section. One caveat is that the filename is
automatically set to 'zuliprc' instead of '.zuliprc', since as most
browsers do not allow filenames to start with a dot.
Fixes #2327 .
2016-12-07 21:28:41 -08:00
7856217a63
Migrate JS modules to CommonJS style.
...
Closes #1488 .
2016-12-07 16:11:52 -08:00
e65c42cb5f
eslint: Turn on errors for new-cap rule.
...
Now the eslint rule "new-cap" is set as: ["error", { "newIsCap": true, "capIsNew": false }]
2016-12-07 05:33:16 -08:00
ce94fb2eb1
deps: Change zxcvbn download method from download-zxcvbn to npm.
...
- Replace download-zxcvbn with downloading it from npm.
- Change zxcvbn.js path to node_modules (because npm put it to
`node_modules` directory.
- Bump `PROVISION_VERSION` in `version.py` to 2.4.
Fixes #2423 .
2016-12-06 17:54:56 -08:00
0951b838ca
deps: Update zxcvbn to 4.4.1
...
Update zxcvbn to 4.4.1, and change `crack_time` to
`crack_times_seconds` because `crack_time` has been changed to
`crack_times_seconds` in 4.4.1.
2016-12-06 17:51:33 -08:00
e6e11aefb3
settings: Add option to disable websockets.
...
This can be useful in scenarios where the network doesn't support
websockets. We don't include it in prod_settings_template.py since
it's a very rare setting to need.
Fixes #1528 .
2016-12-05 21:55:22 -08:00
7bf10ec74f
update-sockjs: Update sockjs from version 0.3.4 to 1.1.1.
...
- Add browserify to npm dependencies.
- Add SockJS-client to npm dependencies.
- Add npm postinstall script to generate browser version of SockJS-client
from npm package.
- Change deprecated SockJS object property 'protocol_whitelist' to
'transports'.
- Fix settings.
2016-12-05 21:36:10 -08:00
abde152d9c
eslint: change array-callback-return from warning to error.
2016-12-05 21:21:19 -08:00
dc6849952b
eslint: change space-before-function-paren from warning to error.
...
Also fix violations.
2016-12-05 09:50:37 -08:00
a8b39e6c0f
Switch yoda eslint rule from warning to error (in .eslintrc)
2016-12-04 19:48:10 -08:00
025fe9980b
Switch no-empty eslint rule from warning to error (in .eslintrc)
2016-12-05 01:35:14 +00:00
0290aeb6ab
lint: Fix several no-unused-vars eslint rule violations.
...
These changes were extracted by tabbott from the original commit
to merge now because they have been reviewed as safe.
2016-12-03 18:43:47 -08:00
426cb13e23
Remove `enforce_arity` function from util.js.
...
Remove `enforce_arity` function from util.js, because it is
not used anymore.
2016-12-03 18:43:46 -08:00
1fb9220354
lint: Remove old jslint linter.
...
Now that we're using eslint, jslint is no longer required.
2016-12-02 18:49:42 -08:00
2c940b93ab
js: Fix some minor whitespace issues.
2016-12-02 18:39:30 -08:00
5e9918135b
eslint: change quote-props from off to error and fix violations.
2016-12-02 18:35:53 -08:00
b8fc3f0e65
eslint: change space-before-blocks from warning to error and fix violations
2016-12-02 17:40:09 -08:00
9c0ebc7359
eslint: change no-else-return to error and fix violations
2016-12-02 14:43:09 -08:00
ed0bc831be
eslint: change one-var from warning to error and fix violations
2016-12-02 11:25:16 -07:00
b3f4feb996
eslint: change max-len from warning to error and fix violations.
2016-12-02 14:16:33 +00:00
e6369fc29b
eslint: change no-plusplus from warning to 2 and fix violations.
2016-12-01 14:27:17 -08:00
c90da24541
eslint: change keyword-spacing from warning to error and fix violations.
2016-12-01 14:22:15 -08:00
d99b17070e
edit: Fix traceback when saving edits to unsent messages.
...
7b0c6459b4Fixes #2416 .
2016-12-01 10:39:43 -08:00
7b2c313f37
eslint: change brace-style from warning to error and fix violations.
2016-12-01 10:20:22 -08:00
4935f0c693
popovers: Hide actions popover once the muting button is clicked.
...
The popover shouldn’t still display once a valid action on the popover
has been taken.
Fixes #2366 .
2016-11-29 16:47:03 -08:00
f7dc2f33cd
Change name of eslintrc file to .eslintrc.json
...
Currently it does this for the eslintrc files in zulip,
zulip/frontend_tests and static/js
This commit also fixes json style issues (quotes)
2016-11-29 08:58:39 -08:00
3d1bcb05e1
tornado: Move event_queue.py to zerver/tornado/.
...
Fixes #729 .
2016-11-26 22:29:28 -08:00
4e5c4c5ffb
streams: Add support for setting stream description during creation.
...
Add new box for stream description in the stream creation form,
modify backend so its contents end up as the stream description.
Fixes : #2283 .
2016-11-26 16:55:35 -08:00
604079a9d4
Fix formatting for Group PMs in the right sidebar.
...
We now sort users by the lower case value of their
full names in each of the links in the "GROUP PMs"
section of the right sidebar. We still use "+n others"
for big huddles.
2016-11-26 11:48:52 -08:00
d953eca14c
Make group PMs reply-to's more consistent in case.
...
We now sort lists of users ids deterministically, and we also
sort list of emails deterministically and without regard to case.
This probably fixes the bug #2343 , although I never got a great
repro on that.
2016-11-26 11:48:52 -08:00
578b276523
node tests: Add tests for message_store.js.
2016-11-26 11:48:52 -08:00
af9ff9a030
Have unread.num_unread_for_person accept a user_id.
...
(It used to take an email as its parameter.)
2016-11-26 11:48:52 -08:00
Tim Abbott
Rafid Aslam
Brock Whittaker
Tommy Ip
Steve Howell
Brock Whittaker
Bojidar Marinov
Bickio
Igor Tokarev
Yago González
Zac Pullar-Strecker
K.Kanakhin
lonerz
kevv87
AZtheAsian
Krzysztof Zbudniewek
aakash-cr7
Arpith Siromoney
Calvin Lee