3 Commits

Author	SHA1	Message	Date
Dinesh	dcc47dcc12	puppeteer: Wait for display settings section to appear before clicking. ... In few rare cases the click on display settings section wasn't working which was causing the test to stay in the "your account" settings section. This lead to a waitFor fail. The screenshot in this failed CircleCI build suggests the above. https://app.circleci.com/pipelines/github/chdinesh1089/zulip/525/workflows/cd77e269-6a3e-4283-b765-d1c4584ccf35/jobs/1807/artifacts This and the previous commit along with the changes to prevent logging out of user on changing password were tested by running this test 1200 times and all of them passed!	2020-08-30 14:59:05 -07:00
Sahil Batra	33e19fa7d1	puppeteer: Replace 'visible: false' with 'hidden: true'. ... We need to replace 'visible: false' with 'hidden: true' to wait for elements to get hidden. Using 'visible: false' just checks whether the selector exists or not and does not check whether the element is hidden or not.	2020-08-10 16:48:53 -07:00
Dinesh	90d956d2ed	puppeteer: Rename settings test to be the last test. ... This test changes user password causing all subsequent tests to fail. Since rechanging the password would be a redudant test/task or having manually entering the new password in every test after this aren't good ideas, this commit makes the settings test run in the end by renaming it be numbered 16. It is assumed that we'll end up having 16 tests seeing the number of tests in casper and considering 03 and 02 from casper are being combined as 02-message-basics.js. Though 03 of casper has not yet been added in message-basics test it will soon be added.	2020-08-04 14:33:37 -07:00