Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
59,865 Commits 28 Branches 143 Tags 631 MiB
Commit Graph

12 Commits

Author SHA1 Message Date
Anders Kaseorg 507eb4913c tsconfig: Enable exactOptionalPropertyTypes. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-05-16 08:58:20 -07:00
Aman Agrawal 1c7c8cede8 recent_view: Fix marking topic as read resulting in error. 
Since we were trying to close dialog widget regardless of caller
after marking messages as read, it results in an error if the dialog
widget is not open especially since there was no dialog widget
involved in the process.

So, track the id of the dialog widget which called the `read` `op`
and operate on it based on it's status if there was a dialog
widget involved.
 2024-05-15 12:02:57 -07:00
Anders Kaseorg 24ecafbdd2 eslint: Fix @typescript-eslint/no-useless-template-literals. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2024-01-29 16:14:26 -08:00
Anders Kaseorg 9c9c453d5a web: Remove unchecked casts of event objects. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-10-25 13:08:36 -07:00
N-Shar-ma 82f105aada popovers: Fix bug where modals persisted on hashchange. 
Modals like those for Read receipts, Schedule message, Message edit
history, User profile, etc would not close when the hash changed.

Now we close any active modal whenever the hash changes; we add a new
function in `modals.ts` to do this, and call it from `hashchange.js`.
 2023-10-22 14:56:06 -07:00
Aman Agrawal 089886245d modals: Rename is_open to any_active. 2023-10-11 09:45:37 -07:00
Aman Agrawal 3498b07379 modals: Rename open_modal to open. 2023-10-10 16:43:57 -07:00
Aman Agrawal 1d4797834e modals: Rename close_modal to close. 2023-10-10 16:43:57 -07:00
Aman Agrawal c809abf07f modals: Rename close_modal_if_open to close_if_open. 2023-10-10 16:43:57 -07:00
Aman Agrawal 0c7184aaa0 modals: Rename close_modal_active to close_active. 2023-10-10 16:43:57 -07:00
Aman Agrawal d54a917104 modals: Rename is_modal_open to is_open. 2023-10-10 16:43:57 -07:00
Aman Agrawal 577a384845 overlays: Extract modal methods in separate file. 2023-10-10 16:43:57 -07:00