zulip

Commit Graph

Author	SHA1	Message	Date
Greg Price	fc0b99cd62	tools: Apply `set -x` to just the interesting parts of *-pull-request. The Git commands we're invoking to do the real work are useful to print, for transparency to see what's happening and that there's no magic here. The boring shell stuff like `remote=${2:-"upstream"}` is not so helpful, and nor is the rather arcane and in any case read-only command `git diff-index --quiet HEAD`. Those only add noise that obscures the interesting parts. So, move the `set -x` down to when we're done with the boring preparatory stuff and ready to perform the commands that do the work.	2020-04-06 17:52:10 -07:00
Anders Kaseorg	392175d6e8	Use #!/usr/bin/env for bash shebangs. /bin/sh and /usr/bin/env are the only two binaries that NixOS provides at a fixed path (outside a buildFHSUserEnv sandbox). This discussion was split from #11004. Signed-off-by: Anders Kaseorg <andersk@mit.edu>	2018-12-17 17:21:08 -08:00
Rohitt Vashishtha	443e31e348	tools: Add script to see PRs as authors intended.	2017-06-01 21:55:08 -07:00

Author

SHA1

Message

Date

Greg Price

fc0b99cd62

tools: Apply `set -x` to just the interesting parts of *-pull-request.

The Git commands we're invoking to do the real work are useful to
print, for transparency to see what's happening and that there's no
magic here.

The boring shell stuff like `remote=${2:-"upstream"}` is not so
helpful, and nor is the rather arcane and in any case read-only
command `git diff-index --quiet HEAD`.  Those only add noise that
obscures the interesting parts.  So, move the `set -x` down to when
we're done with the boring preparatory stuff and ready to perform
the commands that do the work.

2020-04-06 17:52:10 -07:00

Anders Kaseorg

392175d6e8

Use #!/usr/bin/env for bash shebangs.

/bin/sh and /usr/bin/env are the only two binaries that NixOS provides
at a fixed path (outside a buildFHSUserEnv sandbox).

This discussion was split from #11004.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>

2018-12-17 17:21:08 -08:00

Rohitt Vashishtha

443e31e348

tools: Add script to see PRs as authors intended.

2017-06-01 21:55:08 -07:00

3 Commits