Tim Abbott
d7dd158197
test_signup: Fix test failures due to emacs backup files.
2017-01-30 11:55:50 -08:00
Tim Abbott
87337e0d1f
test_realm_aliases: Edit new realm alias test for subdomains.
2017-01-30 11:55:50 -08:00
Harshit Bansal
9bbe0efd77
realm_aliases: Add a test for adding an alias which is already claimed.
...
Fixes : #3514 .
2017-01-30 11:55:50 -08:00
Steve Howell
85cee51c68
Extract frontend_tests/node_tests/pm_list.js.
...
This code used to live in node_tests/stream_list.js.
2017-01-30 11:49:19 -08:00
Steve Howell
373c8a0bb5
Live-update PM list for full-name changes.
...
We now trigger an event in user_events.js, and we dynamically
build the list of names in pm_list.js by calling out to
people.get_recipients().
We have a few variations of functions that build lists of names
for huddles, which should be cleaned up eventually. They are
called at different times in the code path, so the different
functions, while doing mostly the same thing, start with different
data sources.
2017-01-30 11:49:19 -08:00
Steve Howell
f836ae0dfb
Live-update name changes in the recipient bar.
...
We now call message_store.get_pm_full_names() when
re-rendering a message list view, rather than reading
msg.display_reply_to, which could be stale.
2017-01-30 11:49:19 -08:00
Steve Howell
2980a9e33d
Use user's current full name in recipient bars.
...
This breaks the function
message_store.get_private_message_recipient into two functions:
get_pm_emails and get_pm_full_names.
The get_pm_emails function behaves the same way as the original
function, but get_pm_full_names now dynamically gets full names
from people.js using the user_id in the message.display_recipient
row.
This makes the recipient bar show the correct new name if you reload
your page. It doesn't help with live updates.
2017-01-30 11:49:19 -08:00
Steve Howell
a98cbff788
Use user's current full name when rendering messages.
...
The field message.sender_full_name can be out of date, so
we recompute is using data from people.js in
add_message_metadata().
2017-01-30 11:49:19 -08:00
Steve Howell
97243dcd52
Live update full names for senders in the message pane.
...
Note that this only works for people who are currently logged in.
Folks that log in after you may pick up the old full name from
the message. (I'll address this in a separate commit.)
2017-01-30 11:49:19 -08:00
Yago González
a52cd99452
docs: Add book about OSS prod to the reading list.
2017-01-30 11:32:23 -08:00
Steve Howell
00e815e91d
Removed duplicates from changelog.
2017-01-30 11:15:28 -08:00
Tim Abbott
b3c9e186f9
help: Clean up change-your-organization-settings.
2017-01-29 23:02:20 -08:00
Cynthia Lin
7766c122b4
docs: Conform *View messages from a stream* to style guide.
2017-01-29 22:57:38 -08:00
Cynthia Lin
c739e6e752
docs: Update *About streams and topics* doc.
2017-01-29 22:56:23 -08:00
synicalsyntax
969b6db7ed
docs: Rename documentation URLs and titles to be the same.
2017-01-29 22:56:23 -08:00
Cynthia Lin
41d66f1ddf
docs: Conform *Send a group of people a private message* to style guide.
2017-01-29 22:51:54 -08:00
synicalsyntax
26c13a42f8
docs: Conform *Enable or disable Press Enter to send* to style guide.
...
Also, tabbott made a number of edits to the content.
2017-01-29 22:49:23 -08:00
synicalsyntax
7ea84aa0af
docs: Conform *Send a private message* to style guide.
2017-01-29 22:36:48 -08:00
synicalsyntax
8932d46657
docs: Conform *Send a stream message* to style guide.
2017-01-29 22:35:24 -08:00
Tim Abbott
1bbf0f9a98
streams: Consider stream name validation logic.
2017-01-29 22:07:14 -08:00
Tim Abbott
d14037c82e
streams: Fix misplaced import.
2017-01-29 22:07:14 -08:00
Tim Abbott
884aa2b184
streams: Eliminate last use of get_stream in views.
2017-01-29 22:07:14 -08:00
Tim Abbott
4d3e97f304
actions: Remove unnecessary do_create_stream function.
2017-01-29 22:07:14 -08:00
Tim Abbott
700089f386
bugdown: Fix need for Internet in test_inline_dropbox_bad.
2017-01-29 22:07:14 -08:00
Tim Abbott
32f778636b
streams: Add tests for do_rename_stream error paths.
2017-01-29 20:27:00 -08:00
Tim Abbott
b1c2ff9d05
lint: Ban most use of get_stream from zerver/lib/actions.py.
2017-01-29 20:27:00 -08:00
Tim Abbott
01daa3e91a
test_helpers: Move get_subscription out of actions.py.
...
It's no longer used by anything other than test code.
2017-01-29 20:27:00 -08:00
Tim Abbott
035e442b63
actions: Remove unused set_stream_color method.
2017-01-29 20:27:00 -08:00
Tim Abbott
a3f3f5b7bc
remove_default_stream: use access_stream_by_name.
2017-01-29 20:27:00 -08:00
Tim Abbott
19eaa92059
add_default_stream: use access_stream_by_name.
2017-01-29 20:27:00 -08:00
Tim Abbott
de3f539f58
do_change_stream_description: Accept a stream as argument.
2017-01-29 20:27:00 -08:00
Tim Abbott
2dc90e8ebd
rename_stream: Pass a stream object to do_rename_stream.
2017-01-29 20:27:00 -08:00
Tim Abbott
7be34357b2
rename_stream: Move stream name taken check to view.
2017-01-29 20:27:00 -08:00
Tim Abbott
ccdf17f47e
rename_stream: Move stream already has name check to view.
2017-01-29 20:27:00 -08:00
Tim Abbott
d059a0a90a
rename_stream: Move check_stream_name into view.
2017-01-29 20:26:59 -08:00
Tim Abbott
ab1e9f2b97
rename_stream: Move stripping of whitespace to view.
2017-01-29 20:26:59 -08:00
Tim Abbott
4ad1fadab0
streams: Create and use do_change_stream_invite_only.
2017-01-29 20:26:59 -08:00
Tim Abbott
c74ddb74e9
do_make_stream_private: Accept a stream object, not a name.
2017-01-29 20:26:59 -08:00
Tim Abbott
0a75480444
do_make_stream_public: Accept a stream object, not a name.
2017-01-29 20:26:59 -08:00
Tim Abbott
54bcc675f7
subscribe_to_stream: Return the stream object.
...
This simplifies some code paths a bit.
2017-01-29 20:26:59 -08:00
Tim Abbott
3f83ea3879
lint: Ban use of get_stream in most views files.
2017-01-29 20:26:59 -08:00
Tim Abbott
e137787d1a
users: Use access_stream_by_name to access streams.
...
This simplifies the code somewhat and adds greater consistency of
error messages.
2017-01-29 20:26:59 -08:00
Tim Abbott
ea72b97cd9
home: Cleanup narrow_topic logic.
2017-01-29 20:26:59 -08:00
Tim Abbott
a7cb7dd695
home: Use access_stream_by_name to access streams.
2017-01-29 20:26:59 -08:00
Tim Abbott
6c512bdfd3
json_invite_users: Use access_stream_by_name.
2017-01-29 20:26:59 -08:00
Tim Abbott
bc2f23383e
streams: Move list_to_streams to lib.
2017-01-29 20:26:59 -08:00
Tim Abbott
02f5ef1d23
streams: Move filter_stream_authorization to lib.
2017-01-29 20:26:59 -08:00
Tim Abbott
de68dd2860
lint: Ban use of Stream.objects.* in zerver/views.
2017-01-29 20:26:59 -08:00
Tim Abbott
bb86bba20d
stream_exists_backend: Use access_stream_by_name.
2017-01-29 20:26:59 -08:00
Tim Abbott
eeeffa8704
urls: Review useless stream_exists_backend endpoints.
...
The actual function was overcomplicated and was designed to check
whether a stream existed by name, not by ID, so there was no value in
having it be used for checking if a stream existed by ID.
2017-01-29 20:26:59 -08:00