When hover over a typeahead menu item, the semantics have always been
to make it active, and now we also respect the naturalSearch option
there, which will set the text of the search box to the suggestion
immediately upon hover.
(imported from commit 02318d3d830e7e28d638efee0ef27023a73f52f7)
See https://github.com/twitter/bootstrap/issues/7392. I seem to
have fixed it with just the CSS part of their suggested patch.
To repro the bug prior to this fix, enter search, hover over a
typeahead, and then hit the up arrow key. You'll see two items
appear to be selected.
(imported from commit 383d60a606d7c19344a326208312a1555d060877)
The naturalSearch option immediately updates the search box with
the underlying value of a search suggestion when the user moves to
it.
(imported from commit ad5cb5c2591ef4f71a6d648c8839f288cc125cf7)
It allows us to provide suggestions when the user types '' in
a searchbox (e.g. by hitting delete when text is selected).
(imported from commit dc27ef86db2b6ec40039e4e9668b8ccc288c6134)
If you have smartSpaceBar turned on and hit space, the code
now calls lookup(), so that the app code can reload new
suggestions.
(imported from commit 6776babba0a2c9b8a954a4640aa7b81a970ed88e)
If you set the option, then hitting space will select the current
suggestion and allow you to keep typing. If you don't set it,
then it's the old behavior where space allows you to continue
typing without acknowledging your selection.
(imported from commit 8125a322e5a748ac7716361d66fca18c56d5766e)
On the next line, it checks and returns immediately if the source returns
false, but it should first hide the existing box or else it's just left
there until the next typeahead refresh.
This fixes the issue with the typeahead not closing properly when a space
is typed that was introduced in 7aa3f762.
(imported from commit cbe77e2152d889fe53d874e97f41cfc725166929)
Based on https://github.com/twitter/bootstrap/issues/6579. Doesn't
look like upstream is going to fix that or its 6 duplicates any
time soon.
(imported from commit b3e887d929cc42124aeb1f13abd7503f38f92a1f)
This is the patch described here:
https://github.com/twitter/bootstrap/issues/271592189b87ad
That commit has not been upstreamed to bootstrap due to bureaucracy issues.
(imported from commit 3c4a109b58f403569a41f5048ab347a800f029c2)
We now don't use these at all, and they are likely to confuse us later e.g.
when modifying third-party files.
(imported from commit 2034949111466b22b1830ec087f30fa34445fcbd)
We will provide our own copyright and license comments in the files
that need them
Also remove the byte-order mark from spectrum.css. It would appear in the
middle of the file, and there's no need in UTF-8 anyway.
(imported from commit dc32113e88bc6533f37f3378ffeac26f2050d0e7)
Prior to this commit, at <979px, the .container in a .navbar has
`width: auto`, but a normal .container has width 724px, which causes
the two to drift out of sync.
This fixes that.
(Arguably, it's weird for us to waste ~200px scrunching
this down to 724px at this ratio, but we can solve that
as a separate issue later.)
(imported from commit 1f431ca1e2168db75821ea0be43941d29fd3e6b8)
We always want the navbar to stick at the top, no matter what
the screen size, and we want it to consistently look the same
height, etc. regardless of our page width.
This is possibly also accomplished via position: absolute !important
and other overrides in our own CSS, but this actually seems
slightly cleaner in a way.
(imported from commit 340fafb49bcbc1088a816897d320e252c4615d19)
Some time between the 2.0.4 and the 2.1.0 upgrade, Bootstrap broke in
a way such that clicking on a dropdown did not cause it to close.
Here's the bug thread about it:
https://github.com/twitter/bootstrap/issues/4497
I've implemented this workaround discussed there, though the bug is
fixed in 2.1.1, so when we upgrade this will go away (which is why I
only reluctantly tag it 'third', since the diff will not need to be
carried forward.)
(imported from commit f8d9cf65b33306a426d864c9b503bb3446614111)
...from 1200 to 1180 pixels.
The monitor I use for Humbug is exactly 1200px wide. With the scrollbar I come
in just under the original Bootstrap threshold, so I get a scrunched-up nav
sidebar next to a bunch of empty space.
It's annoying to do this in our own CSS because we basically have to duplicate
the whole @media block to make everything fit together.
I don't love editing third-party files like this, but if it gets reverted by a
later update, the consequences are minimal. If we have important hacks like
this (or just a lot of them), we should decide on a better way to manage them.
For now I have just tagged the commit subject with "[third]".
(imported from commit ef3022b7eb0fdfc8862083bdbb1fb805fbeba2c7)
Steve Howell
Kevin Mehall
Leo Franchi
Keegan McAllister
Zev Benjamin
Waseem Daher
Jeff Arnold
Luke Faraone