a9235a74f4
Split the group merging logic form the DOM update logic
...
The goal is to have a more data centric piece that can be unit tested.
We also try to minimise the number of one off jQuery DOM updates and
rerender handlebars fragments instead. This will prevent the
message_group and DOM from drifting apart and not being able to rerender
correctly.
(imported from commit 03f09803f2bc0c3b8187f76f2cfe90be9f7512a3)
2014-03-14 20:48:59 -04:00
4f6ee6744d
Split out group creation from rendering
...
To make the rendering process a bit simpler to read this commit is
refactoring the message group creation into its own function.
(imported from commit b53ce96ed8fee3064d7cf891fc248d0c3d821d1a)
2014-03-14 20:48:59 -04:00
16faed0a83
Create copy_and_paste.js (with code from ui.js).
...
(imported from commit 37a06af5489e7da5196e5710f384d1f5a7ee7578)
2014-03-14 20:48:59 -04:00
fa440d0be2
Only empty the message list DOM on reload
...
We are seeing error on CUSTOMER4 when clearing the DOM on reload. So
now we will only clear the message list.
(imported from commit f5d8d7d36cd1018f7def73ff9eda414387fcec5c)
2014-03-14 20:48:58 -04:00
c5993c2d2d
Create gear_menu.js (with code from ui.js).
...
(imported from commit fc4d058d49d5d4aaaa20ef6237ea3e927eac03e3)
2014-03-14 20:48:58 -04:00
405c3d7626
Created floating_recipient_bar.js (with code from ui.js).
...
(imported from commit 2b6631938b0fc8e39c14aacd92f9f1670b68b199)
2014-03-14 20:48:58 -04:00
f8b71fa497
Created condense.js (with code taken from ui.js).
...
(imported from commit 72b27b48614a7c396170d46936646e52757e2743)
2014-03-14 20:48:58 -04:00
af3411cab8
Handle removing the selected local message from the message list
...
(imported from commit 185fc33cc19699ebe61ce9d65262383e39289cf3)
2014-03-14 20:48:57 -04:00
9162ef3e0f
Fix wrong logic in handling local-only message edit saves
...
(imported from commit a9074fbfb75884c3280807ddeba576c0fbe313b7)
2014-03-14 20:48:57 -04:00
bba2eb7622
Send missedmessage notifications as soon as you're idle or offline
...
Previously, you'd have to be offline to recieve missedmessage
notifications, or maybe idle for an hour. However, I'm pretty sure the
latter code didn't actually work, so we scrap that and just nofity you
via email or push as soon as you're idle.
Closes trac #2350
(imported from commit 899966e0514db575b9640a96865639201824b579)
2014-03-14 20:48:57 -04:00
84b59d4335
Created scroll_bar.js (with code taken from ui.js).
...
(imported from commit 0c4e8538031ceb1a0f50eea9a34e315e23e7d9ff)
2014-03-14 20:48:56 -04:00
be2a1c2893
Move resizing code to resize.js.
...
(imported from commit b6df0007307872751e1a4200af740076e08b5c11)
2014-03-14 20:48:55 -04:00
f760567b96
Fix topic edits that are initiated from the FRB.
...
Grab the id of the selected row, whether it's a message, recipient bar, or FRB
(imported from commit 93b9c282d4220ba9bb271733ded4d90d5c051c75)
2014-03-14 20:48:55 -04:00
7fce920522
Move favicon-related functions to favicon.js
...
util.reset_favicon -> favicon.reset
util.set_favicon -> favicon.set
(imported from commit 250848ec5dc7ac58649197c8cc4b7b4e7b19f25c)
2014-03-14 20:48:55 -04:00
d52e5e551d
Remove {show,destroy}_first_run_message.
...
We essentially inlined the methods in the three places they
were called.
(imported from commit 622ee718d6dd226187f1e37ff754ee2fa635e6f2)
2014-03-14 20:48:54 -04:00
b12b44579c
Set up $.fn.expectOne in setup.js
...
(imported from commit 77922cf8f506d4eb811498d418215eabf74b76ae)
2014-03-14 20:48:53 -04:00
3889edd824
Move xhr_error_message() into channel.js
...
(imported from commit c68c2d475b5673a3dd5f68c75624dfcfe56728ca)
2014-03-14 20:48:53 -04:00
0e129614cf
Remove unused util.recipient_key() function.
...
(imported from commit cee6a58344971ee1439e6b66ec301f1bd0f80502)
2014-03-14 20:48:53 -04:00
50bc5401a4
Moved loading_indicator functions to loading.js.
...
util.make_loading_indicator -> loading.make_indicator
util.destroy_loading_indicator -> loading.destroy_indicator
(imported from commit 8a171622a6096476dd040912d3f1460d53159f20)
2014-03-14 20:48:52 -04:00
a1538b4bab
Eliminate gap at bottom of portico pages.
...
(imported from commit 0e1d9bde16267f9b6533f256c28374ed98566578)
2014-03-14 20:48:52 -04:00
c09b6914ba
Use new background image for /hello.
...
(imported from commit 06174760ee28a4c6b323f5c7e66cb20a50709d2a)
2014-03-14 20:48:52 -04:00
86ff8cdd8c
Add San Francisco image to repository.
...
This is a public domain work.
Source: http://www.flickr.com/photos/allenr/13127238845/in/photostream/
(imported from commit 90f7e79131302a9da2323125ca27f78d5ac79a78)
2014-03-14 20:48:52 -04:00
9cefe46a1f
Change /features icon color to match header.
...
(imported from commit d9cabd13acd8981a5bef93011ae4ea0c45cb451b)
2014-03-14 20:48:51 -04:00
202ac0fe10
Restyle /hello to be more consistent with current app style.
...
(imported from commit 7e1df8cb885908f40569692283e98ac851ca3d2e)
2014-03-14 20:48:51 -04:00
4eded59dbe
Revert "signup: point to /register at the top too."
...
This reverts commit 517df29d10182c05780017c15225c9f95b844225.
(imported from commit 7820bb2dad7010579342450040d0f5c72ad2c627)
2014-03-14 20:48:51 -04:00
c832543168
Remove very confusing dom_id message attribute
...
(imported from commit c7e3e50bf8827f6f087d7df28ec7b7c173a3c041)
2014-03-14 20:48:51 -04:00
ef81999f3f
Make sure to store raw DOM elements, not jQuery objects, in _rows
...
(imported from commit ccf85bfd514b5b143c1021d4a186f1448abc700d)
2014-03-14 20:48:50 -04:00
163d93c15b
Move timestamp up when sender is included
...
(imported from commit a347b397a41028f3ca9642ad1edd704e3255245a)
2014-03-14 20:48:50 -04:00
6d2c6f269d
Make sure to use the proper dom_id in the proper places
...
(imported from commit c4852f972d4fe8b2732c87dcc499f91f837e912c)
2014-03-14 20:48:50 -04:00
8f7542f34d
Use elem.html() instead of elem.replaceWith() when swapping in new rendered messages
...
(imported from commit 82664bf2eb20faa8e98b7912b4c26174046d2dd6)
2014-03-14 20:48:50 -04:00
8b1f0223fe
Update the dom_id of message objects when their id changes
...
(imported from commit e766eff7d966d95616ac192c8cb0cb328bd96b1b)
2014-03-14 20:48:50 -04:00
7f3ea34dc5
Make sure to re-select selected after re-ordering
...
(imported from commit 50878874372d1304014f5285b488db6ab896abbd)
2014-03-14 20:48:49 -04:00
26690adc47
Save the correct-from-dom rerendered message in _rows when rerendering
...
(imported from commit c021beef3106148a6d085ca16f34a1c4bb4fc7af)
2014-03-14 20:48:49 -04:00
e7c8c322c0
Handle case where _lower_bound returns size of input list
...
(imported from commit bd91512615b11935eafd5809ca414eeb0cf189c4)
2014-03-14 20:48:49 -04:00
6ec72a290d
Simplify condition for aborting people.reify().
...
Since it's basically impossible to add a person with an
undefined full_name--even "skeleton" people--there is no
need to check the full_name field to short circuit reify(),
because it will always be defined.
(imported from commit 3a30cfd583a040f7460739abea1604594c450ffe)
2014-03-14 20:48:47 -04:00
065fcf1a1b
Handle out-of-order local ids in message_list
...
(imported from commit e805837d7d2790be90490cc9ec9415882ff9b549)
2014-03-14 20:48:47 -04:00
7cd814d92c
Keep track of local ids in our message list
...
(imported from commit d96eaa14bf9f4b315d6893e6cd6c8d3c069c1d14)
2014-03-14 20:48:46 -04:00
86d310a984
Pass index of element to util.lower_bound matching function
...
(imported from commit eb8ba76b4855355bc23d6419cbb0f3a4aad8b6de)
2014-03-14 20:48:46 -04:00
0d0c427f2b
Remove unused bot_data.get_all()
...
(imported from commit 70ec624667dacede72c00f1bb207d8d18dfdd4c1)
2014-03-14 20:48:45 -04:00
080f7229fc
Make status messages larger
...
(imported from commit 0545d9d074b828c54fbb9156cd8e647c896e2b17)
2014-03-14 20:48:45 -04:00
f1db96143a
Stick 'Edited' tag to the top and darken timestamp further
...
(imported from commit 682b72001cd317b2236cab23e9392c9e4452784d)
2014-03-14 20:48:45 -04:00
9a5289b96c
Change compose box only for going-forward topic changes.
...
(imported from commit 69de10fd9866acab2d12f15489c67eb9daab8d3d)
2014-03-12 21:15:22 -04:00
b8de1dd13f
Change narrows automatically on topic changes.
...
(imported from commit 7a8e606cc6fe0f2e4b5a164e1396e302ad969102)
2014-03-12 21:15:22 -04:00
45002aa03f
Close message edit before doing topic-related changes.
...
Closing the edit box earlier will make future changes less brittle,
when we, for example, re-narrow based on topic edits.
(imported from commit 36219c5129153beebfefe443932825fdf74abc43)
2014-03-12 21:15:22 -04:00
d4fa917c49
Add has_topic() helper to filter.js
...
(imported from commit 8d8d9c2b6638968b18c7603e070c001d6b16cf21)
2014-03-12 21:15:22 -04:00
0376d26c79
Add filter_with_new_topic() method.
...
(imported from commit 2ed9261ec70edf0a4ee1a25989cabfa9ab7907fd)
2014-03-12 21:15:22 -04:00
65e9d0bead
Change compose box for topic changes only if streams match.
...
(imported from commit 0bd6cd53ea4a8db5a457bb7dd5917f25c7c9434a)
2014-03-12 21:15:21 -04:00
63097f32e5
Let arrow keys do the right thing for select widgets.
...
This helps the edit form in particular, when you change a
topic and need to select the propagation option.
(imported from commit c9dd1e62cd9e0b2142855685f04baa06eecf7226)
2014-03-12 21:15:21 -04:00
ff44fb6fcf
For topic changes, set the compose subject outside the loop.
...
If we get a topic change, we can change the subject outside the
loop, since we are passed in event.orig_subject. Doing it inside
the loop was mostly harmless, since after you encountered the first
message with the old topic, the condition to change the subject
evaluated to false, but it was still technically O(N), and it was
kind of confusing.
This commit changes behavior in the edge case that you have the
compose box open for a changing subject, but you are in a narrow
that does not have any of the affected messages. After this commit,
the topic in the compose box will still change, which I believe
is the correct behavior.
(imported from commit 2363e432ebe7ae8e07379324ee0bfb52051428e6)
2014-03-12 21:15:20 -04:00
dfc34eb074
Allow negated has:* searches.
...
Before this change, we were incorrectly trying to do local
filtering on negated has searches.
(imported from commit d1a6f1feef6b3cc1c984eb91a73cd16c4e66874e)
2014-03-12 21:15:20 -04:00
d6617a991c
Remove mobile device indicator from template
...
(imported from commit 48a10a75b30c3f51a6dfa5af43ca138e391289d4)
2014-03-12 21:15:19 -04:00
fcca1549b0
Darken the timestamps
...
(imported from commit c8934a422d8d770634015210fde80eced34aba64)
2014-03-11 13:26:32 -06:00
8b3b33c182
Reword error page; link to Twitter.
...
We use this error page for all 5xx errors, so I'm removing the error
number from the text.
(imported from commit c0c4c8829d466dd20c76dbbc920fc57cafbd6e6c)
2014-03-11 15:16:19 -04:00
40164f4398
Move mobile indicator to the right and style it properly
...
(imported from commit 19f6bd27b30c355c1720d43580f5b6ff6c1c0b4a)
2014-03-11 13:06:23 -04:00
fd7dd0bc2c
Use correct presence names for iOS mobile devices
...
(imported from commit d75f56c26d272342e2b4d074ea90a6d7fb9cff4e)
2014-03-11 13:06:23 -04:00
bd20a756f9
Show a mobile icon in the presence list when relevant
...
We show a user as "on mobile" if:
* They are only active on mobile
* They are inactive on all devices and can receive push notifications
(imported from commit 0510b9371727cd19c72f6990df7112921c36ad48)
2014-03-11 13:06:23 -04:00
4397c25976
Wrap 'Receive audible notifications'.
...
This resolves Trac #2366 .
(imported from commit 0de4b20e0310980181716f7a29a82a4228a16b1b)
2014-03-11 13:06:23 -04:00
bdee9721ec
tests: Delay loading old messages and starting get_updates until phantomjs thinks the page has loaded
...
This doesn't affect code when not in testing. It shaves 7 seconds off of casper
test time on my machine.
(imported from commit 7e27fa781bcf16f36d9c8f058427ba57c41068bd)
2014-03-11 13:06:22 -04:00
f45f0b1df6
Get message row safely in the presence of local ids
...
(imported from commit 4f8c4742206a9fcba4eb19653152aeb4919159bd)
2014-03-11 13:06:22 -04:00
d3f14ae860
message_flags.js: Add comment
...
(imported from commit 6660076a04f765f67ade35664bd09678691d37c3)
2014-03-11 13:06:21 -04:00
9d04b3d643
Don't tightly recurse when updating flags for local messages
...
(imported from commit a4a9f5278c9445fae753311ea16f165be15ff8eb)
2014-03-11 13:06:21 -04:00
6071a11419
tests: Defer sockjs object creation when in testing
...
This speeds up CasperJS tests by 25 seconds per main app page load.
When we switched the SockJS, the casper tests got inexplicably slower. I
finially figured out what's going on. The first SockJS XHR request (remember
that we don't get websockets in the test suite) gets considered part of the page
load and therefore the PhantomJS onLoadFinished handler doesn't get called until
the SockJS XHR finishes, which happens at the heartbeat, 25 seconds later. To
fix this, we simply don't create the SockJS object on page load since it will be
created on demand, anyway.
(imported from commit 845a97526c5102df426cd6fc26182a734e7fcab6)
2014-03-11 13:06:20 -04:00
1c7918495c
socket: Factor out SockJS object creation
...
(imported from commit cedb2b3e6ade0b045e8d4982437f6499ae904222)
2014-03-11 13:06:20 -04:00
72c9deb59e
Handle errors better when rendering messages.
...
Catch any exceptions that happen in the process of triggering
the message_rendered.zulip event. This addresses #2356 .
(imported from commit ce771483cd2533d312fbd68e9c2753c80b3c8d49)
2014-03-11 13:06:19 -04:00
43d866dd71
fixup copy and paste logic
...
Our restructuring of the messages (especially grouping) seems to be the culprit for message copy and paste
(imported from commit 14632a67f55efea4f1b53cc718a4f655ac83b387)
2014-03-11 13:06:19 -04:00
c23028ec7a
Move timestamps to the right
...
(imported from commit 1fb3e726b32065755cf1ff28e1371bc75609450e)
2014-03-11 13:06:19 -04:00
e993b8fc40
Replace "/me" with sender's name in notifications.
...
This fixes #2358 .
(imported from commit 579f217687bd2af80ab6919a72435336ab456410)
2014-03-11 13:06:18 -04:00
3d7c3a6de3
Bring the Github integration setup page up to date
...
We're no longer called 'Humbug', and we have more configuration options.
(imported from commit 56c1c4a25e601def35de102fba86960444ddf513)
2014-03-11 13:06:18 -04:00
bc9a9db9b3
Select message if you click on its pencil icon.
...
This addresses #2351 . While I could see the argument for
wanting to edit a message without changing your selection,
I think it's just very surprising behavior and inconsistent
with the rest of the UI.
(imported from commit 3bb4faca0656258b76bfaafbd7f4a645810578f6)
2014-03-11 13:06:18 -04:00
af16f6730e
Remove border on message body gravatar.
...
(imported from commit e642facf6dccfafc35632aa6ad5e4e60ad79bf24)
2014-03-11 13:06:17 -04:00
9d8758557b
Use global match in alert word regex to match all matches
...
(imported from commit aaec296ad6b18b20c1c2d1cb017cffef8e3e0512)
2014-03-11 13:06:16 -04:00
65b6c80f07
Don't highlight alert words that are in URLs, breaking them
...
(imported from commit e20ee33a1687f935482f48f829c19a1606ce6db1)
2014-03-11 13:06:16 -04:00
246a5737e7
Use a message's position not offset() to detect if it's off the bottom of the page
...
(imported from commit f7915c567b54ad5fd82daf137f89db566a1b417b)
2014-03-11 13:06:15 -04:00
3a8b663eb1
Square off bot avatar.
...
(imported from commit 628816b490732e03cca77d721614979ba25da2f3)
2014-03-06 21:59:55 -05:00
b5ec6c9958
Delete unused .profile_picture CSS class.
...
grepping for it turns up nothing relevant.
(imported from commit c7bb97515c993c0d5ed6de7e4ac9edc99ff83ff2)
2014-03-06 21:59:55 -05:00
c359499386
Square off avatars in commit messages.
...
(imported from commit 8c2c505e6b84b50b4498f51bbf170e4dea3af39a)
2014-03-06 21:59:54 -05:00
b80af20541
Larger emoji.
...
(imported from commit 3fb9a5df7fde4cd073f344d9aed5cb16c1b0de71)
2014-03-06 21:59:54 -05:00
96f6939284
Fix a few more unstyled 'cancel' buttons.
...
(imported from commit 1d8145fe1576af62b73be0badad9de1b75da816a)
2014-03-06 21:59:53 -05:00
fb00ee79a0
Fix unstyled button on Settings stream notification propagation.
...
(imported from commit ebc046e8d0f29a6bbf64005c70f32522a366fa6b)
2014-03-06 12:45:06 -05:00
8f37c3f5fd
Tolerate spaces after language in markdown fences.
...
See #2357 . We now support `~~~ .py ` with that trailing space.
Note that the test coverage is Python-side only due to
bugdown_matches_marked being set to false, since we don't yet
support language syntax on the client side.
(imported from commit ccd5fcb0eee01478d349161400103480678d7486)
2014-03-06 10:15:20 -05:00
91fb286b0d
Properly style integration-edit buttons.
...
(imported from commit dbbe831bbc86b24ba37fa9cb06dfdba32a1e8867)
2014-03-05 17:43:00 -05:00
ae326c066f
Properly style 'Cancel' button in edit dialog.
...
(imported from commit 8c63567f7f696175b7293fabe26fea2d9c60a15a)
2014-03-05 17:33:01 -05:00
a9f01e382a
Switch streams page over to use consistent buttons.
...
(imported from commit c4d7f658f361a759a38951349e027ac3e279fe9b)
2014-03-05 17:23:23 -05:00
66ecc7a6f2
Slightly tidy up realm name change 'Save' button on admin page.
...
This commit got lost in an earlier rebase.
(imported from commit 36bfad56fc08f443c3721c880cb4dd3427fd0541)
2014-03-05 16:43:10 -05:00
2429ed6eeb
Remove old Bootstrap2 button code.
...
(imported from commit 1483c549a3d41802755fea4db7229324e1595b42)
2014-03-05 16:24:55 -05:00
095c82ecc4
Actually switch to Bootstrap3-esque buttons.
...
(imported from commit ddcecb8c5a63324a666ffe170e2d5a76171776c9)
2014-03-05 16:24:54 -05:00
82dfc7b109
Remove border-radius from Bootstrap3-esque buttons.
...
(imported from commit 1c86fb21ab39f8e489481aa0e3f82dc4247364b3)
2014-03-05 16:24:54 -05:00
23155bbbae
Rename some class names for Bootstrap2 compatibility.
...
(imported from commit 6a9b9a9e431902640651cad0a02b848bd2717fbc)
2014-03-05 16:24:54 -05:00
a983a62ad2
[third] Import button CSS from Bootstrap 3.1.1
...
(imported from commit 07fea19901d31339d9cb7481f00a6d244b09bdb4)
2014-03-05 16:24:54 -05:00
6ef234ba80
Slightly tidy up realm name change 'Save' button on admin page.
...
(imported from commit dfa8d4a08d1e2f505f4edf8b0ef5314da47292a1)
2014-03-05 16:24:54 -05:00
b343d322fe
Fix errant scrollbar in stream list
...
(imported from commit 7a70bad72adb5d57ea11e926f48301d2a9cc7fd0)
2014-03-05 14:14:27 -07:00
957486cc95
Fix support for searches like "in:home search:foo".
...
Previously, if you searched for "in:home search:foo", we
weren't making "in:home" a public operator, so the back end
wouldn't know to exclude muted messages, but the front end
also wouldn't exclude muted messages, because it assumed
that queries with "search:" in them were fully narrowed by
the back end.
Prior commits made it so that the back end is now capable
of doing "in:home" narrowing, so to get the properly narrowed
results, we simply needed to make in:home be a public operator
in this commit. We also made in:all be public for convenience,
although it's essentially a no-op.
(imported from commit e4a8b10813b50163c431b1721bd316b676be1b83)
2014-03-05 14:56:35 -05:00
aa9c98ef10
Make the selectable sidebar block width the same width as the overall sidebar
...
(imported from commit 078765c03dbc015b22b3cbb12df692573f6b33cd)
2014-03-05 14:48:54 -05:00
30f89f4669
Convert the bot section of the settings page to use bot_data
...
(imported from commit 63e6982f96ac46d1cebd2ea16d2a7abc7f8d6597)
2014-03-05 14:16:20 -05:00
fa37e91e5c
Add admin status to bot_data
...
(imported from commit 47b84b3ef1e97e355dee84f0595e94a4612bf4df)
2014-03-05 14:16:20 -05:00
3f6e53db6e
Add bot_data module that updated with events
...
(imported from commit b0bd714258132fc81db763d316a15f5a81b1f4ff)
2014-03-05 14:16:20 -05:00
494868d21d
Group bot stream options lists by public/private
...
(imported from commit 940319a25edfd1943d78ff95542ffda6f482a40b)
2014-03-05 14:16:19 -05:00
f82cbe855f
Support editing a bot's default streams
...
(imported from commit 72ceb5152745ddfcc22dfd929904927950bf46e4)
2014-03-05 14:16:19 -05:00
eebbf0d4ee
Show the new bot's default stream settings in the edit view
...
(imported from commit d6f1872e0dedd57ebde31da2caf075804195dfb0)
2014-03-05 14:16:19 -05:00
eb1032c9c2
Add UI to set "all public" default to during bot creation
...
(imported from commit ec03ccdce309c9fbe866343368044b00ea0f5b81)
2014-03-05 14:16:19 -05:00
17b579911e
Add UI to set listen on stream during bot creation
...
(imported from commit b481a55c16f853766c82883b4c6c86de5c87759e)
2014-03-05 14:16:18 -05:00
538d76e6ed
Add UI to create bots with a default send to stream
...
(imported from commit 1333de89a75bd972ec85be7f11f6ea11d4fa34cd)
2014-03-05 14:16:18 -05:00
54ae946061
Squarify swatches on streams page.
...
(imported from commit 06d630d90acf4bc40e86c34cb85b7eaca92a7263)
2014-03-05 14:05:40 -05:00
8efe4c0a1b
Support has:attachment/has:image/has:link searches.
...
This commit finishes up support for has:* searches by adding
the front-end pieces, specifically the part that "has" operators
will not be applied locally. It also implements basic
descriptions for search suggestions and canonicalization
of operands from plural to singular.
(imported from commit a3285bc33d06d76b5a2b403ebcdd911b4cc03980)
2014-03-05 13:58:53 -05:00
1b9752e10e
[notify] Turn on negated search for all realms.
...
This fixes #730 , which includes any customers we want to notify
about the feature being pushed.
(imported from commit c60959ddd7c61ea8e014e984047e9f7bc0d59296)
2014-03-05 10:54:02 -05:00
89f10d7e7a
Handle negated person-related operators in search suggestions.
...
(imported from commit e045a0910ff59d9b8569c5ba3b3b644fe2d7dad7)
2014-03-05 10:54:02 -05:00
e5e0ba9e7c
Handle negated topics in search suggestions.
...
Typing "stream:foo -topic:b" leads to "stream:foo -topic:bar" properly
as a suggestion now.
(imported from commit bb0acf52744f7b13977a3db5d3c130d1402b09b7)
2014-03-05 10:54:02 -05:00
5f7df38b8a
Unbreak custom alert words on the settings page.
...
This doesn't change the alerting UI logic, it just turns
alert_words_ui into a module and calls the setup code from settings.js
when the settings page is rendered.
(imported from commit 05f95383b046086641280f82f648be58688efe61)
2014-03-04 18:06:48 -05:00
f445202ba5
Change the topic in the compose box after a topic rename
...
This helps reduce "double-mixing", closes #2338 , and basically also
closes #2037 .
(imported from commit dadb70ae85d572d642bba4ac6c3b30f31f104ce0)
2014-03-04 18:06:09 -05:00
a4a47db9e0
Error out gracefully if edited message is muted
...
(imported from commit 1aefd61d5633ed67a919cccd2d8c68f7ba8e7bfc)
2014-03-04 17:19:59 -05:00
55fef4d60e
Enable cleanup_before_reload for CUSTOMER4
...
(imported from commit dd81a22a64e8a1098bf3a6b875919a2a25499bb8)
2014-03-04 17:07:05 -05:00
09dfc9a89b
Split selecting a message and hiding the empty narrow message
...
We should hide the empty narrow message message whenever the narrow is
not empty, but we should only select a message if non are currently
selected.
(imported from commit 22f6b0827dc84ed587a83b5d713b12c1d5d4c0a0)
2014-03-04 16:43:00 -05:00
12c04151e9
Prevent click on user filter from collapsing popped-out user list
...
(imported from commit 182d82f41218e12faeaf07cd92cbee88a9fa6624)
2014-03-04 11:11:31 -05:00
60d4c620b9
Disable left-side-userlist on staging, as only CUSTOMER7 uses it
...
(imported from commit 62d9e908cdb3132e22a58efcceee1d06a68d71bb)
2014-03-04 11:11:31 -05:00
16df239f39
Use the first unread from server on reload
...
When reloading the page we want to narrow to the location that is
restored from the query parameters. This is only done if we ask narrow
to use the first unread message from the server.
(imported from commit b585ef51cbb85788b24d90d831b42c45fd188569)
2014-03-03 18:17:15 -05:00
c753dfc9a8
Move reload initiation to an explicit initialize function
...
The reload initiation is required to run before other parts of the site
are started so that page_params will be setup correctly. This moves that
initiation out of an on ready handler to an explicit initialize call
near where the rest of the app is started.
(imported from commit b8994311299327aa3cfa57e3d9e92124a47123f4)
2014-03-03 18:17:15 -05:00
f2e8929b8a
Hide rerender_message and use rerender_messages() in all cases.
...
rerender_messages() does extra work such as making rerendering in narrows
safe, as well as updating recipient bars. That should be the only valid entry
point for rerendering individual messages
(imported from commit f91aeb2070b1056ab95e01d68a342558c2813ae8)
2014-03-04 10:47:44 -05:00
ca031304b9
When rerendering single messages, grab messages from the view's own list
...
(imported from commit 5b3b5cefd65952b81406adcbd6208551228f0c5d)
2014-03-04 10:38:12 -05:00
1af7a9db1f
Reify skeleton person objects that local echo creates when sending out-of-realm PMs
...
(imported from commit c0fcdba736f1270d8c05d00546444ee539301877)
2014-03-04 10:09:40 -05:00
bdaf8b2cfe
Update message group recipient bars when rerendering messages individually
...
(imported from commit 3fb1386fee12c3a4a3f46810368cdd5d8cfb04d8)
2014-03-04 10:09:40 -05:00
6f67d94fc4
Split the recipient row of a message group into a partial
...
(imported from commit 660514daf932235b7c47ac4c22f963da17c7fc8b)
2014-03-04 10:09:40 -05:00
df7f85d3c3
Don't show in-app notifications if stream desktop notifications are disabled.
...
(imported from commit efa29afaa40b65557149ea8a2cbc60e1bc44bee2)
2014-03-03 17:22:17 -05:00
2761f1338d
Fix stream color changes
...
(imported from commit 37c0a2a5fba10404d9c51d1e4cdce7f45e18f54b)
2014-03-03 14:46:38 -07:00
fae92685ae
Convert /json/subscriptions/property to supporting bulk property updates.
...
This includes removing GET support for the endpoint, which is unused
and doesn't map well to this being a bulk endpoint.
(imported from commit 348ff9dfa84be1661368c6d7d35aebf2ae2a9ae0)
2014-03-03 16:08:33 -05:00
66edc784f9
Generate and handle client-side events for global notification changes.
...
(imported from commit 40056e8ae284da27db0215e7d8320c8f7db2c52b)
2014-03-03 16:08:33 -05:00
87635b9e32
Convert settings from static HTML to a template.
...
This will make life much easier for handling update events.
(imported from commit 66b101eb5fae89b4eec6fc797fee8be26ac99bfb)
2014-03-03 16:08:32 -05:00
c96ceeaea4
Add a handlebars helper for variadic compound OR conditions.
...
(imported from commit 9f08e998f9f699c05ccf3f5948fe3361a3834ba1)
2014-03-03 16:08:32 -05:00
88c8472a31
Clarify the cases in which you receive notifications.
...
(imported from commit 7b41b8a1f4baedbc744a6b222fa0ff3127e7a228)
2014-03-03 16:08:32 -05:00
07bb7b2fee
Give users the option to propagate global stream changes.
...
This helps the common case of not liking our default of having audible
and desktop notifications enabled, and not making users adjust the
settings on every existing stream to fix it.
(imported from commit be75edb2c1385d1bd9a289416e2dffd8007f5e0a)
2014-03-03 16:08:32 -05:00
e0bd15669a
Don't post checkbox data directly to /json/notify_settings/change.
...
They have weird properties like not sending anything for unchecked
boxes, which makes it hard to wrap a client-agnostic API around.
(imported from commit fef73a57a55b218b55dab6be3453dd6eac73c789)
2014-03-03 16:08:32 -05:00
7829e809c7
Factor notification settings success and error callbacks into functions.
...
(imported from commit 3bce060ac6ecbad075dbdb8b9ec5514b191f0f95)
2014-03-03 16:08:31 -05:00
d89696291f
Remove Notification (?) explanation popover.
...
(imported from commit f261f87c9571a76b8b0e2538ccb3bb4826ef449e)
2014-03-03 16:08:31 -05:00
dfc462c24d
Grey out per-stream notifications when you mute the stream.
...
This helps clarify that muting trumps notifications in most cases.
(imported from commit 1a6df169219d9501b1232cc7d2c64abec6fd03ea)
2014-03-03 16:08:31 -05:00
b07f4efc13
Use new stream-level notification settings when notifying.
...
(imported from commit 8db2cf5a44ddc8a9ce285c5f0e50e049fea06573)
2014-03-03 16:08:31 -05:00
53021bf7d3
Pass per-stream notification settings between frontend and backend.
...
(imported from commit 42e9b80a4c55e0911d457991d53ce71ca31625bb)
2014-03-03 16:08:31 -05:00
c673b3b0b1
Pass global stream notification settings between frontend and backend.
...
(imported from commit 28ec021e8e5166d3b270c81c5a4ad543d2185aa5)
2014-03-03 16:08:30 -05:00
2d0b9e2aa2
Make right side chevrons visible, lighten usernames, adjust stream list scrolling speed
...
(imported from commit 8068bdf1ae7fd817fda36d7e32ea94e850ab5675)
2014-03-01 15:11:45 -07:00
7a97d01719
Fix broken viewport.message_viewport_info() calculations
...
`#tab_bar_underpadding` overlaps some with `.message_header`,
so adding `#tab_bar_underpadding.bottom + .message_header.height`
gave us a nonsense message viewport top.
Doing the calculation this way is more robust, as long as:
1) `$(".floating_recipient").offset().top` continues to give us a sensical number
and is the last element just before the top of the viewport.
2) nothing appears between the composebox and viewport.
In this commit I also removed the other couple of places where the #tab_bar_underpadding
was being used as a viewport reference, that no longer makes sense.
(imported from commit c7f35e41309900c581d5e2329c1becf161d501d3)
2014-03-01 11:52:46 -05:00
de9d26126a
Only cycle through stream elements when cycling through streams
...
(imported from commit 244d72e88e18cc49f32ecfada791f032140390f2)
2014-02-28 16:48:45 -05:00
ba0d3605ae
Fix stream list scrollbar visibility
...
(imported from commit ef1f860ecd7f3ae908a69ac7c35a45d959505966)
2014-02-28 16:27:13 -05:00
0983809e6f
Fix URLs for stream/topic narrowing links in recipient bar.
...
(imported from commit 4e104cde912521dc360df1a32ce149a5082f9a67)
2014-02-28 16:27:13 -05:00
6b200b3088
Fix broken link for "Link to this conversation".
...
(imported from commit bb07a1fe729c532cdc48eee63188b7b812fe07ff)
2014-02-28 16:27:12 -05:00
5807a44aee
Activity ping handling during a reload should not error out
...
(imported from commit 63c9f935985cdd4f3d795191aae5aa8ab8bad02b)
2014-02-28 16:27:12 -05:00
dda8bf6d8a
Don't error out if we somehow have a top message group but can't find a recipient row
...
(imported from commit 3b51f6a5e6e7998c33bf994316d5ba16e5cc0378)
2014-02-28 16:27:12 -05:00
dc15546ba3
Fix horizontal scroll on stream list
...
(imported from commit 2d28ea608c24e38b8cf58f3993976dcd67353831)
2014-02-27 23:15:55 -05:00
99036efa06
Disable keyboard scrolling in sidebar
...
(imported from commit eca509a90df175d21d85eb409c0db9c8fbb931ea)
2014-02-27 20:25:41 -05:00
a2d2438f03
Restyle pointer to make it visible at lower zoom levels
...
(imported from commit ef5f9e8878181350c823f796138fe652c9d14161)
2014-02-27 20:25:41 -05:00
8ea941e783
Fix bottom padding on stream list
...
(imported from commit 5f92b313919eadaa114da3a2fb1160f2eb3a30f5)
2014-02-27 20:25:41 -05:00
1eae686443
Add slim scrollbar to stream list
...
(imported from commit 58b64081db68fe9b1d2addcaece10167332d1a1b)
2014-02-27 20:25:41 -05:00
1788f5c576
Revert "Revert "Change out the gemoji emoji for android version""
...
This reverts commit 4d32b4ccf9a5134819a4d942699b4d97e2c0fd55.
(imported from commit 6aefec41f294ee83d19aebbfd9a99b2657e0ff83)
2014-02-27 20:25:39 -05:00
0ac73e4d73
Use a dict in presence_info rather than strings
...
This allows us to extend it to contain more details, as we will shortly.
(imported from commit 59b14592609810c5ac634a8237928ce029f33a83)
2014-02-27 20:25:38 -05:00
3fb3b564ae
Make slow fade longer for unread markers
...
(imported from commit 728e977f1f128d4e9b3f5f602538b7b2caaa9303)
2014-02-27 20:25:34 -05:00
f605a7df22
Return an empty list instead of undefined when no groups are visible
...
(imported from commit 5a02b6b94acb20948c9959e9620df7fa5f945625)
2014-02-27 20:25:34 -05:00
63bcf98e71
Fade properly via groups when toggling fade on compose
...
(imported from commit 865c9daf8a267cfa65f7daceddff55a816b9c22c)
2014-02-27 20:25:34 -05:00
9275901277
Refactor viewport.visible_messages and add a viewport.visible_groups
...
(imported from commit 2cd29c41c1fb7ffc4c88673e81e638bbaad91f5f)
2014-02-27 20:25:34 -05:00
840ba90512
Show on-hover topic edits in message list
...
(imported from commit c2cd996c5e17b801e4e10b0a28451c0fb51c5e21)
2014-02-27 20:25:34 -05:00
b51ea69db0
Handle topic edits and rerender view if topics have changed
...
(imported from commit b59f6b532138d660e0acfb949b2eb223b5c5ed0e)
2014-02-27 20:25:33 -05:00
a547043831
Fix search highlighting for message content and topics
...
Previously topics weren't being highlighted at all and messages had their
highlighting persist across different narrows (because we were only checking
whether the message object had a match_content property, not whether it should
currently be used).
(imported from commit 44c91c6d5799dcdf765e19e1a17bd727ce80c918)
2014-02-27 20:25:33 -05:00
865c57fa72
Allow our template partials to take additional named arguments
...
(imported from commit 20e7dae7b5d27ee34936d400394357fc31c8e628)
2014-02-27 20:25:32 -05:00
5aef8b8fad
Maintain scroll position when removing selected message
...
(imported from commit 1021eac527e677fbcac46d0a7d44dd3244bb903e)
2014-02-27 20:25:32 -05:00
4a58241b17
Revert "Change out the gemoji emoji for android version"
...
This reverts commit 05a7245f7b52edf4f55e40d1467022d9f06d5792.
(imported from commit e2bb0346fc2913046e977d539326510fdcab73a5)
2014-02-27 20:25:32 -05:00
240050093b
Preserve scroll when rerendering due to out-of-order messages
...
(imported from commit 9c339cbe8d5bbd75bbdf24a8f14da4f1556cc407)
2014-02-27 20:25:31 -05:00
f93ccd4df1
Enable local echo for all
...
(imported from commit 8c2e66009303b6937c7e0f1743293623e7404c3b)
2014-02-27 20:25:31 -05:00
5dfd6eee2d
Enable negated search for randomfish.org
...
(imported from commit 0a999aa18b47e1f021d7dc56f4ef5d4b0a8c8001)
2014-02-27 20:25:30 -05:00
ccfaee8412
Add left side color bar
...
(imported from commit cdba90d3a4e693838338b0a93cae38a741aa28c4)
2014-02-27 20:25:30 -05:00
efe8fe4650
Fix right sidebar offset to prevent it from overlapping the chevron
...
(imported from commit f5b979c30fa813ab5ac93382a68828415d7e0040)
2014-02-27 20:25:30 -05:00
7ebb3ec05d
Fix message for PM outside current narrow
...
This resolve Trac #2270
(imported from commit ab814e8e50f48a53054c28f07579f65040edceb8)
2014-02-27 20:25:29 -05:00
7fe74a9d2e
Add a background color property to each message
...
(imported from commit add776a0814353650903258894e0db6fc8ec67b6)
2014-02-27 20:25:29 -05:00
15f5884247
Focus textbox when editing PMs.
...
(imported from commit 152cb829779f808bf6ec65daa2cdc35da66e7e25)
2014-02-27 20:25:29 -05:00
dbb3bf6a4d
Fade by groups when rerendering
...
(imported from commit 31f472bb87eaa03bf38dddcc696e843d93e68e08)
2014-02-27 20:25:28 -05:00
0e55e54bec
Remove `last_message` class when manually splicing in new last message
...
(imported from commit d828cd56e797f3174c0a52240d673b708d894c33)
2014-02-27 20:25:28 -05:00
ffdfa203e8
Don't error out scrolling when there's nothing there
...
(imported from commit e2af794dafb93e3509c6fa5f28314ac8e21849b0)
2014-02-27 20:25:28 -05:00
3cd33c0fea
Fix unread markers and selection border
...
(imported from commit 275f4f7d95c7842bfbfd5c47509b19275bba254e)
2014-02-27 20:25:28 -05:00
1d601134ed
Don't error out if we get an edit for a message that's out of view
...
(imported from commit 042cadc8657d048d0fd3a410af5adbbaeac7d92d)
2014-02-27 20:25:27 -05:00
5d013b78eb
Show EDITED message on rerendered edited message
...
(imported from commit e06a951222597561a3e4dab7740fff00d95b2dd4)
2014-02-27 20:25:27 -05:00
cd16eb952c
Keep selected message selected when re-rendering single message
...
(imported from commit 8f034dfe9037cb513506714fd9c369e22af7f83f)
2014-02-27 20:25:27 -05:00
54e8bb872c
Use the dark color classes for recipient rows when needed
...
(imported from commit a77409964a185e6a8856e0577cc95bc78aa96e6d)
2014-02-27 20:25:27 -05:00
f9d5a02710
Fix bug that hid digest email settings box for customers.
...
(imported from commit 6c1e3f53998eca0232fbfe66c62ab87b009bccd8)
2014-02-27 20:25:26 -05:00
5ad256fee7
Fix navigating away from the page in Firefox
...
When navigating away get_events will fail after we delete the event
queue before leaving the page. In that case we try to reload the page to
correct the problem. This happens before the page navigation is
complete, and then we reload zulip keeping the user captive. This was
only observed on on Firefox.
(imported from commit e001172e87a9f2ab7cf07a477e46b9d87752ac04)
2014-02-27 20:25:26 -05:00
fe826cdf2b
Grab the message id from the FRB when narrowing
...
(imported from commit 5b33a1ef09b70bf4f244fe0305a3da3f1d027391)
2014-02-27 20:25:26 -05:00
0dbcdb94af
Set the zid of the FRB parent to be a valid row id
...
(imported from commit 31c559270a1f848e11b45f5ebeea68eaf7385ce4)
2014-02-27 20:25:25 -05:00
d9bfef4848
message_list.view is a member not a function, do not try to call it
...
(imported from commit b1d609b5633a9ab42da7123a2d31a63d7627aeec)
2014-02-27 20:25:25 -05:00
1686d27633
Tweaks and changes to adjust for new message block markup
...
(imported from commit 78210c2b98976243ee1b516bd9400a3071dd8cd9)
2014-02-27 20:25:25 -05:00
f22885223f
Remove message id list from group divs
...
(imported from commit 620a219b5e11db79bfea971fe40deb09173deb10)
2014-02-27 20:25:24 -05:00
305cf30c50
Render just one message when editing and updating
...
(imported from commit 5b28e96e9d410faf9b33a5b0a1b4423191e8de58)
2014-02-27 20:25:24 -05:00
b4e4a98de6
Split out single message template into a partial
...
(imported from commit 4670a5b5006d038ddbe94683cf2ea2c0be27f5ab)
2014-02-27 20:25:24 -05:00
568c33f294
Render messages as groups of divs instead of individual rows
...
Now that we no longer use tables for our message list, we can
more logically group messages together.
(imported from commit 9923a092f91a45fe3ef06f2f00e23e4e3fb62a37)
2014-02-27 20:25:23 -05:00
748e5b6da6
Remove disabled summarization code
...
This experiment has been disabled for everyone for a while: if we
bring something like this back, it is not likely to be exactly the same,
and will be different enough to require a different implementation.
As it is, the summarization code was making a few code paths (rendering
especially) more complex, and is worth removing for simplicity's sake.
(imported from commit 6ac8cdc9f7077a5a1da01ab4268aba3db0bc43f8)
2014-02-27 20:25:23 -05:00
f128ff6d53
Remove firefox-specific table hack, as we're no longer using tables for messages
...
(imported from commit 0d4e171c11e77e4000a8bfe7cbb8fc13e827d54d)
2014-02-27 20:25:23 -05:00
174a62eb7c
Remove requirement of no selected id to hide empty feed message
...
(imported from commit 10f4882a5f2def7e5b8567942758bb33007601d0)
2014-02-27 20:25:23 -05:00
22e6ab4028
Change out the gemoji emoji for android version
...
(imported from commit 6810746b991e597a668fca443189a16da93aa83c)
2014-02-27 20:25:22 -05:00
8075c6e5a8
Allow cycling between streams with shift+{A,D}
...
Closes trac #2273 .
(imported from commit 858ffd47aa6dbb372d426fe94b860dfe1c1cce34)
2014-02-20 13:27:43 -05:00
187796c3d4
Remove transitional defensive code in filter.js
...
(imported from commit b28877e8b187e3b019635b7b52a7d0a157466ce0)
2014-02-20 11:38:50 -05:00
5631e7e624
Remove transitional defensive code in hashchange.js
...
(imported from commit b02de9a51426339f3fdbe74fb61b89f5dd4ce8d4)
2014-02-19 16:20:29 -05:00
2dd3776bc1
Consider .user-list-filter in right sidebar calculations.
...
(imported from commit f94100ba78d5756f20729ab6d752bc48af68ea3c)
2014-02-19 15:16:37 -05:00
07140e7f11
Don't overwrite already reified people
...
(imported from commit ab82e5b6b8bedfbd39e7c36892c0b401796a5fdb)
2014-02-19 12:49:39 -05:00
2ce57fa5b9
Make sure Group PMs show in right sidebar.
...
If you have a lot more individual users in your realm than group
PMs in your recent history, we were squeezing out the Group PMS.
We now max out the ratio for any sub-section in the right sidebar,
as well as bumping up the min.
(imported from commit f7c44367f2a518d27406993cb6358cc96d1aae92)
2014-02-19 12:45:49 -05:00
8ce5404777
Describe negated search terms correctly.
...
This changes Filter.describe and Filter.operator_to_prefix
to handle negated terms correctly.
(imported from commit 673c0d3a5a77784e95772c14e12534ad2daecda2)
2014-02-19 11:05:31 -05:00
8611cc3977
Extract 'verb' variable in Filter functions.
...
Extract 'verb' in Filter.operator_to_prefix() and
Filter.describe(). This doesn't change any functionality;
it is designed to make a subsequent change have a less
noisy diff.
(imported from commit e9c4b6edc498d88ec1783ccdba079d980def9438)
2014-02-19 11:05:31 -05:00
44564274a1
Move methods from search_suggestion to filter.
...
The methods describe() and operator_to_prefix() are
now in filter.js. They seem like they eventually
may be useful outside the scope of search suggestions,
and they seem to go hand in hand with other Filter
responsibilities.
(imported from commit 55f14c3ee848febb2e7c8c6a27afd690569b4e08)
2014-02-19 11:05:30 -05:00
Jason Michalski
Steve Howell
Leo Franchi
Luke Faraone
Waseem Daher
Allen Rabinovich
Zev Benjamin
acrefoot
Jessica McKellar