80a331385e
push_notifications: Fix missing mypy annotation.
2018-05-21 11:39:58 -07:00
cec7686f3d
push notifications: Clean up unregistered/bad APNS tokens.
...
We've had this sort of logic for GCM for a long time; it's worth
adding for APNS as well.
Writing this is a bit of a reminder that I'm not a fan of how our unit
tests for push notifications work.
2018-05-21 11:30:56 -07:00
a68376e2ba
zerver/lib: Change use of typing.Text to str.
2018-05-12 15:22:39 -07:00
42a99e8c1d
zilencer: Rename remote_server_unregister_push.
2018-05-03 12:50:29 -07:00
76650f5930
zilencer: Rename remote_server_register_push to register_remote_push_device.
2018-05-03 12:50:29 -07:00
2f6da2661f
push_notifications: Format blockquotes properly in text_output.
...
New output is of the format:
Hamlet said:
> Polonius said:
> > This is the.
> > Second layer of nesting.
> First layer of nesting.
Fixes #9251 .
2018-05-02 08:57:17 -07:00
62c0d27d1e
push_notifications: Handle errors with token reuse.
...
If an Android token has been used to connect a given device with
multiple Zulip servers, and then is expired, we would 500 in trying to
remove the Zulip-side registration for it, because the code assumed
there was only one such registration. If a token is no longer valid,
it's invalid for all servers, so the correct fix is to just remove them all.
2018-03-23 11:02:55 -07:00
5086ba8568
push_notification: Update comment for unregister.
2018-03-01 22:14:32 -08:00
8a8b0dd87d
code-search: Add comments to help grepping.
2018-03-01 22:14:32 -08:00
693a9a5e70
push notifs: For group PMs, identify the users in the group.
2018-02-16 16:06:03 -08:00
ecbc72b857
push notifs: Add a diagnostic in API of whether push notifs enabled.
...
When the answer is False, this will allow the mobile app to show a
warning that push notifications will not work and the server admin
should set them up.
Based partly on Kunal's PR #7810 . Provides the necessary backend API
for zulip/zulip-mobile#1507 .
2018-02-12 14:34:59 -08:00
8be2dfa81c
APNs: Fix a case I broke while working out tests.
...
I got distracted, came back later to a successful test run in my
terminal, and thought I remembered finishing the change and just
kicking off a final test run to check.
In fact, there was an `assert False` right in the normal case for
production, and I just hadn't finished a test for that path. (m.-)
Definitely the most grateful I've been for our coverage checks,
which highlighted this for me.
Remove the `assert False`, and also finish writing the test it was
there to help me write. Those lines are covered now.
2018-02-09 18:28:16 -08:00
7f6a1714aa
APNs: Don't try to send anything when not configured.
2018-02-09 17:16:21 -08:00
776af2e248
push notifs: Simplify content-truncation code slightly.
...
This should be a pure refactor.
2017-12-18 15:32:56 -08:00
014900c2e5
push notifs: Include same stream and sender info on GCM as on APNs.
...
This takes the information added to APNs payloads by #7080 , and adds
to our GCM payloads the parts that it didn't already have.
2017-12-18 15:32:56 -08:00
e077d6fc74
push notifs: Factor out common payload fields for APNs and GCM.
...
This should be a pure refactor, producing exactly the same payloads.
2017-12-18 15:32:56 -08:00
8a432c5134
APNs: Update comment on versions of our APNs payload format.
2017-12-11 20:55:20 -08:00
98943a8333
Include data of stream/private sender details in apns push notifications
2017-12-11 20:51:09 -08:00
6bc1a682de
notifications: Separate push and email notifications checks.
...
This is an early step in a larger refactor to properly decouple the
email and push notification code paths.
2017-11-28 17:51:18 -08:00
ee546a33a3
zerver/lib: Use python 3 syntax for typing.
...
Edited by tabbott to improve various line-wrapping decisions.
2017-11-28 17:15:14 -08:00
229a8b38c0
zerver/lib: Use Python 3 syntax for typing for several files.
...
This adds a number of annotations that had been missed in previous
passes.
2017-11-28 17:02:24 -08:00
982bd9c38d
Fix push notifications for soft-deactivated users.
...
Previously, these push notification events were being generated, but
then ignored in handle_push_notification because there was no
user_message object.
2017-11-09 15:52:29 -08:00
c99d20db63
push_notifications: Shrink scope of try/except block.
...
There's no reason this needed to indent the entire function.
2017-11-09 15:30:21 -08:00
64b4d83038
push_notifications: Improve debugging of lookup problems.
...
We're having this error being thrown often, and don't know why.
2017-11-09 15:20:24 -08:00
19bd335cbb
Change urllib import to be Python 3-specific.
2017-11-07 10:46:42 -08:00
8302689789
Extract Message.is_stream_message().
...
This sets us up to denormalize on to Message some notion of
whether a message is for a stream (without having to hit the
Recipient table).
2017-10-28 17:57:39 -07:00
fa55d7ed33
retry_event: Remove requirement of failed_tries being already there.
...
This fixes a bug where retries in the signups queue threw an exception.
2017-10-27 18:15:53 -07:00
be619fe881
lint: Wrap many very long lines in the Python codebase.
...
This decreases the maximum line length in our Python codebase to 130.
2017-10-26 17:31:58 -07:00
841f02934d
push_notifications: Add setting to redact content.
...
This commit adds a setting that toggles redacting content of push
notifications and replacing it with "***REDACTED***".
2017-10-19 18:16:06 -07:00
e98ca0714b
notifications: Simplify how triggers are passed around.
...
This removes the utterly unnecessary `triggers` dict (which always was
a dict with exactly one value True) in favor of a single field,
'trigger'.
Inspired by Kunal Gupta's work in #6659 .
2017-10-18 21:42:05 -07:00
b5c107ed27
push_notifications: Remove unnecessary check for no devices.
...
This should have been checked by the caller anyway.
2017-10-13 17:30:20 -07:00
27a450b58d
push_notifications: Improve error message for GCM sending issues.
...
This addresses one of the sources of confusion in #6993 .
2017-10-13 17:30:11 -07:00
298c59f7fd
push_notifications: Fix error message for unregistered bouncer.
...
Previously, we were just returning a JSON error to the client, when it
was a server problem.
Fixes #6639 .
2017-10-11 19:09:24 -07:00
5a6584890d
push_notifications: Start using `get_mobile_push_content()` function.
2017-10-06 16:47:25 -07:00
28628eeaeb
push_notifications: Add `truncate_content()` function.
...
This function truncates the textual content at correct length.
(It will be updated later to handle corner cases of unicode
combining characters and tags when we start supporting them.)
2017-10-06 16:44:19 -07:00
b5a1aacfb3
push_notifications: Add `get_mobile_push_content()` function.
...
Given the rendered content of a message, this function strips
all the markup replacing emojis with their corresponding unicode
representation.
2017-10-06 16:44:18 -07:00
f091823fc8
push_notifications: Set APNS badge as 0 for now.
...
We don't yet have support for tracking the number of open APNS
notifications server-side, so setting this to 0 will at least avoid
confusing users.
2017-10-03 17:07:49 -07:00
d1afab7199
Replace deprecated Logging.warn calls with Logging.warning.
2017-10-02 11:11:42 +02:00
7b8f725707
APNs: Accept 1.6-format payloads in bouncer.
...
This is just enough of a quick fix to work with a stock Zulip 1.6
server. We should really also make this robust to arbitrary input
from the remote Zulip server, even though it'll be a little tedious.
2017-09-28 10:01:16 -07:00
f43e54d352
zerver/lib: Remove absolute_import.
2017-09-27 10:00:39 -07:00
1436d558a3
APNs: Add message body to notification payload.
...
(Edited by greg to leave the badge logic as is for now.)
2017-09-18 16:37:02 -07:00
a33c98f23e
push_notifications: Require the message.triggers fields to exist.
...
The code was already assuming it implicitly, and making it explicit
improves the readability.
2017-09-16 03:14:56 -07:00
5722237f59
push: Rename received_pm to private_message.
...
This is a clearer name for this now more broadly used interface.
2017-09-14 05:41:37 -07:00
97571a203d
push: Add new formatting for stream message push and add tests.
...
This should make the push notifications for messages to streams with
the new stream push notifications setting enabled make sense.
2017-09-14 05:41:37 -07:00
c3a8138f74
user_settings: Add push notifications for all stream messages.
...
Add setting to enable push notifications for all stream messages.
2017-09-14 05:41:37 -07:00
a4bcf1a64b
APNs: Handle HTTP connection errors, and retry.
...
Should help with #6321 as at least a band-aid.
2017-08-29 15:27:41 -07:00
00036ac8db
push_notifications: Fix mypy error.
2017-08-26 14:33:43 -07:00
613d093d7d
push notifs: Implement APNs with new API.
...
And it works!
A couple of things still to do:
* When a device token is no longer active, we'll get HTTP status 410.
We should then remove the token from the database so we don't keep
trying to push to it. This is fairly urgent.
* The library we're using has a nice asynchronous API, but this
version doesn't use it. This is OK now, but async will be
essential at scale.
2017-08-26 14:16:05 -07:00
35db1b2f11
push notifs: Organize imports.
2017-08-26 14:16:05 -07:00
ba673526ab
push notifs: Organize the code a bit.
...
This commit only reorders the code in the file, without touching the
insides of any function, and adds some heading comments.
2017-08-26 14:16:05 -07:00
Tim Abbott
Aditya Bansal
Rishi Gupta
Rohitt Vashishtha
Umair Khan
Greg Price
kunall17
rht
Steve Howell
Maarten Rijke
Harshit Bansal
derAnfaenger
Sarah
Greg Price