zulip

Commit Graph

Author	SHA1	Message	Date
Greg Price	f995ad1ed5	circleci: Simplify Dockerfile templating a bit. Injecting the generated-file warning into the settings dict felt a little unnecessarily magical. A warning like this is always going to be at the top; the way it might differ between files is mainly if the syntax for a comment varies, and in that case a simple substitution like we're doing in this template wouldn't be enough to express the difference anyway. So, embrace the hardcoding. Now, the template and the images.yml entry have a very simple relationship: the keys in one are exactly the keys in the other. That's good for people quickly and confidently understanding it.	2018-01-31 10:53:13 -08:00
Vishnu Ks	91506f1bb3	circleci: Generate xenial dockerfiles along with trusty.	2018-01-31 10:53:13 -08:00
Vishnu Ks	be328b2c7b	circleci: Create script for generating Dockerfiles. [greg: updated Dockerfile comment]	2018-01-31 10:53:13 -08:00

Author

SHA1

Message

Date

Greg Price

f995ad1ed5

circleci: Simplify Dockerfile templating a bit.

Injecting the generated-file warning into the settings dict felt a
little unnecessarily magical.  A warning like this is always going
to be at the top; the way it might differ between files is mainly
if the syntax for a comment varies, and in that case a simple
substitution like we're doing in this template wouldn't be enough
to express the difference anyway.  So, embrace the hardcoding.

Now, the template and the images.yml entry have a very simple
relationship: the keys in one are exactly the keys in the other.
That's good for people quickly and confidently understanding it.

2018-01-31 10:53:13 -08:00

Vishnu Ks

91506f1bb3

circleci: Generate xenial dockerfiles along with trusty.

2018-01-31 10:53:13 -08:00

Vishnu Ks

be328b2c7b

circleci: Create script for generating Dockerfiles.

[greg: updated Dockerfile comment]

2018-01-31 10:53:13 -08:00

3 Commits