24ee369d43
Improve error message in message_list.select_id().
2017-03-27 10:26:30 -07:00
293c89ba94
message edit: Only enable left-arrow-editing for content.
...
We no longer let the left arrow put you into the message edit
UI for a message where you can only edit topics, since that is
just confusing to most users.
This change also improves error handling a bit, and it removes
an unnecessary call to rows.id().
Finally, it moves some logic out of message_list.js, so that we
don't have a circular dependency for this codepath.
Fixes #4259
2017-03-27 10:02:19 -07:00
5e39ccd642
js: Rename viewport.js to message_viewport.js.
...
This fixes the mobile web experience for Chrome on iOS.
Apparently, Chrome-on-iOS silently has a `viewport` module that
overrides and user-defined module by that name, causing all of our
code that accesses the viewport module to not work on that platform.
We fix this by renaming it.
2017-03-10 14:59:59 -08:00
03386f1485
avatar live updates: Do full re-render.
...
We now sweep all active messages for avatar changes and update
the message items and re-render, rather than patching the
DOM. This avoids some quirks that happen when subsequent messages
get sent and we re-render previous messages out of the message
store.
Our approach here is similar to how we do full-name updates.
2017-02-22 22:46:44 -08:00
55cffa1e69
Added keyboard shortcut to edit the last message.
...
Tweaked significantly by tabbott to update Casper tests, document the
new feature, and fix hotkeys.
Fixes #1147 .
2017-02-12 00:29:28 -08:00
97243dcd52
Live update full names for senders in the message pane.
...
Note that this only works for people who are currently logged in.
Folks that log in after you may pick up the old full name from
the message. (I'll address this in a separate commit.)
2017-01-30 11:49:19 -08:00
998dff9e50
lint: Add dangling commas in JavaScript objects.
2017-01-11 15:23:42 -08:00
90fa797f9b
Use stream id to live-update messages for name changes.
...
When we change a stream name, we now use the stream id as the
key to find messages we need to live update. This eliminates
some possible race conditions from two users renaming a stream.
This commit introduces message_live_update.js.
The new call stack is this:
subs.update_subscription_properties
subs.update_stream_name
message_live_update.update_stream_name
message_list.update_stream_name
2017-01-05 15:32:45 -08:00
45f39be37f
lint: Fix many no-unused-vars eslint rule violations.
...
These have been carefully audited by tabbott to ensure they are
unlikely to cause regressions.
2016-12-14 21:34:51 -08:00
dc6849952b
eslint: change space-before-function-paren from warning to error.
...
Also fix violations.
2016-12-05 09:50:37 -08:00
1fb9220354
lint: Remove old jslint linter.
...
Now that we're using eslint, jslint is no longer required.
2016-12-02 18:49:42 -08:00
9c0ebc7359
eslint: change no-else-return to error and fix violations
2016-12-02 14:43:09 -08:00
ed0bc831be
eslint: change one-var from warning to error and fix violations
2016-12-02 11:25:16 -07:00
b3f4feb996
eslint: change max-len from warning to error and fix violations.
2016-12-02 14:16:33 +00:00
e6369fc29b
eslint: change no-plusplus from warning to 2 and fix violations.
2016-12-01 14:27:17 -08:00
c90da24541
eslint: change keyword-spacing from warning to error and fix violations.
2016-12-01 14:22:15 -08:00
cb18ef07a7
Rename hashchange.zulip event to avoid jquery 1.8 interaction.
2016-07-08 11:09:09 -07:00
3d77aa49db
Add subscribe button in narrowed view when stream has no messages.
...
A temporary message appears on successful subscription, with a button
offering to unsubscribe in case the user subscribed by accident.
2016-05-18 20:06:30 -07:00
206452c867
Add stream subscription button added narrowed views.
...
Fixes : #273
2016-05-18 20:06:23 -07:00
fe4a03fd01
Move narrowed_msg_list to message_list.js.
2016-04-26 10:25:11 -07:00
ae49ad383d
Rename all function on MessageList to all_messages.
2016-04-25 13:45:18 -07:00
35b0af2852
Move all_msg_list to message_list.js.
2016-04-21 17:46:21 -07:00
ee39f5009f
Make message_list.js work like the other modules.
2016-04-20 15:29:30 -07:00
af3411cab8
Handle removing the selected local message from the message list
...
(imported from commit 185fc33cc19699ebe61ce9d65262383e39289cf3)
2014-03-14 20:48:57 -04:00
c832543168
Remove very confusing dom_id message attribute
...
(imported from commit c7e3e50bf8827f6f087d7df28ec7b7c173a3c041)
2014-03-14 20:48:51 -04:00
6d2c6f269d
Make sure to use the proper dom_id in the proper places
...
(imported from commit c4852f972d4fe8b2732c87dcc499f91f837e912c)
2014-03-14 20:48:50 -04:00
8b1f0223fe
Update the dom_id of message objects when their id changes
...
(imported from commit e766eff7d966d95616ac192c8cb0cb328bd96b1b)
2014-03-14 20:48:50 -04:00
7f3ea34dc5
Make sure to re-select selected after re-ordering
...
(imported from commit 50878874372d1304014f5285b488db6ab896abbd)
2014-03-14 20:48:49 -04:00
e7c8c322c0
Handle case where _lower_bound returns size of input list
...
(imported from commit bd91512615b11935eafd5809ca414eeb0cf189c4)
2014-03-14 20:48:49 -04:00
065fcf1a1b
Handle out-of-order local ids in message_list
...
(imported from commit e805837d7d2790be90490cc9ec9415882ff9b549)
2014-03-14 20:48:47 -04:00
7cd814d92c
Keep track of local ids in our message list
...
(imported from commit d96eaa14bf9f4b315d6893e6cd6c8d3c069c1d14)
2014-03-14 20:48:46 -04:00
09dfc9a89b
Split selecting a message and hiding the empty narrow message
...
We should hide the empty narrow message message whenever the narrow is
not empty, but we should only select a message if non are currently
selected.
(imported from commit 22f6b0827dc84ed587a83b5d713b12c1d5d4c0a0)
2014-03-04 16:43:00 -05:00
5aef8b8fad
Maintain scroll position when removing selected message
...
(imported from commit 1021eac527e677fbcac46d0a7d44dd3244bb903e)
2014-02-27 20:25:32 -05:00
240050093b
Preserve scroll when rerendering due to out-of-order messages
...
(imported from commit 9c339cbe8d5bbd75bbdf24a8f14da4f1556cc407)
2014-02-27 20:25:31 -05:00
568c33f294
Render messages as groups of divs instead of individual rows
...
Now that we no longer use tables for our message list, we can
more logically group messages together.
(imported from commit 9923a092f91a45fe3ef06f2f00e23e4e3fb62a37)
2014-02-27 20:25:23 -05:00
748e5b6da6
Remove disabled summarization code
...
This experiment has been disabled for everyone for a while: if we
bring something like this back, it is not likely to be exactly the same,
and will be different enough to require a different implementation.
As it is, the summarization code was making a few code paths (rendering
especially) more complex, and is worth removing for simplicity's sake.
(imported from commit 6ac8cdc9f7077a5a1da01ab4268aba3db0bc43f8)
2014-02-27 20:25:23 -05:00
174a62eb7c
Remove requirement of no selected id to hide empty feed message
...
(imported from commit 10f4882a5f2def7e5b8567942758bb33007601d0)
2014-02-27 20:25:23 -05:00
1bd9e5809c
Restore the browser's scroll position on server-initiated reload.
...
(imported from commit 934659c0f1a2c014cfd2811fe49ea31abad262b2)
2014-02-06 10:25:35 -05:00
7e6bb801e2
Move message_range to a function on the message list.
...
(imported from commit c78710a3ccddb15352086b450fb6986e1251f364)
2014-02-03 13:32:02 -05:00
f528ac659d
Only attempt to reorder a message if we had it in the message list originally
...
(imported from commit 0b2802c1f1b6b17cd9f52dd9cecdf84f6f1cf5b0)
2014-01-24 14:01:18 -05:00
00f64113e9
Support locally echoing messages when sending
...
(imported from commit 00b5c5f9b933d119553c32cadff0f17b9f7c2879)
2014-01-23 16:28:55 -05:00
49c4ad61a1
Delay render on narrowing to end, to ensure only one render happens
...
(imported from commit c38574417e339275a90b235ecabc96e0deab95f8)
2014-01-23 13:29:18 -05:00
09dbaabcb6
Update unread flags between multiple browser windows.
...
(imported from commit 1c5e2bc0233c28c72ce4c8253fa0717ae4793f84)
2014-01-23 13:21:59 -05:00
685ab1a583
Add message_list.remove_and_rerender
...
(imported from commit 68da0ad74f797fae3257577bbf415fd1fe9488a6)
2014-01-07 17:33:33 -05:00
80e6dab78a
Parse message IDs as floats
...
(imported from commit d9954e4225e95e2931be1d1fe5ecf0b93914b07e)
2014-01-07 17:33:33 -05:00
73643acd03
Fix muting the last stream in the home view.
...
(imported from commit b35e9903cdb8697a1010147854feb13060e9516d)
2013-12-18 14:30:17 -05:00
06c689738e
Show @-mentioned messages even for muted topics
...
This addresses Trac #1929
(imported from commit 1b30ee7ae602e83f5977ffd4f32e478f719683d1)
2013-12-09 20:09:11 -05:00
7c9e7e57b9
Remove message_list:get_messages, which is redundant with all().
...
(imported from commit 100eb775b89c54c45f70cf903018bdaefa99d3f6)
2013-12-09 10:41:26 -05:00
00946f97df
Log more data for "Cannot select id -1".
...
Show the incoming id and the length of this._items.
(imported from commit 106dda862918a4f40481a5692cbfee1738218150)
2013-12-02 15:45:40 -05:00
9e50781131
Random javascript shortenings
...
(imported from commit 68a34d67ac38e34035a3e3986518824bf5a96fc5)
2013-11-13 16:41:36 -05:00
Steve Howell
Tim Abbott
Igor Tokarev
Rafid Aslam
lonerz
kevv87
AZtheAsian
Tommy Ip
Tim Abbott
Kartik Maji
Vishnu Ks
Leo Franchi
Jason Michalski
Tim Abbott
acrefoot
Jessica McKellar
Steve Howell