Tim Abbott
d21756c396
streams: Fix default streams list not updating on deactivation.
...
If you deactivated a default stream, we would correctly remove it from
the list of default streams in the organization. However, we did not
call `send_event`, so browsers would still display it as a default
stream until the next reload.
This fixes that issue by calling do_remove_default_stream instead of
doing the database query directly.
2017-06-04 10:36:18 -07:00
Aditya Bansal
b99d62d337
pep8: Add compliance with rule E261 timeout.py.
2017-06-04 15:06:29 +05:30
Tommy Ip
8d6af030c0
bugdown: Fix modal_link.
...
The `data-toggle` property prevented the new style of overlay modals
from launching, and regardless, isn't a future-proof options for how
this should work.
2017-06-03 18:41:19 -07:00
Tim Abbott
a0ef2babab
text_fixtures: Rename migration status file to have test in name.
...
This is preparation for making things clear as we move towards not
always rebuilding the test database in provision.
2017-06-02 13:27:34 -07:00
Tim Abbott
6d00da2b80
test_fixtures: Remove hardcoding of check_files status dir.
...
This is preparatory support for using this framework in provision as
well.
2017-06-02 13:27:34 -07:00
Aditya Bansal
8680c87f56
pep8: Add compliance with rule E261 zerver/lib/push_notifications.py.
2017-05-31 17:07:15 -07:00
K.Kanakhin
2434f2d96c
messages: Add support for admins deleting messages.
...
This makes it possible for Zulip administrators to delete messages.
This is primarily intended for use in deleting early test messages,
but it can solve other problems as well.
Later we'll want to play with the permissions model for this, but for
now, the goal is just to integrate the feature.
Note that it saves the deleted messages for some time using the same
approach as Zulip's message retention policy feature.
Fixes #135 .
2017-05-29 21:59:38 -07:00
Harshit Bansal
298e23b447
realm_emoji.py: Allow an user to delete an emoji uploaded by them.
...
If a realm is configured to allow any user to upload an emoji,
then, an emoji author must be allowed to delete an emoji uploaded
by them.
2017-05-29 20:21:25 -07:00
Maxim Averin
a4c3f571db
Switch change_tos_version to use RealmAuditLog.
2017-05-29 15:24:01 -07:00
Maxim Averin
685fb16c39
Switch change_full_name to use RealmAuditLog.
...
This requires adding an `acting_user` parameter to the
`do_change_bot_owner` function.
2017-05-29 15:22:08 -07:00
Tim Abbott
9d7e6b1b48
events: Fix race with realm_waiting_period_threshold changes.
...
The can_create_streams property changed some time ago to depend on 2
different properties of Realm, causing occasional test failures.
2017-05-28 18:21:50 -07:00
Sarah
bb329b4020
zerver/lib/events: Refactor using UserProfile prop_types and notifications
...
Refactor fetch_initial_state_data to use the UserProfile.property_types
and notifications dictionaries.
2017-05-26 14:55:54 -07:00
Nathan Miller
2311e169ec
mypy: Various strict-optional fixes in zerver.
2017-05-26 10:10:20 -07:00
Ethan
1477a9102d
mypy: Fix return annotation; json_method_not_allowed.
2017-05-25 15:41:44 -07:00
Elliott Jin
8b98b79646
bots: Generate queue events for embedded bots.
2017-05-25 15:00:51 -07:00
Christian Hudon
8ab6a23a30
Fix most strict-optional issues in export.py.
2017-05-24 18:50:59 -07:00
Christian Hudon
1761a3b1c1
mypy: strict optional fixes.
2017-05-24 18:50:59 -07:00
Eklavya Sharma
2f227a97d3
mypy: Make zerver/lib/actions.py pass --strict-optional check.
2017-05-24 18:49:54 -07:00
Eklavya Sharma
1d8c316ff0
mypy: Make email_mirror pass --strict-optional check.
2017-05-24 18:49:54 -07:00
Eklavya Sharma
690b6025fb
mypy: Fix return type of a function.
2017-05-24 18:43:51 -07:00
Christian Hudon
14e871ce9c
Change order of arguments so output_dir is not optional. Helps mypy too.
2017-05-24 17:32:21 -07:00
Tim Abbott
6aaca44e17
tests: Fix str/Text mypy issues in various tests.
2017-05-24 15:19:38 -07:00
Rick Chern
e53d1c3885
tests: Remove get_user_profile_by_email from most tests.
2017-05-24 13:05:19 -07:00
umkay
ccc70445d6
mypy: Fix strict-optional errors for test files.
...
Fix mypy --strict-optional errors in zerver/tests
2017-05-24 12:43:28 -07:00
Eklavya Sharma
bac874b7e3
mypy: Allow None in passwords while creating users.
2017-05-23 21:56:50 -07:00
Eklavya Sharma
cc1937c8d5
mypy: Use Optional with strings where required.
2017-05-23 21:56:50 -07:00
vaibhav
f94c321567
Outgoing Webhook System: Add support for personal message triggers.
2017-05-23 21:35:09 -07:00
Mark Shannon
c7c47fe11d
Replace buggy NotImplemented with NotImplementedError().
2017-05-23 20:33:35 -07:00
Jason Michalski
a22d6d2c2a
test-backend: Enable test coverage in multi-process mode.
...
We enable data_suffix option when creating Coverage instances which
causes the output files to include the hostname, pid, and random id.
Before each run erase is called which clears all existing coverage data
files. And then at the end of the test run use the combine method which
merges the reports.
We collect coverage in the main process which collects data from
imports and also when running in single process mode. In the workers we
collect coverage in run_subsuite. This creates more stats files than
strictly required but I don't see a better place to save the stats when
stopping workers.
Note that this has the side effect of enabling parallel testing in
Travis CI.
2017-05-23 18:25:13 -07:00
Sarah
4c4444b2dc
zerver/lib/actions: Fix PEP8 E712 error.
2017-05-23 16:29:49 -07:00
Andrew Archer
40b3330f2c
actions: Refactor get_user_profile_by_email to get_user.
2017-05-23 15:30:14 -07:00
Vishnu Ks
f5d8e256aa
Add ZulipTestCase.example_email and ZulipTestCase.mit_email function.
2017-05-23 15:27:21 -07:00
Vishnu Ks
789ef217a8
send_email.py: Remove unused get_user_profile_by_email import.
2017-05-23 15:27:21 -07:00
Matt Long
19363b2b77
notification_settings: Refactor notification preference settings.
...
Previously, all notification preference setting had a dedicated test
and setter. Now, all are handled through a modular function using the
property_types framework.
2017-05-23 14:47:46 -07:00
Rick Chern
70d68f7e71
Refactoring: Replace get_user_profile_by_email() in lib/upload.py
2017-05-23 12:37:49 -07:00
Konstantin Gukov
dd76222a3f
Fetch system bots using new get_system_bot function.
...
This eliminate a bunch of uninteresting calls to
get_user_profile_by_email.
2017-05-23 10:30:40 -07:00
vaibhav
c7524f2f38
Outgoing Webhook System: Prevent infinite loops with outgoing webhooks.
2017-05-23 08:20:45 -07:00
vaibhav
53a8b2ac87
Outgoing Webhook System: Add DoRestCall and helper functions
2017-05-23 08:19:16 -07:00
Vishnu Ks
7f06a7fa2a
Add ZulipTestCase.mit_user() function.
2017-05-22 19:02:42 -07:00
Lukasz Prasol
01f7d9d651
zerver/lib/events: Refactor get_user_profile_by_email to get_user.
...
Fixes #4831 .
2017-05-22 17:32:36 -07:00
Vishnu Ks
bdf7c6c02f
models: Add get_user function.
...
This is intended to replace get_user_profile_by_email.
2017-05-22 11:26:44 -07:00
Aditya Bansal
85aa07e2d4
pep8: Add compliance with rule E261 to zerver/lib/upload.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
b7c49299a6
pep8: Add compliance with rule E261 to test_runner.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
e3003653c7
pep8: Add compliance with rule E261 to test_helpers.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
26ff19f005
pep8: Add compliance with rule E261 to zerver/lib/test_classes.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
1f1fbd7648
pep8: Add compliance with rule E261 to zerver/lib/notifications.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
84eadc0562
pep8: Add compliance with rule E261 to zerver/lib/message.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
03e43b78ee
pep8: Add compliance with rule E261 to zerver/lib/html_diff.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
b822e75a4b
pep8: Add compliance with rule E261 to export.py.
2017-05-18 03:00:32 +05:30
Aditya Bansal
4c373dde63
pep8: Add compliance with rule E261 to events.py.
2017-05-18 03:00:32 +05:30