Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
21,591 Commits 28 Branches 143 Tags 606 MiB
Commit Graph

21591 Commits

Author SHA1 Message Date
Eeshan Garg 763437cc9c backend: Introduce check_send_private_message. 
check_send_private_message utilizes Addressee.for_user_profile()
to send a private message to a user_profile.
 2017-10-02 15:27:26 -07:00
Eeshan Garg 502e93a5d2 docs: Recommend check_send_stream_message for stream messages. 
This commit updates various places where check_send_message had
been previously recommended to recommend check_send_stream_message
for sending messages to a public stream.
 2017-10-02 15:27:26 -07:00
Steve Howell 2be713a7e4 Rename get_userids_for_missed_messages(). 
We rename this function to get_active_presence_idle_userids().
 2017-10-02 15:19:28 -07:00
Steve Howell e660428c21 Rename missed_message_userids to presence_idle_userids. 2017-10-02 15:19:28 -07:00
Steve Howell 32d5e297a3 Rename get_idle_userids to filter_presence_idle_userids. 
We have two different concepts of "idle", and this function
is based on the "presence" aspect of idleness.  There is also
idleness in terms of a user having no current client
descriptors accepting messages, and we check that later in
the process for things like sending missed message emails.
 2017-10-02 15:19:28 -07:00
neiljp (Neil Pilgrim) ee8d7de7c3 mypy: Upgrade mypy to mypy commit on Oct 2 2017. 
Also fix the fact we apparently forgot to remove fonttools from
dev_lock.txt.
 2017-10-02 15:15:08 -07:00
Tim Abbott e5592fe89f test_signup: Remove REALMS_HAVE_SUBDOMAINS check. 
This test actually is just as correct with
REALMS_HAVE_SUBDOMAINS=True.
 2017-10-02 13:50:07 -07:00
Tim Abbott 9622da6b16 test_signup: De-inline REALMS_HAVE_SUBDOMAINS=True checks. 
These are now just declarations at the top of functions.
 2017-10-02 13:50:06 -07:00
Tim Abbott edc10e8f51 test_decorators: de-inline REALMS_HAVE_SUBDOMAINS with statements. 
This will significantly shrink the diff when we toggle
REALMS_HAVE_SUBDOMAINS soon.
 2017-10-02 13:49:53 -07:00
Tim Abbott f05719e335 test-api: Fix tests to work with subdomains. 2017-10-02 13:31:22 -07:00
Tim Abbott 5a27a4cf1c decorator: Improve wrong-subdomain logging output. 
Often, it's helpful to see both values in errors.
 2017-10-02 13:31:20 -07:00
Vishnu Ks 6b9755c854 email_log: Make generate_email work with subdomains. 
This fixes one of our last few test failures with
REALMS_HAVE_SUBDOMAINS.
 2017-10-02 12:27:27 -07:00
Tim Abbott 6327f30c76 test_decorators: Remove test_login_deactivated_realm. 
This test was a duplicate of test_login_deactivated in LoginTest.
 2017-10-02 11:42:15 -07:00
Tim Abbott f69523e0c8 travis: Modify success-http-headers. 
Travis CI seems to have changed their version of wget such that it no
longer prints this.
 2017-10-02 10:35:48 -07:00
rht 45f30c7f54 tools: Remove unused imports. 2017-10-02 10:13:48 -07:00
rht 2c2adbf647 tools/lib: Remove unused imports. 2017-10-02 10:13:46 -07:00
rht 8a631a2fde tools: Replace optparse with argparse. 2017-10-02 10:09:49 -07:00
derAnfaenger 6c8b405c7e linter: Add rule against using the deprecated Logging.warn. 
Tweaked by tabbott to improve the test cases.
 2017-10-02 09:31:11 -07:00
derAnfaenger d1afab7199 Replace deprecated Logging.warn calls with Logging.warning. 2017-10-02 11:11:42 +02:00
Tim Abbott 7d63928fe1 test_signup: Update deactivate realm tests for subdomains. 
We add a new test to make sure we cover the potential race condition
with the realm being deactivated after starting the registration
process.
 2017-10-01 23:52:08 -07:00
Tim Abbott 50eb94f7ee docs: Remove broken link to shell tips. 
In theory, we could replace it, but it's not clear that's necessary.
 2017-10-01 23:27:29 -07:00
Tim Abbott 651b1882e6 test_outgoing_webhook_system: Set REALMS_HAVE_SUBDOMAINS=True. 2017-10-01 22:47:15 -07:00
Nalin Bhardwaj 73de273726 stats: Remove hourly data from messages sent over time. 
Fixes #6564.
 2017-10-01 22:10:43 -07:00
Priscilla 7c0431a60f docs: Correct the instructions for re-running provision. 
We apparently missed this when renaming provision.py to simply
provision.
 2017-10-01 15:51:32 -07:00
Tim Abbott 8c8613c3c7 install: Add comments documenting installer wrapper. 2017-10-01 15:48:36 -07:00
Eeshan Garg 86c2c7ad34 webhooks: Migrate to check_send_stream_message. 
This commit migrates all webhooks to use check_send_stream_message
instead of check_send_message. The only two webhooks that still
use check_send_message are our yo and teamcity webhooks. They
both use check_send_message for private messages.
 2017-09-30 17:48:55 -07:00
Eeshan Garg 24aff0d0a2 backend: Introduce check_send_stream_message. 
check_send_stream_message is a simpler version of
check_send_message for sending messages where the addressee is
a stream. Instead of relying on Addressee.legacy_build,
check_send_stream_message uses Addressee.for_stream. Consequently,
it eschews many of check_send_message's kwargs that aren't needed
when the intended recipient of a message is a stream.
 2017-09-30 17:48:55 -07:00
Umair Khan 69ccc8ce0e ldap: Show helpful message when realm is None. 2017-09-30 10:18:25 -07:00
Robert Hönig 9d4bffb59d outgoing webhook: Make exception handling more granular and verbose. 
Fixes #6127.
 2017-09-30 10:14:28 -07:00
Robert Hönig 93ebd1660f outgoing webhook: Make notify_bot_owner mypy annotation more specific. 2017-09-30 10:12:31 -07:00
Robert Hönig ba598def0b outgoing webhook: Don't retry on 50x response. 
This reverts one retry case introduced in 53a8b2a.
 2017-09-30 10:12:31 -07:00
Alexander Trost 6a7d34316c Add scripts to be used in docker-entrypoint.sh. 
Based on #450, with commits
restructured by Rein Zustand.
Tweaks by Rein Zustand:
- Replace configure-cert with generate-self-signed-certs
- `mv scripts/lib/create-zulip-admin.sh scripts/lib/create-zulip-admin`
 2017-09-30 09:55:48 -07:00
Alexander Trost b33126a3e5 Add Docker-specific puppet files. 
Based on #450, with commits
restructured by Rein Zustand.
Additionally, tweaked by Rein Zustand for typo mechanics and syntax.
 2017-09-30 09:55:48 -07:00
rht e9d35be2bd run-dev: Replace optparse with argparse. 
Tweaked by tabbott to preserve the usage information correctly and
remove some duplication.
 2017-09-30 09:40:19 -07:00
rht f6e6e8ba44 html-grep: Replace optparse with argparse. 
Tweated by tabbott to still have a useful description.
 2017-09-30 09:35:40 -07:00
rht 3ac8ab8be3 check-provision: Replace optparse with argparse. 2017-09-30 09:32:46 -07:00
rht 2ce9e4d9a1 frontend_tests: Replace optparse with argparse. 
Tweaked by tabbott to fix the command name being reported properly.
 2017-09-30 09:31:06 -07:00
rht 6dd94becb3 zerver/management: Remove unused optparse import. 2017-09-30 09:22:08 -07:00
rht dc5136ed96 analytics: Remove unused optparse import. 2017-09-30 09:22:08 -07:00
rht e0f7b6f8ef docs: Remove the yarn.lock stutter. 
Maybe someday someone will spot this err. However, the documentation is
clear in conveying its content even with the extra yarn.lock.
 2017-09-30 09:16:46 -07:00
Anupam-dagar f82c5e9626 settings: Remove save changes button from "UI settings" section. 
Fixes: #6330.
 2017-09-30 09:11:18 -07:00
Tim Abbott 63bbbba5aa backend: Add support for mobile_flow_otp in social auth. 
It turns out that very little code change is required to support
GitHub auth on mobile.  Ideally, this would come with tests, though
the complicated part of the code path is covered by the Google auth
version.  But writing a test for this would take a long time, and I
think it's worth having the feature now, so I'll be doing tests as a
follow-up project.
 2017-09-30 09:02:46 -07:00
Tim Abbott 327db90a3d Fix fetching of medium-size user avatars. 
In the refactoring in 31d3b1ecc0 that
fixed live-updating of the medium-size avatar data, we started just
fetching the normal-size avatar, not the medium-size avatar.  We fix
this by changing this code path to pass in the user object and
construct the URL using that.

While we're at it, we switch to using the user ID, not the email, to
construct these avatar URLs.
 2017-09-30 08:57:25 -07:00
Tim Abbott 376cab8ba4 popover: Rename show_message_info_popover. 
It's really a user info popover.
 2017-09-30 08:57:25 -07:00
Tim Abbott ddb1a03a5b popovers: Pass user into show_message_info_popover. 
This makes the interface cleaner, which is helpful preparation for
being able to make clicking on mentions show the user's profile as
well.
 2017-09-30 08:57:24 -07:00
Tim Abbott e0087cab69 popovers: Remove unnecessary call to timerender. 
This calls hasn't been actually used since 2013.
 2017-09-30 08:57:24 -07:00
Tim Abbott 3c7e470cfb popovers: Refactor showmessage_info_popover. 
We now rely on getting the sender object from people.js, rather than
hackishly trying to handle the case that it doesn't exist.
 2017-09-30 08:57:24 -07:00
Tim Abbott 16b47a86e4 popovers: Refactor show_sender_info variable names. 
We're going to use the original variable names for other things soon.
 2017-09-30 08:57:24 -07:00
Tim Abbott 18fd5e1a3b user popover: Remove unnecessary historical argument. 
We stopped using this some time ago.
 2017-09-30 08:57:24 -07:00
Tim Abbott d56aa83e31 popovers: Clean up name fetching for presence user info. 
Previously, we relied on fetching the name of the user from the data
attributes on the individual elements, when we can get a more reliably
up-to-date value from the people.js data structure we're fetching
anyway.
 2017-09-30 08:57:24 -07:00