Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
52,669 Commits 28 Branches 142 Tags 695 MiB
Commit Graph

4 Commits

Author SHA1 Message Date
Anders Kaseorg 63c9296d53 tests: Fix direct mutation of ES modules. 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-08-04 18:00:38 -07:00
Tim Abbott f99f567521 unread_ops: Centralize window focused logic. 2023-06-05 21:57:35 -07:00
AcKindle3 fd84651a16 Localstorage: Use `zod` to parse type `FormData`. 
Local storage is an untyped interface external to the frontend code
itself. The `data` field after `JSON.parse`'d from `raw_data` can be
further validated using `zod`'s schema `formDataSchema`.

The test case `server_upgrade_alert hide_duration_expired` in
`navbar_alerts.test.js` has a bug at `start_time`, which is fixed in
this commit. `start_time` is a mock value of `Date.now()` used in
`localstorage.ts`, which will concatenate with a number `expires`.
So `start_time` was supposed to be an integer value. Before fix, `new
Date(1620327447050)` returns a `Date` object which is wrongly
concatenated with `expires`.

Fixes #24997.
 2023-04-24 11:59:02 -07:00
Anders Kaseorg cea1119423 node_tests: Move to web/tests. 
This lets us simplify the long-ish ‘../../static/js’ paths, and will
remove the need for the ‘zrequire’ wrapper.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
 2023-02-23 16:04:17 -08:00