d00fa63aa4
compose: Fix sorting of wildcard mentions in case of PMs.
...
This commit attemts to fix the sorting of wildcard mentions by moving
them below the silent mentions in case of PMs.
It adds a condition in compare_people_for_relevance function to check
for private message type and sorts the wildcard mention below the silent
ones.
It also adds test for sort broadcast mentions and compare_people_for_relevance
function in case of private message types.
Fixes : #21643
2022-04-28 12:53:46 -07:00
280938691f
prod_settings_template: Switch to double quotes in commented lines.
2022-04-28 12:40:28 -07:00
540ce2c765
prod_settings_template: Add some missing quotes in commented lines.
2022-04-28 12:40:28 -07:00
cd011b1a94
ci: Verify production servers using /api/v1/server_settings.
...
The previous commit changed our response for the root domain on a
self-hosted Zulip server containing no realms to be a 404.
This made the HTTP headers verification done here less robust than
would be ideal, in that one could imagine a bug that makes every URL
404 passing that test.
So we instead change the check to verify the /server_settings API,
which doesn't have that problem.
2022-04-28 12:34:59 -07:00
4e08c737ca
home: For web public realms, skip login for spectators.
...
To provide a smoother experience of accessing a web public stream,
we don't ask user to login unless user directly requests a
`/login` URL.
Fixes #21690 .
2022-04-28 12:34:29 -07:00
bd2dc7358b
help: Add redirect to new public access page.
2022-04-28 12:27:13 -07:00
86a6318d30
public access: Fix in-app links to public access option.
...
We also update these links to the new dedicated article on the topic,
and also remove the zulip.com/zulipchat.com hardcoding.
Fixes #21941 .
2022-04-28 12:09:08 -07:00
00fffd1681
help: Rename `web-public-streams` page to `public-access-option`.
2022-04-28 12:09:08 -07:00
d51f798468
portico: Rename web-public streams -> public access option.
2022-04-28 12:09:08 -07:00
a80228092b
help: Introduce "public access option" term for web-public streams.
2022-04-28 12:09:08 -07:00
127108c7d1
workers: Log the exception if the export fails.
...
We previously just swallowed the exception entirely.
2022-04-28 11:52:47 -07:00
4325bf0fc9
droplets: Add a tool to clean up old hostnames in DNS.
2022-04-28 11:30:47 -07:00
b5bcc5f1b4
droplets: Switch to Ubuntu 20.04 base image.
2022-04-28 11:30:47 -07:00
702807829f
droplets: Add IPv6 addresses to droplets.
2022-04-28 11:30:47 -07:00
738d21f24b
droplets: Allow specifying the region for the droplet.
2022-04-28 11:30:47 -07:00
b18b9d25e1
droplets: Add a script to do the provisioning.
2022-04-28 11:30:47 -07:00
44efc8eb37
web_public_view: Redirect to current narrow after login.
...
Add current hash as `next` URL to all login buttons
a spectator can access while in app.
2022-04-28 10:47:49 -07:00
6331a314d4
Correctly hyphenate “non-”.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 22:10:31 -07:00
d58fece832
Correctly hyphenate “web-public”.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 22:10:31 -07:00
8ed605de13
openapi: Mention that `profile_data` will be missing for bots.
...
For why we put this in the schema, instead of at the places where
the schema is consumed, Tim says:
> The code to not include it for bots is present in the common code
> path for formatting user objects for the API, so it should apply
> to all places we have users in the API documentation.
Discussion:
https://chat.zulip.org/#narrow/stream/412-api-documentation/topic/.60profile_data.60.20in.20.60.2Fregister.60.20response/near/1374737
2022-04-27 22:09:55 -07:00
567859d15d
dropdown_list_widget: Convert DropdownListWidget to ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 22:09:10 -07:00
d131327760
dropdown_list_widget: Convert MultiSelectDropdownListWidget to ES6 class.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 22:09:10 -07:00
59c4680370
dropdown_list_widget: Reorder MultiSelectDropdownListWidget constructor.
...
ES6 class constructors must call the superclass constructor before
accessing this.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 22:09:10 -07:00
175dd999ac
dropdown_list_widget: Separate setup method from constructor.
...
This refactoring is required so the next commit can reorder the
constructor.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 22:09:10 -07:00
5ee4f71701
avatar: Add rate limit similar to attachments on medium avatars.
...
Followup on #20136
2022-04-27 16:51:18 -07:00
b4feb673f1
push_notifications: Soft reactivate mentioned users.
...
Fixes #19861
Signed-off-by: Zixuan James Li <359101898@qq.com>
2022-04-27 16:43:54 -07:00
a8fd9eb701
email_notifications: Soft reactivate mentioned users.
...
Signed-off-by: Zixuan James Li <359101898@qq.com>
2022-04-27 16:43:54 -07:00
d8101de34d
notifications: Move user group mentions helpers together.
...
This refactored `get_mentioned_user_group_name` from
`zerver/lib/email_notifications.py` to
`zerver/lib/notification_data.py` just after
`get_user_group_mentions_data` to indicate the logical
similarity between them.
Signed-off-by: Zixuan James Li <359101898@qq.com>
2022-04-27 16:43:54 -07:00
c97162e485
puppet: Check that certbot certs are in use before fixing them.
...
It is possible to have previously installed certbot, but switched back
to using self-signed certificates -- in which case renewing them using
certbot may fail.
Verify that the certificate is a symlink into certbot's output
directory before running `fix-standalone-certbot`.
2022-04-27 16:01:15 -07:00
7e94e3b370
node_tests: Mock classes with classes.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 14:36:00 -07:00
0c7828aeab
user_groups: Add get_user_group_direct_members function.
...
This commit adds get_user_group_direct_members function
which returns a QuerySet of UserProfile and is used in
is_user_in_group function.
2022-04-27 14:17:52 -07:00
d9d27b459d
user_groups: Rename get_user_group_direct_members function.
...
This commit renames get_user_group_direct_members function to
get_user_group_direct_member_ids as it returns a list of ids
and to avoid it being parallel to get_recursive_group_members,
which returns a QuerySet.
2022-04-27 14:17:52 -07:00
0f01e3d327
tests: Add checks for user groups in different realms.
2022-04-27 14:17:52 -07:00
4d319ff34c
tests: Use high enough number for invalid user group and user ids.
...
We use 1111 for testing invalid user and user group id cases instead
of 25, since we may have a user group in 25 in test data in future.
2022-04-27 14:17:52 -07:00
7c247a11a9
test_openapi: Use Python 3.8 typing.{get_origin,get_args}.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
a2825e5984
python: Use Python 3.8 typing.{Protocol,TypedDict}.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
098a514599
python: Use Python 3.8 shlex.join function.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
71390fb635
black: Bump target-version to py38.
...
This has no effect on our current code.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
4d903dcc94
i18n: Remove size limit on lru_cache for get_language_list.
...
Really just for consistency, since the size will be at most 1 anyway.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
0451d1e47f
zulip_tools: Replace universal_newlines with text.
...
Generated by pyupgrade.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
2afe82ba2e
test_link_embed: Convert "".format to f-string.
...
Generated by pyupgrade.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
b572b18e70
test_digest: Modernize set literal syntax.
...
Generated by pyupgrade.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:57:49 -07:00
1c228de049
models: Excise NULL from pointlessly nullable fields.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:40:14 -07:00
fd16f97d6b
python: Excise None from pointlessly nullable booleans.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:40:14 -07:00
af30538a65
forms: Fix type of domain_override parameter.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-27 12:40:14 -07:00
ee0021de08
models: Change Stream.history_public_to_subscribers value to True.
...
The default of a Stream is to be public - having
history_public_to_subscribers default to False is inconsistent with
that. The defaults on the model should generally be consistent.
2022-04-27 12:08:01 -07:00
04fdf3e4d9
import_utils: Fix history_public_to_subscribers being set incorrectly.
...
history_public_to_subscribers wasn't explicitly set when creating
streams via build_stream, thus relying on the model's default of False.
This lead to public streams being created with that value set to False,
which doesn't make sense.
We can solve this by inferring the correct value based on invite_only in
the build_stream funtion itself - rather than needing to add a flag
argument to it.
This commit also includes a migration to fix public stream with the
wrong history_public_to_subscribers value.
Fixes #21784 .
2022-04-27 12:08:01 -07:00
bd072d79a4
test-backend: Respect --parallel=N when running specific tests.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2022-04-26 18:34:14 -07:00
33c5bc5b4d
docker: Document the PostgreSQL Dockerfile build steps.
2022-04-26 18:00:00 -07:00
9687df21b3
docker: Upgrade docker-postgresql to 14.
...
Because we have no upgrade path for the data in the PostgreSQL
databases themselves, this is pushed as, e.g.,
`zulip/zulip-postgresql:14` and *not* as
`zulip/zulip-postgresql:latest`.
Fixes : #21211
Co-authored-by: Alex Vandiver <alexmv@zulip.com>
2022-04-26 18:00:00 -07:00
Somesh Ranjan
Alex Vandiver
Tim Abbott
Aman Agrawal
Alya Abbott
Anders Kaseorg
Chris Bobbe
Zixuan James Li
Sahil Batra
Mateusz Mandera
Varac