zulip

Commit Graph

Author	SHA1	Message	Date
Tim Abbott	3fd8d718f4	websockets: Fix race condition in CSRF token initialization. It appears that we were not always initializing the Socket object after `setup.js` had the opportunity to set csrf_token. This should fix #6961.	2018-03-31 09:29:56 -07:00
Steve Howell	1f6ddf0110	refactor: Extract transmit.js from compose.js. We now isolate the code to transmit messages into transmit.js. It is stable code that most folks doing UI work in compose.js don't care about the details of, so it's just clutter there. Also, we may soon have other widgets than the compose box that send messages. This change mostly preserves test coverage, although in some cases we stub at a higher level for the compose path (this is a good thing). Extracting out transmit.js allows us to lock down 100% coverage on that file.	2018-02-20 09:29:26 -08:00

Author

SHA1

Message

Date

Tim Abbott

3fd8d718f4

websockets: Fix race condition in CSRF token initialization.

It appears that we were not always initializing the Socket object
after `setup.js` had the opportunity to set csrf_token.

This should fix #6961.

2018-03-31 09:29:56 -07:00

Steve Howell

1f6ddf0110

refactor: Extract transmit.js from compose.js.

We now isolate the code to transmit messages into transmit.js.
It is stable code that most folks doing UI work in compose.js don't
care about the details of, so it's just clutter there.  Also, we may
soon have other widgets than the compose box that send messages.

This change mostly preserves test coverage, although in some cases
we stub at a higher level for the compose path (this is a good thing).
Extracting out transmit.js allows us to lock down 100% coverage on that
file.

2018-02-20 09:29:26 -08:00

2 Commits