Tim Abbott
ce670a7892
soft_deactivation: Document add_missing_messages algorithm.
2017-08-15 08:33:14 -07:00
Tim Abbott
14aaefdd46
soft_deactivation: rename find_and_store_to_insert_stream_msgs.
...
The original name was very verbose, and a bit less clear.
2017-08-15 08:29:51 -07:00
Tim Abbott
45bc599b02
soft_deactivation: Clean up user_messages_to_insert.
2017-08-15 08:29:51 -07:00
Aditya Bansal
57858596ab
soft_deactivation: Add new function 'add_missing_messages'.
...
This function will help us in creating undisturbed experience for
returning soft deactivated users.
Tweaked by tabbott to fix minor performance and clarity issues.
2017-08-15 08:29:51 -07:00
Aditya Bansal
dc5510ce44
soft_deactivation: Add helper functions for deactivating users.
2017-08-15 08:29:28 -07:00
Steve Howell
274938bf5f
Eliminate approximate_unread_count().
...
We use page_params.unread_msgs.count in the web
app instead.
Fixes #1300 .
2017-08-14 12:39:00 -07:00
Steve Howell
658ac782a2
Add page_params.unread_msgs.count.
...
This field is convenient for bankruptcy checks. Clients could
calculate it from page_params.unread_msgs before this change, but
it would kind of a painful calculation.
To add count, we had to simplify the mypy annotations, which weren't
really accurate before.
2017-08-14 12:38:09 -07:00
Steve Howell
c0dec29f5f
Exclude inactive streams from unread counts.
2017-08-14 12:38:09 -07:00
Tim Abbott
09f84f91f4
request: Improve documentation of request.py.
2017-08-14 09:49:29 -07:00
rht
668af8b6f9
mypy: Annotate zerver/lib/exceptions.py.
2017-08-14 09:47:28 -07:00
rht
2541b29bdc
mypy: Annotate zerver/lib/request.py.
2017-08-14 09:47:28 -07:00
Jack Zhang
ab9021678e
Remove secondary lines of text from JIRA, Github, and Trello integrations.
2017-08-10 10:21:53 -07:00
Jack Zhang
f9b5a270d0
integrations: Remove titles from integration docs.
2017-08-10 10:21:53 -07:00
Jack Zhang
fc6c2b321b
portico: Reimplement /apps routes using pushState.
2017-08-10 10:21:53 -07:00
Jack Zhang
4125311d6f
integrations.py: Add tag for legacy integrations.
2017-08-10 10:21:53 -07:00
Jack Zhang
e56b060ef4
github_webhook/doc.md: Add link to deprecated Github Services integration.
2017-08-10 10:21:53 -07:00
Jack Zhang
8187b7ab57
bitbucket2/doc.md: Add link to deprecated Enterprise integration.
2017-08-10 10:21:53 -07:00
Jack Zhang
1e6570fa5d
Update integrations doc context relative urls.
2017-08-10 10:21:53 -07:00
Jack Zhang
9461f2f799
docs: Update /integrations links to new pushState routes.
...
Update Email, Beanstalk, Hubot, JIRA, and Trello integrations
links.
The Hubot integrations section (/integrations#hubot-integrations)
was removed in an earlier redesign of /integrations. This commit
replaces the link with the hubot-scripts organization on
Github, which displays the comprehensive list of all integrations
available via Hubot.
Fixes #5875 .
2017-08-10 10:21:53 -07:00
Jack Zhang
a704dad06b
integrations: Replace underscores with dashes in CATEGORIES keys.
...
The CATEGORIES keys, in a similar fashion to INTEGRATIONS keys,
are utilized for links.
2017-08-10 10:21:53 -07:00
Jack Zhang
63ad7b6769
Rename /integrations/doc API endpoint as /integrations/doc-html.
2017-08-10 10:21:53 -07:00
Steve Howell
c7b9044ee5
Fix apply_unread_message_event() for mentions.
...
We were exiting this function in certain cases before updating
mentions. This bug was always there, but it was flaky in terms
of database setup whether the tests would fail, so now the
relevant test sends three consecutive messages.
We also avoid putting duplicate message ids in mentions.
2017-08-10 05:09:04 -04:00
neiljp (Neil Pilgrim)
357c9ed016
mypy: Pass empty dict to makeRecord for args, instead of None.
2017-08-09 18:04:21 -07:00
neiljp (Neil Pilgrim)
a6bb8f552b
mypy: Mark get_session_user() as returning Optional[int].
2017-08-09 18:04:21 -07:00
Tim Abbott
1d10941712
register: Don't display field to enter password unless needed.
...
This should significantly improve the user experience for new users
signing up with GitHub/Google auth. It comes complete with tests for
the various cases. Further work may be needed for LDAP to not prompt
for a password, however.
Fixes #886 .
2017-08-09 13:44:57 -07:00
Umair Khan
2c9a57161a
registration: Add test for password less remote reg.
2017-08-09 13:44:57 -07:00
Umair Khan
4a3fde023f
google: Respect is_signup argument.
...
This allows us to go to Registration form directly. This behaviour is
similar to what we follow in GitHub oAuth. Before this, in registration
flow if an account was not found, user was asked if they wanted to go to
registration flow. This confirmation behavior is followed for login
oauth path.
2017-08-09 13:44:57 -07:00
Umair Khan
5d0ac49f12
registration: Password should be required in form.
...
Password field should be optional only when password auth backend is not
enabled or when password is not required as in Google or GitHub
registration.
2017-08-09 13:44:57 -07:00
Umair Khan
bb0eb76bf3
github: Don't ask for password in registration.
2017-08-09 13:44:57 -07:00
neiljp (Neil Pilgrim)
82bac5ca11
Webhook: Remove duplicate trello code.
2017-08-08 15:55:09 -07:00
Vishnu Ks
f0bb11ef40
management: Use self.get_user in convert_bot_to_outgoing_webhook.
2017-08-08 14:13:19 -07:00
Vishnu Ks
d1bece2ec2
management: Use self.get_realm in create_stream.
2017-08-08 14:13:19 -07:00
Vishnu Ks
9fb5381acb
management: Use self.get_realm in set_default_streams.
2017-08-08 14:13:19 -07:00
Vishnu Ks
3bc475d04f
management: Use self.get_realm in rename_stream.
2017-08-08 14:13:19 -07:00
Vishnu Ks
4e7dbff197
management: Use self.get_realm in realm_filters.
2017-08-08 14:13:19 -07:00
Vishnu Ks
7859ec76cf
management: Use self.get_realm in realm_emoji.
2017-08-08 14:13:19 -07:00
Vishnu Ks
af1c1861da
management: Use self.get_realm in realm_domain.
2017-08-08 14:13:19 -07:00
Vishnu Ks
1b0b135bfc
management: Remove unused imports from process_queue.
2017-08-08 14:13:19 -07:00
Vishnu Ks
0532b35c43
management: Remove unused imports from print_email_delivery_backlog.
2017-08-08 14:13:19 -07:00
Vishnu Ks
164badde13
management: Use self.get_realm in merge_streams.
...
The variable encoding is removed becuase it is not used
anywhere.
2017-08-08 14:13:19 -07:00
Vishnu Ks
6b46762384
management: Fix typo in get_realm CommandError message.
2017-08-08 14:13:19 -07:00
Vishnu Ks
27936fcfd4
management: Remove unused imports from makemessages.
2017-08-08 14:13:19 -07:00
Vishnu Ks
cf61349563
management: Use self.get_realm in logout_all_users.
2017-08-08 14:13:19 -07:00
Vishnu Ks
e28a007487
management: Use self.get_user in knight command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
3a2edc66f1
management: Use get_system_bot in initialize_voyager_db.
2017-08-08 14:13:19 -07:00
Vishnu Ks
f45b80aafe
management: Remove unused imports from initialize_voyager.
2017-08-08 14:13:19 -07:00
Vishnu Ks
05af206392
management: Remove unused imports from import command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
f58efdc3cb
management: Remove unused imports from export_usermessage_batch.
2017-08-08 14:13:19 -07:00
Vishnu Ks
28e76c990a
management: Remove unused imports from email_mirror command.
2017-08-08 14:13:19 -07:00
Vishnu Ks
6687b236bf
management: Remove unused imports from deliver_email command.
2017-08-08 14:13:19 -07:00