Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
53,132 Commits 28 Branches 143 Tags 626 MiB
Commit Graph

124 Commits

Author SHA1 Message Date
Eeshan Garg bf175f6331 webhooks/github: Add support for PR review requests. 
Fixes: #9732.
 2018-07-01 12:40:45 -07:00
Eeshan Garg 04ed123214 webhooks/github: Be more explicit about unsupported PR events. 
This was technically a bug. For events that aren't unsupported
intentionally, the control should fall to the line that raises
UnknownWebhookEventType, and shouldn't be handled by anything else.

The events that are intentionally unsupported should be handled
more explicitly.
 2018-07-01 12:40:45 -07:00
Eeshan Garg e0ef831993 webhooks: Migrate to UnexpectedWebhookEventType. 
This improves test coverage for a lot of our webhooks that relied
on ad-hoc methods to handle unexpected event types.

Note that I have deliberately skipped github_legacy, it isn't
advertised and is officially deprecated.

Also, I have refrained from making further changes to Trello, I
believe further improvements to test coverage should be covered
in separate per-webhook commits/PRs.
 2018-05-22 08:30:19 -07:00
Aditya Bansal a40ae4cae5 zerver/webhooks: Change use of typing.Text to str. 2018-05-12 15:21:24 -07:00
Eeshan Garg 9fb9c0d901 webhooks: Migrate to validate_extract_webhook_http_header. 
This is a part of our efforts to close #6213.
 2018-05-05 15:48:38 -07:00
Eeshan Garg 19177a4aff webhooks: Move github_webhook/ to github/. 2018-04-19 11:00:55 -07:00
Eeshan Garg 48b8558c02 webhooks: Move github/ to github_legacy/ and remove docs. 2018-04-19 11:00:55 -07:00
rht 185fd99816 mypy: Use Python 3 type syntax in several files. 2017-12-30 07:34:51 -05:00
Rhea Parekh bebd8df728 zerver/webhooks/github/view: Sweep force_str. 2017-12-26 09:09:31 -05:00
Tim Abbott 73a668e7ae python: Sort imports in webhooks. 2017-11-15 15:43:10 -08:00
rht 04eaec64f0 zerver/webhooks: Text-wrap long lines exceeding 110. 2017-11-07 17:24:09 -08:00
rht 969cc506d2 zerver/webhooks: Use python 3 syntax for typing. 
Tweaked by tabbott to fix various line-wrapping issues.
 2017-11-04 19:40:32 -07:00
Eeshan Garg aaaed74c3d webhooks: Import REQ, has_request_variables from zerver.lib.request. 
We now import REQ and has_request_variables from zerver.lib.request,
which is where these methods are defined.

Fixes #7195.
 2017-11-02 14:40:55 -07:00
Steve Howell 655f37a34b Rename subject_name in send_message_backend(). 2017-10-27 10:48:11 -07:00
Tim Abbott be619fe881 lint: Wrap many very long lines in the Python codebase. 
This decreases the maximum line length in our Python codebase to 130.
 2017-10-26 17:31:58 -07:00
rht 7115a29bee zerver/webhooks: Remove absolute_import. 2017-09-27 10:00:39 -07:00
Yago González 55b4a3792d lint: Fix violation in the GitHub webhook view. 2017-05-24 22:09:14 -07:00
umkay c1a8fb615c mypy: Fix strict-optional errors in webhooks directory. 2017-05-24 18:57:06 -07:00
Eeshan Garg 7227f488c8 webhooks: Add support for a GitHub push event deleting a branch. 
Fixes: #4742.
 2017-05-16 00:11:20 -02:30
Eeshan Garg af69faafc9 webhooks: Use author's name to format Git push messages. 
We now use the name of the author of a commit as opposed to the
committer to format Git messages with multiple committers.

Part of #3968.
Follow-up to #4006.
 2017-04-26 18:26:09 -02:30
Siddharth Mahapatra e7455e276b git integrations: Expand details in commit push notifications. 
We now show a few new things:
(1) The number of commits pushed.
(2) Who authored the commits (just counts, not which specific ones, for brevity).

Add tests for case of multiple committers.

Part of #3968.
 2017-04-21 11:07:44 -07:00
Raghav Jajodia a3a03bd6a5 mypy: Added Dict, List and Set imports. 
Fixed mypy errors associated with the upgrade.
 2017-03-04 14:33:44 -08:00
Rishi Gupta 2bbfdeeb7b Fix more errors caught by mypy 0.501. 
Another set of relatively easy to review changes.
 2017-03-03 14:15:38 -08:00
Tomasz Kolek 7de45951e2 Make webhooks as separate modules with view and tests. 
Create python packege for every webhook with view.py and tests.py
 2017-01-25 23:14:19 -08:00