Ayush Jain
bddcfb1c96
Add realm-level settings to control inline image and url preview.
...
This gives users more control in case they don't want previews,
especially for the "previews of linked websites" feature.
Fixes : #2640 .
2017-03-21 15:46:17 -07:00
Cynthia Lin
589551b6ee
settings: Change "Custom alert words" to "Alert words".
2017-03-15 11:25:37 -07:00
sinwar
6f0564e9f4
python: Fix remaining bare excepts in codebase.
...
Fixes #2862 .
2017-03-05 16:17:04 -08:00
Tim Abbott
464928fdcc
bugdown: Fix mypy error with python 3 coverage.
2017-03-05 00:53:26 -08:00
Tim Abbott
ff9f827c9a
coverage: Don't require coverage in six.PY2/PY3 branches.
2017-03-04 22:51:35 -08:00
Raghav Jajodia
a3a03bd6a5
mypy: Added Dict, List and Set imports.
...
Fixed mypy errors associated with the upgrade.
2017-03-04 14:33:44 -08:00
Rishi Gupta
28d3af0965
Fix several new errors caught by mypy 0.501.
...
Clear out a bunch of easy to review errors, so we can focus on the more
complicated ones.
2017-03-03 14:12:52 -08:00
Igor Tokarev
31dff09efa
Support email changes for !avatar syntax.
...
Significantly modified by tabbott to avoid calling
get_user_profile_by_email in bugdown, and have 100% test coverage of
the views code.
Fixes #2041 .
2017-02-28 21:56:04 -08:00
Harshit Bansal
40d137d621
bugdown: Change rendered emoji image to `unicode/<codepoint>.png.`
...
Use `name_to_codepoint.json` file (and the similar structure in
emoji_codes.js) to map emoji names directly to codepoints and change
the rendered emoji image to `unicode/<codepoint.png>` rather than
`<emoji_name>.png`.
Fixes : #3539 .
2017-02-26 18:30:15 -08:00
Tim Abbott
6d00d4d2b1
mypy: Clean bugdown use of Optional.
2017-02-10 23:53:44 -08:00
Tim Abbott
e746868375
mypy: Fix optional typing usage in rendering code path.
2017-02-10 23:53:44 -08:00
Tim Abbott
4e20b622ad
bugdown: Remove unused height argument to add_a.
2017-02-10 23:53:44 -08:00
Steve Howell
6e2189f134
bugdown: Disable link previews when bots send messages.
...
We do not use `get_link_embed_data` for messsages sent by
bots, as bots often repeat the same URL over and over again
and are generally either text-focused or have their own
mechanisms to provide preview content.
Fixes #2968 .
2017-02-03 17:08:23 -08:00
Steve Howell
709493cd75
Pass in sent_by_bot flag to bugdown parser.
...
We will use this flag to suppress certain url previews
for bots.
2017-02-03 17:07:38 -08:00
Steve Howell
5b8cc03c61
bugdown: Restore data-user-email to user mention spans.
...
(The commit q7ef4e40258280e202325c9295579c93fb948b replaced
data-user-email with data-user-id, but we still need to
support data-user-email for old clients like non-updated
androids and we still want to start the migration forward
to data-user-id.)
2017-02-02 12:32:18 -08:00
Tim Abbott
4e171ce787
lint: Clean up E126 PEP-8 rule.
2017-01-23 22:06:13 -08:00
Tim Abbott
9cc83f87fc
lint: Clean up E241 PEP-8 rule.
2017-01-23 21:21:14 -08:00
Tim Abbott
6f0d2a9445
lint: Clean up E115 PEP-8 rule.
2017-01-23 20:55:37 -08:00
Steve Howell
1137ef4e40
Mark up mention buttons with data-user-id on the backend.
...
We use data-user-id now in the buttons for at-mentions when
we render messages. A previous commit already made the front
end support this new style.
2017-01-21 21:45:12 -08:00
Tim Abbott
5d52f1ec17
bugdown: Move realm_filters_key logic out of callers.
...
This gets rid of the confusing duplicate realm_filters_key and
message_realm arguments that previously were passed to bugdown.
2017-01-21 21:37:57 -08:00
Sampriti Panda
34a4a1378d
bugdown: Use specified realm, not sender realm, for rendering.
...
This changes bugdown to use the realm passed in by the caller (if any)
for rendering, fixing a problem where bots such as the notification
bot would have their messages rendering using the admin realm's
settings, not the settings of the realm their messages are being sent
into.
Also adds a test for the notification bot case.
Fixes #3215 .
2017-01-21 21:37:57 -08:00
Tim Abbott
99c5563bc6
internal_send_message: Make realm argument mandatory.
...
A lot of care has been taken to ensure we're using the realm that the
message is being sent into, not the realm of the sender, to correctly
handle the logic for cross-realm bot users such as the notifications
bot.
2017-01-21 21:37:30 -08:00
Tim Abbott
19b89eb050
bugdown: Rename realm_id to realm_filters_key.
...
This should substantially improve the clarity of the code, since
inside bugdown, this is only being used as a hash key that happens to
usually be a realm ID, not used as a Realm ID.
2017-01-16 21:48:55 -08:00
Tim Abbott
3f8d4193da
lint: Fix % comprehensions being used without a tuple.
2017-01-09 11:45:11 -08:00
Brock Whittaker
b976e179e6
css: Restyle Open-Graph Links.
...
This styles open-graph links to be cleaner and smaller.
2017-01-05 16:15:01 -08:00
Rishi Gupta
caccf8ee17
Remove models.get_realm(domain).
2017-01-03 16:46:15 -08:00
Rishi Gupta
c6e12e74be
Change domain to realm_id in bugdown and realm filter dicts and caches.
2017-01-03 16:25:20 -08:00
Tim Abbott
b36e94c954
bugdown: Blacklist linkifying the .md TLD.
...
Fixes #2065 .
2016-12-29 18:17:50 -08:00
Tim Abbott
39f0ffdedd
Move static/third/gemoji to static/generated/emoji.
...
Fixes #1153 .
2016-12-27 20:16:23 -08:00
Robert Hönig
0917493588
mypy: Convert zerver/lib to use typing.Text.
2016-12-25 10:33:45 -08:00
reallyly
94b28e0afb
pep8: Fix E128 violations.
...
With some line-wrapping tweaks by tabbott.
2016-12-13 10:50:14 -08:00
Igor Tokarev
fae59502ab
URL preview: Improve test coverage.
2016-12-13 10:43:02 -08:00
Igor Tokarev
c93f1d4eda
Add oembed/Open Graph/Meta tags data retrieval from inline links.
...
This change adds support for displaying inline open graph previews for
links posted into Zulip.
It is designed to interact correctly with message editing.
This adds the new settings.INLINE_URL_EMBED_PREVIEW setting to control
whether this feature is enabled.
By default, this setting is currently disabled, so that we can burn it
in for a bit before it impacts users more broadly.
Eventually, we may want to make this manageable via a (set of?)
per-realm settings. E.g. I can imagine a realm wanting to be able to
enable/disable it for certain URLs.
2016-12-07 17:40:18 -08:00
Mikebarson
690d72d35f
mypy: Convert more zerver/lib files to typing.Text.
...
This commit touches files in zerver/lib/bugdown/ and
zerver/lib/webhooks.
2016-12-05 21:17:24 -08:00
bulat22101
a6f91064a2
pep8: Fix E129 violations
2016-12-03 10:56:36 -08:00
Sidhant Bhavnani
8c0c12c1d9
pep8: Fix E303 violations.
2016-12-02 15:34:11 -08:00
Alex Huang
007b693cc7
pep8: Fix E131.
2016-12-01 23:16:47 -08:00
AZtheAsian
c23f9e0df7
pep8: Fix E111 violations
2016-12-01 14:18:11 -08:00
Rafid Aslam
c5316b4002
lint: Fix E127 pep8 violations.
...
Fix pep8: E127 continuation line over-indented for visual indent
style issue.
2016-12-01 10:23:55 -08:00
Bickio
6b0df43463
pep8: Fix E125.
2016-11-30 20:03:29 -08:00
Rafid Aslam
41bd88d5ed
pep8: Fix E301 pep8 violations.
...
Fix "E301: expected (1 or 2) blank line" pep8 violations.
2016-11-29 08:51:44 -08:00
Rafid Aslam
7a2282986a
pep8: Fix E225 pep8 violations.
2016-11-28 15:21:15 -08:00
Anders Kaseorg
573ec14955
Remove shebang line from non-scripts
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2016-11-26 13:20:22 -08:00
Vladislav Manchev
d7e1e4a2c0
Add initial implementation of custom realm filters.
...
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.
Fixes #544 .
2016-11-17 17:11:25 -08:00
hackerkid
cdb716aa63
bugdown: Add explanation for unicode-emoji JS regex.
2016-11-17 10:44:07 -08:00
Umair Khan
29254142f6
Django 1.10: Run maybe_update_realm_filter when it's needed.
2016-11-15 09:34:08 -08:00
hackerkid
67120d7a9d
Support backend unicode-emoji rendering without whitespace.
2016-11-14 21:02:18 -08:00
hackerkid
8c83b34ad5
Support backend emoji rendering without whitespace.
2016-11-11 16:18:57 -08:00
Igor Tokarev
852bc6b491
bugdown: Re-enable support for italics in bugdown.
...
Fixes : #1103 .
2016-11-10 19:14:40 -08:00
Meena Rajan
30acb23314
bugdown: Add support for strikethrough in markdown processor.
...
[Tweaked to move tests to bugdown_data.json, add additional tests, and
add frontend processor support by tabbott]
2016-11-07 22:26:38 -08:00