Aman Agrawal
d54a917104
modals: Rename is_modal_open to is_open.
2023-10-10 16:43:57 -07:00
Aman Agrawal
577a384845
overlays: Extract modal methods in separate file.
2023-10-10 16:43:57 -07:00
Aman Agrawal
6713ad9d4d
overlays: Extract function checking if overlays or modals are open.
2023-10-10 16:43:57 -07:00
Anders Kaseorg
3cac29a8e1
settings_org: Extract settings_components module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 17:26:49 -07:00
Anders Kaseorg
835ee69c80
docs: Fix grammar errors found by mwic.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 13:24:09 -07:00
Anders Kaseorg
7b4a74cc4d
codespell: Fix typos caught by codespell.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 11:55:15 -07:00
Karl Stolley
eea59e2edc
compose_banners: Hide upload progress banner on error.
2023-10-09 11:55:01 -07:00
Prakhar Pratyush
5b7014e7d6
server_history: Prevent concurrent requests for the same stream_id.
...
This commit updates the 'get_server_history' function to return
early if a request is already in progress for a given stream_id,
thus preventing concurrent requests for a single stream_id.
We maintain a set 'request_pending_stream_ids', which contains all
the stream IDs for whom requests are in progress.
Using this set, we return early.
Fixes #26915 .
2023-10-09 11:17:03 -07:00
N-Shar-ma
0cdb54cf65
compose: Ensure cursor is scrolled into view after content is inserted.
...
This fixes the bug where on pressing enter after the last line in a
textarea, the cursor would go to the new line but the textarea would
not scroll it into view unless more was typed. This was observed on
chromium browsers.
A new function `insert_and_scroll_into_view` is added to `compose_ui.js`
which blurs and refocuses the textarea after inserting the content, then
autosizes the textarea.
2023-10-09 11:13:53 -07:00
Anders Kaseorg
5327bcc5ac
user_group_settings_ui: Merge into user_group_edit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 10:58:50 -07:00
Anders Kaseorg
63b4e74cea
views_util: Cut import of narrow.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-09 10:54:00 -07:00
Anders Kaseorg
564e91f3a8
narrow: Cut import of hashchange.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 19:41:59 -07:00
Anders Kaseorg
ba1895cb1c
notifications: Rename to desktop_notifications.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
Anders Kaseorg
fcaf1fe7d5
notifications: Split out audible_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
Anders Kaseorg
6ef08873d8
notifications: Split out compose_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
Anders Kaseorg
db20fd12e0
notifications: Split out message_notifications module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 16:22:40 -07:00
Anders Kaseorg
e48771993b
widgetize: Move widget registration to new widgets module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
Anders Kaseorg
0c991d813f
sent_messages: Lift event loop restarting to transmit.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 13:17:51 -07:00
Prakhar Pratyush
b274169ccc
util: Fix the 'find_wildcard_mentions' function.
...
The function considers @**all**, @**everyone**, @**stream**,
and @**topic** as wildcard mentions.
Earlier, the function didn't have a check to match @**topic**
in the message_content.
2023-10-06 11:38:37 -07:00
Anders Kaseorg
971a003180
compose_actions: Extract compose_reply module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 09:07:43 -07:00
Aman Agrawal
3cbfe6f31f
tests: Remove unnecessary mocks of recent_view_util.
...
Since is_visible was refactored to use a variable, these mocks
are not required.
Also, since is_visible return `false` by default, mocking it
to return false is not required.
2023-10-06 08:35:21 -07:00
Anders Kaseorg
c56f784489
compose: Move update_email to compose_state.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:34:39 -07:00
Anders Kaseorg
c4d338a6ab
drafts: Extract drafts_overlay_ui module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-06 08:30:31 -07:00
Anders Kaseorg
d5064fc7b2
narrow: Extract narrow_title module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 16:26:45 -07:00
Anders Kaseorg
dd584ba8a9
stream_settings_ui: Move set_color to stream_settings_api.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 15:32:04 -07:00
Anders Kaseorg
e8a2a5ce36
compose: Move initialize to new compose_setup module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 14:42:19 -07:00
Tim Abbott
3d804ef186
pm_list: Rename handle_narrow_deactivated.
...
It did the same thing as handle_narrow_activated when passed the
home_msg_list filter.
We still leave a renamed version for use by the inbox/recent views.
2023-10-05 10:31:23 -07:00
Tim Abbott
0a189119aa
stream_list: Rename handle_narrow_deactivated.
...
It did the same thing as handle_narrow_activated when passed the
home_msg_list filter.
We still leave a renamed version for use by the inbox/recent views.
2023-10-05 10:31:23 -07:00
Tim Abbott
20b2323c67
left_sidebar: Deduplicate handle_narrow_deactivated.
...
handle_narrow_activated did the same thing is passed the home_msg_list
filter.
2023-10-05 10:31:23 -07:00
Tim Abbott
246139e1d0
narrow: Extract handle_post_view_change.
2023-10-05 10:31:23 -07:00
Tim Abbott
62fe1dcad1
narrow: Simplify compute_narrow_title for All messages.
...
filter.get_title() already returns "All messages" for the filter we
now pass in, which is the "in:home" operator defined by that view.
2023-10-05 10:31:23 -07:00
Tim Abbott
ab15462669
hashchange: Remove duplicate handle_narrow_deactivated call.
...
narrow.deactivate calls this directly.
2023-10-05 10:31:23 -07:00
Sahil Batra
8710feb5dd
billing: Update modal shown on license increase to use micromodal.
...
We now use micromodal in the license update modal on billing page
to make it consistent with other modals in the app and this is
preparatory work for moving away from bootstrap as well.
2023-10-05 09:28:27 -07:00
Anders Kaseorg
13d1241eed
activity: Extract new activity_ui module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 08:27:30 -07:00
Anders Kaseorg
4ec78ee2d4
compose_recipient: Move selected_recipient_id to compose_state.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-05 08:21:33 -07:00
Aman Agrawal
75826d8409
handlebars: Move popover handlebars to a new popovers folder.
...
Organize related handlebars in a new folder together.
2023-10-05 08:19:49 -07:00
Aman Agrawal
acd584c336
actions_popover: Rename template to remove `_content`.
2023-10-05 08:19:49 -07:00
Anders Kaseorg
d17c0dabc8
stream_data: Move stream_*_policy_values to settings_config.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 16:35:24 -07:00
Anders Kaseorg
0f0fd3f07d
tests: Remove sub_store mock from recent_view test.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-04 16:35:24 -07:00
Aman Agrawal
2ec8273c6e
left_sidebar: Move all messages popover to inbox.
...
Also, renamed files and variables as needed.
2023-10-04 13:10:08 -07:00
Prakhar Pratyush
28fb5ea24d
settings: Add UI for automatically follow and unmute topics settings.
...
This commit adds two drop-down settings in 'SETTINGS / NOTIFICATIONS'
and 'SETTINGS / DEFAULT USER SETTINGS'.
The new settings lie in a new section named "Topic notifications",
just below the "Noification triggers" section.
Label: "Automatically follow topics"
Options: "Topics I participate in", "Topics I send a message to",
"Topics I start", and "Never".
Label: "Automatically unmute topics in muted streams"
Options: "Topics I participate in", "Topics I send a message to",
"Topics I start", and "Never".
Fixes #25914 .
2023-10-04 13:04:29 -07:00
Anders Kaseorg
b50e500dae
scheduled_messages: Move update_send_later_options.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 17:56:43 -07:00
Anders Kaseorg
fb19476c4e
compose: Move uppy to upload module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 14:50:02 -07:00
Anders Kaseorg
9b6301c755
upload: Don’t leak an extra body event handler for each edited message.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 14:10:15 -07:00
Anders Kaseorg
16e2a32c4c
popover_menus: Extract message_actions_popover module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 11:58:29 -07:00
Lauryn Menard
ca5d1c1265
tests: Update events and schemas for scheduled message events.
...
Updates the testing for scheduled message event schemas to be fully
checked by `zerver/tests/test_events.py` and `tools/check-schema`.
Adds the missing 'failed' field to the scheduled message events
in `web/tests/lib/events.js` as well.
2023-10-03 09:05:22 -07:00
Aman Agrawal
d3588c7559
activity: Hide right sidebar when narrowing to a user via enter press.
...
Fixes #26989
2023-10-03 08:17:06 -07:00
Anders Kaseorg
5efbece30a
stream_color: Extract update_stream_color to new module.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2023-10-03 08:15:21 -07:00
Aman Agrawal
b443916da1
lightbox: Replace image with media.
...
Since lightbox can also play videos now, replace image with media.
2023-10-02 22:39:02 -07:00
Aman Agrawal
3a507b5752
lightbox: Add support for playing video.
2023-10-02 22:39:02 -07:00