Commit Graph

2 Commits

Author SHA1 Message Date
Alex Vandiver 84be0a300b audio: Re-convert ding.mp3 from original source.
Similar to zulip.mp3 in the previous commit, this file is corrupted
and only playable in some browsers.

Re-download it from the source[^1], and convert it to MP3 via
`ffmpeg`.

[^1]: https://freesound.org/people/InspectorJ/sounds/411089/ per docs/THIRDPARTY
2024-08-12 12:55:55 -07:00
Marco Burstein ba46dc83c6 notifications: Add a setting for changing the notification sound.
Also, add a new notification sound, "ding". It comes from
https://freesound.org, where the original Zulip notification sound comes
from as well. In the future, new sounds can be added by adding audio
files to the `static/audio/notification_sounds` directory.

Tweaked significantly by tabbott:
* Avoided removing static/audio/zulip.ogg, because that file is
  checked for by old versions of the desktop app.
* Added a views check for the sound being valid + tests.
* Added additional tests.
* Restructured the test_events test to be cleaner.
* Removed check_bool_or_string.
* Increased max length of notification_sound.
* Provide available_notification_sounds in events data set if global
  notifications settings are requested.

Fixes #8051.
2018-12-09 21:25:30 -08:00