Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
61,671 Commits 28 Branches 142 Tags 695 MiB
Commit Graph

6 Commits

Author SHA1 Message Date
Alex Vandiver 84be0a300b audio: Re-convert ding.mp3 from original source. 
Similar to zulip.mp3 in the previous commit, this file is corrupted
and only playable in some browsers.

Re-download it from the source[^1], and convert it to MP3 via
`ffmpeg`.

[^1]: https://freesound.org/people/InspectorJ/sounds/411089/ per docs/THIRDPARTY
 2024-08-12 12:55:55 -07:00
Alex Vandiver 9e2db6047f audio: Restore un-corrupted zulip.mp3 file. 
This file's bytes changed in ba46dc83c6, corrupted by some unknown
process; its bytes begin:
```
00000000: efbf bdef bfbd efbf bd64 0000 0000 0000  .........d......
00000010: 0000 0000 0000 0000 0000 0000 0000 0000  ................
00000020: 0000 0000 0000 0000 0000 496e 666f 0000  ..........Info..
00000030: 000f 0000 000f 0000 1a1e 0011 1111 1111  ................
00000040: 1122 2222 2222 2222 3333 3333 3333 4444  ."""""""333333DD
00000050: 4444 4444 4455 5555 5555 5555 6666 6666  DDDDDUUUUUUUffff
00000060: 6666 7777 7777 7777 77ef bfbd efbf bdef  ffwwwwwww.......
00000070: bfbd efbf bdef bfbd efbf bdef bfbd efbf  ................
00000080: bdef bfbd efbf bdef bfbd efbf bdef bfbd  ................
00000090: efbf bdef bfbd efbf bdef bfbd efbf bdef  ................
```

This is not an MP3 file (which should begin with the bytes `fffb`) nor
an MP3 encapsulated in ID3 (which would begin `4944 33`).  This left
it playable by some browsers, but not others like Safari.

Restore the version from before ba46dc83c6, which is universally
recognized as an MP3 file.
 2024-08-12 12:55:55 -07:00
Greg Price 56b6b71236 notification_sounds: Add "Chime", the new Zulip sound used on Android 
This is the same sound that since zulip/zulip-mobile#5221 has been
the default notification sound for Zulip on Android.

The actual sound was created by Anders.

Co-authored-by: Anders Kaseorg <anders@zulip.com>
 2022-03-28 12:56:54 -07:00
Aman Agrawal 93889d9690 notificaiton_sounds: Add some atonal sounds created by @stwime. 
Removed underscore from names.
 2021-02-05 12:28:20 -08:00
Aman Agrawal 8baade439d notification_sounds: Add sounds created by @stwime. 
These are all good notification sounds that may fit taste of
different users.
 2021-02-05 12:28:20 -08:00
Marco Burstein ba46dc83c6 notifications: Add a setting for changing the notification sound. 
Also, add a new notification sound, "ding". It comes from
https://freesound.org, where the original Zulip notification sound comes
from as well. In the future, new sounds can be added by adding audio
files to the `static/audio/notification_sounds` directory.

Tweaked significantly by tabbott:
* Avoided removing static/audio/zulip.ogg, because that file is
  checked for by old versions of the desktop app.
* Added a views check for the sound being valid + tests.
* Added additional tests.
* Restructured the test_events test to be cleaner.
* Removed check_bool_or_string.
* Increased max length of notification_sound.
* Provide available_notification_sounds in events data set if global
  notifications settings are requested.

Fixes #8051.
 2018-12-09 21:25:30 -08:00