5bcc403ea4
Add filter tests for is:alerted predicate
...
(imported from commit 077fdab5437f498f015da7ed81a77036c9ff6361)
2013-09-10 13:13:18 -04:00
a33957db32
Handle mailchimp error 214 (duplicate email) in signup worker
...
(imported from commit cb34c153fc96bca7c8faed01d019aa2433fcf568)
2013-09-09 10:57:09 -04:00
b8dc9cc198
Send you the subscribers list when you add a subscription
...
(imported from commit 810de1f03c6765ef1c5476df30aff4c467783cab)
2013-09-06 23:13:47 -04:00
17cad06a2d
Add Dict.from_array()
...
(imported from commit 0650edb2217afa2c37be1bbc4f9e2ac40f4c0e2c)
2013-09-06 23:13:47 -04:00
f9cfa6b5f7
Include subscriber list in page_params.stream_list
...
(imported from commit 7f03eec37c7cbdcdefb590c39a76444bd1b55230)
2013-09-06 23:13:47 -04:00
c46007e08e
When a user subscribes to a stream, notify other stream subscribers
...
This is a backend-only change. No frontend code that uses this is
included.
(imported from commit 4bc379de3bbfc0975ff939fa5895d716a4d1ff1b)
2013-09-06 23:13:47 -04:00
65ed20469e
Split out get_subscribers method on backend
...
(imported from commit b5941ff90bbf5b31a9fa31aa83e5d1856d483dcc)
2013-09-06 23:13:47 -04:00
1c2479c807
Fix overly-tight coupling in set_stream_color test
...
The test will fail if a new attribute is added to the structure that
gather_subscriptions() returns. It should only be concerned with the
subscription's color.
(imported from commit fd5bad97bbce2544e0078ee029f54d4e45da9c15)
2013-09-06 23:13:47 -04:00
cf59f07fed
Replace alert_words as event contains full list
...
(imported from commit 489975f8bcbd0c3bcec07dd5ed62de5cae686140)
2013-09-06 16:05:08 -04:00
a67d461139
Hoist joining of message content in alert_words processor
...
(imported from commit 5025b7108839ddc04d6d9e575a9a288223526fe8)
2013-09-06 16:05:08 -04:00
7d76c47321
Re-enable alert word bugdown processor for staging
...
(imported from commit a9fb8284a47d18b97b84d3ce37482132b21d3885)
2013-09-06 14:51:40 -04:00
8ad6a0daa9
Cache realm alert_words to avoid database hits when rendering
...
We found that since bugdown processes are threaded, the cost of
doing a db query in a markdown processor is quite high---each
thread must start up a new db connection including a SSL handshake
etc. We should strive to keep our rendering pipeline free of mandatory
DB queries.
(imported from commit 555066bd03da6c681b74ce6137acc264eb41c55d)
2013-09-06 14:50:25 -04:00
7b375634f9
Temporarily disable alert_words markdown processor on staging
...
(imported from commit ab3eed4ce36ebcd3d928d2d92fc34c9ebacc11f9)
2013-09-06 13:39:26 -04:00
252045fe2e
Fix assignee in JIRA created message
...
(imported from commit 5ebadd14dee58c20746c80dfd99ba70a3d772ab6)
2013-09-06 11:24:03 -04:00
cf3e98d74a
use staging for wdaher.com for the email script
...
(imported from commit fbad47386f5c48785f766886218370612db31c26)
2013-09-05 19:19:41 -04:00
592e1ead6b
Actually use the realm specified by the email mirror when doing the markdown
...
(imported from commit 00b909b1d0c70a3523ab53d2f91815ab14ba2a6f)
2013-09-05 18:24:55 -04:00
cb78014eef
bugdown: Allow block-level block quotes
...
It is triggered by specifying the "language" of a code block to
"quote" or "quoted":
Hamlet said:
~~~ quote
To be or **not** to be.
That is the question
~~~
(imported from commit 847a0602e335e9f2955e32d9955adf8ac8de068c)
2013-09-05 17:34:28 -04:00
dd26260884
bugdown: Clarify variable name
...
(imported from commit 27968536bd6a3fcda6d26d8dde7f82d9f0990dd2)
2013-09-05 17:34:28 -04:00
b3644ecfad
Fix attribution of Github issues messages
...
(imported from commit 941e52e51dfd9fddfe4f86bb33f25877d6d0edbd)
2013-09-05 16:04:59 -04:00
2f1551e745
Replace comment references to trac.humbughq.com with trac.zulip.net
...
(imported from commit 231d0884345be525d58ce51f48a76bba6960f09d)
2013-09-05 15:43:08 -04:00
5c81148839
Switch our trac realm filter to use trac.zulip.net
...
(imported from commit 19163f5be01a1d9370d9ed45c55bedd670772dac)
2013-09-05 15:43:07 -04:00
e58e6f1b7d
Check admin permissions on the target realm, not on their own realm.
...
Trac #1772
Also abstracts this into a method.
(imported from commit f435b3379fb5387f8b3fdf7ca728ab760eadbf95)
2013-09-05 15:36:59 -04:00
ce710292ca
Always use external-content.zulipcdn.net for mit.edu realm.
...
(imported from commit 21d1101185bf52f21fcc345e791217311e9c0a13)
2013-09-05 14:35:42 -04:00
b557b94d0b
bugdown: Rewrite image urls to avoid mixed-content warnings.
...
(imported from commit fc0a41befb04f2a8aad2937a856366ac3cadb192)
2013-09-05 14:35:29 -04:00
cdfc6dc10a
bugdown: Fetch youtube preview images over HTTPS.
...
(imported from commit 9dbf3c21083cbbcf1288789f400c33ec735d4416)
2013-09-05 14:35:29 -04:00
3f1c967e3d
Clean up approximate_unread_count.
...
The new version is more accurate (doesn't rely on UserMessage IDs
being sorted, which they aren't necessarily) and simpler.
(imported from commit 671dd89dc8881ae2dcb8d0e804fd65458e074a29)
2013-09-05 14:35:29 -04:00
663fd4653f
Feature-flag alert words to staging + reddit
...
(imported from commit 1fe9c596b26ce6676514719e4ed2e185108685cb)
2013-09-05 10:21:39 -04:00
41b286232d
Allow filtering to alerted messages with is:alerted
...
(imported from commit 99834f1ee1b9b2e0f5c7427afa1494bf404e3626)
2013-09-05 10:18:41 -04:00
897dd87b94
Add a span around alert words to mark them visually
...
(imported from commit 9b8fbbd957086f1eeaa3409e5830aa6d7974fbe8)
2013-09-05 10:18:40 -04:00
b2ddd670e4
[schema] Add backend support for per-user alert words
...
(imported from commit 7a9c596a010cbedbddf594c5d9c68bb9ed46d122)
2013-09-05 10:18:40 -04:00
6b820038ad
Server side tests for message editing, including subject propagation.
...
(imported from commit 0a68bdc337eda1b04976fb41a50a29f9f626ef25)
2013-09-04 14:51:46 -04:00
19a835e7d5
Add a checkbox that propagates topic edits to subsequent messages.
...
Trac #1348
(imported from commit 28e2a8cb3ecda5ec50d17501f4ccbd8644212065)
2013-09-04 14:51:46 -04:00
6adfed7f3d
Add backend support for basic Desk.com webhook
...
(imported from commit 425a26b2ba5ffd4f4437e8d8438e8ef540d7b1ee)
2013-09-04 13:19:23 -04:00
a213fb5df2
Comment that authenticated_rest_api_view does Basic auth
...
(imported from commit 145ea6b0a17ab904c32e23e809410f56448baa72)
2013-09-04 13:19:22 -04:00
7e6af0a5d0
Mark messages from the desktop app as sent_by_human
...
(imported from commit 001073221387cbbaa541b17f9a377490562a28f1)
2013-09-04 11:00:11 -04:00
085fdebc98
Use the X-Gm-Original-To header instead of iterating through To/Cc/Bcc
...
This will allow mail with an implicit destination (mailing lists, complex
forwarding) to be received by our system.
See http://support.google.com/a/bin/answer.py?hl=en&answer=2368151 for
documentation of Google's behaviour that adds this header.
(imported from commit f8fd500e3c27e12af5941c63c91d5c796a2cd24a)
2013-09-03 17:46:44 -04:00
eeb04ed78e
deactivate_user: Only delete sessions that aren't expired.
...
(imported from commit e3d844a55581a7e7faab8ea9ed6703480fae8f51)
2013-09-03 11:40:42 -04:00
be5c90c217
Add test for realm-specific emoji
...
(imported from commit 2148038b300b71afe0a7517709ed0404536b69fd)
2013-09-03 11:01:01 -04:00
549c644480
Move webhooks views to a separate file
...
(imported from commit 73db9f5ccc03d19024f35001b0805ca17eeadff7)
2013-08-30 10:18:49 -04:00
6eea2d7988
Rename views.py to views/__init__.py
...
(imported from commit 6d2fc769b3997f8ae9aea1119ebe1c27872baf42)
2013-08-30 10:18:49 -04:00
acdfb6afa0
email mirror: make being one of many recipients okay.
...
Previously the email gateway had to be the only address in a recipient
field or we'd mis-parse the recipient.
This commit also makes the mirror correctly handle addresses of the
form "Jessica McKellar <jesstess@zulip.com>".
(imported from commit 7435f2b59b8f47dc599cc869f64597a730af7d12)
2013-08-29 18:13:21 -04:00
c4157ed2b6
Make email mirror testing easier by using a different mailbox locally.
...
The mirror will use INBOX when deployed and Test locally. Send an
e-mail to the Test mailbox by including the word "localhost" in the
subject; a GMail filter will place it in Test on receipt.
(imported from commit bacf9a9554c8c5e1f3ec8497761edf2c15d3745d)
2013-08-29 18:13:21 -04:00
c94ba52d3a
Backend support for "announce stream"
...
(imported from commit dab3206a973083c3cee8225fa9ca71f4eecc269f)
2013-08-29 10:32:32 -04:00
e3247de572
Factor out get_active_user_profiles_by_realm()
...
(imported from commit 634ebf265b02303a938f7595de3622e25bc22b49)
2013-08-29 10:28:20 -04:00
09ff770435
Make invite-only stream invite notifications less confusing
...
Previously, when added to an invite-only stream, you got notifications
like this:
Hi there! We thought you'd like to know that Some Person just subscribed
you to the invite-only stream 'Secret stuff'
You can see historical content on a non-invite-only stream by narrowing
to it.
Note that the second line is irrelevant and confusing in light of the
first!
This commit leaves this out, and also, to make sure I didn't mess
anything up (and because I needed to change the tests anyway), adds a
test for invite-only stream notifications.
(imported from commit 49c333629c78fc06f6d2f1ec8a627c6d38e7716a)
2013-08-29 10:27:34 -04:00
ac1f9b5128
check_message: Allow zephyr mirroring bot to send to invite-only streams.
...
(imported from commit d45c75915cc4e29328768f1ed0e0ec972e5b7269)
2013-08-28 19:07:05 -04:00
5b62101a5f
check_message: Clean up confusing and redundant authorization checks.
...
(imported from commit 1b756c89ec740f988e8f15d21fb413de9947d658)
2013-08-28 19:07:05 -04:00
371654adb3
zephyr_mirror: Make Webathena work for golem.
...
(imported from commit 6f8bf1f44c521b22c9fc990711d2821e5a60761d)
2013-08-28 18:56:54 -04:00
591b42bb1c
bugdown: Clarify code around inline_interesting_links processor.
...
(imported from commit a1d734230135ab9099fafea7814bfec25754ea4e)
2013-08-28 18:56:53 -04:00
1e88bb914e
Add test_private_suggestions() to search_suggestion.js
...
(imported from commit db89f8574a4f7e169e66ebaff3a9c2cd49a4b0dc)
2013-08-28 17:41:17 -04:00
8363b7c59a
Add test_subset_suggestions() to search_suggestion.js
...
(imported from commit db9173ffa92ca225baf24a1103807034e4f31a7f)
2013-08-28 17:41:16 -04:00
cf0f205f75
tests: check that non-subscribers can't send messages to an invite-only stream.
...
(imported from commit 5ee0fb49e994c4d283348d89a25606ca6d314005)
2013-08-28 16:43:40 -04:00
2cc06aafe1
tests: don't skip message sending restriction checks!
...
We were using the internal do_send_message, which does not do any
security checks.
(imported from commit 14a31a39a392dd2bc6b79f4345aa80217d5356f2)
2013-08-28 16:43:40 -04:00
f67f5b7619
Allow superusers to send messages to even private streams.
...
(imported from commit b7253174fa25d61b5bda056a5e5353e3b8ea918b)
2013-08-28 16:43:40 -04:00
d72ed33dc6
Be more verbose and explicit in the checks on who can send a message.
...
It was getting hard to follow and is going to get more complicated
with a new super user check in a later commit.
(imported from commit 8d5cfa960824519d87ce0f09aab3a120ba9ef357)
2013-08-28 16:43:40 -04:00
5b598a6d9c
Avoid churning the cache for stream name changes that don't change the cache key.
...
(imported from commit 1cc1ed01eaaaec4e6ddd6901fb5b877f831b604c)
2013-08-28 13:34:26 -04:00
6aecdda7f7
Allow stream renames like corporate -> Corporate
...
(imported from commit 46d5078fb700631ef2a5b847eeeb055ff75d87d1)
2013-08-28 13:34:25 -04:00
857680102f
Remove enforce_arity checks from Dict
...
(imported from commit 8fdb6d8807e5c16349c7fcf71f25ce73348a5fe1)
2013-08-28 12:29:11 -04:00
b27f27f932
node tests: add some asserts for stream_data.delete_sub.
...
(imported from commit 3428f32206105b240e230e1050e7c16cd9c3729c)
2013-08-28 10:24:52 -04:00
2be988e6b7
Give recipient_cache and associated functions a clearer name.
...
(imported from commit 14b12b196e33dfc4eeca5ab0f12c130ddaef1065)
2013-08-28 10:23:40 -04:00
95c70967d2
rename-stream: support non-ASCII stream names.
...
(imported from commit 5fe2c803c0645bb6367f39bfe58acc478a66a0eb)
2013-08-28 10:23:39 -04:00
8f3c5dc924
Add a management command to rename a stream.
...
(imported from commit b3acadc09b289b48e2ac298e50a5427545b6a473)
2013-08-28 10:23:39 -04:00
97f0320dd1
Add the backend facilities for renaming a stream.
...
An important part of this is updating the various caches that cache
the display_recipient.
(imported from commit 888bf54fd205516cf31a25ba3f4e45ad11bbd4d5)
2013-08-28 10:23:39 -04:00
c1439c8853
actions: factor stream name checks into a function.
...
(imported from commit e107e895f247f6bfafe2c21de12d8a3c5de9268a)
2013-08-28 10:23:39 -04:00
1f4f799030
Flush the per-process recipient cache after every request.
...
This cache was created to make recipient lookups within a single
request (e.g. when fetching old messages) cheaper. To support stream
name changes, we need to invalidate this cache on every request so
that users get a consistent view of the name change.
(imported from commit 801051b9f6a108c1f50be7eca9a1242d661919b1)
2013-08-28 10:23:39 -04:00
cd4daaa41f
Factor the display_recipient cache key into a function.
...
(imported from commit 4a80c4db6ddcf8104f45b6b068e598378e655bc0)
2013-08-28 10:23:37 -04:00
d64c09b1ed
Add a cache_delete for deletion of items from memcached.
...
(imported from commit 4fbdc4c4b230a5ab029dacc2463437f81fb0d023)
2013-08-28 10:23:04 -04:00
21d857e577
Add a cache_delete_many for bulk deletion of items from memcached.
...
(imported from commit 33fc65dce89e51b99f13b50216d975272a028c16)
2013-08-28 10:23:03 -04:00
2dbe6914d9
Factor out finding active user IDs to a function.
...
(imported from commit c2d25b24833be900af40d45331e4b9eb9e3a2dc6)
2013-08-28 10:23:03 -04:00
648e85160d
Fix buggy application of subscription update events.
...
(imported from commit 4c76dc3ee5d3d1a298591c0c60dbe0e3aa30e0af)
2013-08-27 19:12:20 -04:00
77dbbe7f23
zephyr_mirror: Require zcrypt when mirroring to invite-only streams.
...
(imported from commit 1b88a8fc9bc26f2f9b1bb3f037093f85255feb17)
2013-08-27 18:26:12 -04:00
e95a81addb
Add Webathena login button to our mirroring page.
...
(imported from commit 43d8323bb502299027436a8c94c04f55d87bf953)
2013-08-27 15:41:43 -04:00
667372068c
Add idempotency test coverage for muting.js
...
(imported from commit 50496866fa11df433150ff28f0f1e58e9e8b33bc)
2013-08-27 15:40:54 -04:00
9f054eb15f
Add a detailed docstring to rest_dispatch()
...
(imported from commit 6ff92e71e995e544c19828258a11d97e68294e3a)
2013-08-27 14:27:28 -04:00
f225c467b0
Strip whitespace from email/key during API auth
...
Trac #1681
(imported from commit 4c97bfea052d2da7673ba5a9520f7ddc7515d975)
2013-08-27 14:27:28 -04:00
141877a06c
Give a helpful error if API key is wrong length
...
Trac #1680
(imported from commit 0a50e7a93b37a5a3e74fb99c97a8917d8fbcc8f9)
2013-08-27 14:27:28 -04:00
2bb6f45af2
Add a data-name attribute to stream elements in the stream list and modify the test accordingly
...
(imported from commit 24791703015a47ae89fdf628d6511736b9d0f026)
2013-08-27 09:44:57 -07:00
134da30fdf
Add webathena authentication button for Zephyr users.
...
This shows up when you're not running a Zephyr mirroring bot and lets
you use Webathena to have us run it. Obviously needs more docs.
Current problems include:
* supervisorctl reload ends up recreating /var/run/supervisor.sock
with the wrong permissions, so it only works once in a row before
you need to chmod that.
* /etc/supervisor/conf.d needs to be humbug-writeable; this is a clear
local root vulnerability
* This uses SSH and thus is kinda slow.
(imported from commit 7029979615ffd50b10f126ce2cf9a85a5eefd7a2)
2013-08-26 18:17:25 -04:00
44ecd09ac7
Simplify Github event capture condition and improve error handling
...
Attempted captures are causing errors and I'm not sure why.
(imported from commit ecf7a711fc13f2c8e036a0ebf6db6c2cd566109b)
2013-08-26 15:37:37 -04:00
0856274fd2
Change empty messages to '(deleted)'
...
Before this it was [deleted]. Using parens is consistent with how we put
in (no topic) if you don't specify a topic.
(imported from commit 931c06a1096cf7b0d226336cbe82535abd2e6032)
2013-08-26 14:13:42 -04:00
a2bf6c3dd7
Test stream_data.in_home_view()
...
(imported from commit 29f1a187000e1818797c1a4781afaabca0ed29de)
2013-08-26 13:59:33 -04:00
b486f06e71
Test stream_data.get_invite_only for unknown stream
...
(imported from commit fb4e51b44b8c20844a7575af1a471a626273ae39)
2013-08-26 13:59:33 -04:00
5e2de02dfc
Test stream_data.get_color() for unknown stream
...
(imported from commit 7507e43de3f261a19d210c58863d1e614567f4bc)
2013-08-26 13:59:32 -04:00
ca5cf073f4
Add test_get_and_set() to stream_data tests
...
(imported from commit 007486f08879ea8b98524a91ef3fc02565cc4d86)
2013-08-26 13:59:32 -04:00
96a2f0d907
Test TypeError exception in Dict.from
...
(imported from commit 088bf04ecf10338e2d1cff1b86d5beb263ee19dc)
2013-08-26 11:21:30 -04:00
5dda9a5816
Test is_subscribed=false path of unread.get_counts
...
(imported from commit 7fb6531fb6d2d475bf43de6267fd018cc7347d7a)
2013-08-26 11:21:30 -04:00
1821005dfe
Restore subject counts for Uppercase streams
...
(imported from commit ef0e78d39c56da67544441a73ea257f215fefd94)
2013-08-26 11:21:29 -04:00
ffa9cfd492
Test that unread.process_loaded_messages ignores read messages.
...
(imported from commit 262f20933551e786022de564f46c75f901d8123f)
2013-08-26 11:21:29 -04:00
582eef8305
Add test_message_unread()
...
(imported from commit 7f26cafb90757a9c490a148b6dd7b4f4f0fb5f95)
2013-08-26 11:21:29 -04:00
06065d50bf
Add dict.num_items()
...
(imported from commit 209a01b61d18d4b65b54e473cf727065aada68e8)
2013-08-26 11:21:29 -04:00
7f1a1dba9d
Show realm emoji in typeahead and update the list via events.
...
(imported from commit bd8b8be5d088d503cac2b72cf228e769827e2308)
2013-08-23 21:39:29 -04:00
e2a13637f2
Management command for realm emoji
...
(imported from commit 4de3ac69c34bc6e92d180c672fa8276338fecf53)
2013-08-23 21:39:29 -04:00
d8146141a9
Render realm emoji.
...
(imported from commit 5a8dca8963bc6e2e16762844aebaefcb85a6aad2)
2013-08-23 21:39:29 -04:00
32aa0bb72d
[migration] Add RealmEmoji model for realm-specific emoji.
...
(imported from commit d0a08b748f458c0ab68985b4cf00c78950ab40c4)
2013-08-23 21:39:29 -04:00
63fa194139
Turn off the "muted" topic special case
...
(imported from commit ea34ea060eb29864c4816d0f14ee106dcb10be9d)
2013-08-23 18:33:48 -04:00
4a7bab9a6f
Allow collapsing of recipient sections.
...
This is experimental, for staging only. There might be a better
way to model this than dueling force_expand/force_collapse flags,
but it works for now. The code in collapse_recipient_group()
could also be DRYed up relative to expand_summary_row().
(imported from commit 107151d1ecd640970fb7700d41278a003bd1abaa)
2013-08-23 15:57:31 -04:00
2b1a99f985
Tweak Github test data to not cause the Github payload capture to error out
...
I believe the test data to be incorrect, but we'll find out when
we've captured some real data.
(imported from commit ae32af0436b6273d0b2a60b2c55047aace6adcad)
2013-08-23 15:44:19 -04:00
b3ebb13469
Remove some ".d" suffixes in predicate tests.
...
I was saying bar.d in places where I wasn't really specifically
testing the .d feature, and it was distracting and just an
unintentional consequence of copy/paste.
(imported from commit 7b137b28cb33c72b83f02fe1d2961c5c6accc263)
2013-08-23 14:10:03 -04:00
439e984f3d
Break up Filter predicate tests
...
(imported from commit 780559045d6ea84612617db9249d7f191dbd86d9)
2013-08-23 13:56:28 -04:00
3239efd864
Simplify MIT regex code and harden tests
...
(imported from commit 96c988fb8c90d04dd4bcd7d2bbc04f1b1c8d8cb7)
2013-08-23 13:32:10 -04:00
Steve Howell
Leo Franchi
Scott Feeney
acrefoot
acrefoot
Zev Benjamin
Kevin Mehall
Tim Abbott
Luke Faraone
Jessica McKellar
Allen Rabinovich