Commit Graph

10647 Commits

Author SHA1 Message Date
Anders Kaseorg c155403884 docs: Fix various capitalization errors.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 10:25:52 -07:00
Anders Kaseorg 768f9f93cd docs: Capitalize Markdown consistently.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 10:23:06 -07:00
Anders Kaseorg 60a25b2721 docs: Fix spelling errors caught by codespell.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-11 10:23:06 -07:00
Tim Abbott dedb28055a stats: Fix a few strings not tagged for translation. 2020-08-10 16:26:37 -07:00
Shanu b5b7bc9a7c
loading: Add aria-hidden="true" attribute to loading spinners.
Fixes #16082.
2020-08-09 16:47:56 -07:00
Anders Kaseorg 56931b68e0 styles: Unprefix appearance property.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 15:17:20 -07:00
Anders Kaseorg f63d132276 js: Use unminified KaTeX (and minifiy it with everything else).
Since our Webpack config passes pre-minified JS files to
script-loader, they can’t be used as modules.  Use the normal
unminified version, letting Webpack minify it and give us source maps.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-07 11:27:44 -07:00
sahil839 a33b695a21 overlays: Add popovers.hide_all call to close_overlay.
This is a prep commit for changing the bots list page to show
normal user popover instead of extended profile one.
This is added so that any open popovers are closed, if one
tries to close the overlay.

This was not needed previously because we were using modal for
showing extended user profile. Now as we would be adding popover,
we would need this to close the open popovers before closing overlay.
2020-08-06 16:05:22 -07:00
sahil839 1acfb4e942 popover: Rename show_user_info_popover function.
This commit renames the show_user_info_popover function to
show_user_info_popover_for_message, as it is used to open
the popover for users which are essentially related to a
particular message, like message sender and mentioned user.
2020-08-06 16:04:13 -07:00
Sumanth V Rao 572b3930e7 invite: Use `email` rather than `values[0]` in invite.js. 2020-08-06 15:47:00 -07:00
sahil839 982fa366ae stream: Send PATCH request for stream description only if it is changed.
We should send PATCH request for changing stream description only if
it is actually changed, there is no need to send request to backend
if the description is not changed.
2020-08-06 12:15:29 -07:00
sahil839 6bad8b23fc streams: Send PATCH request for stream rename only if name is changed.
We shoudl only send PATCH request to API for stream rename only if
stream name is actually changed.

Previously, when trying to save the stream name without actually
changing it, backend returned 400 with error as "Stream already
has that name". Ideally, we should not make PATCH request if name
is not changed and it should just close the edit widget.
This commit solves this bug.
2020-08-06 12:15:29 -07:00
Tim Abbott beae13b4d6 recent_topics: Renaming confusingly named deletion handlers.
This functions were oddly named in a way that didn't make clear their
role in handling deleted messages.
2020-08-06 12:00:30 -07:00
Tim Abbott 5142bdd317 recent_topics: Fix exception processing old deleted messages.
When old messages are deleted, they may not be present in
message_store when we receive the event notifying the client about
their deletion.
2020-08-06 11:58:23 -07:00
Anders Kaseorg 483445e3d3 styles: Remove unit from 0 lengths.
Generated by stylelint --fix.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:34:44 -07:00
Anders Kaseorg 6dea671fde styles: Merge duplicate selectors.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:34:44 -07:00
Anders Kaseorg 3572dcc67c styles: Remove shorthand property overrides.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:34:44 -07:00
Anders Kaseorg 725ca116dd styles: Remove duplicate properties.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:34:44 -07:00
Anders Kaseorg 3bab1df0e7 styles: Remove invalid -wekbit-box-align [sic] property.
I’m going to assume that this is not intended to be an optimization
for “WekBit” and can, in fact, be deleted.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:30:45 -07:00
Anders Kaseorg b30c86b1a8 styles: Remove obsolete ::-moz-selection vendor prefix.
This is automatically added back by autoprefixer when necessary.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:30:45 -07:00
Anders Kaseorg 0f78efdbb5 styles: Replace invalid user-drag property with -webkit-user-drag.
Commit abbd8a7f45 (#13112) should have
removed the nonexistent user-drag property rather than the
Webkit-specific -webkit-user-drag property.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:30:45 -07:00
Anders Kaseorg 12dcaed177 styles: Remove obsolete filter: alpha() properties.
This was a workaround for IE < 9.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-06 11:30:45 -07:00
sahil839 004b6f2e62 stream_edit: Send values of changed settings only to backend.
This commit changes change_stream_privacy function to only
send the values of changed settings to backend.
We also avoid sending PATCH request if none of the settings
in stream privacy modal are changed.

This change also fixes the bug in changing stream permissions
for realms with limited plans.

Fixes #16024.
2020-08-05 16:17:04 -07:00
Anders Kaseorg c593a62b50 styles: Enable stylelint function-url-quotes rule.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-04 16:34:19 -07:00
Anders Kaseorg 18ce4aed8b styles: Enable stylelint font-family-name-quotes rule.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-04 16:34:19 -07:00
Anders Kaseorg c6ed5c81de styles: Format CSS with Prettier.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2020-08-04 16:34:19 -07:00
SiddharthVarshney 5d6df3dc01 css: Use SCSS nesting for `.carousel-indicators`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 7f2c5a7015 css: Use SCSS nesting for `.carousel-indicators li`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 7af8b7ff6c css: Use SCSS nesting for `.tour .carousel-control`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 1531e38bc2 css: Use SCSS nesting for `.tour .carousel-inner .call-to-action`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney d0d4a066d1 css: Use SCSS nesting for `.tour .carousel-inner .other-resources`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 26d1df58f7 css: Use SCSS nesting for `.tour .carousel-inner .other-resources .other-resources-section`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney a57d979a46 css: Use SCSS nesting for `.tour .carousel-inner .comparison-slack img`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 9a67565c12 css: Use SCSS nesting for `.tour .carousel-inner img`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney fdf893c0af css: Use SCSS nesting for `.tour .carousel-inner .zulip-slack-comparison`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 8487110cca css: Reorder css for `.tour .carousel-inner .zulip-slack-comparison .caption`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney e91d3664c3 css: Use SCSS nesting for `.tour .carousel-inner .zulip-slack-comparison img`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney b05031530d css: Reorder css for `.tour .carousel-inner .zulip-slack-comparison img`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney e8a516aa4d css: Use SCSS nesting for `.tour .carousel-inner .start-button`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney d3208c61d7 css: Use SCSS nesting for `.carousel.carousel-fade .carousel-inner`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney a8c8aae6f5 css: Use SCSS nesting for `.carousel.carousel-fade .carousel-inner .item`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney bfb3e86eab css: Use SCSS nesting for `.carousel.carousel-fade .carousel-inner .item.active`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 6371fe7b37 css: Use SCSS nesting for `.portico-landing.hello .open-source`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 0e47e2bd2a css: Merge `.portico-landing.hello .open-source img` css. 2020-08-04 16:24:12 -07:00
SiddharthVarshney b7216af233 css: Use SCSS nesting for `.portico-landing.hello .features`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 4e20923421 css: Use SCSS nesting for `.portico-landing.hello .features .col-2`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 7f5f61267e css: Use SCSS nesting for `.portico-landing.hello .screen`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney ba4709b000 css: Use SCSS nesting for `.portico-landing.hello .screen.hero-screen`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney 1b5138d546 css: Use SCSS nesting for `.screen`. 2020-08-04 16:24:12 -07:00
SiddharthVarshney db3530d984 css: Use SCSS nesting for `.screen .message-feed`. 2020-08-04 16:24:12 -07:00