649235cfec
python: Remove unused imports.
...
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
2019-02-22 16:54:36 -08:00
a4b294da98
url preview: Remove useless logging.error in open graph code path.
...
As detailed in the comment, someone pasting a broken URL isn't a
situation that a server administrator needs to be notified about.
2019-02-05 13:25:47 -08:00
76deb30312
preview: Hash cache keys for preview urls.
...
We don't want really long urls to lead to truncated
keys, or we could theoretically have two different
urls get mixed up previews.
Also, this suppresses warnings about exceeding the
250 char limit.
Finally, this gives the key a proper prefix.
2018-10-14 09:28:57 -07:00
4d03c15848
url_preview: Don't import beautifulsoup at import time.
...
This is a small performance optimization to Django startup, in line
with other recent commits.
2018-08-08 14:19:42 -07:00
e4821875f7
mypy: Improve typing of oembed data, to Dict[str, Any].
2018-06-19 10:48:38 -07:00
3006b3f52f
url_preview: Fix crash when description has no content.
...
There's several things we'll want to cleanup with this feature, but
for now we're content to just make this not crash.
2018-05-17 12:40:43 -07:00
1f9244e060
zerver/lib: Change use of typing.Text to str.
2018-05-10 14:19:49 -07:00
3f4bf2d22f
zerver/lib: Use python 3 syntax for typing.
...
Extracted from a larger commit by tabbott because these changes will
not create significant merge conflicts.
2017-11-21 20:56:40 -08:00
1dcc981af8
mypy: Add explicit Any type parameters for embedded data Dicts.
2017-11-07 11:26:46 -08:00
e311842a1b
zerver/lib: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
be856bad46
mypy: Reduce use of Any in zerver/lib/url_preview/ return types.
2017-11-04 16:18:27 -07:00
f43e54d352
zerver/lib: Remove absolute_import.
2017-09-27 10:00:39 -07:00
f32c1892ff
preview.py: Fix error raised on uploading file with unicode filename.
2017-06-19 14:58:44 -04:00
c7c47fe11d
Replace buggy NotImplemented with NotImplementedError().
2017-05-23 20:33:35 -07:00
0917493588
mypy: Convert zerver/lib to use typing.Text.
2016-12-25 10:33:45 -08:00
6bb959ff4e
url_preview: Fix BeautifulSoup DeprecationWarning.
2016-12-15 17:05:10 -08:00
fae59502ab
URL preview: Improve test coverage.
2016-12-13 10:43:02 -08:00
c93f1d4eda
Add oembed/Open Graph/Meta tags data retrieval from inline links.
...
This change adds support for displaying inline open graph previews for
links posted into Zulip.
It is designed to interact correctly with message editing.
This adds the new settings.INLINE_URL_EMBED_PREVIEW setting to control
whether this feature is enabled.
By default, this setting is currently disabled, so that we can burn it
in for a bit before it impacts users more broadly.
Eventually, we may want to make this manageable via a (set of?)
per-realm settings. E.g. I can imagine a realm wanting to be able to
enable/disable it for certain URLs.
2016-12-07 17:40:18 -08:00
Anders Kaseorg
Tim Abbott
Steve Howell
neiljp (Neil Pilgrim)
Aditya Bansal
rht
Mark Shannon
Robert Hönig
Igor Tokarev