Anders Kaseorg
bf8fc8429b
unread: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
9c2ab2842f
unread: Ignore deprecated sender_id synonym.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
ca99016f04
user_status: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
4b4ef75729
muted_users: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
8ce77cabae
user_topics: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
6bff8161ea
user_topics: Remove stream__name from user_topic_schema.
...
This field is internal to the backend and never escapes to the
frontend.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
97907b0a9c
pm_conversations: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
e28240a9ac
stream_data: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
9b511f5caa
sub_store: Fix ApiStreamSubscription["email_address"] type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
370a6c350e
local_message: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
788552b916
alert_words: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
1ee5c46a20
user_groups: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
41ec6c9b7c
user_groups: Fix UserGroupRaw["direct_subgroup_ids"] type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Anders Kaseorg
d5cc7d7b79
emoji: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 15:53:44 -07:00
Karl Stolley
3a4719915c
compose: Let pill-container dictate spacing of pills.
...
The 2px and 6px values expressed as variables here are taken from
@terpimost's mocks in Figma.
2024-06-21 14:46:44 -07:00
Karl Stolley
0844e2cba9
pills: Size pill components and inputs in ems.
2024-06-21 14:46:44 -07:00
Anders Kaseorg
39d4ddaa96
stream_edit_subscribers: Rename misleading variable.
...
.safeParse does not return a “schema”.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 14:44:52 -07:00
Anders Kaseorg
15d4866856
stream_edit_subscribers: Fix incorrect error result test.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 14:44:52 -07:00
Varun Singh
05a480f1d1
zcommand: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
87a9877a93
attachments_ui: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
f2c3207538
stream_topic_history_util: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
3d64fb6cda
message_edit_history: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
f553142c7c
settings_linkifiers: Use `raw_data` and `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Varun Singh
4186cac151
stream_edit_subscribers: Use `raw_data` & `data` more.
...
Prefer using `raw_data` and `data` instead of
`data` and `clean_data`.
2024-06-21 12:58:21 -07:00
Kenneth Rodrigues
245332eef4
new conversation: Show correct tooltip when dms are disabled.
...
Earlier the `data-conversation-type` attribute of the new conversation
button was being set to `direct` only if dms were enabled. As a result a
stale tooltip was being shown when dms were disabled.
This commit updates the attribute to `direct` reagardless of dms being
enabled or not.
Fixes #29916 .
2024-06-21 11:21:37 -07:00
Karl Stolley
2820bd277f
pygments: Fully isolate light and dark themes.
...
Co-authored-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 11:15:34 -07:00
Karl Stolley
8936febbd3
pygments: Remove legacy Zulip customizations.
...
These styles were from before opting to work with themes maintained
by the Pygments project. Their removal will make it much easier to
upgrade Pygments themes in the future, and more importantly,
reduce the effort required to square syntax highlighting in the web
and mobile apps.
2024-06-21 11:15:34 -07:00
Varun Singh
80cf16a303
stream_edit_subscribers: Convert module to TypeScript.
2024-06-21 09:54:08 -07:00
Varun Singh
894cafe3c0
subscriber_api: Fix types of function parameters.
2024-06-21 09:54:08 -07:00
Varun Singh
5891a9ef24
subscriber_api: Don't return unused channel request objects.
2024-06-21 09:54:08 -07:00
Anders Kaseorg
ce71e5ad8c
starred_messages: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
9a94cb2269
people: Validate paramters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
b93509019d
people: Mark possibly missing fields as optional.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
02e236f58a
realm_user_settings_defaults: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
282ea2d77f
realm_user_settings_defaults: Fix user_list_style type.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
bb8f044a35
scheduled_messages: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
ed1c169bfb
user_settings: Validate parameters with Zod.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Anders Kaseorg
fd253539e0
ui_init: Use Zod to split state_data.
...
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-21 09:28:35 -07:00
Aman Agrawal
32b4aa0883
navbar: Remove empty space to the left and right.
2024-06-20 16:11:19 -07:00
Anders Kaseorg
139d6ff81b
markdown_timestamp: Remove incorrect space.
...
The space wasn’t visible because it was narrower than the padding on
`.rendered_markdown time`, but it showed up in copy-and-paste.
Signed-off-by: Anders Kaseorg <anders@zulip.com>
2024-06-20 16:04:30 -07:00
Sahil Batra
e19524ba92
settings: Use new group setting to private channels creation permission.
...
This commit updates webapp code to use new group based setting to check
permission for creating private streams.
2024-06-20 15:48:14 -07:00
Sahil Batra
69e88f8787
tests: Extract common function to test realm group based settings.
...
Test for "can_access_all_users_group" setting does not use the
common function as it allows different options as of now.
2024-06-20 15:48:14 -07:00
evykassirer
f6c9b515c7
input_pill: Redesign input pills.
...
This commit also replaces the close button with
an svg. This is part of the app redesign, and
preparation for the upcoming search pill project.
2024-06-20 15:16:17 -07:00
evykassirer
84cf7f8677
input pill: Remove pill-container-btn class in favor of search styling.
...
This style is currently only used for search suggestions. Soon,
styling for those suggestions will become more specific, and so
for now we'll keep those styles in search.css to be more clear
about what the new styles affect. If we want to repeat something
like this in the future somewhere else in the app, we can come
up with a generic styling then once we have a better idea of
what that will look like.
2024-06-20 15:16:17 -07:00
Aman Agrawal
792a9bd81e
presence: Fix presence status not updated for offline users.
...
As per the new presence API, we don't get presence info for
users if they went offline after `last_update_id`. This results
in webapp not updating presence info for them.
To fix it, we loop over all the active / idle status users and
update presence status for them as per the latest server time.
2024-06-20 12:35:42 -07:00
Ujjawal Modi
9bb74fb064
settings-config: Use snake case for expires_in_values keys.
2024-06-20 12:26:29 -07:00
Ujjawal Modi
cdbc20d304
invite-user-modal: Remove duplicate CSS rules.
...
Removes some CSS rules used in the invite user modal that were
already being applied via the shared `modal_select` class.
Co-authored-by: Lauryn Menard <lauryn@zulip.com>
2024-06-20 12:26:29 -07:00
Kislay Verma
d38d82edc3
dropdown_widget: Fix bug in `disable_for_spectators`
...
If `disable_for_spectators` is true, the widget text is greyed out
but the tippy instance is still delegated, causing it to appear
on click/enter.
This commit fixes that by not delegating tippy if the
`disable_for_spectators` is true.
This bug was surfaced when it was found that the
topic type filter in Recent conversations has disabled
styling for spectators, but a spectator could still click on it to
open the dropdown.
Fixes #30461
2024-06-20 12:09:04 -07:00
Shubham Padia
43eebbf9c6
scroll: Set tabIndex to -1 for simplebar content wrapper.
...
Fixes #30403 .
Having tabIndex set to 0 led to keyboard focus being put on
a scrollbar container, which led to users having to tab twice
to skip a container.
This commit also removes instances of tabIndex being set to
-1 programatically for certain cases, since it is -1 by default now.
This commit also removes `outline: none` for simplebar since
that property is not needed anymore because the wrapper is
not focusable anymore.
2024-06-20 10:25:51 -07:00
Shubham Padia
b771c5f5b0
pm_list_data: Rename private_message(s) to conversation(s).
...
Since it's an array of PMConversation objects, not of messages, the
old name was confusing.
2024-06-20 09:58:39 -07:00