ce94fb2eb1
deps: Change zxcvbn download method from download-zxcvbn to npm.
...
- Replace download-zxcvbn with downloading it from npm.
- Change zxcvbn.js path to node_modules (because npm put it to
`node_modules` directory.
- Bump `PROVISION_VERSION` in `version.py` to 2.4.
Fixes #2423 .
2016-12-06 17:54:56 -08:00
0951b838ca
deps: Update zxcvbn to 4.4.1
...
Update zxcvbn to 4.4.1, and change `crack_time` to
`crack_times_seconds` because `crack_time` has been changed to
`crack_times_seconds` in 4.4.1.
2016-12-06 17:51:33 -08:00
d11cdac876
docs: Add documentation for linking to a stream.
...
Fixes #2560 .
2016-12-06 17:47:26 -08:00
7c3aff92d9
integrations: Add webhook payloads, webhook code, API endpoint, and tests for heroku
2016-12-06 11:05:00 -08:00
e6e11aefb3
settings: Add option to disable websockets.
...
This can be useful in scenarios where the network doesn't support
websockets. We don't include it in prod_settings_template.py since
it's a very rare setting to need.
Fixes #1528 .
2016-12-05 21:55:22 -08:00
84765e48a9
integrations: Add webhook code, API endpoint, and tests for papertrail
2016-12-05 21:48:11 -08:00
7bf10ec74f
update-sockjs: Update sockjs from version 0.3.4 to 1.1.1.
...
- Add browserify to npm dependencies.
- Add SockJS-client to npm dependencies.
- Add npm postinstall script to generate browser version of SockJS-client
from npm package.
- Change deprecated SockJS object property 'protocol_whitelist' to
'transports'.
- Fix settings.
2016-12-05 21:36:10 -08:00
aa7f11dd6c
docs: Add user guide for *Streams and Private Messages*
2016-12-05 21:22:37 -08:00
abde152d9c
eslint: change array-callback-return from warning to error.
2016-12-05 21:21:19 -08:00
c51d2c3d8f
docs: Add user guide for signing out
2016-12-05 16:59:18 -08:00
f89e732d9e
integrations: Add webhook code, API endpoint, and tests for mention.
2016-12-05 16:46:32 -08:00
dc6849952b
eslint: change space-before-function-paren from warning to error.
...
Also fix violations.
2016-12-05 09:50:37 -08:00
f354892ba4
docs: Add user guide for *Create a stream*
2016-12-05 05:48:13 -08:00
a8b39e6c0f
Switch yoda eslint rule from warning to error (in .eslintrc)
2016-12-04 19:48:10 -08:00
025fe9980b
Switch no-empty eslint rule from warning to error (in .eslintrc)
2016-12-05 01:35:14 +00:00
dd62123d4b
docs: Add user guide for *Format Your Messages*.
2016-12-03 20:44:01 -08:00
441743cb89
integrations: Add webhook code, API endpoint, and tests for stripe.
...
This integration still needs documentation.
2016-12-03 20:42:43 -08:00
0290aeb6ab
lint: Fix several no-unused-vars eslint rule violations.
...
These changes were extracted by tabbott from the original commit
to merge now because they have been reviewed as safe.
2016-12-03 18:43:47 -08:00
426cb13e23
Remove `enforce_arity` function from util.js.
...
Remove `enforce_arity` function from util.js, because it is
not used anymore.
2016-12-03 18:43:46 -08:00
5ba3e214da
Add user guide for *Editing past messages*.
2016-12-03 14:20:06 +00:00
1fb9220354
lint: Remove old jslint linter.
...
Now that we're using eslint, jslint is no longer required.
2016-12-02 18:49:42 -08:00
2c940b93ab
js: Fix some minor whitespace issues.
2016-12-02 18:39:30 -08:00
5e9918135b
eslint: change quote-props from off to error and fix violations.
2016-12-02 18:35:53 -08:00
b8fc3f0e65
eslint: change space-before-blocks from warning to error and fix violations
2016-12-02 17:40:09 -08:00
9f0383520c
settings: Fix Zulip Labs Spacing Issue.
...
This fixes the spacing issue with Zulip Labs not having a space between
the icon.
2016-12-02 14:49:05 -08:00
9c0ebc7359
eslint: change no-else-return to error and fix violations
2016-12-02 14:43:09 -08:00
d8636980ae
settings: Convert bot and alert word settings to use new buttons.
2016-12-02 13:03:43 -08:00
d184288e00
css: Add box-shadow and bg-white components.
2016-12-02 13:03:43 -08:00
6e86515b15
css: Move display-none and inline-block to components.css.
2016-12-02 13:03:43 -08:00
a7681c3c2f
css: Move .light to components.css.
2016-12-02 13:03:43 -08:00
b61d6bc251
settings: Use new checkboxes and buttons in display settings.
2016-12-02 13:03:40 -08:00
e13a892479
settings: Remove unnecessary outer div from display settings.
2016-12-02 13:03:35 -08:00
85d6fdda4d
settings: Use new checkboxes and buttons in UI settings.
2016-12-02 13:03:32 -08:00
51fbe4395d
settings: Use new checkboxes and buttons in notification settings.
2016-12-02 13:03:23 -08:00
7fd15984fc
components: Add a new settings page checkbox.
...
This allows us to style checkboxes to be transparent boxes with green
borders.
2016-12-02 12:06:49 -08:00
0e3332d86e
[Bootstrap]: Fix Null Case Issue.
...
This fixes the case in which `this` evaluates as null and throws an
error in TravisCI.
2016-12-02 11:58:53 -08:00
2aa9512506
Add data-name to realm filter settings section.
...
This new settings section, was added into master but doesn't have the
correct data-name attribute to be called by the new modal.
2016-12-02 11:56:24 -08:00
ed0bc831be
eslint: change one-var from warning to error and fix violations
2016-12-02 11:25:16 -07:00
b3f4feb996
eslint: change max-len from warning to error and fix violations.
2016-12-02 14:16:33 +00:00
e6369fc29b
eslint: change no-plusplus from warning to 2 and fix violations.
2016-12-01 14:27:17 -08:00
c90da24541
eslint: change keyword-spacing from warning to error and fix violations.
2016-12-01 14:22:15 -08:00
d99b17070e
edit: Fix traceback when saving edits to unsent messages.
...
7b0c6459b4Fixes #2416 .
2016-12-01 10:39:43 -08:00
7b2c313f37
eslint: change brace-style from warning to error and fix violations.
2016-12-01 10:20:22 -08:00
2784a3e27f
docs: Add user guide for Uploading and Sharing Files.
2016-11-30 22:30:56 -08:00
3c0ea4da6f
docs: Add user guide for *mention a team member*.
2016-11-30 19:41:49 -08:00
4935f0c693
popovers: Hide actions popover once the muting button is clicked.
...
The popover shouldn’t still display once a valid action on the popover
has been taken.
Fixes #2366 .
2016-11-29 16:47:03 -08:00
b837221e05
Fix for possible webkit painting bug.
...
The left sidebar will overflow its bounds (even when set to overflow:
hidden) and go behind other text on the sidebar above. By setting the
z-index to 0 we seem to solve the problem.
This is probably actually a webkit bug, but this makes it no longer
affect us.
Fixes #1899 .
2016-11-29 15:29:59 -08:00
f7dc2f33cd
Change name of eslintrc file to .eslintrc.json
...
Currently it does this for the eslintrc files in zulip,
zulip/frontend_tests and static/js
This commit also fixes json style issues (quotes)
2016-11-29 08:58:39 -08:00
3d1bcb05e1
tornado: Move event_queue.py to zerver/tornado/.
...
Fixes #729 .
2016-11-26 22:29:28 -08:00
9636d89de1
Add documentation for changing SITE param in jenkins configuration.
2016-11-26 19:30:45 -08:00
4e5c4c5ffb
streams: Add support for setting stream description during creation.
...
Add new box for stream description in the stream creation form,
modify backend so its contents end up as the stream description.
Fixes : #2283 .
2016-11-26 16:55:35 -08:00
a79acf854f
docs: Automate creation of Hubot documentation lozenges.
...
This removes a bunch of semi-duplicated code.
2016-11-26 15:27:54 -08:00
604079a9d4
Fix formatting for Group PMs in the right sidebar.
...
We now sort users by the lower case value of their
full names in each of the links in the "GROUP PMs"
section of the right sidebar. We still use "+n others"
for big huddles.
2016-11-26 11:48:52 -08:00
d953eca14c
Make group PMs reply-to's more consistent in case.
...
We now sort lists of users ids deterministically, and we also
sort list of emails deterministically and without regard to case.
This probably fixes the bug #2343 , although I never got a great
repro on that.
2016-11-26 11:48:52 -08:00
578b276523
node tests: Add tests for message_store.js.
2016-11-26 11:48:52 -08:00
af9ff9a030
Have unread.num_unread_for_person accept a user_id.
...
(It used to take an email as its parameter.)
2016-11-26 11:48:52 -08:00
772571fd82
Use data-user-ids-string in Private Messages sidebar.
...
This commit also changed message_store.recent_private_messages
to use user_ids_string instead of reply_to.
2016-11-26 11:48:52 -08:00
aadfe133e2
buddy list: Use user_ids in DOM list elements.
2016-11-26 11:48:52 -08:00
73fb9c6f66
Fix alignment of 'Not Delivered buttons' on smaller devices.
2016-11-26 10:13:48 -08:00
79b4ac8155
Add tooltips to buttons appearing when message is not delivered.
2016-11-26 10:13:48 -08:00
0525b65f90
Fix positioning of error message appearing on adding custom alert words.
...
Fixes #2413 .
2016-11-26 10:11:55 -08:00
29d3019262
Switch no-loop-func eslint rule from warning to error (in .eslintrc)
...
The one error that needed to be fixed was in static/js/echo.js.
The function in the loop was being used by _.each(). This has been
replaced by iterating through the array using a while loop instead.
2016-11-25 14:02:44 -08:00
497c7702cc
Run eslint in tools/lint-all with npm run --silent lint
...
This commit adds a basic eslintrc that emulates jslint defaults.
Rules that conflict with our existing code have been switched to
warnings instead of errors. Globals have been added to the eslintrc. The
bundled js file (generated by webpack) and blueslip.js are ignored with
.eslintignore.
To display warnings, run npm run lint-loud. This runs eslint without the
--quiet option on static/js and frontend_tests.
npm run --silent lint is run by tools/lint-all (in addition to jslint).
The --silent option is used to suppress the default output from npm run.
Fixes #535 .
2016-11-18 16:15:45 -08:00
d7e1e4a2c0
Add initial implementation of custom realm filters.
...
This PR was abandoned by Vladislav and then substantially modified by
Igor Tokarev and Tim Abbott to complete it and fix a number of bugs.
Fixes #544 .
2016-11-17 17:11:25 -08:00
8f96853fcb
presence: Convert presence_info to use user IDs.
...
When we filtered buddy lists, a recent change introduced some
bugs related to case-insensitive emails. We now circumvent the
bug by indexing presence_info with user_ids.
2016-11-17 13:27:28 -08:00
9c3d448fe4
compose: Clarify @-all errors are about mentions.
...
Every message to that stream goes to that number of users :).
2016-11-17 12:35:35 -08:00
5d2b81358c
Code Simplification and Emoji Drag Fix.
...
There’s no need for four separate `$(sel).is()` statements, one will
do. This also added .drag to the list to ignore.
2016-11-17 11:21:15 -08:00
2663215625
Do not close message compose box on drag.
...
On the drag to resize emoji box action, do not close the message
compose box.
2016-11-17 11:21:15 -08:00
82a497ec08
Remove spurious blueslip error for topic lists.
...
If we update an unread count for a topic that is not part of
our truncated list, we don't need to complain.
2016-11-16 22:01:30 -08:00
9582079cd9
edit: Fix "View source" icon being orphaned post-hover.
...
It turns out it wasn’t a one-liner, it was actually a -2-liner. :)
2016-11-16 14:03:54 -08:00
3b594a6efa
bug fix: Keep old, active, upper-case topics in the topic list.
...
If you narrowed to a topic that was not one of the most recent 5
topics and had uppercase characters, it would disappear from the
topic list as soon as all of its messages were read.
2016-11-16 12:17:31 -08:00
f4bf154981
bug fix: Fix topic unread counts for upper-case streams.
...
If stream names weren't entirely lowercase, then our function
topic_list.is_for_stream() was improperly reporting false and
failing to update unread counts for the active topic widget.
This regression was probably introduced in the fairly recent
53eea250d0Fixes #2330 .
2016-11-16 10:08:44 -08:00
9eb825fff5
Refactor PM unread counts to use user_ids as keys.
...
We now use comma-delimited lists of user_ids for the following
data structures in unread.js:
- unread_privates[<user_ids_string>]
- get_counts.pm_count[<user_ids_string>]
2016-11-15 18:31:59 -08:00
1783879108
people.js: Add methods for user_ids_string/emails_string.
...
Added:
* people.user_ids_string_to_emails_string
* people.emails_strings_to_user_ids_string
2016-11-15 18:31:59 -08:00
7750d43d23
Simplify finding elements in pm_list.js.
...
We no longer need iterate_to_find, and we just use simpler
selectors.
2016-11-15 18:31:59 -08:00
f5e1dcd11d
buddy list: Sidebar menu now uses user_id, not email.
2016-11-15 18:31:59 -08:00
49d24cee2a
subs: Fix clearing filter table on subscribe.
2016-11-15 12:49:40 -08:00
3d8ed7b55f
subs: Rewrite Stream Filter Function.
...
This is more performant, along with accepting a parameter for
filtering only streams that are subscribed to if the toggle is set to
subscribed only.
Also, it now does substring matches, rather than just matching if an
entire word matches the search query.
Fixes #2141 .
2016-11-15 12:21:43 -08:00
1def0b6701
hashchange: Add hashchange ignore mechanism for overlays.
...
This will make it possible to do hash changes in soon-to-be-overlay
pages like the /#subscriptions and /#settings page.
2016-11-15 11:53:38 -08:00
1feedbe346
Add github webhook integration.
2016-11-15 10:48:12 -08:00
75db036733
Add toggle component.
...
This adds the toggle component which removes the necessity to have HTML.
2016-11-15 10:20:37 -08:00
26857ac3aa
admin: Use helpers when opening user form.
2016-11-15 09:37:47 -08:00
7656c31769
Extract admin.get_email_for_user_row().
2016-11-15 09:37:47 -08:00
33a87492e2
admin: Remove obsolete active_user_row class.
2016-11-15 09:37:47 -08:00
ecfac010fc
Extract admin.set_up_deactivate_user_modal().
...
This sets us up to eliminate the "active_user_row" hacks in
our next commit.
2016-11-15 09:37:47 -08:00
dcfb5c30c6
admin users: Fix real-time-sync for full names.
...
When an ordinary user changes their name, the admin sees the change
when they open the edit form now.
2016-11-15 09:37:47 -08:00
ea58005796
Fix styling in api_key_box section on settings page.
...
Before fix, "Your API key" section was to close left side of the box.
2016-11-15 09:32:10 -08:00
e40e756d47
echo: Fix local echo sending a message to "yourself, ".
...
Previously, this would incorrectly include a user with name and email
"" in the recipients list shown in the local echo code path.
We fix this and add a test for the issue.
2016-11-14 21:43:13 -08:00
951f1d9cdb
Add missing unicode range to text: replace(inline.breaks.text)
...
This is a followup of #2297 .
2016-11-14 20:10:54 -08:00
59750a1cb9
Move more unread logic out of stream_list.js.
...
There are two split-outs code of the code here:
- Animation stuff is in unread_ui.js.
- PM unread counts get handled by pm_list.js.
2016-11-14 17:50:55 -08:00
e732892654
css: De-duplicate some common styles for unread counts.
2016-11-14 16:16:55 -08:00
7c1711179c
Rename subject_count class to topic-unread-count.
2016-11-14 16:16:55 -08:00
72b8200b0b
refactor: Extract update_unread_count() in topic_list.js.
...
This function does the "heavy" lifting of updating an unread
count. (It's not exactly heavy lifting, but it makes it so
the parent just needs to find the outer element of the unread
div, using whatever method makes sense for the parent.)
2016-11-14 16:16:55 -08:00
e7a2b51647
Consolidate people searches (buddy list/subscribers).
...
We now use the same people-filtering code for the buddy
list that we use in subscriber search.
2016-11-14 16:01:13 -08:00
71d93207cd
Match "Charles Dickens" with "ch di" in subscriber search.
2016-11-14 16:01:13 -08:00
6eb1dc3e73
Refactor filter_people_by_search_terms().
...
Build individual matchers for each search term.
2016-11-14 16:01:13 -08:00
2746518f3c
Make subscriber filter match on emails.
...
We will match emails that start with search terms.
2016-11-14 16:01:13 -08:00
b2e91eae13
Add marked.js support to emojis in miscellaneous and dingbats block.
...
https://en.wikipedia.org/wiki/Emoji#Unicode_blocks
2016-11-14 15:58:16 -08:00
8fa519ded6
Remove some dead code in stream_list.js.
...
I forgot to remove this code in a recent refactoring that copied
this code into activity.js. It should not have caused any errors,
but it's no longer needed.
2016-11-14 15:53:23 -08:00
4ed5c21821
Update Desk.com webhook integration.
...
Updates the HTML docs to match changes to the Desk.com website,
including all new screenshots for the custom action workflow.
Tests four types of messages that could be sent as notifications from
Desk.com. Desk.com allows an account administrator to send any text
in a custom action, so there isn't a standard format.
Custom actions send URL-encoded POST data, the test fixtures contain
URL-encoded text like what could be sent by a custom action configured
as described in the Zulip Integrations documentation to post a new
message to a stream. (See also #2169 , errors in this documentation.)
New zerver.tests.webhooks.test_deskdotcom.DeskDotComHookTests:
* Static text: minimal plain text string
* Case updated: activity alert with link to a Desk.com case and message
* Unicode text Italian: activity alert with message in Italian
* Unicode text Japanese: activity alert with message in Japanese
Each posts a new message in the deskdotcom stream.
Tested on Ubuntu 14.04. I created the fixtures with Emacs, I would
appreciate if someone can check that the Italian and Japanese messages
look ok. I used the same text for a live test and it displayed correctly.
Fixes #2031
2016-11-11 16:06:22 -08:00
Rafid Aslam
actuallyatoaster
Sampriti Panda
Zac Pullar-Strecker
Bickio
K.Kanakhin
Cynthia Lin
lonerz
Maydha K
Vamshi Balanaga
AZtheAsian
Robert Hönig
kevv87
Tim Abbott
Krzysztof Zbudniewek
Brock Whittaker
Tommy Ip
aakash-cr7
Joy Chen
Arpith Siromoney
Tomasz Kolek
Calvin Lee
Tomasz Kolek
Steve Howell
Vladislav Manchev
hackerkid
Feorlen