93678e89cd
webhooks: Migrate 14 webhooks to use check_send_webhook_message.
...
These are the straightforward ones.
Note that there is a line in zerver.lib.test_classes.build_webhook_url
that lost test coverage. That's because most of our tests test using
stream messages so the webhook URLs being tested always have a query
parameter. So the line that accounts for there being no query
parameters never gets called, which is fine, but we should still
keep it.
2018-03-16 11:34:20 -07:00
af56df7723
webhooks: Enable custom topics and default PM notifications.
...
This commit adds a generic function called check_send_webhook_message
that does the following:
* If a stream is specified in the webhook URL, it sends a stream
message, otherwise sends a PM to the owner of the bot.
* In the case of a stream message, if a custom topic is specified
in the webhook URL, it uses that topic as the subject of the
stream message.
Also, note that we need not test this anywhere except for the
helloworld webhook. Since helloworld is our default example for
webhooks, it is here to stay and it made sense that tests for a
generic function such as check_send_webhook_message be tested
with an actual generic webhook!
Fixes #8607 .
2018-03-16 11:34:20 -07:00
e30ba19b79
mypy: Apply type: ignore to api_github_webhook_dispatch calls.
2018-03-15 14:33:56 -07:00
31dce7c87c
minor: Request parameter should be of type HttpRequest.
2018-03-15 14:33:53 -07:00
17937175ac
mypy: Centralize ViewFuncT definition into new file zerver/lib/types.py.
...
Originally was going to centralize this in zerver/lib/request.pyi, but this
file is not visible at run-time, being only a stub. The matching request.py
file seemed inappropriate, as it doesn't actually use ViewFuncT.
2018-03-15 14:16:40 -07:00
5c1858e584
webhooks/taiga: Update text to conform to the new style guide.
...
Note that the "Save" button has no text in the Taiga webhook
setup UI. There is a small floppy disk symbol for saving which
is visible right beside the form fields. So I simply said,
"Save the form".
2018-03-14 18:13:13 -07:00
f89b3fdb1c
webhooks/heroku: Update text to conform to new style guide.
2018-03-14 18:13:13 -07:00
cad422f4b6
webhooks/travis: Update text to conform to doc style guide.
...
Note that this file runs into the CSS bug addressed in #8433 .
2018-03-13 20:15:04 -07:00
71619f7d32
webhooks/insping: Update text to conform to style guide.
2018-03-13 20:12:26 -07:00
5fdb0666dc
webhooks/zapier: Update text to conform to doc style guide.
2018-03-13 20:12:26 -07:00
0a3961502f
webhooks/ifttt: Update text to conform to doc style guide.
2018-03-13 20:12:26 -07:00
9e1dbde82d
mypy: Final small migrations to python3.5 annotations in many files.
2018-03-12 11:23:30 -07:00
9e52a9f879
webhooks/flock: Add flock integration.
2018-03-11 20:31:13 -07:00
7c830c5767
webhooks/beeminder: Mock time.time() to avoid race.
...
Rewritten in significant part by tabbott to actually be correct.
One particularly nasty thing the original webhook integration did is
do `current_time = time.time()` at the top of the `view.py` function
-- that means that code ran at import time, not runtime.
2018-03-09 11:12:40 -08:00
fa8525c862
webhooks/hellosign: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
f3590dc2f5
webhooks/gosquared: Update text to conform to doc style guide.
...
Note that the 5th step cannot be reached unless a webhook has been
configured first, which is why it is the last step.
2018-03-08 08:19:32 -08:00
12396dd39b
webhooks/gogs: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
88a198041a
webhooks/gitlab: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
f7a21b18dc
webhooks/github_webhook: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
b6fc33e1da
webhooks/gci: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
fa1583bf45
webhooks/dropbox: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
4f039e4536
webhooks/delighted: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
18c6cd9dd2
webhooks/codeship: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
1c44a9c4c0
webhooks/bitbucket2: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
f551f3a9b8
webhooks/beanstalk: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
9de90645f3
webhooks/basecamp: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
7ee7d4a4d1
webhooks/appfollow: Update text to conform to doc style guide.
2018-03-08 08:19:32 -08:00
553634536c
beeminder: Mostly eliminate nondeterministic failures in test suite.
...
There's probably follow-up work to do here to eliminate these
completely, but this dramatically shrinks the ~1 minute race window
that was previously present between import and test function being
called.
2018-03-06 13:44:06 -08:00
12c4a8293d
webhooks/crashlytics: Update the text.
...
This commit:
* Restructures the doc to use a numbered-step format.
Note that there are no screenshots. I signed up for a
Fabric/Crashlyics account but you have to link an Android/iOS app
to even get to the settings panel, which seemed like too much work
just to get a screenshot.
However, the way we can verify (somewhat) the correctness of the
last step is that it is a paraphrase of the first paragraph of
Fabric's Webhook docs, which can be found here:
https://docs.fabric.io/apple/crashlytics/custom-web-hooks.html
2018-03-06 12:52:22 -08:00
53ccbdcfd6
webhooks/dropbox: Update text and remove screenshots.
...
This commit modifies the text to:
1. Removes unnecessary screenshots.
2. Use the numbered-style format.
3. I also removed the instructions for generating an access token.
I took a look at Dropbox's docs and you shouldn't need that
for a webhook setup. The whole point behind a webhook is that
one can get by without using OAuth.
4. Rearranges the instructions to only contain 4 steps. For
uncomplicated instructions, that seems to be the ideal number.
2018-03-06 12:52:22 -08:00
91983834e6
integrations: Add documentation for Front.
2018-02-28 16:18:19 -05:00
822dfc6a34
integrations: Add webhook code, API endpoint, and tests for Front.
2018-02-28 16:18:19 -05:00
c45acad24b
integrations: Add webhook payloads for Front.
2018-02-28 16:18:19 -05:00
76898dd4d3
integrations: Make minor wording changes to integrations docs.
2018-02-27 08:23:51 -08:00
1516e51126
webhooks/gitlab: Support both "Build Hook" and "Job Hook" events.
...
GitLab recently changed their event name for build notifications
from "Build Hook" to "Job Hook". Instead of just supporting the
latter, we should support both just in case people are running
older versions of GitLab.
2018-02-25 09:35:07 -08:00
fbbdc0110a
webhooks/gitlab: Replace "Build Hook" with "Job Hook".
...
At some point, GitLab decided to change the name of the event for
CI notifications from "Build Hook" to "Job Hook" and we started
running into errors in webhook-logger.log.
2018-02-24 06:22:19 -05:00
096c0b68f3
webhooks/basecamp: Update text and remove screenshots.
...
This commit:
* Removes the unnecessary screenshot. The UI is intuitive enough
and standalone instructions should suffice.
* Rearranges the instructions into 4 steps.
* Makes the wording more explicit.
2018-02-24 06:21:02 -05:00
3b7598014f
webhooks/appfollow: Update text and remove screenshot.
...
This commit:
* Removes the unnecessary screenshot. The user should be able to
easily see the fields in question in this case.
* Wraps the text at 80 chars.
* Combines the instructions into 4 steps.
2018-02-24 06:21:02 -05:00
ed345427e5
webhooks/airbrake: Combine instructions into 4 steps.
...
The docs for this can easily be combined into 4 steps. For
uncomplicated setups, 4 seems to be like a good number.
Again, I have no way of verifying the correctness of the instructions
here because Airbrake doesn't let you do anything till you specify
your credit card information, which I didn't want to.
2018-02-24 06:21:02 -05:00
4d410a5eb7
webhooks/gci: Update text.
...
This commit modifies the text to:
* Use number 1 for all steps and let Markdown take care of the rest.
* Removes the line that says this webhook is "experimental". It isn't
anymore.
2018-02-24 06:21:02 -05:00
9667594a34
webhook/delighted: Update text and remove screenshot.
...
This commit modifies the doc.md to:
* Use consistent language and style.
* Use the number 1 for all numbered steps and let Markdown take
care of the rest.
* Have detailed steps on how to get to the Integrations settings
instead of just linking to the page.
* Remove unnecessary screenshots.
2018-02-24 06:21:02 -05:00
e139d29fca
webhooks/codeship: Update text and remove screenshots.
...
This commit:
* Adds a missing step to the documentation.
* Replaces wording such as "Go to X" with "Click on X".
* Removes the unnecessary screenshots.
* Rearranges the doc to contain only 4 steps. For uncomplicated
setups, 4 seems to be the right number.
2018-02-24 06:21:02 -05:00
0d39b05cf6
webhooks/beanstalk: Update text and remove screenshots.
...
This commit:
* Removes the unnecessary screenshot.
* Reorders the instructions and combines them in to 4 steps.
* Improves the contents of the webhook-url-with-bot-email-indented.md
macro and makes it more consistent with create-bot-construct-url.md.
* Sets the recommended stream name to "commits", since that's what
the webhook function for Beanstalk expects in
zerver/webhooks/beanstalk/view.py. This allows us to use the
create-stream.md macro.
2018-02-24 06:21:02 -05:00
bd787c12c4
webhooks/bitbucket2: Update text and remove screenshots.
...
* Remove unnecessary screenshot. It doesn't help very much in this
case.
* Update text to instruct users to not leave the `Title` field
empty (it cannot be blank).
* Replace wording such as `Go to Settings` with `Click on Settings`.
* Combine the "fill out the form" and "click 'Save'" steps.
* Replace "Choose X on the left-hand side" with "Choose X".
* Replace "Remember to check the X" with "Check the X".
2018-02-24 06:21:02 -05:00
03624b78c2
webhooks: Add Facebook integration.
2018-02-19 09:41:49 -08:00
08efd7828a
integrations: Update text for bitbucket2 doc.
...
With minor fixes by eeshangarg.
Eeshan: I added a screenshot because I thought it would be helpful.
2018-02-13 22:28:48 -03:30
7697adfcdc
integrations: Update text for appfollow doc.
...
With minor fixes by eeshangarg.
2018-02-13 22:19:05 -03:30
80a0976afe
integrations: Update text for basecamp doc.
...
With minor fixes by eeshangarg.
Eeshan: I updated the screenshot. The old one was blurry, the
whole process is largely the same.
2018-02-13 22:15:10 -03:30
de3d478a80
integrations: Update text for airbrake doc.
...
With minor fixes by eeshangarg!
Eeshan: I decided to remove the screenshot. It looks very old and
was blurry and the instructions were very screenshot-agnostic
anyway!
I couldn't update the screenshot because Airbrake doesn't even let
you use the free trial till you give them your credit card info,
which I didn't want to do!
2018-02-13 21:56:31 -03:30
2ed1ab4b7a
mypy: Amend topic REQ parameters in helloworld/mention webhooks.
2018-02-13 11:40:52 -08:00
b9ca7bd954
beeminder: Clean up messy imports in tests.
2018-02-12 12:06:12 -08:00
3f832b95de
webhooks/beeminder: Fix documentation to append email to URL.
...
The Beeminder integration requires an `email` parameter that
our bot creation documentation macros don't yet support.
2018-02-12 12:03:25 -08:00
76c56ad81d
webhooks/beeminder: Make deadline time (time_remain) positive.
2018-02-12 12:03:25 -08:00
ea0fe90367
webhooks/beeminder/doc.md: Use better macros.
2018-02-09 11:53:32 -08:00
037c891fcf
webhooks/delighted: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
69f248aaf9
webhooks/codeship: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
06e86ce50d
webhooks/bitbucket2: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
5e1a193e76
webhooks/circleci: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
af683800fd
webhooks/basecamp: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help
docs.
2018-02-08 17:45:56 -08:00
ad6dae1bf5
webhooks/appfollow: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
2733540492
webhooks/airbrake: Reformat documentation steps into numbered list.
...
This is a part of our efforts to migrate our webhook docs to have
a more structured numbered-list format similar to our /help docs.
2018-02-08 17:45:56 -08:00
4414f2b24b
webhooks/beeminder: Use create-a-bot.md macro.
2018-02-08 16:22:55 -08:00
15eaafa50f
Add underscores to thumbs_up and thumbs_down emoji
2018-02-07 11:55:02 -08:00
db152da7c9
webhooks/beeminder/doc.md: Add instructions for creating a bot.
2018-02-07 10:03:31 -08:00
1303248b0b
integration: Add statuspage.io webhook integration.
2018-02-07 09:59:12 -08:00
9fdd6f2bd4
integrations: Add Insping integration.
2018-01-31 14:36:54 -08:00
e8fe4a65af
webhooks/gitlab: Filter out hidden comments from issue descriptions.
...
Hidden comments of the form `<!-- comment -->` were previously
rendered as is when a new Issue was created. Now, we strip those
out completely!
2018-01-24 10:48:55 -08:00
a2ed76c383
mypy: Use Python 3 syntax for typing in beanstalk/tests.py
2018-01-23 08:49:42 -08:00
7ed76eeb23
mypy: Use Python 3 type syntax in zerver/webhooks/zendesk/view.py.
2018-01-23 08:37:56 -08:00
c4420ba0c6
mypy: Use Python 3 type syntax in zerver/webhooks/librato/view.py.
2018-01-23 08:37:56 -08:00
8a0cd1a966
mypy: Use Python 3 type syntax in zerver/webhooks/github_webhook/view.py.
2018-01-23 08:37:56 -08:00
d30c2463c2
mypy: Use Python 3 type syntax in zerver/webhooks/deskdotcom/view.py.
2018-01-23 08:37:56 -08:00
c6804f5c8d
mypy: Use Python 3 type syntax in zerver/webhooks/delighted/view.py.
2018-01-23 08:37:56 -08:00
39fe64132d
mypy: Use Python 3 type syntax in zerver/webhooks/codeship/view.py.
2018-01-23 08:37:56 -08:00
2c16c76551
beeminder: Fix buggy coding tag at top of file.
2018-01-18 09:07:06 -08:00
252a485621
integrations: Add documentation for Groove.
2018-01-17 13:00:11 -05:00
e5fc49e23a
integrations: Add documentation for Raygun.
2018-01-17 12:53:22 -05:00
c758636c1e
integrations: Add webhook code, API endpoint, and tests for Raygun.
2018-01-17 12:53:22 -05:00
a90e99dd3e
webhooks: Add Beeminder webhook.
2018-01-17 09:24:12 -05:00
4cb9edecda
integrations: Add documentation for Opbeat.
2018-01-17 09:17:19 -05:00
4e2b99a98b
integrations: Add webhook code, API endpoint, and tests for Opbeat.
2018-01-17 09:17:19 -05:00
457c5a7735
webhooks/gci: Support 'outoftime' event.
...
This commit adds support for the 'outoftime' event. Such an event
is triggered when the task deadline for a particular task has
passed.
2018-01-16 15:57:35 -08:00
64034241a0
webhooks: Create Intercom integration and docs.
2018-01-16 08:51:17 -05:00
aeeb9d07a8
integrations: Handle errors in Groove payloads.
2018-01-16 07:31:50 -05:00
68d86b62fa
integrations: Add webhook payloads for rollbar.
2018-01-11 06:32:37 -05:00
e417a99830
webhooks/gitlab: Support topic parameter to specify a topic.
...
Fixes #7743 .
2018-01-11 06:29:55 -05:00
ffa7637215
integrations: Add webhook code, API endpoint, and tests for Groove.
2018-01-09 09:32:52 -05:00
4f700ddcbf
integrations: Add webhook payloads for Raygun.
2018-01-04 11:44:39 -05:00
7c113d185f
integrations: Add webhook payloads for Facebook.
2018-01-03 14:47:50 -05:00
18c3bec667
webhooks/gci: Support "unassign" event type.
...
This commit adds support for the "unassign" event type, the
payloads for which are generated when a mentor unassigns a student
from a task.
2018-01-02 16:42:00 -05:00
2c7f4d2187
webhooks/gci: Support "extend" event type.
...
This commit adds support for events of type "extend", the payloads
for which are generated when a mentor extends the deadline for a
task.
2018-01-02 16:42:00 -05:00
e7f1a9ee34
inetgrations: Add webhook payloads for Honeybadger.
2018-01-02 11:45:33 -05:00
185fd99816
mypy: Use Python 3 type syntax in several files.
2017-12-30 07:34:51 -05:00
39fc26deff
integrations: Add webhook payloads for Runscope.
2017-12-29 07:27:20 -05:00
de62e11c23
integrations: Add webhook payloads for StatusPage.io.
2017-12-28 15:53:06 -05:00
2e35b7fd60
mypy: Use Python 3 type syntax in zerver/webhooks/taiga/view.py.
2017-12-28 07:26:44 -05:00
93cc19e3f8
mypy: Use Python 3 type syntax in zerver/webhooks/helloworld/view.py.
2017-12-28 07:26:44 -05:00
3b7fbc1a1d
mypy: Use Python 3 type syntax in zerver/webhooks/gosquared/view.py.
2017-12-28 07:26:44 -05:00
bebd8df728
zerver/webhooks/github/view: Sweep force_str.
2017-12-26 09:09:31 -05:00
99cb001345
zerver/webhooks/beanstalk/view.py: Sweep force_bytes and force_str.
2017-12-26 09:09:31 -05:00
f66f04f83a
mypy: Use Python 3 type syntax in 'bitbucket/tests.py'.
2017-12-26 08:34:38 -05:00
34aee15d63
mypy: Use Python 3 type syntax in 'gitlab/view.py'.
2017-12-26 08:34:38 -05:00
78042d7f18
mypy: Use Python 3 type syntax in 'webhooks/gogs/tests.py'.
2017-12-26 08:34:38 -05:00
51be0e5e76
mypy: Use Python 3 type syntax in zerver/webhooks/solano/view.py.
2017-12-26 08:34:06 -05:00
4f4d689f86
mypy: Use Python 3 type syntax in zerver/webhooks/splunk/view.py.
2017-12-26 08:34:06 -05:00
6c5f66c561
mypy: Use Python 3 type syntax in zerver/webhooks/slack/view.py.
2017-12-26 08:34:06 -05:00
ccc3d69f61
mypy: Use Python 3 type syntax in zerver/webhooks/bitbucket2/tests.py.
2017-12-26 08:31:09 -05:00
6bcc01bfee
mypy: Use Python 3 type syntax in zerver/webhooks/bitbucket/view.py
2017-12-26 08:30:33 -05:00
da9c808db4
mypy: Use Python 3 type syntax in zerver/webhooks/transifex/view.py
2017-12-26 08:30:33 -05:00
64ce353d4b
mypy: Use Python 3 type syntax in zerver/webhooks/circleci/view.py
2017-12-26 08:30:33 -05:00
2f575cca72
Add Dropbox webhook integration.
...
This is just a basic Dropbox webhook integration. It just
notifies a user when something has changed, it does not
specify what changed. Doing so would require storing data,
as Dropbox API was created mainly for file managers, not
integrations like this.
Closes #5672
2017-12-22 10:36:21 -05:00
6fc50fa21a
mypy: Use Python 3 type syntax in `zerver/webhooks/sentry/view.py`.
2017-12-22 08:17:00 -05:00
34001081c2
mypy: Use Python 3 type syntax in `zerver/webhooks/yo/view.py`.
2017-12-22 08:17:00 -05:00
678b43494b
mypy: Use Python 3 type syntax in `zerver/webhooks/airbrake/view.py`.
2017-12-22 08:17:00 -05:00
2acf3cf1d4
mypy: Use Python 3 type syntax in `zerver/webhooks/mention/view.py`.
2017-12-22 08:17:00 -05:00
e7f0139f69
mypy: Use Python 3 type syntax in `zerver/webhooks/travis/view.py`.
2017-12-22 08:17:00 -05:00
c8aadaa408
integrations: Add webhook payloads for Intercom.
2017-12-19 16:50:06 -05:00
8936d03f3a
webhooks/gitlab: Support Merge Request Hook approved event type.
...
Such payloads are generated when a GitLab repository has merge
request approvals enabled and a project member approves a merge
request. Approving is not the same as merging.
2017-12-18 19:12:54 -05:00
21008a49b9
webhooks/gci: Support approve-pending-pc event type.
...
This event is generated when a mentor approves a task but
GCI is still waiting on a student's parental consent.
2017-12-18 10:00:20 -08:00
a61a7f3965
mypy: Use Python 3 type syntax in zerver/webhooks/pingdom/view.py.
2017-12-18 11:32:52 -05:00
4508264f25
mypy: Use Python 3 type syntax in zerver/webhooks/opsgenie/view.py.
2017-12-18 11:32:52 -05:00
52f0c4472e
mypy: Use Python 3 type syntax in zerver/webhooks/ifttt/view.py.
2017-12-18 11:32:52 -05:00
23b29212a3
mypy: Use Python 3 type syntax in zerver/webhooks/greenhouse/view.py.
2017-12-18 11:32:52 -05:00
403ea486e4
mypy: Use Python 3 type syntax in zerver/webhooks/gogs/view.py.
2017-12-18 11:32:52 -05:00
33e1879295
mypy: Use Python 3 type syntax in zerver/webhooks/beanstalk/view.py.
2017-12-18 11:32:52 -05:00
c55685063f
mypy: Use Python 3 type syntax in zerver/webhooks/appfollow/view.py.
2017-12-18 11:32:52 -05:00
90aa6c627e
tests: Replace api_auth usages with auth methods in zerver/webhooks.
2017-12-18 09:24:09 -05:00
3792bd2d69
integrations: Add webhook payloads for Groove.
2017-12-14 18:54:22 -05:00
ebc7c72d99
mypy: Use Python 3 type syntax in wordpress/view.py
2017-12-11 20:33:00 -08:00
2db270be4b
mypy: Use Python 3 type syntax in crashlytics/view.py
2017-12-11 20:33:00 -08:00
1fa5233923
mypy: Use Python 3 type syntax in gitlab/tests.py
2017-12-11 20:33:00 -08:00
cc427911fa
mypy: Use Python 3 type syntax in stripe/view.py
2017-12-11 20:33:00 -08:00
f07d39353a
mypy: Use Python 3 type syntax in zerver/webhooks/basecamp/view.py.
2017-12-11 20:27:55 -08:00
d038e7ea6b
mypy: Use Python 3 type syntax in zerver/webhooks/bitbucket2/view.py.
2017-12-11 20:27:55 -08:00
20c2e53de4
mypy: Use Python 3 type syntax in zerver/webhooks/jira/view.py.
2017-12-11 20:27:55 -08:00
15fb392dd1
mypy: Use Python 3 type syntax in zerver/webhooks/papertrail/view.py.
2017-12-11 20:27:55 -08:00
3fb9803398
mypy: Use Python 3 type syntax in zerver/webhooks/teamcity/view.py.
2017-12-11 20:27:55 -08:00
1d202e30d8
integrations: Add webhook payloads for Opbeat.
2017-12-11 15:40:49 -06:00
4eb3202b13
integrations: Remove weather example from zapier doc.
...
I don't think it made the page more readable, and doubled the length.
2017-12-11 15:39:26 -06:00
1f34300006
mypy: Use Python 3 type syntax in zerver/webhooks/trello/tests.py.
2017-12-09 16:50:12 -08:00
a6465e8e35
mypy: Use Python 3 syntax in zapier/view.py.
2017-12-08 18:34:26 -08:00
1262d14d39
mypy: Use Python 3 syntax in gci/view.py.
2017-12-08 18:34:26 -08:00
38e65570ae
mypy: Use Python 3 syntax for typing in heroku/view.py.
2017-12-08 18:34:26 -08:00
5febd177cf
mypy: Use Python 3 type syntax in zerver/webhooks/newrelic/view.py.
2017-12-05 16:32:18 -08:00
d55d680758
mypy: Use Python 3 type syntax in zerver/webhooks/homeassistant/view.py.
2017-12-05 16:32:18 -08:00
c2ef7e7ce5
mypy: Use Python 3 type syntax in zerver/webhooks/freshdesk/view.py.
2017-12-05 16:32:18 -08:00
67773a4b84
mypy: Use Python 3 type syntax in zerver/webhooks/semaphore/view.py.
2017-12-03 13:48:18 -08:00
6dd639454e
integrations: Add topic parameter for Appfollow.
...
Tweaked by tabbott to document the integration.
2017-11-28 15:49:19 -08:00
d5bb45db60
webhooks/gci: Fix missing mypy annotation.
2017-11-28 14:08:44 -08:00
bea653fabc
webhooks/gci: Improve message formatting.
...
* Use Student Name instead of Task Name in subject.
* Use Task Instance URL instead of Task Definition URL (and workaround
for a bug in the API).
2017-11-28 13:53:42 -08:00
5b8f38f4e3
webhooks/bitbucket2: Ignore push events with no changes.
...
We now ignore payloads where payload['push']['changes'] is empty,
because an empty push doesn't really convey any useful information.
I couldn't find a way to replicate the action that would generate
such a payload, so I took one of our existing payloads and editted
out payload['push']['changes'] myself, so this payload is not
authentic.
2017-11-26 17:03:07 -08:00
23162a1433
github_webhook: Use indented Markdown macros.
2017-11-25 17:01:11 -08:00
1dca7cc367
webhooks/beanstalk: Use indented Markdown macros.
2017-11-25 17:01:11 -08:00
5f6dbe6226
fixtures: replace optparse example with argparse.
2017-11-21 21:23:41 -08:00
02a32e246e
webhooks/gitlab: Support test payloads without an "action" attribute.
...
Payloads that don't have a payload['object_attributes']['action']
attribute are generated when GitLab sends a test payload to verify
if the webhook was set up successfully. In this case, we should
send a message notifying that the webhook was configured
successfully.
2017-11-19 20:56:10 -08:00
73a668e7ae
python: Sort imports in webhooks.
2017-11-15 15:43:10 -08:00
bafba95eb7
Text-wrap the remaining long lines exceeding 110.
2017-11-15 10:58:03 -08:00
8480deb754
integration docs: Fix broken desk.com markdown.
2017-11-10 17:33:42 +00:00
325ca0df62
integration docs: Fix broken Stripe markdown.
...
More information: https://chat.zulip.org/#narrow/stream/issues/topic/.237336
2017-11-10 17:19:52 +00:00
7477fbb14e
docs: Remove dangling </p> tag.
...
Fixes #7336
2017-11-09 14:39:40 -08:00
bb46bea44d
Remove usage of six.moves.text_type.
2017-11-09 10:00:00 -08:00
04eaec64f0
zerver/webhooks: Text-wrap long lines exceeding 110.
2017-11-07 17:24:09 -08:00
d038bf89ac
mypy: Adjust pivotal/view.py function parameter type based on body.
2017-11-07 11:26:46 -08:00
549a26860f
refactor: Remove six.moves.range import.
2017-11-07 10:46:42 -08:00
ec5120e807
refactor: Remove six.moves.zip import.
2017-11-07 10:46:42 -08:00
19bd335cbb
Change urllib import to be Python 3-specific.
2017-11-07 10:46:42 -08:00
8990b1046d
zerver: Remove inheritance from object.
2017-11-06 08:53:48 -08:00
42f5eea61f
mypy: Improve typing of request.pyi (REQ).
...
This expands request.pyi to type-check the arguments passed into REQ.
Tweaked by tabbott to fix the report.py annotations.
2017-11-04 20:26:03 -07:00
720df640e7
mypy: Set freshdesk TicketDict to inherit from typed Dict.
2017-11-04 19:47:45 -07:00
969cc506d2
zerver/webhooks: Use python 3 syntax for typing.
...
Tweaked by tabbott to fix various line-wrapping issues.
2017-11-04 19:40:32 -07:00
aaaed74c3d
webhooks: Import REQ, has_request_variables from zerver.lib.request.
...
We now import REQ and has_request_variables from zerver.lib.request,
which is where these methods are defined.
Fixes #7195 .
2017-11-02 14:40:55 -07:00
20f3e9b779
webhooks/gci: Support 'needswork' event_type.
...
This commit adds support for payloads that are generated when a
mentor submits a task for more work.
2017-11-02 16:46:11 -02:30
9969a3a40b
webhooks/gci: Replace 'type' -> 'event_type', 'uuid' -> 'id'.
2017-11-02 16:39:48 -02:30
7d8de37299
mypy: Specify librato Callable type.
2017-10-31 00:03:35 -07:00
eb55a3a1ba
template context: Give better names to the URLs for the API.
...
The "subdomain" label is redundant, to the extent it's even
accurate -- this is really just the URL we want to display,
which may or may not involve a subdomain. Similarly "external".
The former `external_api_path_subdomain` was never a path -- it's a
host, followed by a path, which together form a scheme-relative URL.
I'm not quite convinced that value is actually the right thing in
2 of the 3 places we use it, but fixing that can start by giving an
accurate name to the thing we have.
2017-10-30 18:29:29 -07:00
c4fcff7178
refactor: Replace super(.*self) with Python 3-specific super().
...
We change all the instances except for the `test_helpers.py`
TimeTrackingCursor monkey-patching, which actually needs to specify
the base class.
2017-10-30 14:30:25 -07:00
655f37a34b
Rename subject_name in send_message_backend().
2017-10-27 10:48:11 -07:00
8e2cdedf9a
lint: Fix lines in Python codebase longer than 120 characters.
2017-10-26 17:47:30 -07:00
b936e8c24b
lint: Fix lines in Python codebase longer than 125 characters.
2017-10-26 17:36:54 -07:00
be619fe881
lint: Wrap many very long lines in the Python codebase.
...
This decreases the maximum line length in our Python codebase to 130.
2017-10-26 17:31:58 -07:00
bd814eea2b
webhooks/taiga: Support relateduserstory events.
...
This commit adds support for the following:
1. When a user story is added to an epic.
2. When a user story is removed from an epic.
2017-10-25 10:59:58 -07:00
f8b5976335
webhooks/taiga: Support Epic events.
2017-10-23 11:09:43 -07:00
cfadb43b93
codebase: Remove multiple whitespaces after comma.
2017-10-18 10:04:23 -07:00
fb17481a7f
webhooks/gci: Support claim, comment, submit, approve event types.
2017-10-16 22:01:19 -07:00
fc947d92e2
mypy: Improve return type in bitbucket2 webhook function.
2017-10-11 12:16:50 -07:00
71eee35bce
webhooks: Add a Google Code-in integration.
2017-10-09 09:04:39 -07:00
e3c395f247
webhooks: Remove use of get_user_profile_by_email.
...
This function is deprecated.
2017-10-02 15:28:44 -07:00
32bd609361
webhooks/yo: Migrate to check_send_private_message.
2017-10-02 15:27:26 -07:00
d20b57c20d
webhooks/teamcity: Migrate to check_send_private_message.
2017-10-02 15:27:26 -07:00
d1afab7199
Replace deprecated Logging.warn calls with Logging.warning.
2017-10-02 11:11:42 +02:00
86c2c7ad34
webhooks: Migrate to check_send_stream_message.
...
This commit migrates all webhooks to use check_send_stream_message
instead of check_send_message. The only two webhooks that still
use check_send_message are our yo and teamcity webhooks. They
both use check_send_message for private messages.
2017-09-30 17:48:55 -07:00
da3c008872
webhooks/trello: Remove trello/view/templates.py.
...
TRELLO_MESSAGE_TEMPLATE and TRELLO_SUBJECT_TEMPLATE are
redundant. This commit removes them. Now, subjects don't end
in periods. And where a period is necessary in the message body,
one is appended at the end of the specific template for that
message.
2017-09-28 10:58:07 -07:00
a6b83def8f
webhooks/trello: Support updating Card descriptions.
...
We now support events that add, change or remove Trello Card
descriptions.
Minor fixes by eeshangarg.
2017-09-28 10:58:07 -07:00
765f8e7d41
webhooks/trello: Display Card comment's text in notifications.
...
Now, when someone makes a comment on a Trello Card, the text
of the comment is quoted in the notification.
Minor fixes by eeshangarg.
2017-09-28 10:58:07 -07:00
7115a29bee
zerver/webhooks: Remove absolute_import.
2017-09-27 10:00:39 -07:00
e6daee441b
mypy: Adjust board_actions.py to allow Optional[Text] values.
2017-09-25 16:02:56 -07:00
a041a23199
webhooks/trello: Ignore when Board background is changed.
...
I feel like getting notifications about a board's background being
changed isn't very useful information and could interrupt the flow
of other important information such as Card changes or movement,
so I think we should not support this event and
should simply ignore such payloads in the future.
2017-09-15 01:02:47 -07:00
27101ae931
trello: Use client_head wrapper in tests.
2017-08-26 13:45:27 -07:00
7d08ff69f0
tests: Remove most references to get_api_key.
...
This test helper doesn't really have value.
2017-08-24 23:30:46 -07:00
69059dcac8
tests: Clean up subscribing from webhook tests.
2017-08-24 21:37:57 -07:00
Eeshan Garg
neiljp (Neil Pilgrim)
Ricky
Tim Abbott
Alena Volkova
Rishi Gupta
nyan-salmon
Sumana Harihareswara
Josh Mandel
Privisus
Patrick Grave
Abijith10
infinitelooped
fredfishgames
Viraat Chandra
Sivagiri Visakan
Kiy4h
Xavier Cooney
MadElf1337
rht
Rhea Parekh
greysome
Angelika Serwa
Marco Burstein
Callum Fraser
Ivche1337
Arseny Chekanov
derAnfaenger
Sampriti Panda
Tommy Ip
Greg Price
Steve Howell
Marco Matarazzo