9b13b19006
docs: Add ')' and correct reference to step number in bots guide.
2017-05-29 20:52:23 -07:00
4a531ac203
Updates get_help() function in 'virtual_fs' bot.
...
Update example commands from calling by keyword 'fs'
(As was done previously) to calling by at-mention of
the bot.
Updates '/contrib_bots/bots/virtual_fs/virtual_fs.py' by
correcting instructions on how to call 'virtual_fs' bot.
2017-05-29 20:44:13 -07:00
9f17bded92
Fix minor errors in bots-guide.
2017-05-29 20:41:15 -07:00
643d70eae1
contrib_bots: Add check_expected_responses() test helper and use it.
...
This further simplifies the logic for testing a contrib_bots bot to
require very little code per test in the common case.
2017-05-29 20:39:27 -07:00
695c71d2cc
bots: Add weather reporting bot.
2017-05-29 20:33:16 -07:00
7126f6f30c
settings: Allow either admin or realm emoji author to delete it.
...
If a realm is configured to allow any user to upload a realm emoji
then that user should also be allowed to delete the emoji in case
he feels it doesn't look good or if he uploaded a wrong emoji file.
This commit tweaks the realm emoji settings UI to allow an user who
uploaded an emoji to delete it.
Fixes : #4761 .
2017-05-29 20:21:26 -07:00
298e23b447
realm_emoji.py: Allow an user to delete an emoji uploaded by them.
...
If a realm is configured to allow any user to upload an emoji,
then, an emoji author must be allowed to delete an emoji uploaded
by them.
2017-05-29 20:21:25 -07:00
879abd6290
Add coverage for update_existing_reaction().
2017-05-29 20:10:53 -07:00
1ae66cda6f
Increase test coverage for insert_new_reaction.
2017-05-29 20:10:53 -07:00
80920438a5
Add coverage for get_emojis_used_by_user_for_message_id.
2017-05-29 20:10:53 -07:00
99c2e1875d
api: Increase the version from 0.2.5 to 0.3.0.
2017-05-29 20:09:59 -07:00
debe9fa9dc
api: If there is no $HOME, assume .zuliprc doesn't exist.
2017-05-29 20:09:57 -07:00
ecbbc8788a
Move code from reactions -> emoji_picker.
...
This moves all the code dealing with emoji_picker
navigation and click/enter events to emoji_picker.js.
Some of the code still delegates back to reactions.js
in some way.
The navigate() code really does nothing reaction-specific,
nor does filter_emojis(), nor do some of their helpers.
This was mostly moving code, but I also did some
s/reaction// or s/reaction/emoji/ in names.
2017-05-29 17:10:05 -06:00
3654406f17
Simplify/rename code to choose reaction in emoji picker.
...
We now call the function toggle_selected_emoji(), and it
is simpler in these ways:
* We get the selected emoji more directly.
* We reuse code in toggle_emoji_reaction().
2017-05-29 17:10:05 -06:00
ed2ceb49cb
Use toggle_emoji_reaction for "+" hotkey.
...
This is a more direct codepath when we know which emoji
we want to toggle.
2017-05-29 17:10:05 -06:00
1ee757a237
Use toggle_emoji_reaction() in the emoji picker.
...
If we know the name of the emoji you need to toggle,
we can toggle_emoji_reaction(), which is less complex
than toggle_reaction().
2017-05-29 17:10:04 -06:00
805c99ae27
Add hide_emoji_popover() to toggle_emoji_reaction().
...
This change sets us up to de-duplicate some code. It
changes behavior for the edge case situation where
you had the reaction menu open but then decide to
click on one of the existing reactions. This change
closes the emoji popover, which is probably the
correct behavior.
2017-05-29 17:10:04 -06:00
63d0711c4b
Rename message_reaction_on_click() to toggle_emoji_reaction().
...
This prepares us to de-duplicate some code.
2017-05-29 17:10:04 -06:00
9cf9837f12
webhooks: Add outgoing webhook bot user to development database.
2017-05-29 16:01:23 -07:00
4acc89d379
help: Document the : hotkey for choosing reactions.
2017-05-29 15:43:55 -07:00
7b152bf0ad
help: Clarify discussion of the emoji reactions picker.
...
The word "menu" was kinda confusing here.
Follow-up to #4547 .
2017-05-29 15:43:44 -07:00
3037be9bc0
help: Document how to navigate the emoji reactions picker.
...
Fixes #4547 .
2017-05-29 15:43:07 -07:00
4040cadf7d
coverage: Omit some test runner files from coverage.
...
These files are part of the test runner and can't realisitically have
test coverage due to being imported before coverage in the setup
sequence.
2017-05-29 15:30:49 -07:00
4893779001
test_events: Avoid coverage errors in LogEventsTest.
2017-05-29 15:26:33 -07:00
a4c3f571db
Switch change_tos_version to use RealmAuditLog.
2017-05-29 15:24:01 -07:00
685fb16c39
Switch change_full_name to use RealmAuditLog.
...
This requires adding an `acting_user` parameter to the
`do_change_bot_owner` function.
2017-05-29 15:22:08 -07:00
ce26f0e086
integrations: Remove legacy basecamp integration.
...
Now that we have the webhook integration, there's no reason to
maintain the pre-webhook version.
2017-05-29 15:10:59 -07:00
49e3ee36c4
Add tests for reactions.remove_reaction().
2017-05-29 14:59:52 -07:00
affff8ac82
Extract reactions.set_reaction_count.
2017-05-29 14:59:52 -07:00
1747223c35
reactions: Refactor remove_reaction().
...
* Add whitespace/comments.
* Use find_reaction() helper.
* Handle full-removal earlier in block.
* Sequence operations in a more organized way.
2017-05-29 14:59:52 -07:00
5c405f7048
reactions: Refactor add_reaction().
...
This commit splits out some helper methods to make it easier
to test:
get_reaction_section
find_reaction
get_add_reaction_button
update_existing_reaction
insert_new_reaction
2017-05-29 14:59:52 -07:00
2d73e03e37
ui-refactor: Rename modals.js to overlays.js.
...
Fixed #4702 .
2017-05-29 11:24:46 -07:00
1f4e1ece3a
Fix flaky time-based test.
...
For testing waiting period thresholds, we need to
explicitly set date_joined for Hamlet to be now.
2017-05-29 11:54:06 -06:00
43e76816ff
message view: Recipient bar date stamp shows older years.
...
timerender.js render_now() will always include older
years when rendering the date stamp on the recipient bar
and the date rows above messages.
Fixes #4843 .
2017-05-29 08:54:06 -07:00
fcf97660db
testing-coverage: add node tests for timerender.js.
...
Initial set of tests for the timerender.js module.
Fixes #4819 .
2017-05-29 08:51:28 -07:00
ea3c994186
refactoring: timerender.js render_now() returns an object.
...
The render_now() function in timerender.js will now return
an object instead of an array, which is then passed to the
functions render_date_span() and update_timestamps().
This should increase readability and extensibility.
Fixes #4820 .
2017-05-29 08:51:24 -07:00
5ffdce9aab
test-js-with-node: Set timezone to UTC for tests.
2017-05-29 08:47:26 -07:00
5f48b51b60
provision: Add `cd /srv/zulip` to profile.
...
I didn't bump the provision version on this change, as it
won't break anything if somebody fails to make this change.
2017-05-29 08:40:49 -07:00
c95abd4618
Replace broken aria-labelledby with aria-label in help modal.
...
Fixes #4921 .
2017-05-28 22:49:16 -07:00
30e54a94f2
html: Add aria-labels for search bars for accessibility.
...
Added an attribute which can be read by assistive technology.
Fixes #4996 .
2017-05-28 22:49:00 -07:00
735aa9f2c6
Rename misleading 'system-docs' reference.
2017-05-28 22:21:13 -07:00
c0f0dabec6
Rename misleading 'code-docs' reference.
2017-05-28 22:21:13 -07:00
7f6b6fae26
Rename misleading 'tutorial-docs' reference.
2017-05-28 22:21:13 -07:00
f6c59a483c
docs: Rename misleading 'dev-install-docs' reference.
2017-05-28 22:21:13 -07:00
54a618b597
docs: Rename misleading 'prod-install-docs' reference.
2017-05-28 22:21:13 -07:00
9c0ba87b5e
docs: Rename misleading 'user-docs' reference.
2017-05-28 22:21:13 -07:00
8cc1f13d24
test: Add test_notify_realm_of_new_user.
2017-05-28 19:14:52 -07:00
44ec27c122
webhooks/gosquared: Migrate docs to Markdown.
2017-05-28 18:44:00 -07:00
e5484f1bf5
webhooks/ifttt: Migrate docs to Markdown.
2017-05-28 18:44:00 -07:00
846e560bfd
webhooks/hellosign: Migrate docs to Markdown.
2017-05-28 18:44:00 -07:00
neiljp
Abhijeet Kaur
Krzysztof Krzysztof
Harshit Bansal
Steve Howell
Eeshan Garg
vaibhav
Tim Abbott
Daniel Lau
Maxim Averin
Rohitt Vashishtha
David
Cory Lynch
derAnfaenger
Ron Shafii