Umair Khan
d95d34a66a
Retry email failures in missed-message emails queue.
...
Fixes #6518 .
2017-10-03 10:35:07 -07:00
Umair Khan
7d6ddaad26
mypy: Use Dict instead of Mapping in queues.
2017-10-03 10:35:07 -07:00
Tim Abbott
5eddedd9f6
requirements: Switch talon to a zulip fork.
2017-10-03 09:03:53 -07:00
Tim Abbott
104d5f1142
requirements: Switch virtualenv-clone to a zulip fork.
2017-10-03 08:59:03 -07:00
Tim Abbott
d4fd2e5f41
requirements: Switch pyoembed to a zulip fork.
...
This helps us avoid the install process breaking if upstream has a
problem.
2017-10-03 08:56:42 -07:00
Tim Abbott
b8b9af3733
requirements: Switch fakeldap to a zulip fork.
...
This will help us avoid breaking installation of older versions of
Zulip.
2017-10-03 08:52:44 -07:00
Cynthia Lin
c87ecf0f63
hotkeys: Prevent drafts overlay from showing while lightbox is open.
...
Fixes #6757 .
2017-10-03 08:36:54 -07:00
Cynthia Lin
c99f3d585d
hotkeys: Prevent lightbox closing when message view hotkey is pressed.
...
Fixes #6757 .
2017-10-03 08:36:54 -07:00
Umair Khan
60b8cba7df
django: Bump version to 1.11.5.
2017-10-03 08:27:06 -07:00
Brock Whittaker
e8b127916a
emails: Override default button styling.
...
Some email services will provide default styling for things like
buttons, and in this case the site created a style that had a
`background` attribute that overrode our `background-color` attribute
because of CSS importance heirarchy. This swiches us to use
`background` as well.
This also forces no `text-shadow` on buttons.
Fixes : #6775 .
2017-10-02 17:58:30 -07:00
Tim Abbott
7581e0e1c5
settings: Remove remaining references to REALMS_HAVE_SUBDOMAINS.
2017-10-02 16:43:54 -07:00
Tim Abbott
1d72629dc4
subdomains: Hardcode REALMS_HAVE_SUBDOMAINS=True.
2017-10-02 16:42:43 -07:00
Tim Abbott
95a0a4a06f
subdomains: Update AuthBackendTest for subdomains always on.
...
This is separate from the main subdomains commit mainly for
readability of the history.
2017-10-02 16:32:11 -07:00
Tim Abbott
26a5332828
subdomains: Update some tests to run with subdomains.
...
Specifically, our request middleware adds an extra database query for
these code paths, to verify whether the subdomain is valid.
2017-10-02 16:32:11 -07:00
Tim Abbott
13bb546ddd
subdomains: Hardcode can_add_realm_domains=True.
...
It was already always True if REALMS_HAVE_SUBDOMAINS, and now that's
the only supported configuration.
2017-10-02 16:32:10 -07:00
Tim Abbott
66658bbf25
subdomains: Hardcode REALMS_HAVE_SUBDOMAINS in API docs.
2017-10-02 16:32:10 -07:00
Tim Abbott
262a0692ab
subdomains: Delete completely_open helper function.
...
We no longer use this anyway.
2017-10-02 16:32:10 -07:00
Tim Abbott
e9f13a91e7
subdomains: Remove get_unique_non_system_realm.
...
This functionality is no longer required with REALMS_HAVE_SUBDOMAINS
always True.
2017-10-02 16:32:10 -07:00
Tim Abbott
e6f8032972
subdomains: Remove get_unique_open_realm code paths.
...
Since we no longer support !REALMS_HAVE_SUBDOMAINS in production,
these no longer make sense.
2017-10-02 16:32:10 -07:00
Tim Abbott
c447e7530b
docs: Update realms documentation for REALMS_HAVE_SUBDOMAINS removal.
2017-10-02 16:32:10 -07:00
Tim Abbott
99e4ceebd4
test_auth_backends: Extract REALMS_HAVE_SUBDOMAINS overrides.
...
This will make the diff a lot smaller when we hardcode
REALMS_HAVE_SUBDOMAINS=True.
2017-10-02 16:32:09 -07:00
Tim Abbott
83a226ad3d
do_send_message: Replace get_user_profile_by_email.
...
get_system_bot is the new way to do this sort of thing.
2017-10-02 16:15:36 -07:00
Tim Abbott
bd066fe0f1
test_subdomain_restrictions: Update to assume subdomains.
2017-10-02 15:32:39 -07:00
Tim Abbott
e3c395f247
webhooks: Remove use of get_user_profile_by_email.
...
This function is deprecated.
2017-10-02 15:28:44 -07:00
Eeshan Garg
32bd609361
webhooks/yo: Migrate to check_send_private_message.
2017-10-02 15:27:26 -07:00
Eeshan Garg
d20b57c20d
webhooks/teamcity: Migrate to check_send_private_message.
2017-10-02 15:27:26 -07:00
Eeshan Garg
763437cc9c
backend: Introduce check_send_private_message.
...
check_send_private_message utilizes Addressee.for_user_profile()
to send a private message to a user_profile.
2017-10-02 15:27:26 -07:00
Eeshan Garg
502e93a5d2
docs: Recommend check_send_stream_message for stream messages.
...
This commit updates various places where check_send_message had
been previously recommended to recommend check_send_stream_message
for sending messages to a public stream.
2017-10-02 15:27:26 -07:00
Steve Howell
2be713a7e4
Rename get_userids_for_missed_messages().
...
We rename this function to get_active_presence_idle_userids().
2017-10-02 15:19:28 -07:00
Steve Howell
e660428c21
Rename missed_message_userids to presence_idle_userids.
2017-10-02 15:19:28 -07:00
Steve Howell
32d5e297a3
Rename get_idle_userids to filter_presence_idle_userids.
...
We have two different concepts of "idle", and this function
is based on the "presence" aspect of idleness. There is also
idleness in terms of a user having no current client
descriptors accepting messages, and we check that later in
the process for things like sending missed message emails.
2017-10-02 15:19:28 -07:00
neiljp (Neil Pilgrim)
ee8d7de7c3
mypy: Upgrade mypy to mypy commit on Oct 2 2017.
...
Also fix the fact we apparently forgot to remove fonttools from
dev_lock.txt.
2017-10-02 15:15:08 -07:00
Tim Abbott
e5592fe89f
test_signup: Remove REALMS_HAVE_SUBDOMAINS check.
...
This test actually is just as correct with
REALMS_HAVE_SUBDOMAINS=True.
2017-10-02 13:50:07 -07:00
Tim Abbott
9622da6b16
test_signup: De-inline REALMS_HAVE_SUBDOMAINS=True checks.
...
These are now just declarations at the top of functions.
2017-10-02 13:50:06 -07:00
Tim Abbott
edc10e8f51
test_decorators: de-inline REALMS_HAVE_SUBDOMAINS with statements.
...
This will significantly shrink the diff when we toggle
REALMS_HAVE_SUBDOMAINS soon.
2017-10-02 13:49:53 -07:00
Tim Abbott
f05719e335
test-api: Fix tests to work with subdomains.
2017-10-02 13:31:22 -07:00
Tim Abbott
5a27a4cf1c
decorator: Improve wrong-subdomain logging output.
...
Often, it's helpful to see both values in errors.
2017-10-02 13:31:20 -07:00
Vishnu Ks
6b9755c854
email_log: Make generate_email work with subdomains.
...
This fixes one of our last few test failures with
REALMS_HAVE_SUBDOMAINS.
2017-10-02 12:27:27 -07:00
Tim Abbott
6327f30c76
test_decorators: Remove test_login_deactivated_realm.
...
This test was a duplicate of test_login_deactivated in LoginTest.
2017-10-02 11:42:15 -07:00
Tim Abbott
f69523e0c8
travis: Modify success-http-headers.
...
Travis CI seems to have changed their version of wget such that it no
longer prints this.
2017-10-02 10:35:48 -07:00
rht
45f30c7f54
tools: Remove unused imports.
2017-10-02 10:13:48 -07:00
rht
2c2adbf647
tools/lib: Remove unused imports.
2017-10-02 10:13:46 -07:00
rht
8a631a2fde
tools: Replace optparse with argparse.
2017-10-02 10:09:49 -07:00
derAnfaenger
6c8b405c7e
linter: Add rule against using the deprecated Logging.warn.
...
Tweaked by tabbott to improve the test cases.
2017-10-02 09:31:11 -07:00
derAnfaenger
d1afab7199
Replace deprecated Logging.warn calls with Logging.warning.
2017-10-02 11:11:42 +02:00
Tim Abbott
7d63928fe1
test_signup: Update deactivate realm tests for subdomains.
...
We add a new test to make sure we cover the potential race condition
with the realm being deactivated after starting the registration
process.
2017-10-01 23:52:08 -07:00
Tim Abbott
50eb94f7ee
docs: Remove broken link to shell tips.
...
In theory, we could replace it, but it's not clear that's necessary.
2017-10-01 23:27:29 -07:00
Tim Abbott
651b1882e6
test_outgoing_webhook_system: Set REALMS_HAVE_SUBDOMAINS=True.
2017-10-01 22:47:15 -07:00
Nalin Bhardwaj
73de273726
stats: Remove hourly data from messages sent over time.
...
Fixes #6564 .
2017-10-01 22:10:43 -07:00
Priscilla
7c0431a60f
docs: Correct the instructions for re-running provision.
...
We apparently missed this when renaming provision.py to simply
provision.
2017-10-01 15:51:32 -07:00