Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity
20,485 Commits 28 Branches 143 Tags 631 MiB
Commit Graph

5590 Commits

Author SHA1 Message Date
Tim Abbott b8e7369dee mypy: Remove type: ignores not needed in Python 3. 2017-08-25 11:04:20 -07:00
Tim Abbott 498c298c14 rate_limiter: Fix buggy use of NotImplementedError. 2017-08-25 09:53:09 -07:00
Tim Abbott bee86b6e6b send_email: Fix modification of mutable default value. 2017-08-25 09:43:53 -07:00
Tim Abbott 537ad1ff1b templatetags: Fix buggy exception clause. 2017-08-25 00:39:58 -07:00
Tim Abbott 1bb09e35d2 message: Add assertions for invalid recipient types. 2017-08-25 00:39:36 -07:00
Tim Abbott f3c73e4aa4 actions: Add assertion for invalid flag operations. 2017-08-25 00:34:56 -07:00
Tim Abbott 35f1bbb968 process_new_human_user: Simplify prereg_user logic. 
We don't need the old code paths now that we don't have an MitUser
model anymore.
 2017-08-25 00:34:06 -07:00
Umair Khan 9720d3a986 accounts_register: Use redirect_to_deactivation_notice. 2017-08-25 00:09:06 -07:00
Umair Khan 43c40f6144 Add tests for deactivation notice. 2017-08-25 00:09:06 -07:00
Umair Khan b473ff54ce Show realm deactivation notice for login/register. 
Fixes #6247
 2017-08-25 00:09:06 -07:00
Tim Abbott 50defd9b70 test_classes: Remove some unnecessary functions. 2017-08-24 23:33:12 -07:00
Tim Abbott 7d08ff69f0 tests: Remove most references to get_api_key. 
This test helper doesn't really have value.
 2017-08-24 23:30:46 -07:00
Tim Abbott e2ae096035 test_signup: Fix coverage of remaining find_my_team code. 2017-08-24 23:30:46 -07:00
Tim Abbott 59aae22f99 registration: Fix find_my_team handling of unusual users. 2017-08-24 23:17:08 -07:00
Tim Abbott ca7075a0a8 test_signup: Clean up find_my_team test suite. 2017-08-24 23:17:08 -07:00
Tim Abbott eeabed9119 models: Add new get_user_profile_by_api_key helper. 
This results in a slight performance increase.
 2017-08-24 23:17:08 -07:00
Tim Abbott 80caa5c66f socket: Use get_user_profile_by_id. 
This should have a slight performance benefit.
 2017-08-24 23:16:42 -07:00
Tim Abbott ffafa05bd5 decorator: Remove unnecesary import. 2017-08-24 23:16:31 -07:00
Tim Abbott 2aab6e0f49 forms: Replace is_inactive with more comprehensive check. 
While we're at it, we clean up the old confusing error messages.
 2017-08-24 23:16:31 -07:00
Tim Abbott b3dbba3ad4 actions: Extract validate_email_for_realm helper. 2017-08-24 23:16:31 -07:00
Tim Abbott c8f53e55db websocket_client: Use get_system_bot. 
This messy code is used only for our websocket Nagios tests, so using
get_system_bot makes sense.
 2017-08-24 23:16:18 -07:00
Tim Abbott e915fa058a test_classes: Stop using get_realm_by_email_domain. 
get_realm_by_email_domain was intended to be registration flow code
not used in other code, but it was leaked to a few places.  This
removes one of the main remaining references to it outside the
registration code path.
 2017-08-24 21:38:02 -07:00
Tim Abbott 95ed00bade tests: Remove now-unused subscribe_to_stream helper. 2017-08-24 21:38:02 -07:00
Tim Abbott 69059dcac8 tests: Clean up subscribing from webhook tests. 2017-08-24 21:37:57 -07:00
Tim Abbott 5fa7c3e0b2 test_classes: Clean up API for unsubscribing. 
The old API required test authors to unnecessarily repeat themselves.
 2017-08-24 21:37:57 -07:00
Tim Abbott eb720485c5 tests: Add and use new self.subscribe. 
This new method cleans up the API for subscribing to something from a
test case.
 2017-08-24 21:37:57 -07:00
Tim Abbott 60105fe38a registration: Remove accounts_home_with_realm_str. 
This was the old mechanism for logging into a specific realm on a
server with more than one not using REALMS_HAVE_SUBDOMAINS.
 2017-08-24 20:44:52 -07:00
Tim Abbott 522562f68f outgoing_webhook: Stop using get_realm_by_email_domain. 
There was no reason to do a complicated lookup to get the realm here.
 2017-08-24 20:27:00 -07:00
Tim Abbott 80458945c7 tests: Remove unnecessary use of get_realm_by_email_domain. 
That function was primarily intended for some limited registration
code paths, not the generic usage it was getting.
 2017-08-24 20:22:56 -07:00
Aditya Bansal 6a2c83f051 notifications: Group messages by (recipient, sender) for PM's. 
This fixes a issue with multiple PM's being clubbed into a single
missed message email.

Fixes #6224.
 2017-08-24 19:58:55 -07:00
Tim Abbott 0693656b89 register: Allow the empty string as a subdomain. 
This is conditioned on the server being configured with
ROOT_DOMAIN_LANDING_PAGE=True.
 2017-08-24 19:39:40 -07:00
Tim Abbott 3d4893d906 settings: Rename SUBDOMAINS_HOMEPAGE to ROOT_DOMAIN_LANDING_PAGE. 
This new setting name is a lot more readable.
 2017-08-24 19:32:16 -07:00
Tim Abbott ab61fe5922 auth: Fix Google auth to not assume SUBDOMAINS_HOMEPAGE. 
Previously, Google auth would redirect you back to the login page on
this code path.
 2017-08-24 19:03:42 -07:00
Eeshan Garg 31986d1b94 github_webhook: Update "pull_request unassigned" event fixture. 
The older fixture for this event assumed that the "assignee" key
had a value of '{}' if no one was assigned to a PR anymore.
However, that is no longer true because testing with requestbin
showed that in the latest JSON payload for this event, the key
"assignee" now has the value of 'null' (None when converted to
Python) when a user is unassigned from a PR. The current code
didn't handle this correctly. This commit makes sure it does!

Its unclear as to whether the old fixture was simply wrong or
whether GitHub changed its payloads in any way.
 2017-08-24 16:48:00 -07:00
Tim Abbott 8b0c0c33b5 login: Fix logging for login/register actions. 
Previously, Zulip's server logs would not show which user or client
was involved in login or user registration actions, which made
debugging more annoying than it needed to be.
 2017-08-24 16:29:27 -07:00
Tim Abbott a570a57fd5 login: Log which user was authenticated in mobile flows. 2017-08-24 16:29:27 -07:00
Tim Abbott 5206dad373 decorator: Fix is_browser_view handling of e.g. mobile apps. 
We may end up with some endpoints that could be the browser or the
mobile apps, and we want the right default to happen here.
 2017-08-24 16:26:57 -07:00
Tim Abbott 7ffc107061 decorator: Rename is_json_view to is_browser_view. 
This improves clarity, now that we're planning to start logging in the
login/registration pages, which aren't browser views.
 2017-08-24 16:25:08 -07:00
Tim Abbott a3bc041894 send_password_reset_email: Simplify argument parsing. 2017-08-24 14:41:45 -07:00
Vishnu Ks 2b076ef822 management: Move all_users option to ZulipBaseCommand. 2017-08-24 14:35:18 -07:00
Vishnu Ks 9d043e7fb0 management: Use self.style attribute for colored output. 2017-08-24 14:29:32 -07:00
Vishnu Ks f4df74d968 management: Use add_user_list_args in send_password_reset_email. 2017-08-24 14:29:32 -07:00
Vishnu Ks 65a20b3b99 management: Use add_user_list_args in remove_users_from_stream. 2017-08-24 14:29:32 -07:00
Vishnu Ks 0949924ea3 management: Use add_user_list_args in add_users_to_streams. 2017-08-24 14:29:32 -07:00
Vishnu Ks a82b3f1ea5 management: Use add_user_list_args in turn_off_digests. 2017-08-24 14:29:32 -07:00
Vishnu Ks f9a6dffe1a management: Add add_user_list_args function to ZulipBaseCommand. 2017-08-24 14:29:32 -07:00
Steve Howell 87c4961597 Add zerver/lib/topic_mutes.py 
This is mostly pure code extraction.

It also removes some dead code in update_muted_topic, where
were updating muted_topics spuriously before calling
do_update_muted_topic.
 2017-08-24 14:20:35 -07:00
Robert Hönig 18a080cd6c Don't handle json payload key errors inside webhooks. 
Fixes first part of #6213.
 2017-08-24 11:33:14 -07:00
Tim Abbott 93fb6a1688 models: Add support for using the root subdomain. 
Previously, realm.uri and realm.host didn't support using a subdomain
of the empty string (""), aka using the root domain.

Also, since we're already accessing self.subdomain, we don't need to
check REALMS_HAVE_SUBDOMAINS again.
 2017-08-23 23:19:19 -07:00
Tim Abbott f46f3871b4 integrations: Add support for using root subdomain. 
This fixes up the URL/link construction to make the root subdomain work.
 2017-08-23 23:18:36 -07:00