b3dbba3ad4
actions: Extract validate_email_for_realm helper.
2017-08-24 23:16:31 -07:00
c8f53e55db
websocket_client: Use get_system_bot.
...
This messy code is used only for our websocket Nagios tests, so using
get_system_bot makes sense.
2017-08-24 23:16:18 -07:00
e915fa058a
test_classes: Stop using get_realm_by_email_domain.
...
get_realm_by_email_domain was intended to be registration flow code
not used in other code, but it was leaked to a few places. This
removes one of the main remaining references to it outside the
registration code path.
2017-08-24 21:38:02 -07:00
95ed00bade
tests: Remove now-unused subscribe_to_stream helper.
2017-08-24 21:38:02 -07:00
69059dcac8
tests: Clean up subscribing from webhook tests.
2017-08-24 21:37:57 -07:00
5fa7c3e0b2
test_classes: Clean up API for unsubscribing.
...
The old API required test authors to unnecessarily repeat themselves.
2017-08-24 21:37:57 -07:00
eb720485c5
tests: Add and use new self.subscribe.
...
This new method cleans up the API for subscribing to something from a
test case.
2017-08-24 21:37:57 -07:00
60105fe38a
registration: Remove accounts_home_with_realm_str.
...
This was the old mechanism for logging into a specific realm on a
server with more than one not using REALMS_HAVE_SUBDOMAINS.
2017-08-24 20:44:52 -07:00
522562f68f
outgoing_webhook: Stop using get_realm_by_email_domain.
...
There was no reason to do a complicated lookup to get the realm here.
2017-08-24 20:27:00 -07:00
80458945c7
tests: Remove unnecessary use of get_realm_by_email_domain.
...
That function was primarily intended for some limited registration
code paths, not the generic usage it was getting.
2017-08-24 20:22:56 -07:00
6a2c83f051
notifications: Group messages by (recipient, sender) for PM's.
...
This fixes a issue with multiple PM's being clubbed into a single
missed message email.
Fixes #6224 .
2017-08-24 19:58:55 -07:00
0693656b89
register: Allow the empty string as a subdomain.
...
This is conditioned on the server being configured with
ROOT_DOMAIN_LANDING_PAGE=True.
2017-08-24 19:39:40 -07:00
3d4893d906
settings: Rename SUBDOMAINS_HOMEPAGE to ROOT_DOMAIN_LANDING_PAGE.
...
This new setting name is a lot more readable.
2017-08-24 19:32:16 -07:00
ab61fe5922
auth: Fix Google auth to not assume SUBDOMAINS_HOMEPAGE.
...
Previously, Google auth would redirect you back to the login page on
this code path.
2017-08-24 19:03:42 -07:00
31986d1b94
github_webhook: Update "pull_request unassigned" event fixture.
...
The older fixture for this event assumed that the "assignee" key
had a value of '{}' if no one was assigned to a PR anymore.
However, that is no longer true because testing with requestbin
showed that in the latest JSON payload for this event, the key
"assignee" now has the value of 'null' (None when converted to
Python) when a user is unassigned from a PR. The current code
didn't handle this correctly. This commit makes sure it does!
Its unclear as to whether the old fixture was simply wrong or
whether GitHub changed its payloads in any way.
2017-08-24 16:48:00 -07:00
8b0c0c33b5
login: Fix logging for login/register actions.
...
Previously, Zulip's server logs would not show which user or client
was involved in login or user registration actions, which made
debugging more annoying than it needed to be.
2017-08-24 16:29:27 -07:00
a570a57fd5
login: Log which user was authenticated in mobile flows.
2017-08-24 16:29:27 -07:00
5206dad373
decorator: Fix is_browser_view handling of e.g. mobile apps.
...
We may end up with some endpoints that could be the browser or the
mobile apps, and we want the right default to happen here.
2017-08-24 16:26:57 -07:00
7ffc107061
decorator: Rename is_json_view to is_browser_view.
...
This improves clarity, now that we're planning to start logging in the
login/registration pages, which aren't browser views.
2017-08-24 16:25:08 -07:00
a3bc041894
send_password_reset_email: Simplify argument parsing.
2017-08-24 14:41:45 -07:00
2b076ef822
management: Move all_users option to ZulipBaseCommand.
2017-08-24 14:35:18 -07:00
9d043e7fb0
management: Use self.style attribute for colored output.
2017-08-24 14:29:32 -07:00
f4df74d968
management: Use add_user_list_args in send_password_reset_email.
2017-08-24 14:29:32 -07:00
65a20b3b99
management: Use add_user_list_args in remove_users_from_stream.
2017-08-24 14:29:32 -07:00
0949924ea3
management: Use add_user_list_args in add_users_to_streams.
2017-08-24 14:29:32 -07:00
a82b3f1ea5
management: Use add_user_list_args in turn_off_digests.
2017-08-24 14:29:32 -07:00
f9a6dffe1a
management: Add add_user_list_args function to ZulipBaseCommand.
2017-08-24 14:29:32 -07:00
87c4961597
Add zerver/lib/topic_mutes.py
...
This is mostly pure code extraction.
It also removes some dead code in update_muted_topic, where
were updating muted_topics spuriously before calling
do_update_muted_topic.
2017-08-24 14:20:35 -07:00
18a080cd6c
Don't handle json payload key errors inside webhooks.
...
Fixes first part of #6213 .
2017-08-24 11:33:14 -07:00
93fb6a1688
models: Add support for using the root subdomain.
...
Previously, realm.uri and realm.host didn't support using a subdomain
of the empty string (""), aka using the root domain.
Also, since we're already accessing self.subdomain, we don't need to
check REALMS_HAVE_SUBDOMAINS again.
2017-08-23 23:19:19 -07:00
f46f3871b4
integrations: Add support for using root subdomain.
...
This fixes up the URL/link construction to make the root subdomain work.
2017-08-23 23:18:36 -07:00
d44ac5c320
auth: Clean up google_oauth2_test arguments.
2017-08-23 20:50:03 -07:00
d3e3c704d4
do_create_realm: Remove unnecessary second return value.
...
Unlike creating a stream, there's really no reason one would want to
call the function to create a realm while uncertain whether that realm
already existed.
2017-08-23 20:07:17 -07:00
8a65fdce49
subdomains: Fix over-aggressive redirect to find_my_team.
...
If the root domain is a valid subdomain, we don't want to redirect
everyone away from it.
2017-08-23 20:07:17 -07:00
397340b454
test_events: Fix a missing mypy import.
2017-08-23 20:04:20 -07:00
8418f0d30e
dev_login: List realms and show only users in the selected realm.
2017-08-23 19:27:32 -07:00
225debdbc5
test_events: Fix a misplaced type annotation.
2017-08-23 19:19:14 -07:00
8cbdaca9f5
fix_unreads: Fix handling of muted_topics on missing streams.
...
If the stream no longer exists, we can just ignored the muted_topics
entry.
2017-08-23 18:14:11 -07:00
f797604e66
Add test coverage for unreads count (stream muting).
2017-08-23 18:00:59 -07:00
7918551fa9
fix_unreads: Help postgres figure out the most efficient query.
...
In theory, this shouldn't make a difference, but in practice, this
helps postgres make better use of our unread messages index.
2017-08-23 18:00:33 -07:00
50fe1f7d9c
streams: Fix errors when notifications_stream is deactivated.
...
Fixes #6225 .
2017-08-23 17:54:05 -07:00
58ad61a4ac
actions: Fix errors when notifications_stream is deactivated.
2017-08-23 17:53:52 -07:00
59790f37fc
models: Create get_notifications_stream method in class Realm.
2017-08-23 17:50:34 -07:00
ead40d8d08
Exclude muted streams from page_params.unread_msgs.count.
...
This adds one fairly cheap query, and gets the bankruptcy count
more in the ballpark of the home unread count. (But we don't
account for topics yet.)
2017-08-23 17:39:22 -07:00
75d9f66bf0
fix_unreads: Fix error handling with no recipient_ids.
...
Previously, this would send an invalid database query to postgres.
2017-08-23 17:15:33 -07:00
2bb5013efc
integrations: Add discourse integration.
...
The actual integration lives on the Discourse side.
2017-08-23 15:25:12 -07:00
bc61fae6d2
fix_unreads: Actually update pre-pointer unread counts.
...
This fixes an oversight in the original version. (We have only
used this in controlled experiments.)
2017-08-23 13:13:23 -07:00
1ad3671801
test fixtures: Add some more quotes and remove some Oscar Wilde.
2017-08-23 13:00:39 -07:00
b9e0c69b15
test_data.source.txt: Replace postmodernism generator text with a play.
2017-08-23 13:00:39 -07:00
2b4faaa847
Support non-search queries in /json/messages/matches_narrow.
...
For filters like has:link, where the web app doesn't necessarily
want to guess whether incoming messages meet the criteria of the
filter, the server is asked to query rows that match the query.
Usually these queries are search queries, which have fields for
content_matches and subject_matches. Our logic was handling those
correctly.
Non-search queries were throwing an exception related to tuple
unpacking. Now we recognize when those fields are absent and
do the proper thing.
There are probably situations where the web app should stop hitting
this endpoint and just use its own filters. We are making the most
defensive fix first.
Fixes #6118
2017-08-23 01:07:57 -07:00
Tim Abbott
Aditya Bansal
Eeshan Garg
Vishnu Ks
Steve Howell
Robert Hönig
David Taylor
James Rowan